From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D138CA00C4; Fri, 7 Oct 2022 00:28:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B4E6400D6; Fri, 7 Oct 2022 00:28:53 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 2DEB140042 for ; Fri, 7 Oct 2022 00:28:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665095331; x=1696631331; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=D0KJkK7BJcfaBz1E47lRAYcb+c2eUmPziE5lZylxKNU=; b=S7/ZJ+I6xpuELr2wNATQqhflJEVwDnUW58/4ahKBeni7ZNkIhbH3KXgS /r+fFW7e/aIl3SDV6cTyBOMsrEKzfSi4Y0xJgkY/W1GLfE4qIsA7cMDjG QPH0ljEdFstJc16KlHerRJjg7DBTbhHD2ZnoJRDclNjY2rEJdUIvXU5Ez zLP02zBGK2CTuiTpp0dMFBbaiczWLFsWo5as2GMY2PDEv9aCyrXpUi8ye fN+16V7eXU5pN7dw8MsTKZoIbq/UU/07BjyE7pGXUA6bs/mShIIyr9Ytn Q2Lk1zsiJAzdnur/WUKcOicdDq8nEDXIi5MjXd1Saxj47xmLV1UJxtLWv Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="286817022" X-IronPort-AV: E=Sophos;i="5.95,164,1661842800"; d="scan'208";a="286817022" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2022 15:28:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="624905173" X-IronPort-AV: E=Sophos;i="5.95,164,1661842800"; d="scan'208";a="624905173" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 06 Oct 2022 15:28:50 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 6 Oct 2022 15:28:49 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 6 Oct 2022 15:28:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 6 Oct 2022 15:28:47 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 6 Oct 2022 15:28:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j77emIZZfbe5Y1dPH58FG0WYzD26ump1Sk6ruwRT8ivR2MnaOWUKDjsWyOtOCNb9ZJd4qmfbPDYeERX0GBV5U7u+omHm2uyszuO8FxfX3Dewf65Y++8lNyOwAd+g0uE9dLBjz3gdS1X7pipk1ZhoUO1VjzOIH928Z114MRAEIpylgFi8ocq0Z6Y1xAckEcXVWF8815spArFbT2MCvGhZd/XyheEGsLUonmWFPilTF4AilgJl0XshxXwH222Hsfjs0DLO9M2Li2tm/JmyZyoYru3qzufpb/uqsd1ehqgu+3kKLYbFc6sT0rDiVOVgTpMBBmqRk7P36RRElmbBN0pjmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LMrJEZAohXpjymXTBbxgrpSnj+Bcv7n1gGdsJAU+7tc=; b=F7LDM5OaCnp+yoOqv8Fbsk3dClRnJHUlB9xo3m2d6nGanNJAQQDtuoI+C3t8jifmsXcAeR/hdRi1UcQLEKO+IkPskNEvQDZNA5JxJXEEIpBlHhJpwORjuja4c5ze9DDbUiFoIbZqyS9P7/jdZTo/Svq6T/Y9fJ+VGsp6NiqilW7PqhhSYrGXnNaaPMBk34iZsRrDXL21cjJUPsXOFGS2AskFGVqAMQBTOHzFZcmgF9fccqhQ3wm0m2pBy/CoAhNruJY4UopuhjghVGNoCW22QAzmdx0Aru5cu4ey5Xa2YBIWHassTQkoP1xw8VTDBjcK92YCblXguhlGXpVEW0OfrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by SJ0PR11MB5037.namprd11.prod.outlook.com (2603:10b6:a03:2ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Thu, 6 Oct 2022 22:28:45 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e6be:3feb:17fd:bdcf]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e6be:3feb:17fd:bdcf%7]) with mapi id 15.20.5676.029; Thu, 6 Oct 2022 22:28:45 +0000 From: "Chautru, Nicolas" To: Akhil Goyal , "dev@dpdk.org" , "thomas@monjalon.net" CC: "maxime.coquelin@redhat.com" , "trix@redhat.com" , "mdr@ashroe.eu" , "Richardson, Bruce" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "Zhang, Mingshan" , "hemant.agrawal@nxp.com" Subject: RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11 Thread-Topic: [EXT] [PATCH v12 0/7] bbdev changes for 22.11 Thread-Index: AQHY2BUl5bBG5M3zx0ykZ2uyuuAxba4BosgAgABQTjA= Date: Thu, 6 Oct 2022 22:28:45 +0000 Message-ID: References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com> <20221004171656.17967-1-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|SJ0PR11MB5037:EE_ x-ms-office365-filtering-correlation-id: ed31a46f-4701-4f14-dbec-08daa7ea2179 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rnln/+AS3MJzKXQ3SX+vzvxs9D6XnR7qhoa9oFUS80UAGFffii5fJQpAf1CfzNsNYPILBLge8nglpH+slNlScipCTpItmHU4Odp2B0SFVB3rtUdy9D23dusSnEzkGq0kYZAm4YbHM3JuAIGHBw1errW1aiU8v7tDoUFyM/xHbT7DKGm3NMx8iDPEkRKp5CX9uzm27KyEC6yQi2ihNMINPbyQ/P1++XopuNsUeJDIPnhbtAQu6ui0xqn8OP4GG3Nz3PVALa6Dd0j32x32gu+lCEN/XfAh7MTBa1o0tkAogVIL65AA8HPGN+EJ44DSQyBXgYmFHX4ZALr8XilKx82ZgPMs6N6jJV4IYOs3x9157djH0Mfoxz5EuYiekdv/7Avrd6VkImblKSkUGZZpEVhb+e4aMbEXQFS1KbAd/tIvy7Y2wrdQEyjJDr7FJ6jYXTYkHyO5/Zotwl2B6/41+8My73R2eKZOT0+ZLlp1l4HDDdGSSA+7x2CgceardSoCfQ4pESzqsBZyzmOYbfY6ECxtbleShL2SoSw/3OFaEc5KF0W8T+XAeJJQ5HTAPLeR8dYZRzC3drShq/PCGxCoeE6MFHvQr1Bfd9iLaSL5PICNu/DsxTid10l/kj7qM4b+LTDkMJhpmptRGf0U9fTK2WEzw/Is38E2ejBpdE/+9+pn6dS/s6m8nxU4EqqyY/iWU9+nb1CloagALjGxL4FjikzT8tP3gao/+2RvP0MxLWyxP4wwY6qaD5lCQu9w11qlA9Em68ywRthi6R2+XyS+g4HmkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(39860400002)(346002)(396003)(366004)(136003)(451199015)(7696005)(33656002)(83380400001)(186003)(52536014)(9686003)(5660300002)(26005)(6506007)(38100700002)(2906002)(53546011)(38070700005)(8936002)(55016003)(122000001)(86362001)(82960400001)(316002)(110136005)(54906003)(478600001)(71200400001)(66946007)(66556008)(41300700001)(64756008)(76116006)(4326008)(8676002)(66476007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iOLcVc4IwdQChs2W9ulG+/zl+jsw75Xjj42s+47VX+PvdhQAMCJZ/PGAPDF8?= =?us-ascii?Q?3YQgIHRM2hA+7nPcml8BGeKoJrXQD+Che28sek9aOi2EDLTi42JHsIdGACXh?= =?us-ascii?Q?tujSVzq8grH/Cxg8S/L1ufkjrXUk3+Cy9wPXn1D1415jGwWLHjvinNBTqWKE?= =?us-ascii?Q?8LGBm2jDIDDEUqDhU9+qCWsDXbcGcdFe7Y2OUezci2dSMB55B5ZkhRQTal6K?= =?us-ascii?Q?IpZmso0zROGpeqaMFtsRqIv3ZJpV2l3zHkVZf3TAx8yuj9VKh6V+Hkc5Lqaq?= =?us-ascii?Q?qK4gZv0SLy1flAOLqg08X4eTzaLUbkIgsFW8K8AVSoS1r/dfz9XlRuDbfr8y?= =?us-ascii?Q?ZPqgrkrh7hzzNZAxg3/PBHzJ8m25Uehf1R4mltKiRHaF2KnJAwVtFdIOyX/n?= =?us-ascii?Q?ZAmd5b9Vv3rYpZiH+R/neOvbDRt2ZVUpHl5hZu84n4PsbdtVK9tJIvef4cIZ?= =?us-ascii?Q?Ilr9Q8TvhqbLhk5u4BOybNn9wwRdpZtKOK1q97zm/xJbMa3+L6u23vsMTWp0?= =?us-ascii?Q?EZFyEVmDS/JEokZwbLttmxMrgSvQe35JfyhjNP6Hlfhs9F+hl3eojE0h5voP?= =?us-ascii?Q?17MUuJ9/wff7pQ7CADPD6evZOdHlplHc8NP80WfHYk0Bj5CNAUIuEzO/3D3o?= =?us-ascii?Q?C3kcraogDJcas1C3a5xj8M0cp4MyEbsgowz6pcn7zhbFWljwxXTZYsSHEsuO?= =?us-ascii?Q?0UWwixOuRAkv7Q6ryWGW7w4RdYlNFlRbmpHBIoZUFHdtqtNLmWCVnTM4ZRFx?= =?us-ascii?Q?g6Xt/T28D7dBQX2BHXiDncko+bMDe0CXwDFvwFamup4Wzbo/GoJaSIsr/uzY?= =?us-ascii?Q?Dr5KDKXGk6ExDVFla+xFqmRFrtiwvRUmIxnQAmH0Az40OJV5x1TVYD9CgAXs?= =?us-ascii?Q?Us3SY6ICvvBVaHwMLCzmWWAi7oN25KTksHcqnSq2wq3VitmjUUKq7mFJ4MOS?= =?us-ascii?Q?K64yLm6UsF0p7yn3VohRbAaoHXb1Q23hoVKrZW6T6yOhjI9GoYMBZShx8sji?= =?us-ascii?Q?dgvDrBYxUgXfpp7oXjh4WhlNE0JaL2nVv5qdPCUs65efM//tNJSApCEKhfSi?= =?us-ascii?Q?D+oOpT651AgQDN6RVk+ckbK0IAPWZ/MyonGmC/J0BJGmR1ffHVvaczmN4Dsb?= =?us-ascii?Q?MruNur4OLXGRUniVXyxOZ5agnlkCzPxYI9jnRIOYLJ85lf6z4vEOjMB8IKUK?= =?us-ascii?Q?oF6zkoKtTdYVp7d5fcLDSsaXP5IpMS1GE1M5UZR2BDl9VSoOB6JJlVd2BQdv?= =?us-ascii?Q?+fzTUdDSJ43U2sshzKDoGzL+PVP0JbWhvotCW7tyLPRtkFNWkTK2J50KUsN7?= =?us-ascii?Q?LeKJmD/a2nw2QQbggehMdOvHFa6MBxvGFq01enQE2bSIH3gaVr4azEehn3h1?= =?us-ascii?Q?KzmWHnEWeJdEpKE//sJ6RA0Ev3UKEVILrJoNSWklkn/UrqAyjAROyqVKsVle?= =?us-ascii?Q?FkfcrRj08fEjzt51B+xd3ZZ1upW4jgc16v44EFbY3EfJlbs7X20T1rO7gzKl?= =?us-ascii?Q?aFgqxbKx7xptJUaDJwO+bjHmF8xoYpYY4RZali8cHv/ZCAEy9WSjdwAm9Ett?= =?us-ascii?Q?ynLUrwAc7xpQx6YMvLLToIX7kClmisHRMUlohjxt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed31a46f-4701-4f14-dbec-08daa7ea2179 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 22:28:45.1541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hwn+c97504Jyb8y+7D1eckYTuFK8uYqxqiPwRvfll2+uDw/qNlcnoHiWF2XvP1dPWv2+l9hzXzLfF1x2bZTYG1rf59Wikhk4n6mm6VhQdLs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5037 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Akhil,=20 A couple of things I miss in term of guidelines for my benefit and that I d= on't see in documentation: - May I ask what rule we should use for documentation line breaking? I am u= nclear of the reason for some of the changes you made whose origin version = looked legit to me. Were you trying to fit into 80 chars (not always the ca= se) or was this to split the sentence by phrase as opposed to breaking simp= ly just before 100 chars? Can you clarify the recommendation? I see in the = doc it suggests 80 chars but unsure whether this is because this was not up= dated when moving to 100 chars.=20 - Do we really need a dot at the end of every text in a comment even when n= ot an actual sentence? I don't personally see the point nor do I believe th= is is followed in much of DPDK existing code (it depends at best), nor was = this case in the file where new structure was added (keeping consistency). = Is that really a recommendation for DPDK guideline for all new code to add= a dot at the end of all text?=20 Thanks for kindly clarifying, I can then update the other serie based on su= ch guidelines.=20 Thanks for the other formatting issues and commit message changes.=20 Nic > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, October 6, 2022 10:32 AM > To: Chautru, Nicolas ; dev@dpdk.org; > thomas@monjalon.net > Cc: maxime.coquelin@redhat.com; trix@redhat.com; mdr@ashroe.eu; > Richardson, Bruce ; > david.marchand@redhat.com; stephen@networkplumber.org; Zhang, > Mingshan ; hemant.agrawal@nxp.com > Subject: RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11 >=20 > > Hi Akhil, Thomas, > > > > v12: minor change to fix misaligned comment on patch 6 raised by Thomas= . > > Thanks. > > v11: updated based on Thomas review notably on comments through the > > serie and ordering. Thanks. I have also updated rel_notes and > > deprecation through the serie this time. > > v10: replacing the _PADDED_MAX enum to _SIZE_MAX macro based on > > suggestion from Ferruh/Maxime/Akhil. Thanks > > v9: removing code snippet from documentation in 5/7 requested by Akhil. > > Thanks. > > v8: edit based on review by Akhil : typos, coding guidelines. No > > functional change. Thanks > > v7: couple of typos in documentation spotted by Maxime. Thanks. > > v6: added one comment in commit 2/7 suggested by Maxime. > > v5: update base on review from Tom Rix. Number of typos reported and > > resolved, removed the commit related to rw_lock for now, added a > > commit for code clean up from review, resolved one rebase issue > > between 2 commits, used size of array for some bound check > > implementation. Thanks. > > v4: update to the last 2 commits to include function to print the > > queue status and a fix to the rte_lock within the wrong structure > > v3: update to device status info to also use padded size for the relate= d > array. > > Adding also 2 additionals commits to allow the API struc to expose > > more information related to queues corner cases/warning as well as an > > optional rw lock. > > Hemant, Maxime, this is planned for DPDK 21.11 but would like > > review/ack early is possible to get this applied earlier and due to tim= e off > this summer. > > Thanks > > Nic > > > > Nicolas Chautru (7): > > bbdev: allow operation type enum for growth > > bbdev: add device status info > > bbdev: add device info on queue topology > > drivers/baseband: update PMDs to expose queue per operation > > bbdev: add new operation for FFT processing > > bbdev: add queue related warning and status information > > bbdev: remove unnecessary if-check > > > > app/test-bbdev/test_bbdev.c | 2 +- > > app/test-bbdev/test_bbdev_perf.c | 6 +- > > doc/guides/prog_guide/bbdev.rst | 103 +++++++++++ > > doc/guides/rel_notes/deprecation.rst | 13 -- > > doc/guides/rel_notes/release_22_11.rst | 14 ++ > > drivers/baseband/acc100/rte_acc100_pmd.c | 30 ++-- > > .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 9 + > > drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 9 + > > drivers/baseband/la12xx/bbdev_la12xx.c | 10 +- > > drivers/baseband/null/bbdev_null.c | 1 + > > .../baseband/turbo_sw/bbdev_turbo_software.c | 13 ++ > > examples/bbdev_app/main.c | 2 +- > > lib/bbdev/rte_bbdev.c | 57 +++++- > > lib/bbdev/rte_bbdev.h | 158 +++++++++++++++- > > lib/bbdev/rte_bbdev_op.h | 169 ++++++++++++++++-- > > lib/bbdev/version.map | 12 ++ > > 16 files changed, 560 insertions(+), 48 deletions(-) > > > Hi Nicolas, >=20 > There were many formatting issues in this patch. This has been a practice= in > whole of bbdev. > Please take a diff of what is applied on the tree and what was submitted = to > take care of the formatting in future patches and please plan to fix the = rest > of bbdev documentation (API + prog_guide). >=20 > Series applied to dpdk-next-crypto >=20 > Thanks.