* [dpdk-dev] [PATCH] app/bbdev: fix wrong variable
@ 2021-04-23 7:42 Min Hu (Connor)
2021-04-23 18:50 ` Chautru, Nicolas
2021-04-26 0:56 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
0 siblings, 2 replies; 6+ messages in thread
From: Min Hu (Connor) @ 2021-04-23 7:42 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, nicolas.chautru, thomas
This patch corrected misused variable.
Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
app/test-bbdev/test_bbdev_perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 45b85b9..b8bf512 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -372,14 +372,14 @@ check_dev_cap(const struct rte_bbdev_info *dev_info)
if (nb_harq_inputs > cap->num_buffers_hard_out) {
printf(
"Too many HARQ inputs defined: %u, max: %u\n",
- nb_hard_outputs,
+ nb_harq_inputs,
cap->num_buffers_hard_out);
return TEST_FAILED;
}
if (nb_harq_outputs > cap->num_buffers_hard_out) {
printf(
"Too many HARQ outputs defined: %u, max: %u\n",
- nb_hard_outputs,
+ nb_harq_outputs,
cap->num_buffers_hard_out);
return TEST_FAILED;
}
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/bbdev: fix wrong variable
2021-04-23 7:42 [dpdk-dev] [PATCH] app/bbdev: fix wrong variable Min Hu (Connor)
@ 2021-04-23 18:50 ` Chautru, Nicolas
2021-04-25 16:30 ` Thomas Monjalon
2021-04-26 0:56 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
1 sibling, 1 reply; 6+ messages in thread
From: Chautru, Nicolas @ 2021-04-23 18:50 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, thomas
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, April 23, 2021 12:43 AM
>
> This patch corrected misused variable.
>
> Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Thanks
Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
> ---
> app/test-bbdev/test_bbdev_perf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-
> bbdev/test_bbdev_perf.c
> index 45b85b9..b8bf512 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -372,14 +372,14 @@ check_dev_cap(const struct rte_bbdev_info
> *dev_info)
> if (nb_harq_inputs > cap->num_buffers_hard_out) {
> printf(
> "Too many HARQ inputs defined: %u,
> max: %u\n",
> - nb_hard_outputs,
> + nb_harq_inputs,
> cap->num_buffers_hard_out);
> return TEST_FAILED;
> }
> if (nb_harq_outputs > cap->num_buffers_hard_out)
> {
> printf(
> "Too many HARQ outputs defined:
> %u, max: %u\n",
> - nb_hard_outputs,
> + nb_harq_outputs,
> cap->num_buffers_hard_out);
> return TEST_FAILED;
> }
> --
> 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/bbdev: fix wrong variable
2021-04-23 18:50 ` Chautru, Nicolas
@ 2021-04-25 16:30 ` Thomas Monjalon
2021-04-26 0:57 ` Min Hu (Connor)
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2021-04-25 16:30 UTC (permalink / raw)
To: Chautru, Nicolas, Min Hu (Connor), dev; +Cc: Ferruh Yigit
Chautru, Nicolas:
> From: Min Hu (Connor) <humin29@huawei.com>
> >
> > This patch corrected misused variable.
> >
> > Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>
> Thanks
>
> Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
It is not enough. The commit log must described what was broken in which case.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/bbdev: fix wrong variable
2021-04-25 16:30 ` Thomas Monjalon
@ 2021-04-26 0:57 ` Min Hu (Connor)
0 siblings, 0 replies; 6+ messages in thread
From: Min Hu (Connor) @ 2021-04-26 0:57 UTC (permalink / raw)
To: Thomas Monjalon, Chautru, Nicolas, dev; +Cc: Ferruh Yigit
在 2021/4/26 0:30, Thomas Monjalon 写道:
> Chautru, Nicolas:
>> From: Min Hu (Connor) <humin29@huawei.com>
>>>
>>> This patch corrected misused variable.
>>>
>>> Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>
>> Thanks
>>
>> Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
>
> It is not enough. The commit log must described what was broken in which case.
>
Hi, fixed in v2, thanks.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] app/bbdev: fix wrong variable
2021-04-23 7:42 [dpdk-dev] [PATCH] app/bbdev: fix wrong variable Min Hu (Connor)
2021-04-23 18:50 ` Chautru, Nicolas
@ 2021-04-26 0:56 ` Min Hu (Connor)
2021-05-05 14:43 ` [dpdk-dev] [EXT] " Akhil Goyal
1 sibling, 1 reply; 6+ messages in thread
From: Min Hu (Connor) @ 2021-04-26 0:56 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, thomas, nicolas.chautru
The logging should show context by printing the two variable which
compared to each other. 'nb_harq_inputs', not 'nb_hard_outputs';
'nb_harq_outputs', not 'nb_hard_outputs'.
This patch corrected misused variable.
Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
---
app/test-bbdev/test_bbdev_perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 45b85b9..b8bf512 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -372,14 +372,14 @@ check_dev_cap(const struct rte_bbdev_info *dev_info)
if (nb_harq_inputs > cap->num_buffers_hard_out) {
printf(
"Too many HARQ inputs defined: %u, max: %u\n",
- nb_hard_outputs,
+ nb_harq_inputs,
cap->num_buffers_hard_out);
return TEST_FAILED;
}
if (nb_harq_outputs > cap->num_buffers_hard_out) {
printf(
"Too many HARQ outputs defined: %u, max: %u\n",
- nb_hard_outputs,
+ nb_harq_outputs,
cap->num_buffers_hard_out);
return TEST_FAILED;
}
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [EXT] [PATCH v2] app/bbdev: fix wrong variable
2021-04-26 0:56 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
@ 2021-05-05 14:43 ` Akhil Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2021-05-05 14:43 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: ferruh.yigit, thomas, nicolas.chautru, stable
> The logging should show context by printing the two variable which
> compared to each other. 'nb_harq_inputs', not 'nb_hard_outputs';
> 'nb_harq_outputs', not 'nb_hard_outputs'.
>
> This patch corrected misused variable.
>
> Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
> ---
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-05 14:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 7:42 [dpdk-dev] [PATCH] app/bbdev: fix wrong variable Min Hu (Connor)
2021-04-23 18:50 ` Chautru, Nicolas
2021-04-25 16:30 ` Thomas Monjalon
2021-04-26 0:57 ` Min Hu (Connor)
2021-04-26 0:56 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-05-05 14:43 ` [dpdk-dev] [EXT] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).