DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Song, Keesang" <Keesang.Song@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Aman Kumar <aman.kumar@vvdntech.in>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform
Date: Tue, 2 Nov 2021 15:56:08 +0000	[thread overview]
Message-ID: <BY5PR12MB36817863DBFBC0B6ADD79719968B9@BY5PR12MB3681.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2507236.ifWSo0Cply@thomas>

[AMD Official Use Only]

It would be great to make max lcores dynamically allocated.
Thanks so much Thomas for your confirmation that this is to be merge in 21.11-rc2.


-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net>
Sent: Tuesday, November 2, 2021 8:19 AM
To: Aman Kumar <aman.kumar@vvdntech.in>
Cc: dev@dpdk.org; Song, Keesang <Keesang.Song@amd.com>; david.marchand@redhat.com
Subject: Re: [PATCH] config/x86: add support for AMD platform

[CAUTION: External Email]

02/11/2021 15:52, Aman Kumar:
> -Dcpu_instruction_set=znverX meson option can be used to build dpdk
> for AMD platforms. Supported options are znver1, znver2 and znver3.
> Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in>
> ---
> +# AMD platform support
> +if get_option('cpu_instruction_set') == 'znver1'
> +    dpdk_conf.set('RTE_MAX_LCORE', 256) elif
> +get_option('cpu_instruction_set') == 'znver2'
> +    dpdk_conf.set('RTE_MAX_LCORE', 512) elif
> +get_option('cpu_instruction_set') == 'znver3'
> +    dpdk_conf.set('RTE_MAX_LCORE', 512) endif

Ideally we should try getting rid of this config and make all structs depending on max lcores allocated dynamically.
I think it may be an interesting target for next year 22.11 release.

About the patch itself, I am OK to merge it in 21.11-rc2.

  reply	other threads:[~2021-11-02 16:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 14:52 Aman Kumar
2021-11-02 15:18 ` Thomas Monjalon
2021-11-02 15:56   ` Song, Keesang [this message]
2021-11-02 18:45 ` David Marchand
2021-11-02 19:04   ` Thomas Monjalon
2021-11-18 12:25     ` Thomas Monjalon
2021-11-18 13:52       ` Bruce Richardson
2021-11-18 14:05         ` Thomas Monjalon
2021-11-24 12:36           ` Thomas Monjalon
2021-12-17 20:12             ` Song, Keesang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR12MB36817863DBFBC0B6ADD79719968B9@BY5PR12MB3681.namprd12.prod.outlook.com \
    --to=keesang.song@amd.com \
    --cc=aman.kumar@vvdntech.in \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).