From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB0CDA0C4E; Tue, 2 Nov 2021 17:35:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72E6A4069F; Tue, 2 Nov 2021 17:35:51 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2082.outbound.protection.outlook.com [40.107.237.82]) by mails.dpdk.org (Postfix) with ESMTP id CB68641139 for ; Tue, 2 Nov 2021 16:56:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8QVY+LNbt278to8/fddR6ZAuL3NQXXB1EL+7ik9tcZqsmTTJi5mZr3FfJkXJtuRfWfhUI3bWykBD8uLZfSs+QWLT0zAmneYznVtCsSJGAxQQj7GMw9l7MD2Nm3QsUrTBrAzmUH/J+zPUaneMZgE779NI1Q4/kQrih3/3M/CgNAFfgsccs/0stp5w/8OuBDbBt8O8PYRKoudpe5bwCPPux1k5hWTUMnzTCOXs4vIePZfFswxfJX896G5ZvYZdEWdTjiQau7bpQdbadF5aFdpjlK365adqWidd9XygTKTLIMBcyp0vUfquHjDrcQqosLHNJ7GjjMX6l7i0rGvylcz9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fTQ1J7GjN56SRgOLmjZKLIsxQHpl5vUCJWwNjFTgB+w=; b=Ldc06R3V/ohDvSknUOJULEMIxWD9Gy2piX8FYMfgqoz+dogQ9wjAV+n9KiLtTSEV4pbsfGs+kMpsRKhkAtasxWZ9niIZj+MHwr9+hb+knJ5rnNePSvh4wxMkLS14+ms/odot/+GKWYy+mR5c9sMKGJw3laDeCX4h9D42+pBHcIT2YwTkMWiAulkjEcDhqpwLwZkslBgTUgXrG+q9hOWU/uth3nhVp2dJLwM2sXeA0BY45YdgI7Pkdd8dpLoi+PIKmgNTXgtT9HAIxo4N48KNQ98iYVckQOZ6kOwtOaYUx5ifRDxmLypzWu59AxR44DB9UE2r7WpsHB978T3xtdlijg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fTQ1J7GjN56SRgOLmjZKLIsxQHpl5vUCJWwNjFTgB+w=; b=Gh8saNodDSIP4RwX576mVDhsBs1ckkGVQt21hJmnLLOvHz1LRwQfNmQd1JU8ASAqpFgp8Le+aMtE8umFLyKOg1j6wieNsddjKoskBUbeqp1CjlVBW1Xx/oWIqVFZkEPPZB5RoVvWdz/c9tmRM5shJ+eD7+GAhPAobzoUnABCrdc= Received: from BY5PR12MB3681.namprd12.prod.outlook.com (2603:10b6:a03:194::16) by BYAPR12MB3352.namprd12.prod.outlook.com (2603:10b6:a03:a8::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 2 Nov 2021 15:56:08 +0000 Received: from BY5PR12MB3681.namprd12.prod.outlook.com ([fe80::1419:77f5:8c88:c53c]) by BY5PR12MB3681.namprd12.prod.outlook.com ([fe80::1419:77f5:8c88:c53c%7]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 15:56:08 +0000 From: "Song, Keesang" To: Thomas Monjalon , Aman Kumar CC: "dev@dpdk.org" , "david.marchand@redhat.com" Thread-Topic: [PATCH] config/x86: add support for AMD platform Thread-Index: AQHXz/lfUEfmbyxpbUCdNmVb+GWX1KvwWegAgAAJf4A= Date: Tue, 2 Nov 2021 15:56:08 +0000 Message-ID: References: <20211102145253.413467-1-aman.kumar@vvdntech.in> <2507236.ifWSo0Cply@thomas> In-Reply-To: <2507236.ifWSo0Cply@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=91c6c9ba-f0ab-499d-90da-1f2b2c8e6007; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-11-02T15:52:44Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 988d7bc8-9a48-4492-b5e5-08d99e1948e9 x-ms-traffictypediagnostic: BYAPR12MB3352: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YWdbGO0LhL7FBpYkM3QtYQzxKwjfZW8vF5Q7Z8kK/C+jqs3qTfD1cPRVFK130sjtycDqf8hZiC+0vThvdYHGKyhWynR0rJKWFIw4M8H7VRkz+uhA31DkkNETbgG8z0CytvaEiTnVGmV9dGs/NRNBpeZ4svPeymv81sG+8RNStpi5Q8a47L1d9H+fb4dF/wWbV6GEA5gOzZcnxF8pyMpc/vhmRLR699bNVhbRYoPqODTZllbhniTkQqZ848onXnEmiwDF4bXoCj5HF67RmneCpYIFANuEf/9MVMVpYfiTSW9WqLWSmBx1C431Ef2rXSf+ToyDnGFq8Ed410C47a8T/xSfzaUl3jJgXws8pRF54jobrx0b0mdCSdn/fkqfazMLVGe6n1yQn6nnfKMCmmcTSOFx24uWWkza2lfeGVrkd/pdsgIuwDbCeWN2ZlVjUhqKJ5IysZdJROKLk1JjLJ9VTdV/fQt2rvb+7ziurAm8QIi4+THk5/CsiD4H266D4vTsv/3mo3SmaWxF7RI3DvTZa1ctqKl8RzBOdByn2AI74VI2D/Wf6jgV8n+cHaS3Z3+az3vAYGWcZuyS/0F2pEK04yY4fHi6L2Fodze+C29rZ92lsQ69G/AFnlD56l7kK/kQF1u90yLhSfO5KS5ZOPPm8tdC6R04Y0EaopE/Fozc9/IcnEbg2kGmXkqhdMetsK21OXFTFrGJHXeN8R9rRcOWsQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB3681.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(38100700002)(8676002)(83380400001)(55016002)(8936002)(110136005)(54906003)(33656002)(186003)(26005)(53546011)(6506007)(122000001)(7696005)(4326008)(316002)(86362001)(508600001)(66946007)(66446008)(66556008)(64756008)(66476007)(76116006)(2906002)(71200400001)(5660300002)(52536014)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aYXtboS5K83+iaYooKBiXVY5ndzG2q5L8Qc25JY5ylRHByEKq4yvBTCpYCY6?= =?us-ascii?Q?dBpHpjXdZ86TQ7hpl2iRkf4uM66aSyFhh5wFNkKvej72mPXNx8YOluK1G91a?= =?us-ascii?Q?tjq2HbONO3GFFEUJW5voe9VEgSIeIFUTzCCip02Xng2c6SQ1Q7VynkUgFH1y?= =?us-ascii?Q?p2WgBUV0YZz3l6V9jJHvjHbdVnf3rRJYNyzc7UlXshxU/jjre7JbtguQpiJq?= =?us-ascii?Q?yzWnYefPCP/vmIkKpXbLrKcdRh5scON1weSy+wOeM0V6n2w3llBt39HpyzAg?= =?us-ascii?Q?18QATxA9eyzPIL8bHYMGUG634UkWnfr9KH2W19Nv75xylU0W/E75N3Y9Eo3T?= =?us-ascii?Q?uNdjEtGxJ/OA3gRlEwEGufEpJCZgHKGj+sYVa3SkHfXUw3mOxgMpvoSOelq3?= =?us-ascii?Q?31LV7hmKMRnLla0Zr2b8naKnPMOFyYB7sObjE9hs6bf3iRufqsOqRnvcXol2?= =?us-ascii?Q?bRwOhcHrsi12t8etbtMPWmi+V98XXLp1pa0W3wuk0rsBLJSWvYNWpxReJydp?= =?us-ascii?Q?m8AvJUy0kxOWgOKoHYg+g0gKfxtuufhW4kVgGD0tHsBsJiDS6pYnx62QVvV1?= =?us-ascii?Q?L3bxE3YWNkAtZwPxEAqmxg71tv1LXiMrMOglkEXHf0pn3Gxgn4afTmrEQ4Ym?= =?us-ascii?Q?jut/+aAQV3+pU+RanBwR/GoV0KrhKKJkjBPkwnhanUOrLsqPZ9Km0uaRa1aB?= =?us-ascii?Q?wW7e0QbwpqkQm/n2CKWwoEqhEvefbRfxPPEdElFw5gDOtIVGUUEUWdI/gwXV?= =?us-ascii?Q?nbUNsVAO2hvEoeX8gDM/8CtyCthuMneYLiDEx5tGPeq9iQBTIp/DmS0u1c+V?= =?us-ascii?Q?i6oXb4avOx95ILTeImSLara12xWxjOT+mYKBpApEGwcVKzZOxHpfWo49MGNc?= =?us-ascii?Q?xyaLOkytYjUX4fv2FLW5xjOTtzrG2gOGMNUYxcNPBu/498HWWAP7qYuALcbN?= =?us-ascii?Q?48kmLO9xRXauraptxHj3WqiBSS9XwYaq+UXDNZN4eRVUbJjI+Xr9boSjj7tr?= =?us-ascii?Q?HTrV3bWAlp8qBnWk7T2MF9l8cL+08wFBZEpgUeclB8sb507pNW2kdG++GYDm?= =?us-ascii?Q?QyoOsnG7l0OLh9hdUXGMDicglaaP/a0pzNSLAbSTTxrRLKJvl39wLKYIX38D?= =?us-ascii?Q?81HuDZy4OxVmVonLDVA9ONeq4tI2T6Ik7XFLpNnEZZQlTo6GqfnXVqOrbzDu?= =?us-ascii?Q?kFsv7CgReFxYgibofqc6UqJk89+KMg6BL/KLrpcbedZ//9wkpdqntNAH9oPF?= =?us-ascii?Q?b1SiiX2+V3uLD5S2Ec1rabagKzHcB5sumG7NOlecOLpMf4zp1P0aFjZKiYxa?= =?us-ascii?Q?Xn/CmGYMPsCQvNVZk0n3Mwy5U9v8v9YoQSgQAaw0MpGLBatdlxSQzgerq8EA?= =?us-ascii?Q?1jOQbxev01ZNdjrrp3y4N2VeotL+K087h9fz+77xvoYyYBz09Y1/JhDlpdzT?= =?us-ascii?Q?eZ1CcewpbZRFxQ4zw76KHUu46TNGU9F0wGwHo9PR53Io+JLP93E6ooAFs2K2?= =?us-ascii?Q?1EVT/swnh4wIz3n2ZsLL4SUEb8DFiRJoGBHB51JizQfb/vgik9A1QnO71KzQ?= =?us-ascii?Q?WFRPG/NSTNK3gCQpLfBTcXAi+FZ1Qi9CVRepL3SpI2NMB5cVAlbh5lolme29?= =?us-ascii?Q?m0u3Blt7Ry8kVt7CgTb5pCs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3681.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 988d7bc8-9a48-4492-b5e5-08d99e1948e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 15:56:08.2863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EbCDfeOJG+lkPf2oI8/pXqopShuO0ukNTlcrBzW47IHqChrzy4OoIXp+taIhkmHPYtO15pS9Q1oA4FuHiZjSMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3352 X-Mailman-Approved-At: Tue, 02 Nov 2021 17:35:50 +0100 Subject: Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" [AMD Official Use Only] It would be great to make max lcores dynamically allocated. Thanks so much Thomas for your confirmation that this is to be merge in 21.= 11-rc2. Best, Keesang -----Original Message----- From: Thomas Monjalon Sent: Tuesday, November 2, 2021 8:19 AM To: Aman Kumar Cc: dev@dpdk.org; Song, Keesang ; david.marchand@redh= at.com Subject: Re: [PATCH] config/x86: add support for AMD platform [CAUTION: External Email] 02/11/2021 15:52, Aman Kumar: > -Dcpu_instruction_set=3DznverX meson option can be used to build dpdk > for AMD platforms. Supported options are znver1, znver2 and znver3. > > Signed-off-by: Aman Kumar > --- > +# AMD platform support > +if get_option('cpu_instruction_set') =3D=3D 'znver1' > + dpdk_conf.set('RTE_MAX_LCORE', 256) elif > +get_option('cpu_instruction_set') =3D=3D 'znver2' > + dpdk_conf.set('RTE_MAX_LCORE', 512) elif > +get_option('cpu_instruction_set') =3D=3D 'znver3' > + dpdk_conf.set('RTE_MAX_LCORE', 512) endif Ideally we should try getting rid of this config and make all structs depen= ding on max lcores allocated dynamically. I think it may be an interesting target for next year 22.11 release. About the patch itself, I am OK to merge it in 21.11-rc2.