From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE177A034C; Tue, 21 Dec 2021 10:05:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B732A40040; Tue, 21 Dec 2021 10:05:27 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2053.outbound.protection.outlook.com [40.107.95.53]) by mails.dpdk.org (Postfix) with ESMTP id 7602240040; Fri, 17 Dec 2021 21:12:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IsrWjXPxpcaQAkIXatbg0vorRWG+iqyq2l2Szaw+yY/HpluEhR3VSZTGm3xSCLDewsBGzv8+8ywYYw4p0gFxEb72W1kI0ayu78so+xZW/ztXIyAW/yFLlSF7T3vXX3ak2comvuDnAPQ78KdOCh7RX6Xw/eSgf4ge4WTpuzqYCpwNnIamiEN0kBlYkq5t541wmNwf85OUceupB5FkQhnj7zxbd5uu3zkwAfybyGEPMhUAdzVx0/vLd7uy5JyC4jd86Wl+zJlXTTJwz3fRJO3RryuSgvNQGb7jwwOg4c7wfQehdI4+TIxZa4j6O7doHsC70C/wT+5AHt91IFjmhUyWNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QEySG5AygjvRQLwBoLWKYdPZTLaHjxIfb6ZvMwvcdm0=; b=PBxHkLvL81hanF3fd/m+LcOgxkLfC2FKWXBYeN/FT33Tkc+A1dCYi1bJZvLn9L65w0il4tbaKGfUsK7SuvTKkLUx0GU3LBPfK30oj2D6EuJsq0Eek2pZnRHxOPqeO+QpAgJJ+jqznfP8ZjCozuQshhHLpBMw71PnVX6T+EtERS/TvFjl97Q0jRStuwrzp00N3fFBDdEKAjg4A5wPN+wA5U87gPWQO+6DCVtqpSgjy3gmeLQyvNeK2YJmHIbdxenMWDQrEERkbJRcPXRuXnkTR8Vuiwi22NCeoYyfMtGdahvc8RIAxpvMe0y0SizhVdlaNKXJ6iXapnb7mAA8No6FiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QEySG5AygjvRQLwBoLWKYdPZTLaHjxIfb6ZvMwvcdm0=; b=yRSJFYiIqVozNY6XxkrTHnoFO2hiUqfn/pz4W0rcZlX+KG2IH0ga34gXFa92u9kWPChH5s1/UaZ+Oox7P3bb2Y73KofMEjuaSEO5YO/wiPVERY0NLBZl/o4/a1P+7dejWWKD+d+m2ODUOyZusE8HN95uYz2I9nf5SIQtEOGl8Ss= Received: from BY5PR12MB3681.namprd12.prod.outlook.com (2603:10b6:a03:194::16) by BYAPR12MB3096.namprd12.prod.outlook.com (2603:10b6:a03:ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.16; Fri, 17 Dec 2021 20:12:45 +0000 Received: from BY5PR12MB3681.namprd12.prod.outlook.com ([fe80::11d3:3a9c:3f4c:2567]) by BY5PR12MB3681.namprd12.prod.outlook.com ([fe80::11d3:3a9c:3f4c:2567%5]) with mapi id 15.20.4801.017; Fri, 17 Dec 2021 20:12:45 +0000 From: "Song, Keesang" To: Thomas Monjalon , "techboard@dpdk.org" CC: Bruce Richardson , Aman Kumar , David Marchand , "dev@dpdk.org" Subject: RE: [dpdk-dev] [PATCH] config/x86: add support for AMD platform Thread-Topic: [dpdk-dev] [PATCH] config/x86: add support for AMD platform Thread-Index: AQHXz/lfUEfmbyxpbUCdNmVb+GWX1Kvwk5WAgAAFggCAGLW/AIAAGEEAgAADhICACVVXAIAkpJCg Date: Fri, 17 Dec 2021 20:12:45 +0000 Message-ID: References: <20211102145253.413467-1-aman.kumar@vvdntech.in> <5216156.SXqKmVLy82@thomas> <2321772.7Oz6CMQZNc@thomas> In-Reply-To: <2321772.7Oz6CMQZNc@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=860ae429-d290-4069-9327-95765de3e9b9; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-12-17T20:11:08Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d8e26536-994a-42ba-e4d6-08d9c19996f4 x-ms-traffictypediagnostic: BYAPR12MB3096:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sm+w7J1IWLk2SU/E3XqKi3mWnQxIH51agg/9GdyxneTiK2s/GH7gwNisWmbFCjX63DSBUqGOBX4v5aAPRLyi9iZCPkVqIrFOlPBmk7K5FVF7J/8VJhAFPvcMPUhnwBoLeZ2Lv6LxVV9/uLZM0zmwHNJDI0tuUAaZ3Sz92vrJU9D0R2VKwIViP/2U3ibsksCgEEYQ6se7UBrcYmDSS3N2Cg6id8IgdEwGEM8lf5lV1L8miLJ2LHorwMrtx72EyedmUb99dDGRP0MCnu3DxOSLsML8g6tO9eku2zBkgP5utqeGYmHFtk11qTM7OFSLIy4/2ztrNdiBvK3hBjaC8yKOmESMSHZmzxLHRIHfBOlLQBnTzf8vJtuVw0tLGKDLdF24NBdtk97ZtYcLqq4TYIzzu0l5SuGZ60Ysvi5t7hNoiKN6Kof09jDHDQ+o1zpNCYNjaWhur3VxVmdVRny7KaiKRt7lvdYpApJn0OnJpNyJlSUpLp5u9Gmfl1kxqvfnD0XbnFWozvycOjC2AMbLjRW8hhcXtvJlE66CcY/bynufpxkzWBti7G120Bb5tuC894YDNnFZVsUXXmnnEUVNXMCIracxU/Jz3r/3UFa+/fBHBbl7S8zg0cNub6brWGd8K4diss0dpS8a3vtIA7xUGipKDLueKbXR7uDCD/vMW3hIxCNBmPtf/pxhieqXkppUMNBgOE9Ks8TnDfGbFkVHTnJWtHH5BZpIJUk2bIHqTkc8YvJtqn8pDxQMITNTdB1IbiQ8mXpwaKR9PJB+1q8zqJ59FEBe41+reu+WfwcHfOJ/HjE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB3681.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(966005)(508600001)(5660300002)(6506007)(26005)(71200400001)(53546011)(66446008)(76116006)(45080400002)(8676002)(66556008)(66946007)(66476007)(4326008)(64756008)(38070700005)(52536014)(54906003)(110136005)(316002)(86362001)(9686003)(8936002)(186003)(55016003)(83380400001)(38100700002)(122000001)(2906002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7RBbGUr9ta88wTnkgKPp46PxGKDmc6cOE8H7HHUr1XYmI84GjY/1SWtJqxab?= =?us-ascii?Q?qGxSBS9q39km9U5g4SeXM/oELuySG6qhIvzkyaGnpc4sFUXJ1hkM5Fz/AjV6?= =?us-ascii?Q?R23lxYdDwcR82LAd3wyf9bOzg7t+sQ+f6QEqi6s1jtg8eymNufJYK1NAq73k?= =?us-ascii?Q?329k/2TCE2F0Azru87XNcSy8m28j7u2pE/exTo6z8htBGOXczoIVi4NoAM+T?= =?us-ascii?Q?EgME8p2F1XLwTvoT0EP6A3qRPG7EXu3pUt9ALdu5sNmiBk7nM5bvub3WC0aR?= =?us-ascii?Q?kZl9SLOdY14SL6LzJzf2PnPsxQ4FSjQ/kheboH328aelfZST+p3IXKfLQUhP?= =?us-ascii?Q?/N9Fr1H8rX2+p+FU5Phtw34ZLWrxzUDR4TNFf07I3xKa3n52pGx3xeRbLnSj?= =?us-ascii?Q?UhK+TtEI95Sgb9lhAWVgn5e/Ohe2EeirtAqDC2D3b4An47hdg1FulGwgIXIv?= =?us-ascii?Q?sX+doXxl0C1rfYPlZhqrlHchVEAPM+Dhoj8rkH9SKZmCnG0ShJniBaPl9TzZ?= =?us-ascii?Q?nZ6yEfoFqGw31jXzVcIlNLNiUK/0i4ZUb8ERbG9uFexc+4U11NI8+eGpygpA?= =?us-ascii?Q?Yk3vhFDBwOZmopzVQ2pi6MBl90jtJJQZmPSyZuSeEsHRTqgHUNs+hhSxuZmx?= =?us-ascii?Q?qts7gvY+jTGJ1hHZmiMsON+cS2IJ+Blp2Hda5ddPi+b1Uaj/Eb90ekfQLE5G?= =?us-ascii?Q?ULN/1DmE4denVwvIRa2EitTLpYUl1K6+Z0ojTI5UMpL8uhzZ9Sg0nRxStITY?= =?us-ascii?Q?jcBX025ji4DIUx1EZum61X0cjV8zY6fzNZfg8aj0EK+RepGb9pmMz4mX9VBx?= =?us-ascii?Q?hk0T/GqLjVjijBsQEStVt9ErHl90u9RmmBtKJNsCkJlsbITdICso7Rxeq4wS?= =?us-ascii?Q?9/dw/lL2jiaoPOlfGVRMz6l/yN6G7yjZd1saj0dW/vBgIH3bUwiktEjOit3z?= =?us-ascii?Q?Fq1vW1hgZKFDMv2rRsnDjWqd7gHqDjj1WXvsjnA/kG6aO7/xDgsb0SEolY/s?= =?us-ascii?Q?6cGIF5o7TXi45Bk4YR7eJ2G1GTwyyi4YxlVV/rsIqx4PKytQZAAZ3itNVXix?= =?us-ascii?Q?5L5kLRSOFJfezf/DUClDVbX1cP43Y4GikHGo9avziTYRgK9yLYw+OatIzvnD?= =?us-ascii?Q?liPJYBsyTXEMkAPbrtn7TnbdC1jjpZLNnyCLTtdNtHNiETTyVUw6GqVrFJcm?= =?us-ascii?Q?WlMY3Qf2psqoCC+7yLg/kUIP/5PqZ4o90ygTGlWHxaVQPXwGairUyS8E+G4z?= =?us-ascii?Q?ycdByRCfe1rlXDehLHv4jRL3ZbK5Q/HdTgDaEhIZOgWQDoEidwCRODpuwKmm?= =?us-ascii?Q?WjZmVW41W9C+cP/vNHXUo9rXKCPTERy+6w+R2rVSYbY1vdfaRLYXjP5npOR3?= =?us-ascii?Q?+pGUgl8lc7q/AZnGT2ArX7kL4CuUEZbB/SJ6KB8IjTrwnnKg8OL5Ou1DHRZA?= =?us-ascii?Q?0tTeoaHMQXsFvRi03S9UTNx2REwgR+YwCZRvzGThk1BmW+5jltDgBrOVfk7N?= =?us-ascii?Q?iGEssd/WkVkmY0dCgYSMANWecCO8N3B2no1hwqo4jzk4Op1Q9ZkrBgkfzxGF?= =?us-ascii?Q?g6nBZM7819DQfvH2lvz5zRoE54j44ljJG/xQU2des3BDtCl1Vtn/L3r11l61?= =?us-ascii?Q?1FKMfrF3pweFiJvZNbea3Wc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3681.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8e26536-994a-42ba-e4d6-08d9c19996f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 20:12:45.4549 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hxQEZoNcAtDoVGmsPgycigrO3owB4fQpilW1g/q5LvrJtPryzds7Wur8VbS+UcVIabiGUhlAE8W0UyP65ny69A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3096 X-Mailman-Approved-At: Tue, 21 Dec 2021 10:05:26 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only] I don't see any update since Thomas's. Do we have this patch taken care of submitting to 22.03 and backporting it? -----Original Message----- From: Thomas Monjalon Sent: Wednesday, November 24, 2021 4:37 AM To: techboard@dpdk.org Cc: Bruce Richardson ; Aman Kumar ; David Marchand ; Song, Keesang ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform [CAUTION: External Email] Ping techboard for comments 18/11/2021 15:05, Thomas Monjalon: > 18/11/2021 14:52, Bruce Richardson: > > On Thu, Nov 18, 2021 at 01:25:38PM +0100, Thomas Monjalon wrote: > > > I request a techboard decision for this patch. > > > > > > > > > 02/11/2021 20:04, Thomas Monjalon: > > > > 02/11/2021 19:45, David Marchand: > > > > > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar wrote: > > > > > > > > > > > > -Dcpu_instruction_set=3DznverX meson option can be used to > > > > > > build dpdk for AMD platforms. Supported options are znver1, > > > > > > znver2 and znver3. > > > > > > > > > > > > Signed-off-by: Aman Kumar > > > > > > --- > > > > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > > > > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > > > > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > > > > > + > > > > > > +# AMD platform support > > > > > > +if get_option('cpu_instruction_set') =3D=3D 'znver1' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 256) elif > > > > > > +get_option('cpu_instruction_set') =3D=3D 'znver2' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) elif > > > > > > +get_option('cpu_instruction_set') =3D=3D 'znver3' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) endif > > > > > > > > > > I already replied to a similar patch earlier in this release. > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2 > > > > > F%2Finbox.dpdk.org%2Fdev%2FCAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqC > > > > > ua6UdMXXHgrcmT6g%40mail.gmail.com%2F&data=3D04%7C01%7Ckeesan > > > > > g.song%40amd.com%7C621ed6a39c304c905dbb08d9af4717c5%7C3dd8961f > > > > > e4884e608e11a82d994e183d%7C0%7C0%7C637733542157359380%7CUnknow > > > > > n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > > > > > 1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DL9IM4ZtukVwY5qdbGgkt2zlu > > > > > sGm0ZmrQmE9oMeg1RDo%3D&reserved=3D0 > > > > > > > > > > So repeating the same: do you actually _need_ more than 128 > > > > > lcores in a single DPDK application? > > > > > > We did not receive an answer to this question. > > > > > > > Yes I forgot this previous discussion concluding that we should > > > > not increase more than 128 threads. > > > > > > We had a discussion yesterday in techboard meeting. > > > The consensus is that we didn't hear for real need of more than > > > 128 threads, except for configuration usability convenience. > > > > > > Now looking again at the code, this is how it is defined: > > > > > > option('max_lcores', type: 'string', value: 'default', description: > > > 'Set maximum number of cores/threads supported by EAL; > > > "default" is different per-arch, "detect" detects the > > > number of cores on the build machine.') > > > config/x86/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > > config/ppc/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > > config/arm/meson.build: it goes from 4 to 1280! > > > > > > So I feel it is not fair to reject this AMD patch if we allow Arm to = go beyond. > > > Techboard, let's have a quick decision please for 21.11-rc4. > > > > > I would support increasing the default value for x86 in this release. > > This patch is not increasing the default for all x86, only for some > CPUs as given at compilation time. > I think it is the same logic as Arm CPU-specific compilation. > > > I believe Dave H. had some patches to decrease the memory footprint > > overhead of such a change. I don't believe that they were merged, > > and while it's a bit late for 21.11 now, those should be considered > > for 22.03 release and then maybe for backport.