From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 01320A034F;
	Sun, 21 Feb 2021 12:58:51 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7B83322A29B;
	Sun, 21 Feb 2021 12:58:51 +0100 (CET)
Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com
 [216.228.121.143])
 by mails.dpdk.org (Postfix) with ESMTP id AA33A22A281
 for <dev@dpdk.org>; Sun, 21 Feb 2021 12:58:50 +0100 (CET)
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
 id <B60324af90002>; Sun, 21 Feb 2021 03:58:49 -0800
Received: from HQMAIL107.nvidia.com ([172.20.161.6])
 by hqpgpgate101.nvidia.com (PGP Universal service);
 Sun, 21 Feb 2021 03:58:49 -0800
X-PGP-Universal: processed;
 by hqpgpgate101.nvidia.com on Sun, 21 Feb 2021 03:58:49 -0800
Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Feb
 2021 11:58:43 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103)
 by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id
 15.0.1497.2 via Frontend Transport; Sun, 21 Feb 2021 11:58:43 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I+M/Q9Nsc2mZLXDouC8UWoUvHbBJ8TFnT5eud4hiO0UDV4dX+GqcWG68kQWg5kqUn0Kok5NLaT/Un2qckt7Cb6EyNImPR0aD5nxQrbW/R4ULQKBPYUdi5182SaLC4/XG3EcqfcOotA2HYX5AXouT5S3faak3dTrKWHjk6CILT4eEzYknNDvBsA2YPUzNdSSCbk89vzvhCNR8Ek6W4DojFRahYQ3VaIqJd0XNNcWpCArQL00siGOxu6rkkPaDfBhQ0XSuMekg6579XnxTxGF+xKfSkSOmHgSKKmx25rXqbIvEQc8qUr5MUAcSVval6WATWYAHok0T4CEY1Y2xvTmMXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=95yEidG697ush70vLxLveoA01cskfTOBLLx1N+GD2jY=;
 b=P8CQCl5HnBWGmkpjXsx/pZuL0m8Eu37X22Q+brOZ7xjw7EPAyUQZwF9DZpCNB3HhbRWsYwSGFnATXkYSi48n9Q+3+yb2ceHRX1RMBiaxSOCsHayNy3AL7Qs2eYap0xVFye92ijcTncbLV5pL6bpt6/7CipsP33ncY1ruhNKPUBHZGK/VmOt4TXSG/MSKvNtLxphXq+Q68gM8tuiO8NGqobY1OzgBhV+qJlr8nmD3lhz7gsi+7g1GjcPaOz2KTULvXH/idCuk43Pq8QeeColR0PDlhrrBYCtXysye89rYwIFiINrSmmTX5Dmz/VmCHv8+Ou4bArxmz+4AndrCCVjwew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
Received: from BY5PR12MB3938.namprd12.prod.outlook.com (10.255.139.31) by
 BYAPR12MB3448.namprd12.prod.outlook.com (20.178.196.202) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.3868.30; Sun, 21 Feb 2021 11:58:40 +0000
Received: from BY5PR12MB3938.namprd12.prod.outlook.com
 ([fe80::f0b1:e271:56a6:79f2]) by BY5PR12MB3938.namprd12.prod.outlook.com
 ([fe80::f0b1:e271:56a6:79f2%7]) with mapi id 15.20.3846.045; Sun, 21 Feb 2021
 11:58:40 +0000
From: Tal Shnaiderman <talshn@nvidia.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Tyler Retzlaff <roretzla@microsoft.com>,
 Nick Connolly <nick.connolly@mayadata.io>, Bruce Richardson
 <bruce.richardson@intel.com>, Narcisa Ana Maria Vasile
 <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX
 symbols
Thread-Index: AQHXB/EOT8IRXXdVdEK3E9rW6NxulqpiTUewgAAaOQCAABT64A==
Date: Sun, 21 Feb 2021 11:58:39 +0000
Message-ID: <BY5PR12MB3938BC823506F8A7AAB61CD0A4829@BY5PR12MB3938.namprd12.prod.outlook.com>
References: <20210220232910.772-1-dmitry.kozliuk@gmail.com>
 <20210221012831.14643-1-dmitry.kozliuk@gmail.com>
 <20210221012831.14643-8-dmitry.kozliuk@gmail.com>
 <DM6PR12MB39454590AE3240C7FC056CBFA4829@DM6PR12MB3945.namprd12.prod.outlook.com>
 <20210221132410.3a42e3ad@sovereign>
In-Reply-To: <20210221132410.3a42e3ad@sovereign>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=nvidia.com;
x-originating-ip: [77.137.56.206]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a5c638e6-1657-4cdf-e37d-08d8d660075b
x-ms-traffictypediagnostic: BYAPR12MB3448:
x-microsoft-antispam-prvs: <BYAPR12MB344819A2DC781390FFA129F6A4829@BYAPR12MB3448.namprd12.prod.outlook.com>
x-header: ProcessedBy-CMR-outbound
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: nNOLpo31PmMYqETJSdcIZShReYun6dH2jhdD1HkJ20tKXEPaFtAYwpU52Lfsq6lOc6PJaSdQVyMWzIlJuur3+uqs6QF2Sx5icubg5u73HedAKiodzAG8jbrIJPtE7bP5009qnXUVnbKdeP7L+LonXXHR04A68lU2lJGC+NMtugixIe5hUAgOJ6OraieDWXfRK3p9cZMFu8XCgF8A/MuuDTEf9iQw8ua6lm0ztLIT6gIHRFfUjuxwlZirhOceCylUE+M3ndovx0Yx+Knh4DTwQAQ0KkncEUl3V5/rPhZXso7Fd+FlasDeAGE0uF84VB9EhT+lsMXltgQ6pW3cngRF4WlRjAo8c62K2kynWEWSehx6lr+J6Z9Rk1PowXnT/GX7zFjBZLaSYbV5eIrr5IlfuxhgQEtpscHdsFZhBYEQQi6nsVOwMlXk4pKARaRmlKPnvba457jJuuOCWOR7M6sqF9lcMvfJJV4J7OsTy55Nq4RAme0zyHj/A6TC8j8U9C8Q7disn3sHd+1xRj32co1kMg9vC7pgwuYGqqzV5uAL+zLXkROA3nZQ0vbF6pSqrX9wnCLugehPlIyGsQL818dXCoMYe881ZPKywWe/rt4LvAI=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BY5PR12MB3938.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(66556008)(66446008)(66476007)(64756008)(83380400001)(2906002)(8936002)(86362001)(54906003)(186003)(26005)(55016002)(9686003)(7696005)(6506007)(5660300002)(4326008)(33656002)(478600001)(8676002)(76116006)(66946007)(966005)(71200400001)(52536014)(316002)(6916009);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1bdlMx0iWRA5sBhuUdqsse5qNnAXT0PMCD6O3zI+2dLIK5lt5ufblgpo8q7l?=
 =?us-ascii?Q?z5Cm/6xTx43HqZhHBrqMMNzl5aW73mOoxayXxWnN/DDx7PY+Vn/3JdL6G6tv?=
 =?us-ascii?Q?Lx6RMgOAJ2lvZpETTv1kkl2CxMP92auqcvN1n5FE5V58Q/rA8R5e0XmkJwE2?=
 =?us-ascii?Q?wkUtEdMC9X8lhjO+ErmVZxZPJEjSKu0oPgAUDZPGBs1+ylVSjHTQjBad5vqm?=
 =?us-ascii?Q?YTfLmZvF6m7YP4AX5fS8lpkvrCT2Q7HApdtMqAAwSN5MufLb1OdlRvp5/40b?=
 =?us-ascii?Q?cRoLNorv2zhZ/KvxDDHdeDY8Q63YSsK6w7uPZ0tIn/i6kEesUe0SZ9TXCF8b?=
 =?us-ascii?Q?7ACDyVs2ysHUjYF3+gCqN1j1tGEB3iY9imI0137YBea7DATNQbin97SQE+kQ?=
 =?us-ascii?Q?oqLtUzQscWnfbaE7h192hiI00G9tGeN23G205ji/TurdZDZ8r4ps9T1ytJke?=
 =?us-ascii?Q?H/dTc8DuvhwFzY4ZYkj1RTdc1H/XtEIRB9320TCQ+x0GDw1I0WM2/vB0S48O?=
 =?us-ascii?Q?2c/HxpqeEhpiQ0yWyjh5rS9V/yGx+/MBCMFnrIH4rjBGFv04z9GHP8LlpFoq?=
 =?us-ascii?Q?Dg0lesskCzfEGEbrhKQv+vjWn/xo0ilyoTxvXtLqhq2rNcs99YzkYJosplik?=
 =?us-ascii?Q?YM46PTqCJOt9yzqU6fIuuVYWiVX+D8d0CRDH5ehPkByA7Z28K1YSQH6iAF96?=
 =?us-ascii?Q?W763+kubrPQ04NBscI2QU42oR76Tp4CuDd5gz1LYcIXuqfBGMxZO2hJl3fdC?=
 =?us-ascii?Q?zJsLAD0J2ZKCLj+22IOtZbtPcR7jz752znsUnxNi85wDz70z3uUoirnU6ARi?=
 =?us-ascii?Q?+4ysNur0ClKMWQfHAHAzOEQTrJz0Gy0N8NnAGtDnA6PpSzHLg8+JeLhkrpXR?=
 =?us-ascii?Q?371F2AivI8VyZ482RqENUxt5nK6T+RVhzaSiAtdp0o1Mih77HCTg2C4SBP6B?=
 =?us-ascii?Q?QHWCUGhpM/O0M5mezzHq58hJvoaR1h/JWnUQj5VOdvjWsCXeLm+h7aWUiJJg?=
 =?us-ascii?Q?phIsWpKDcTGcnXFPgZM+hqiU7I28TifasOvPW/Irjqs83XOkEK5g9zfCSMcj?=
 =?us-ascii?Q?M8J45CdCEJ0rN4wzndGKnXreNljgSuAyK4bER3R/uZDjgWghwKekwnFJCQ7d?=
 =?us-ascii?Q?FEoSpao8gDfoe2ftV29ZKD6biuJ1EpUwM8dPl7qHy+X5LGur3u6mOOZ8Dqjs?=
 =?us-ascii?Q?R58WkpRx9KJL17v6/3fZlE40fZRRPzeUxW4HtUsH7SjAu3i3wUZQxREdf/19?=
 =?us-ascii?Q?34AdtT69QTsPqTqOtRvE3sa9sZUqSGTlEJ/S0Y5Au7uD7U4axUYABmH3DSTm?=
 =?us-ascii?Q?9vTmBx8Oeasylk5LbVUEMXdW?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3938.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5c638e6-1657-4cdf-e37d-08d8d660075b
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2021 11:58:40.0212 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G/aezzfPI5GVDTmiIkp/XudIeS4gq1+tO/30JW1OfsvzAGc0PU8zEyS2EFLka02iunNUfYUBDd7WHny1kgYzfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3448
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1613908729; bh=95yEidG697ush70vLxLveoA01cskfTOBLLx1N+GD2jY=;
 h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature:
 ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:
 Thread-Index:Date:Message-ID:References:In-Reply-To:
 Accept-Language:Content-Language:X-MS-Has-Attach:
 X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
 x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
 x-ms-traffictypediagnostic:x-microsoft-antispam-prvs:x-header:
 x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck:
 x-microsoft-antispam:x-microsoft-antispam-message-info:
 x-forefront-antispam-report:x-ms-exchange-antispam-messagedata:
 x-ms-exchange-transport-forked:Content-Type:
 Content-Transfer-Encoding:MIME-Version:
 X-MS-Exchange-CrossTenant-AuthAs:
 X-MS-Exchange-CrossTenant-AuthSource:
 X-MS-Exchange-CrossTenant-Network-Message-Id:
 X-MS-Exchange-CrossTenant-originalarrivaltime:
 X-MS-Exchange-CrossTenant-fromentityheader:
 X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
 X-MS-Exchange-CrossTenant-userprincipalname:
 X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
 b=p5uAt95QL56UjQeel3Q8v+mWV30CyBpI9NfRqQ5SnCeSpYzpUgEiM5hNclf9Dt4BQ
 K5W+tRa4v8iLLetXo0bIW004Ca78J4xyojudgT3kcqAuFrrBJccntWRRoyeJ3eG04y
 iaz/crV6/1esPL0JYG1EmWuNEGpHdh6lvzYr/THSIjKBucBQHN8Nxox0ib3t3fc8LN
 MWO5O7pnOwmfj+tYY8Mpzf/fmDFJG4HSwI/Gyw1sqC9cem/Yv0WnT4vzUsWkWp5SrT
 1hnMjF3wJERLTESA4Lt/en5/Kg7ODOoh/qfY4GDgv7dRzdXIc4fvPZZh48MIqGvJD6
 SdqXVdNE5qumA==
Subject: Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX
 symbols
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Subject: Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX
> symbols
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> On Sun, 21 Feb 2021 08:59:50 +0000, Tal Shnaiderman wrote:
> [...]
> > > -#ifndef close
> > > -#define close _close
> > > -#endif
> >
> > mlx5 uses close() in mlx5.c and is broken after this change above, BTW =
why
> not add an rte_close instead of local definition?
>=20
> I'm reluctant to add file manipulation API to EAL. It would be replicatio=
n of
> POSIX with "rte_" prefix, while standard C has everything needed to deal
> with files (and IOCTLs are platform-specific code anyway). I think librar=
ies and
> PMDs striving to be cross-platform should move to using FILE* some day. F=
or
> now, local definitions keep them running without any risk of breakage.
>=20
> Thanks for all your comments, it's weird I didn't hit the failures locall=
y.
> Will fix in v3.

You might be missing the DevX SDK installation, without it meson will skip =
the mlx5 build.

You can get it either by installation WIOF2 2.60 [1] or get only the SDK fr=
om [2] (I attached it to the Bugzilla ticket when asked the UNH team to add=
 mlx5 compilation to CI.

[1] - https://www.mellanox.com/products/adapter-software/ethernet/windows/w=
inof-2
[2] - https://bugs.dpdk.org/show_bug.cgi?id=3D620
=20