From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Huichao Cai <chcchc88@163.com>
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
Date: Thu, 2 Dec 2021 09:35:54 +0000 [thread overview]
Message-ID: <BY5PR12MB42274362C00625FB817ADD08A4699@BY5PR12MB4227.namprd12.prod.outlook.com> (raw)
Hi,
On Thu, 2 Dec 2021 10:24:40 +0800, Huichao Cai wrote:
> > Substituting options with NOOP might cause rte_ipv4_fragment_packet to produce more fragments than necessary, since options with copied flag unset will still occupy space in IPv4 header.
> --The "ip_options_fragment" just make a replacement and doesn't change the length of the IPv4 header.So I don't quite understand why it leads to produce more fragments.
If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments.
Best regards,
Dariusz Sosnowski
next reply other threads:[~2021-12-02 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:35 Dariusz Sosnowski [this message]
2021-12-02 11:38 ` Huichao Cai
2021-12-02 12:03 ` Ananyev, Konstantin
2021-12-02 12:11 ` Huichao Cai
2022-02-09 5:50 ` Huichao Cai
-- strict thread matches above, loose matches on Subject: below --
2022-02-10 12:21 Ananyev, Konstantin
2022-02-11 2:20 ` Huichao Cai
2022-02-11 10:11 ` Ferruh Yigit
2021-11-24 8:47 Huichao Cai
2021-12-01 11:49 ` Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB42274362C00625FB817ADD08A4699@BY5PR12MB4227.namprd12.prod.outlook.com \
--to=dsosnowski@nvidia.com \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).