From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E7B74A0C44;
	Mon, 12 Apr 2021 14:07:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D56D4141163;
	Mon, 12 Apr 2021 14:07:51 +0200 (CEST)
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-eopbgr750073.outbound.protection.outlook.com [40.107.75.73])
 by mails.dpdk.org (Postfix) with ESMTP id C10A4141159
 for <dev@dpdk.org>; Mon, 12 Apr 2021 14:07:50 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HUa4Nl5XBSMyQXy9ZA8RSlsdTCLZRcFrNRY6/SPna7KKc4+3wWOaENGZoJnIN13xRPigogcUXCaHsCbguT1cKEecHS9Okqqgw1XvHqSj4MGnlgxTLfWOzFu61vY4VDnPj8aQNUiCw6nzgkUcIwcc0jCfv7I2cuFdKG/QAQ/EaRM6EH7U9oLbTVxaV21tz/+463NLR5mzwy4NMjpFqykLiIsnwAQGfbZATlbTR6yqVgU/xJoJY35QgwTwpDwb4a+qBibxjB93mdtvh1ipdOzt6rJezpzj5tBfVGcZLuMw5ngvrdu3rmKJ9HlpRnmiv1B5wm8FD6dtAORNFUIAqjfCVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9yRokOgXm8exTVONMNaDEZjFFPMoKTC+bA9B5L0ZJxc=;
 b=OYV1LSsDoq7nvnXB5eyRHE4cw5fuUN1mj02h2VOOrxtRafyy2jNlfxhubKqzqayqQVZEAgCjOFCJ9atnwYypFqp9jDmkEGIF0SIQxzMd0JjcotMtRgk+fsHwGMgx3IKWAbYE3rsrzWxo6n1i2lo5HJtLRKwdg/x9xxpQAdJywRG+Y4HjmJ7Ydq5+I8hUACvlcG711isNy46n6dwz94bOB8OE3Hc0j/yF2EBC4ZV3nqQDYmhUsHnYpPoG9Rj9ARDGH7R99uepRD0JLk35yznVJV+mjlf/bnD56WqkuiX0jDKH1A+NNXFnP+lTTvkwcccPH+boBtV28kMU4vImUq81KQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9yRokOgXm8exTVONMNaDEZjFFPMoKTC+bA9B5L0ZJxc=;
 b=DbyVmEm3P/GGDLJZdfstEMPCaZqTBd5JXBe7PjOeaQX6B4b2iDbCMbp4so06m87ocwKCT5sjFTkOZhm8Z7vt0Stcv8exIo6qghJ+MkSBXYvgvTOd+MBuzKE3tmJR6t4rB+HsDE26Vji8VWJrzHCAn4/DdEwvaY5D0AmnkF9Y+NfP++OUST8n6Zkfewx8d6+0U/Y/CXTbgeet8c4u6M/a291pUOWAxeO/BLHKVDBTFGqxhY11rb7WwPp+/rCTucglN99Afzq07p1VSszo+bgFJgbmWBbyHSfS3rAwawZ6hh6X7KB2kHO0aLYHC3m7inuvztEh2mlUulCDNG80VdAI9w==
Received: from BY5PR12MB4324.namprd12.prod.outlook.com (2603:10b6:a03:209::10)
 by BY5PR12MB3666.namprd12.prod.outlook.com (2603:10b6:a03:1a4::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Mon, 12 Apr
 2021 12:07:49 +0000
Received: from BY5PR12MB4324.namprd12.prod.outlook.com
 ([fe80::b919:53f4:6757:331c]) by BY5PR12MB4324.namprd12.prod.outlook.com
 ([fe80::b919:53f4:6757:331c%5]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021
 12:07:49 +0000
From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: Tal Shnaiderman <talshn@nvidia.com>, NBU-Contact-Thomas Monjalon
 <thomas@monjalon.net>, Gaetan Rivet <gaetanr@nvidia.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Asaf Penso <asafp@nvidia.com>, Wenzhuo Lu
 <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>, Bernard
 Iremonger <bernard.iremonger@intel.com>, Gaetan Rivet <grive@u256.net>,
 Anatoly Burakov <anatoly.burakov@intel.com>, Dmitry Kozlyuk
 <dmitry.kozliuk@gmail.com>, Narcisa Ana Maria Vasile
 <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>, Ray Kinsella <mdr@ashroe.eu>, Neil
 Horman <nhorman@tuxdriver.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew
 Rybchenko <andrew.rybchenko@oktetlabs.ru>
Thread-Topic: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage
Thread-Index: AQHXLhUwM1OSd1OnrUWbYT+AFHXzuqquK+0AgAKgtZA=
Date: Mon, 12 Apr 2021 12:07:49 +0000
Message-ID: <BY5PR12MB432400E36505319A514C853FA1709@BY5PR12MB4324.namprd12.prod.outlook.com>
References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com>
 <1618064637-16413-2-git-send-email-xuemingl@nvidia.com>
 <DM6PR12MB394563AC0A816499A4D26FFFA4729@DM6PR12MB3945.namprd12.prod.outlook.com>
In-Reply-To: <DM6PR12MB394563AC0A816499A4D26FFFA4729@DM6PR12MB3945.namprd12.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: nvidia.com; dkim=none (message not signed)
 header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com;
x-originating-ip: [207.244.67.150]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: efed4a18-f6b6-4f4e-5555-08d8fdab9760
x-ms-traffictypediagnostic: BY5PR12MB3666:
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BY5PR12MB36668276C26FF7AE641479F3A1709@BY5PR12MB3666.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:873;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Q/NfOQPv5opsGGvQ0qv9rDhY+N/6ZK4d6t1c/Zb+3CWlmtfj+FSbCurL1inS65n5ljA7D9uLTnpfDvuCSwh1x18U8H+rE5/Ah1Jipyseb88KlPvBUEnbvUrbaE8M+PjE5jjcdUmcDK1ZHuX58lDb3qsuiVNJUjkSm5IA0CDY6LN7LXZrKlbEDcxOjAL2LcM/kXLnzvSVTjWUgNieWtQ19DGUX7oYLvcShploluEuImg87LfpC3FFcpAcizu35ut0FRw+tC1RbsilaBATbr6bNimY9Vw4c9ZKWGEitCbn3S35f/1d6IWYfdU2Tl6e8lG+JhOKKguyi7XFUja0O3VZqg1lFzf23NKGTstz121XP/yB4pEHDrV/fqlEkXFYL2YNY297mE5Tsy2GpGxbYLyWOZEECRJFZZR/AmPLIl6zVydAfToqBoUPQ0Dk87q82QViYu1fuWZm1c8A4m9KJVWA2ErLqGKKV9lInEJXVX8sylS+Jyr340AKWAed1ZZELIh5A6pUiaf0B180hMKV2Xetno3faPvELTkesmUyctGP0N1D15yx5XH9ntfcFTMmpBzyNgAvWiwC3vHLvQSJiqPC9w/tlMgdL2lwygAOm2vi71I=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BY5PR12MB4324.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(39860400002)(346002)(396003)(376002)(366004)(136003)(38100700002)(7416002)(9686003)(478600001)(66446008)(71200400001)(76116006)(316002)(55016002)(4326008)(66556008)(53546011)(64756008)(6506007)(86362001)(8676002)(66476007)(83380400001)(33656002)(5660300002)(55236004)(8936002)(2906002)(6636002)(110136005)(186003)(54906003)(66946007)(52536014)(26005)(7696005);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?KvW+kskHFxnGYA2Kme4TtAUxHg067KCOOVIJLVOPI6Z18um7iEkBOPam1KPB?=
 =?us-ascii?Q?x+6UY4w+asF0c/FJgmNYN+9ZdLaGO38JzBw6YPiBsruoTtMf+c1NbUL0S0JM?=
 =?us-ascii?Q?1FYjb5d2XRn1QM/YkTZG7b3ZPKBG927/Lf8uiIoW1LUW68ERe21sFXvIlFH6?=
 =?us-ascii?Q?RVkG7IYDtmED77h460axzpjhdTG+691LCeyWpDrKP5wqJHjuM9gsdLPkXtGf?=
 =?us-ascii?Q?7n5BnXZAwwI+nObGJpJLVw2AmFqDQl3GD7UModF19wdGfbwkiG+PniV9hvXe?=
 =?us-ascii?Q?2BvjZfG1fEeAYIIEsKPFtc6kHmKEEBGHcoIHUE0ea7ALAJPnXWXjxjqfXz7Y?=
 =?us-ascii?Q?l1Iqe09rJYav6nOsckoHqThVBXWo5/ZouotyHu/TNJJY8w/kJIA6OSuXD4wb?=
 =?us-ascii?Q?pTJnHHwF47xc8rzhYp57Vl5AcAE0+clfIktQ5OTtSA4oyxcbQ76UdMuf0Tgq?=
 =?us-ascii?Q?OzjgX0kpKcyyPJhCssQspP3g0za6mA/gX7W9Eg/3hbq0zaHTAJF7GmRjqmHO?=
 =?us-ascii?Q?DjW2nrhkCFafhUoCTz8T6UZRiQ9kQA1j3ylJhgsdYeRaesOy0JY/2xUHwayL?=
 =?us-ascii?Q?kCb8WBBJV+a1EKkRYXUu0uayI+27qKmJLwKcNHbtXzWRCQsbkLUFKOm4JnRG?=
 =?us-ascii?Q?Jr2Wtz5LqFmfGpYwUdjVaCY1dpDicQVpM1RS+YfWjOkaC2gSqwHYsJ1zbXIj?=
 =?us-ascii?Q?tdR2RNcBs648EB21ENbY84QRWvDaMrVbPkO6FXb7sXjfiu13V7L8gEP+WhNX?=
 =?us-ascii?Q?4dif1/0d9tYl/eMeQCWhq/baiB/xtovyOYvqF4PK5UlPDvujQol3ZCUIXhgM?=
 =?us-ascii?Q?NBcNC4hCnabkKJslTTNupcWTsEM9Bi0PfdionsopMj/A0awsfHLXZwkgrNOA?=
 =?us-ascii?Q?t51HItJOXNP1M7judg9Zdyeh2ynSX9lQ4kSh8wG/o6k78ziCJJNlb583lsRa?=
 =?us-ascii?Q?u7q2Ak9rTq50IuI7dz/vt2WQues79KVIjf4G1Ec4Z2AP8M+E3NPDx7ccpGnh?=
 =?us-ascii?Q?SAO07+74HUT2IwOZoc/sPgdrzzM/l1LZEEc3qDDC5CuTsyQXZZXCg6N1gPIA?=
 =?us-ascii?Q?XlxIDN2V8QGVgZfaVOB/N0CGZvUTrs2uXq/TIR9Sh2YGmjM71GLtYxMW11y3?=
 =?us-ascii?Q?8zkY+RRulZrQ6lBv6lDWciIa9pniUtq9u6AG4JOMW/FATLAMkmb0jqNo1zH2?=
 =?us-ascii?Q?2lpjoaNe8+/a9rRkrK5THOsPQHfh9guyqndYpp+myplPkxtQRXHpVJ38Ks2M?=
 =?us-ascii?Q?ypO+qMQeb7VQcJFoMhQhCxmx25rvSen5bKocRHZK6SLUukWIB8ttULkl4M40?=
 =?us-ascii?Q?MkbxH9gRzeHeSi5UysZX5fn+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4324.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efed4a18-f6b6-4f4e-5555-08d8fdab9760
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 12:07:49.2478 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 49yDL2+o7l6zIH3Rr6L3uOuYXFSJ9t5T0bd4fYjTcjW8sewe1/A0p93sJn1vUc+iR5hsqbN1yxMkWDHVdzvrJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3666
Subject: Re: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Sunday, April 11, 2021 4:00 AM
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; NBU-Contact-Thomas Monjalon=
 <thomas@monjalon.net>; Gaetan Rivet
> <gaetanr@nvidia.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Asaf Penso <a=
safp@nvidia.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Beilei Xing <beilei.xing@intel.com>; Bernard Irem=
onger <bernard.iremonger@intel.com>; Gaetan Rivet
> <grive@u256.net>; Anatoly Burakov <anatoly.burakov@intel.com>; Dmitry Koz=
lyuk <dmitry.kozliuk@gmail.com>; Narcisa Ana Maria
> Vasile <navasile@linux.microsoft.com>; Dmitry Malloy <dmitrym@microsoft.c=
om>; Pallavi Kadam <pallavi.kadam@intel.com>; Ray
> Kinsella <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>; Ferruh Yig=
it <ferruh.yigit@intel.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Subject: RE: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer stor=
age
>=20
> > Subject: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer
> > storage
> >
> > In current design, legacy parser rte_devargs_parse() saved scratch
> > buffer to devargs.args while new parser rte_devargs_layers_parse()
> > saved to devargs.data. Code using devargs had to know the difference
> > and cleaned up memory accordingly - error prone.
> >
> > This patch unifies scratch buffer to data field, introduces
> > rte_devargs_reset() function to wrap the memory clean up logic.
> >
> > Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> > Acked-by: Ray Kinsella <mdr@ashroe.eu>
> > Reviewed-by: Gaetan Rivet <grive@u256.net>
> > ---
> >  app/test-pmd/config.c                        |  3 +-
> >  app/test-pmd/testpmd.c                       |  5 +--
> >  drivers/bus/vdev/vdev.c                      |  9 +++---
> >  drivers/net/failsafe/failsafe_args.c         |  3 +-
> >  drivers/net/failsafe/failsafe_eal.c          |  2 +-
> >  examples/multi_process/hotplug_mp/commands.c |  6 ++--
> >  lib/librte_eal/common/eal_common_dev.c       |  9 +++---
> >  lib/librte_eal/common/eal_common_devargs.c   | 34 +++++++++++---------
> >  lib/librte_eal/common/hotplug_mp.c           |  6 ++--
> >  lib/librte_eal/include/rte_devargs.h         | 18 ++++++++---
> >  lib/librte_eal/rte_eal_exports.def           |  1 +
>=20
> rte_eal_exports.def was united with version.map and removed thus the modi=
fication above is unneeded.

Thanks, I'll rebase my code :)

>=20
> >  lib/librte_eal/version.map                   |  1 +
> >  lib/librte_ethdev/rte_ethdev.c               |  8 ++---
> >  13 files changed, 59 insertions(+), 46 deletions(-)