From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DFC6A0A02; Tue, 6 Apr 2021 08:32:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D770C406A2; Tue, 6 Apr 2021 08:32:33 +0200 (CEST) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690088.outbound.protection.outlook.com [40.107.69.88]) by mails.dpdk.org (Postfix) with ESMTP id 48F844068B for ; Tue, 6 Apr 2021 08:32:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E5E89pTNVjNL8HUQ+MyNvVwyBbmgAyHlDDisUsogtgRfWZD/9bwPqMwVOQuzOzL42ZTOo+c6x8FaGB9mFm8HhyVViCtiS3QaH0jwXZAqw+pOS84ImgeRyGBTI1AEZdj6gwE/k9skj/Wrl94aAUNgisQ/mxTsSWDB0hR9SCmdC7KduPyaoVo33Glgq77l0Hr7efCvOhMpAsKg+UAMXi9AcBpdlJ6cRk9uWOc4KFe7w3Jsm0RQ9z8X+uUhiElySzSG9bIVeSFxaOnRCCVBRk55dCni3Sq2LJCILdAWDiU7VVWgYFDq998mLLuhubfjq4geKBKMW6CInC9rE4zhXUMZlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBrYUpCGDtV4X9V7PPvqbYkqQ4BghB3Cy2jpLhZxd3Y=; b=Vjl2jLDVqxVGnibyBYY+0RXSZxbPM7dE5B/utyH5n+5LIg2Nj7iGfw3QGLg/oAtq0zU5vR3sqkUH3DI9Nls3Gkvftu4a7Yf5BKngLddNLtfuQoAVOpEhoAXlc1DG0QPBrQsXQ95HJQwi/TKn6WXEQR0iKquHBAxO7NhlHmfA1v/MEJ9fb+REM5xXjB2sGKzGGDjAbI0ML+QZuOIMH+vAMs+duQm4K6778ThF3tbH/A4FFFgE9H+J1936M8nSGFonri06Coasy2djRLd6q/fFdIk3Da5XCcnOsLvUOTgngep8Vw09wgCUO3fVZjB1uEQZZy9CJKta/gXveZUoi/hdDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBrYUpCGDtV4X9V7PPvqbYkqQ4BghB3Cy2jpLhZxd3Y=; b=EKPLR0NGRHYjy+Qw+jIvoKuIgAY26GkakYnl8ZAmj0xAA9xfm5b7f4QuDf9eO/7Mwqz1cmgoVayb8QQuOgCg4bz9sUaPYhBiGl94KI8ZwRzuvhv5EoVOPw3ghCY41XcNYdtnhT5mk78/i5Fx06qeTKIsWxEBBJCi0WukeLmkascpwo5/UWiiG+USmIxUjiZDoYkgOKS5ijN6D9nRmptve8l6NIn5+05ICyLCNxQG4FjnlnSVKNcLQ2ofRf3flI2sfvZvca2SPSwfqAdA5aVpj9Zmia7lg5PTDUL6BNnxNtEUJmUIlW9XfRIMB0pcHwB5Oht0Zu4jmVo72q9zL9oajA== Received: from BY5PR12MB4324.namprd12.prod.outlook.com (2603:10b6:a03:209::10) by BYAPR12MB3366.namprd12.prod.outlook.com (2603:10b6:a03:db::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 6 Apr 2021 06:32:31 +0000 Received: from BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::b919:53f4:6757:331c]) by BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::b919:53f4:6757:331c%5]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 06:32:31 +0000 From: "Xueming(Steven) Li" To: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" CC: "Xueming(Steven) Li" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types Thread-Index: AQHXKfw7hXzH99GtpEGP3tREW/aizqqnCONg Date: Tue, 6 Apr 2021 06:32:31 +0000 Message-ID: References: <20210331223423.2089467-1-thomas@monjalon.net> <20210405091506.562830-1-thomas@monjalon.net> <20210405091506.562830-3-thomas@monjalon.net> In-Reply-To: <20210405091506.562830-3-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [207.244.67.150] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6c0b3bab-2c0e-489a-eaaa-08d8f8c5c1c9 x-ms-traffictypediagnostic: BYAPR12MB3366: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ETss4QtvfmN5c8ZnC8X23CnlL0R2j3vsWkbyvQLrLuUQrlPfSzm8dNjtVTRr/ojs7WK9ctGPT7ZEZWQ6ZHmfO2NuOPzEg/nvIlQVGqBH0B5K6MzKP0oJIhXFAdmGphA6wW94QRaYQq3zeVZMEcP8wS9YC9mHwgoERUgmfIgtxD1kCFou6NcSnUpZqMJISZbWBkFn4UVsA+1QcL/pnkA8OxQaystmW0BzdswVCs9XhM07xrwI5E2Asy39MKrwBDxgjXecPworiJnTeW9uMe1yd0EGdMC+6UikUj53JvSny1suqsVkVT6Azs6HxOcaC/mAfPhTc3ZQOimnUhnbnrUQVlO/8aeYG365j3esBzqYRw93qQxO02VrKYVGWDgkTTqolyPkhAY+TKq23guavRn2cqUmwzUuj/AW4MLWn8ACS+SBLe8nBNy9fMeuB8e2ghI1Sgw0i9WjDJe9ZthoI7IGGj1PKlBfKbhcuDZqFu9NBa/qqyfO6x5YwAmoSXOxEAVlypCn0ZaSxXnVlmKjq8ZRST8SwhWkJ2n7ykNBTkI3ZL8rNdT5rW4NrxR2BSC/pABiSyFbynXAxJ2DKQIlC+W7n+xBkWcvSfDeMoi4Ic4C9Dxg6mveFXzdoqfV1h/+0Eqwg80lSv2eSLNagK4MIrR0hp0iQBfczdNEKHTruIXn6BY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4324.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(55016002)(52536014)(6506007)(83380400001)(316002)(110136005)(8936002)(66476007)(64756008)(4326008)(9686003)(76116006)(55236004)(7696005)(66946007)(71200400001)(107886003)(478600001)(2906002)(5660300002)(8676002)(26005)(186003)(38100700001)(33656002)(66446008)(66556008)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?YO2HZRfwxOq2YJ7Ni9cOWBmxrwFQx55feD1KlYxHDfoYRecv5fmf7wU6EBCP?= =?us-ascii?Q?kpmXPWE4j7a4Funu4d2PYaWOg/Dq0RuXJHQy73Hm1/qWtAcHS5MTdoIbahxL?= =?us-ascii?Q?bbcGdfvkFbWpDZ80Vmuaj/mL9I72BoVg+/z2lkHWYOM4N5co13Vji0VA4KRP?= =?us-ascii?Q?UmhGqoxD1wOBc83+WpffI3qd0vgw1tCdWBOwe630/hLe8geDmEjmBPp2xyZN?= =?us-ascii?Q?50Fd+zEqOm+Sxv7iGvxroljr3N9mTUxkHtvrm6YqfkLDt5URC17FIr2bJW++?= =?us-ascii?Q?QsqdfzJ4EeBlq03JiF5M1Gz+nCVCx9AlJq9D/KDdWRN7cIu4Qspy0kQwmgqX?= =?us-ascii?Q?k/wvMoQPOdAI8a2yTy2myP+Yhtg8KVCnBtUHQD2sJPDgUnxJ0mzTK8vDxgLm?= =?us-ascii?Q?FrzGk1a8aCslVQcz8M0R3/OS/iiMrLBtmmbPhcC9rBVUrQYT+V0HfClwLgGM?= =?us-ascii?Q?/2r/ifPzPQ0WxzApx+79QGRbV5jENg/3432vsZLFaOr6lQw7LqXzjy+NoVdt?= =?us-ascii?Q?3E8ARMWr8HETnP0LZ5HUyCXEkxX9LrX25CDeE618egstlKMObDUXpUFxugP5?= =?us-ascii?Q?FtEcDlpnpoJd1LRyARzTVI9KlKsHtOe9Fpq5KBHAMXkMq5qLNnlim0cF3Ew0?= =?us-ascii?Q?1Pt3k1tG7tJF0Vvs+wrdcFH4OfmcjPUVdmiNIQYpJZ+hXdryXC0sT2Gr+g53?= =?us-ascii?Q?N8UV9ASCu+P/7wAtaNN+iLN34oXQgTuB+fKMrPUzPr/TFZvy7VJG+q+45TfD?= =?us-ascii?Q?NAe70OcWRdTu0c2Q2Z46FFKJh4t1ghSXcMeSgDET6q6uAjF77vJRcyOWbdtt?= =?us-ascii?Q?9o4Xkh49XD40Z9uDkFk+4zAgxcTIfjvVFXuGb90AjM7CFSs9Q1YQ3K50JftO?= =?us-ascii?Q?Vl3YYX8g7GRL0YlPQJWuTPSUGMer5lUO/hvPTFAfXfS4p58LKN9HIxFvzAOw?= =?us-ascii?Q?HN61EOM1MlyY0kCtzyIoQzmARmOexaOlqSmOyRLlb8yzttSh0tiCSr2MtXqJ?= =?us-ascii?Q?pBtFkoX1RObzNucZWWZ2vMkvkopHfL9DAdX3ai4mzEAzo1Olmj8G29/x2Wnr?= =?us-ascii?Q?0P4WHDCzZ3NmCbrvBdWikr/ElV4fsGkQbALoVULWIQtCbBUd/eDAoBz684iV?= =?us-ascii?Q?HipVGz5pSMR4HPkcs6i4lUX4jdZVfNYZ3JGFf0QHg6/lrnqSAnpte9wASMsu?= =?us-ascii?Q?E/Y951IHzf/gUl+/l0cOj+3WfietTtjVu7TG4wIIfv+kS2JBYC9KMeQhz/jL?= =?us-ascii?Q?PzbRTo2SpolijrkNphmP2O8kwJ3IPKIxSxPRycNEfeP8sc+C90PzQimLXHjy?= =?us-ascii?Q?3JYOOKVZptASyVbaPI+Nijo5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4324.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c0b3bab-2c0e-489a-eaaa-08d8f8c5c1c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 06:32:31.4290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NDILC/2i9TKq1CVm9oR4CQRJBRIPLwrOSfrZAbf1AN3AZpRA6fvcBCVKHkpCNhQ4IfjPtW5Z2qqoNuSu5prQBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3366 Subject: Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Thomas Monjalon >Sent: Monday, April 5, 2021 5:15 PM >To: dev@dpdk.org >Subject: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation = types > >The names of the prototypes pci_probe_t and pci_remove_t are missing a pre= fix rte_. >These function types are simply renamed. > >No compatibility break is expected for the applications because it is cons= idered as an internal name in the driver interface. No long line warning with checkpatch? Besides this, Reviewed-by: Xueming Li > >Signed-off-by: Thomas Monjalon >--- > drivers/bus/pci/rte_bus_pci.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h= index 3a092bc6d5..64886b4731 100644 >--- a/drivers/bus/pci/rte_bus_pci.h >+++ b/drivers/bus/pci/rte_bus_pci.h >@@ -112,12 +112,12 @@ struct rte_pci_device { > /** > * Initialisation function for the driver called during PCI probing. > */ >-typedef int (pci_probe_t)(struct rte_pci_driver *, struct rte_pci_device = *); >+typedef int (rte_pci_probe_t)(struct rte_pci_driver *, struct >+rte_pci_device *); > > /** > * Uninitialisation function for the driver called during hotplugging. > */ >-typedef int (pci_remove_t)(struct rte_pci_device *); >+typedef int (rte_pci_remove_t)(struct rte_pci_device *); > > /** > * Driver-specific DMA mapping. After a successful call the device @@ -16= 4,8 +164,8 @@ struct rte_pci_driver { > TAILQ_ENTRY(rte_pci_driver) next; /**< Next in list. */ > struct rte_driver driver; /**< Inherit core driver. */ > struct rte_pci_bus *bus; /**< PCI bus reference. */ >- pci_probe_t *probe; /**< Device Probe function. */ >- pci_remove_t *remove; /**< Device Remove function. */ >+ rte_pci_probe_t *probe; /**< Device probe function. */ >+ rte_pci_remove_t *remove; /**< Device remove function. */ > pci_dma_map_t *dma_map; /**< device dma map function. */ > pci_dma_unmap_t *dma_unmap; /**< device dma unmap function. */ > const struct rte_pci_id *id_table; /**< ID table, NULL terminated. */ >-- >2.31.1