From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F83AA0524; Tue, 13 Apr 2021 01:37:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F6CB16085D; Tue, 13 Apr 2021 01:37:35 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2055.outbound.protection.outlook.com [40.107.237.55]) by mails.dpdk.org (Postfix) with ESMTP id 5BF304067E for <dev@dpdk.org>; Tue, 13 Apr 2021 01:37:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMLhQ7GauUTjDDsRHBzL1x2lCg4ytWaJtx7kinONj7aX5JbpkcAxyL88xoYDPnVg26mDqtaa9OBXupIVRR8bUmOLmWu1mvtg3Fwt8pkhIJT3WI673zBkPF6Fne0mat1GVgh1Y0D/9+zFsinj8y+M+c2kH9/ocKxSwUPv44Lsbjc2/Owe2Zu7JKOCXUqoziLfon5EofmUwjnp+TgwQGQ1KM/F24RitCq2Fmvj7G9jelLuipJ5QSQ0yVTmF3JoUCDu9FljZdkn/cXJeFTNWWDr0n+5BmX788NUUeMAHem8N3eSkQNZAJhREDQD+Dk0SQ6ToIvY2WonDcGb1FJ3+5sbJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+wmhOnNow79eddbA4GNivAcf7iExo7ro20PYSC73VI=; b=QXVqez4Nm7KAzeXktiRdWUpGBFrRAzYT2Yxfz9UixlytauaLa92exqqpAVg12z9vk6BnlU0aCwcEowD5BGSlwjiKAZtija8rHJHqtQk4O1XR1mDadlKJeT5AncOTlpzzwsxz/Ho/d+PaGTIfewOffNTTosV+wuJhpDmXKfee1ee+/6dMmgf4wpvQ8TBk4zj1G3cPmdi8VxL0qdL+NgVDYDn3UBU4v7XSlf1BWm2BxUocwiEMYrlSgKdg7BFu4t4SnImGrgU6WQAoeB6NoqNkfTmNNH4DZqr42J+Uei8yvpIRjnrhGFfJ3nui3PBROrZs241bCqr5JcUQq5TphkrOBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+wmhOnNow79eddbA4GNivAcf7iExo7ro20PYSC73VI=; b=cGJyAKuQvVL13efEPbdimF/MtCw5BCv4QuiW9oVGTWfjK1DOrV2ll3TiEzh3hhZDKF1A1Oa8TxgcGqv/hGe5ycxJPbcUaqynHtpye7E8xkbZqYrmo4EyiH0aUD6kUg/MvE1Ijl9Xo4I1xaIazFuS9ALsYWYiY+JaHbk+x6v/ZkDxH8LQ+304GHkzjAyqY6yQo2oZp39F31ytkUk72TNPedU7isTpH0b5ViuvLEFXchm+5fzOai5ly5U2wTSWa9HHG2Lao1qXg85UwOi/TJ9d2Opue6KN4m2T6t3nFdkuOT9N8WIHgvPEci18Hf4ofeqEQKFDiKQmgwsLn03YPxxzDA== Received: from BY5PR12MB4324.namprd12.prod.outlook.com (2603:10b6:a03:209::10) by BY5PR12MB4903.namprd12.prod.outlook.com (2603:10b6:a03:1d6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Mon, 12 Apr 2021 23:37:32 +0000 Received: from BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::b919:53f4:6757:331c]) by BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::b919:53f4:6757:331c%5]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 23:37:32 +0000 From: "Xueming(Steven) Li" <xuemingl@nvidia.com> To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net> CC: Gaetan Rivet <gaetanr@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>, Asaf Penso <asafp@nvidia.com> Thread-Topic: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing API Thread-Index: AQHXLhU5AJoFhjfgIkWZBhQpi6qKU6qxZhSAgAAnMxA= Date: Mon, 12 Apr 2021 23:37:31 +0000 Message-ID: <BY5PR12MB43243D1C2B207F99DDFE5631A1709@BY5PR12MB4324.namprd12.prod.outlook.com> References: <1618064637-16413-1-git-send-email-xuemingl@nvidia.com> <1618064637-16413-5-git-send-email-xuemingl@nvidia.com> <4995828.0Bq7md6tjP@thomas> In-Reply-To: <4995828.0Bq7md6tjP@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [180.162.52.50] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f30c18a2-f853-4409-e1ac-08d8fe0bf16e x-ms-traffictypediagnostic: BY5PR12MB4903: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BY5PR12MB4903C3BF077A9982DCF6333AA1709@BY5PR12MB4903.namprd12.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2Y1WR8N57e8S+Os7ueKoswy7t3VnJa8y1e1UcUCefdsQXVM0TLgwrznCpLlJtbP8SAoOv7Rp7LBynlR6PcxYsG4Ddlj2wCmCISNi1VscbCuhkXPvBdbBHzzBRwcMhPEAQBT/aWD29wvM+4ucn7iLxQRSr2dmh2cpCrR2uMoPTFRFpDu6ZGt3Sv3O0YSEeCzViiii5REt/66vsNc33XEju7jtSGSFU4qBWpxuhF2DHGIYlFaN0doL5OKR+z+lYdEzqVY9k9tKk3hpUvf7/O82xiWcAhh+8lL4QZg0OXMkwZzAf7EaYT0tM6rov/MyHDtiW5bEypjeG5LUG4snoSrN21/VDFJ2DYYNOmjDv3VzCRUZUnUb12hZhWokN+Fw4PxpT6z6H/LDJ1XljahhXVV3lmFDA2U70j1YoviLh9cFZIK+QUFE1af8mF9KfEvInT5bgg6vyu4yLyrILmh5JduSSRxOqKzCmui5YVFS4UxgBmtUem8xf7D04ceocxZDUaMDVcHZGPaHfanH+CyzTp8KEKVkA3mrlXjTXSEqcmi7C4hozIyHy3TZRyzEYquAvmBp4Pg9QPkUe/+mL79ohMFmYiNcGmM1AXu20mh36XfyN0Y= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4324.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(376002)(136003)(366004)(346002)(66946007)(26005)(7696005)(478600001)(71200400001)(76116006)(9686003)(66446008)(6506007)(66556008)(53546011)(54906003)(4326008)(66476007)(107886003)(55016002)(64756008)(186003)(8936002)(52536014)(33656002)(316002)(86362001)(83380400001)(5660300002)(8676002)(2906002)(6916009)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ttyfc3P6v+wqq7x6jyEuf09AvhJ0Kb7IKazrFUQ7KVu1bkU6Mnph6U61zKYl?= =?us-ascii?Q?I70XjEsPAPVYmkFNxH0tgKpD+dDtv/Deh/5sG2WYgPW1oWR/h2bERoCOhfRu?= =?us-ascii?Q?MrIYxbLIQBZYr0lfosvvwObrWvWEBdGUHuITscp2RWCjBIN5TXCGJpH7zy35?= =?us-ascii?Q?oomV9jQvY/bbb/YhKmEXSC/t46viC556nu/bNj+WTjBU3To9yxjbvsGUOxK1?= =?us-ascii?Q?5iEDGz5mnal3uat5jXpLOOx3RyOBnMaXqWmD8rBBbNeUJwqSrwx71rSLA/Iw?= =?us-ascii?Q?LIKl8tCgxHdbyqZf5KW0MBM3d5MK4kK3yp/9BE0DjKyoouqa0nJ8owLVDlMM?= =?us-ascii?Q?/DMA0KCxVKVPx8T3SysyUUBkoLL5es4WS0u/vX8FSSm8v9EDvynMybOX6ZJ6?= =?us-ascii?Q?vLlrVkYTrMW8lRHJibtqK5i1cXG02CEKS8tsTLpAbvD7eaa/sfKFfQH7lZxh?= =?us-ascii?Q?8OlzdQX2wLZ08rhcx2txzNQvcVz2pBCAyNxj+EWCzS3qHH1zNRoLzbqi0tco?= =?us-ascii?Q?w+EXPn9r4hufiCxCM1EqUxxSkdo7b5RFpwaiQ3CveQOdSywl2hVcvESPlBL/?= =?us-ascii?Q?zt3yM70XKv3WDS518jWHYe5AV6XNVjIGJIZM9Eyo5a1Vn9icKOKJSUHaxl4s?= =?us-ascii?Q?YAfINTqAhNeTQ7czJfjav0okBZahpK5TpJkfYvyiWg3H6/c+w4az5JkLj6Li?= =?us-ascii?Q?5MLSFu7oBufxFbjD50ZGmX5XabuFJYjF1saJBGHXIWkzOYOHopysj5WwB7Rl?= =?us-ascii?Q?2l70wpL7WNZvX1CZ6ccU1GiLQm/t+ibYQTknYKdfKVH7IehcIRHmSltLMPJV?= =?us-ascii?Q?iilX5N3hrloDHNIxBUuLijVOr/Gmop40cIoTnTDFArPAHwOkaNqZqUv8C64G?= =?us-ascii?Q?ZrVOdsnCWNkwmyOlyvKBmG1nt6JCNDOTGsRrHkXQWa2TgDK9Y44ZKMNawzLJ?= =?us-ascii?Q?ma1ASrEaGt2hlz3AAQnNilrfjMfIIqCUM7dQajRyvUR62MkW2zzMVsHY6DJ5?= =?us-ascii?Q?11xXKl/6eyfserZMyywIp6s0hSUUTyWH45FFfLkARgHfL/LEepMjKpHMe563?= =?us-ascii?Q?JSeiP1faCi4l1tvVvS4G2QRff+DBTAZgfGR3F3kjKUVUivYcYIgzBCrvYAFF?= =?us-ascii?Q?hvahAuKeXe/tCJr7fZSGQG331FCdC21psELPHtnmTrhEQDvMoF3HmmL+zDc7?= =?us-ascii?Q?JUsb0O4HRbyEWX5MlT9QXg2oMVE5donnDHn/Z760uDcA0QDaqJBR2Bx5bOmH?= =?us-ascii?Q?e1OQ6+2WXyGCYlj7NF8c3Q29arcpWmT0V/gt23f5dz2JZW8GNvrxVumyObWL?= =?us-ascii?Q?7HhzSh5vLZ8qKjzEBh213dEr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4324.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f30c18a2-f853-4409-e1ac-08d8fe0bf16e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 23:37:32.0212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6BaBaCdJiCD6HMi4SIhMFcTRXBd+lbPl/wwvKjgqLU/UA1QMCrpUTAsKQqtGSE4BLHQKzjD2qQ1ax7BEhzrm0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4903 Subject: Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, April 13, 2021 5:17 AM > To: Xueming(Steven) Li <xuemingl@nvidia.com> > Cc: Gaetan Rivet <gaetanr@nvidia.com>; dev@dpdk.org; Asaf Penso <asafp@nv= idia.com> > Subject: Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name par= sing API >=20 > 10/04/2021 16:23, Xueming Li: > > + /* Resolve devarg's name. */ >=20 > s/devarg's name/devargs name/ >=20 > > + if (bus && bus->devargs_parse) >=20 > Please make checks explicits with !=3D NULL >=20 > > + ret =3D bus->devargs_parse(devargs); > > + else if (layers[0].kvlist !=3D NULL) > > + ret =3D devargs_bus_parse_default(devargs, layers[0].kvlist); > [...] > > +/** > > + * Parse device arguments, setting the device name in the devargs as a= result. >=20 > It should be > " > Parse bus part of the device arguments. >=20 > The field name of the struct rte_devargs will be set. > " >=20 > > + * > > + * On error rte_errno is set. >=20 > This sentence can be below (in @return section). >=20 > > + * > > + * @param da > > + * Pointer to the devargs to parse. > > + * The 'bus_str' field must be set. >=20 > Why "must"? > It should be optional, so this sentence should be removed. >=20 > > + * > > + * @return > > + * 0 on successful parsing. > > + * -EINVAL: on parsing error. > > + * -ENODEV: if no key matching a device argument is specified. > > + * -E2BIG: device name is too long. > > + */ > > +typedef int (*rte_bus_devargs_parse_t)(struct rte_devargs *da); >=20 > [...] > > + rte_bus_devargs_parse_t devargs_parse; /**< Parse device arguments */ >=20 > Should be "Parse bus devargs" Thanks, will fix all issues in next version. >=20 >=20