DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode
Date: Sun, 28 Mar 2021 13:14:33 +0000
Message-ID: <BY5PR12MB4324C5002E23951A92DC9978A17F9@BY5PR12MB4324.namprd12.prod.outlook.com> (raw)
In-Reply-To: <8ae67994-0410-214f-b033-d60b9b681505@ashroe.eu>

Thanks for comments, new version sent:
http://patchwork.dpdk.org/project/dpdk/patch/20210328131222.16584-1-xuemingl@nvidia.com/

>-----Original Message-----
>From: Kinsella, Ray <mdr@ashroe.eu>
>Sent: Tuesday, March 23, 2021 5:59 PM
>To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; dev@dpdk.org; Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>; Dmitry
>Malloy <dmitrym@microsoft.com>; Pallavi Kadam <pallavi.kadam@intel.com>; Neil Horman <nhorman@tuxdriver.com>
>Subject: Re: [PATCH] eal: update all buses default scan mode
>
>
>
>On 23/03/2021 09:57, Dmitry Kozlyuk wrote:
>> 2021-03-23 09:34 (UTC+0000), Kinsella, Ray:
>>> On 23/03/2021 09:33, Kinsella, Ray wrote:
>>>>
>>>>
>>>> On 22/03/2021 23:32, Dmitry Kozlyuk wrote:
>>>>> 2021-03-16 20:45 (UTC+0800), Xueming Li:
>>>>> [...]
>>> [SNIP]
>>>>>>  	rte_mem_page_size;
>>>>>
>>>>> New function is private to EAL, so it doesn't need exporting.
>>>>>
>>>>
>>>> Right - it is annotated as INTERNAL.
>>>>
>>>
>>> Sorry, let me be clearer - it is being correctly annotated unless I have missed something.
>>
>> This function is purely internal to librte_eal. It doesn't need to be
>> added to .map or .def. It also doesn't need __rte_internal, like other
>> functions in eal_private.h don't need it either.
>>
>
>ok - I get you now - agreed.

  reply	other threads:[~2021-03-28 13:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 12:45 Xueming Li
2021-03-22 23:32 ` Dmitry Kozlyuk
2021-03-23  9:33   ` Kinsella, Ray
2021-03-23  9:34     ` Kinsella, Ray
2021-03-23  9:57       ` Dmitry Kozlyuk
2021-03-23  9:58         ` Kinsella, Ray
2021-03-28 13:14           ` Xueming(Steven) Li [this message]
2021-03-28 13:12 ` [dpdk-dev] [PATCH v1] " Xueming Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR12MB4324C5002E23951A92DC9978A17F9@BY5PR12MB4324.namprd12.prod.outlook.com \
    --to=xuemingl@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=mdr@ashroe.eu \
    --cc=navasile@linux.microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=pallavi.kadam@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git