From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62BD0A0C45; Sun, 11 Jul 2021 12:26:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3E394067E; Sun, 11 Jul 2021 12:25:59 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2089.outbound.protection.outlook.com [40.107.94.89]) by mails.dpdk.org (Postfix) with ESMTP id 01FC140040 for ; Sun, 11 Jul 2021 12:25:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MbC7x19mvRDSHL8W/G7pzFg8x0pUi9m1z9JPwxGr6S2VJNei6hudtshB7O6v3TK/lKBJXj/agvN29bJPeu9at8sDocQXe9zrgGJsH4DEv6W9rIBoGut3S21YIwrG/kMkqlQHuql/EWZKkQddZmNSPYqyNGKa0APcGYmPxo8EpCc8eI7thODM96bLe3pOlBhbRcDPn+Xo+J4UCyy6Tx5x27HZ7g/ynqUcYEl3GRRHBI+MiYgDhikn8ZtL7AywuF1CFS5WCkTnwwFMTSNfyYw87EZGxBcx+cCEZjdp6fbt+Z/XY92onSEwDqHFCgRR3QzkeFNQfX2csN/gDhS4Yrg8hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iHWRjHwUrfjwbqJ2gGv0awLdn4SdrDxXkjU1OdZb+7g=; b=XffB+nTiuS1BuvO3q1UwUirwPw/uJ9kVFyM1IdxG55eoIxLin8RT8RgITZ9U2CjqNCEk4TxV56ffqoolVy93CdhmBIqJ4grRegT8W2Yj+yPVHMyYHOc8W5B/zYxOOw3CE2iITjNgkbGRbMQA9ccVXzL5RosFbhUOpYpJpEFwQqPkurFota3aZGeBQ6aEfjntbZkUAC2CpMbJaNnSN6XBNX9D4mDqiDrQFO9H3WaR918CSxeKt39iqXUrVfkX4pgB+KPTEllXrD3v9GA3ZXIrg3tx4gmoNWtSS5BnJJh8FAjo1kQvo7weiUSXI7DqJ1McFr7OZbKxXdtqDNc/LzmHMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iHWRjHwUrfjwbqJ2gGv0awLdn4SdrDxXkjU1OdZb+7g=; b=aPS1v4bfKqRHKr+sBVewSSnfRMwQrj2sVMmSfJxQuW9caPQYSZqduHDTZtY6quGKk/Izpkq0EoC7wMAblVgO+nrkmTy7U6AYO29WSpTdn59yQSYMjpA4VDZFGfX6zYrYwvFUSRVyxoZMDPGCcZE6jS02h1TM5ugQemEpFtIOURlfdY6Kpn7QBQSuPFMhFfH69EdPuIvBHfU8MlMT2lLMhp/zXutuHqN+YfeXOjVYc2XxeB3nIxCZBTAjq2/y8qWBFZfA/aln7kx/C5sqbT6eumga5P5sRDEDwPNLsk6/fE9SO0vXOf5kpE17igYlcBeOsYHicZX6QZPl8+k/H6Qxxw== Received: from BY5PR12MB4834.namprd12.prod.outlook.com (2603:10b6:a03:1b2::17) by BY5PR12MB4195.namprd12.prod.outlook.com (2603:10b6:a03:200::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Sun, 11 Jul 2021 10:25:57 +0000 Received: from BY5PR12MB4834.namprd12.prod.outlook.com ([fe80::3814:b909:389e:4030]) by BY5PR12MB4834.namprd12.prod.outlook.com ([fe80::3814:b909:389e:4030%5]) with mapi id 15.20.4308.026; Sun, 11 Jul 2021 10:25:57 +0000 From: Gregory Etelson To: "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" , Raslan Darawsheh CC: Slava Ovsiienko , Ori Kam , Xiaoyun Li Thread-Topic: [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field Thread-Index: AQHXcZQ/gxTJXm15K06E9s72E8WF7as9ma1g Date: Sun, 11 Jul 2021 10:25:57 +0000 Message-ID: References: <20210705115217.4768-1-getelson@nvidia.com> In-Reply-To: <20210705115217.4768-1-getelson@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b658aa4-918c-417f-5dfe-08d94456458d x-ms-traffictypediagnostic: BY5PR12MB4195: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 78LL7hYl6BPUCymvpMNjlDLiSwa4v5laR12qawz/41x6OUbvcVvYaWFMJDSEr7ywcZSTbMttkVS5zhCcTsbfzEbjCjXondJNOnoqNMzsSGbomjD5eSlqyvidbA37w7jmuCNGKGYqbkneEdYzvIktHAoHzadPyMKarW1oadPBJlrNntGAxEV7adEcD3DJComaeF1+7p/cTOZ4iuZKOacNu2ytFKfXxLEAI4kPti5hSy4UOOl5rumOurQR+vsafQ5G/PzYaMqtUUwzarOiJb4Lbo4BRoNB5U0XKTXJWM8v0PjUUrj3PC3V+v6xSbOoU4bjxdmOM3X2h8VeG+frYvxFQN1APy/PzDqCmdf7/H92d60Ls0RFMFg/0IGLRoumhc8ylfIsP9Gbdt6WWm7pwffyuXHF8iFJFlmd3TA4VPznaarR/Y0TUAW3oJlGrzmY3aNcobdVfSDjVn9w601+o8G6F1CcvLXndzFSZk1jFAwI7wLl3a2B5kXk7F8Rck5iy6ME1zl011RTqCG2CeizWpaUKk7m5amRY3J9Tzfg6sDTWTr3LrbgBA/0Xs8/f80dUcvhCsKv2iNFPbIQXHoaq0YWGuWKFmeuw8qLQ9h58vEPkuv4TziyqPfCw+B/jCH8Un5objBT0G3GywEtLET6s2jsJw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4834.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(8936002)(38100700002)(64756008)(76116006)(122000001)(66556008)(2906002)(6506007)(5660300002)(71200400001)(9686003)(52536014)(55016002)(53546011)(26005)(66946007)(6636002)(8676002)(7696005)(66476007)(4326008)(83380400001)(66446008)(33656002)(110136005)(86362001)(316002)(478600001)(186003)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XVGpHPmYLiBRciEGt0wTIdXusi5uTaweGTL/tGDbR/KYL33i/gneRIDEn4JC?= =?us-ascii?Q?8+313TU2ZbOarc55sK8blsLlaeAwPBCYh9Ug6/Adwij9jtX76MqmQfP5DG8B?= =?us-ascii?Q?kB9OLAd6ptozua1YIsMLAg2+bC7jtc+7TyFxUc2xUvYez60R4tuwqEBQRsw3?= =?us-ascii?Q?ZLwzbeP7HVKXR0Nj3Hu8GyVp2xox5soErzSFsUuuAAaFwPpS+7EjE2J5ukcZ?= =?us-ascii?Q?fPIigLW9bi2MqQIvBOika9iUvyyvjM7ZdT9DgbQo5z6Vcrsb+ejMbIr5SSSQ?= =?us-ascii?Q?zbKpHfNpebN521JirMzjzESel3xxJMpSlEA6WQA5Lmv9HsXAROgNhawMwTNj?= =?us-ascii?Q?dvUMvVM9i5s2LZdjBoWIRcq6hK20KZlo7I30P3fYIvfAQL5l+YECeTr8Kwm/?= =?us-ascii?Q?rSkSv2Nmk8GAp20PLHpy7WNMT8n1d8ZxNOimfwUhKEqt+k11JAGiAkF41QbM?= =?us-ascii?Q?7T5dvH2ck4Zyme0Dp3UPslp4TGvjxls2VPoDoqx+aYEVOl9PiEDDhZNZeVmn?= =?us-ascii?Q?w/RjSot65qmyZqTBS+87rejokuMpS5RBYvPg5qujfwVCNHW1f3b/9nfO5yL5?= =?us-ascii?Q?dcnSqWQJUd8F9k/Imm1XWh7mbOiqIfKOURZhbYdM2OnXiYjjW6zz1LFktzLV?= =?us-ascii?Q?8Sxoksl5Nn8KSUkQbOe7xJXM94+J1uwa2lySVKI2BP+6Hzg3Gp2WJPZ87IYF?= =?us-ascii?Q?dEBtEb2CneEKiMVS+sZvnj8cwxeuzyvJj4G7fwohYp943Sk7e3AMwX8/wr/1?= =?us-ascii?Q?a48SfSQprn2DTbzqDHUV1Oukn8BvS7S2V3teS1ZmkMeDngqZJNyXqV8b30Ty?= =?us-ascii?Q?4EgaT6QxVQdV+veze2pa+cyME3FjBSMoesz14y1torRbJAqbrV/ogqjoe1Cx?= =?us-ascii?Q?8DzoRW23Ex09msrBxVbLopGIbWOUyVjPcSwvMfHm/1gRTAzFFMir84sVbKHd?= =?us-ascii?Q?MifujHyIx2pMH6uZAibBWvf5aDBTEjCFc8vovKIZunuy/QTsxkYgD62oP1T/?= =?us-ascii?Q?E76aCvoMjrmjEZ/rgh6k32vLsiHup70lAOUcTmNsPh7Ch6UCDgfNo43e91ZH?= =?us-ascii?Q?Gd31LAebU80cJ+ZmjqKxrncLwnsGufFQvUKTwweHPCRBVb+5jKwmWLfB36B6?= =?us-ascii?Q?IzCY3NgOvxDrdC4JWWN9ACRqYVN1HvOtdjpWqCy48up0r+8A/j+zmuuR6bqV?= =?us-ascii?Q?FUSQ+xYdfCiaYhlvGthDcWruX2vxgbcVGJDu6+HJGWEkN9kjlb+inFbiPoi6?= =?us-ascii?Q?L96jy7G5XJu7znsrHOtokSMULdKNnxtjtFMHbp/ZCvI1MxXfUcNJOM5PnPtR?= =?us-ascii?Q?G1WdK7OZs+sr0JWNLTyjvw8f?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4834.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b658aa4-918c-417f-5dfe-08d94456458d X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2021 10:25:57.3355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2lIlAvM33oxpull1CYiZdsLiGdpETBWHH+8ImCovraCoZYGVIXDv/59eAzwiu3L+LofLK9WlyV+wUSAURlspTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4195 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Andrew, Can you estimate when that patch will be merged ? Regards, Gregory > -----Original Message----- > From: Gregory Etelson > Sent: Monday, July 5, 2021 14:52 > To: dev@dpdk.org > Cc: Gregory Etelson ; Slava Ovsiienko > ; Ori Kam ; Xiaoyun Li > > Subject: [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl > field >=20 > The new item allows PMD to offload IPv4 IHL field for matching, if hardwa= re > supports that operation. >=20 > Signed-off-by: Gregory Etelson > --- > app/test-pmd/cmdline_flow.c | 12 +++++++++++- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 1 + > 2 files changed, 12 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 1c587bb7b8..c1c7b9a9f9 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -173,6 +173,7 @@ enum index { > ITEM_VLAN_INNER_TYPE, > ITEM_VLAN_HAS_MORE_VLAN, > ITEM_IPV4, > + ITEM_IPV4_VER_IHL, > ITEM_IPV4_TOS, > ITEM_IPV4_ID, > ITEM_IPV4_FRAGMENT_OFFSET, > @@ -1071,6 +1072,7 @@ static const enum index item_vlan[] =3D { }; >=20 > static const enum index item_ipv4[] =3D { > + ITEM_IPV4_VER_IHL, > ITEM_IPV4_TOS, > ITEM_IPV4_ID, > ITEM_IPV4_FRAGMENT_OFFSET, > @@ -2567,6 +2569,13 @@ static const struct token token_list[] =3D { > .next =3D NEXT(item_ipv4), > .call =3D parse_vc, > }, > + [ITEM_IPV4_VER_IHL] =3D { > + .name =3D "version_ihl", > + .help =3D "match header length", > + .next =3D NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), > item_param), > + .args =3D ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4, > + hdr.version_ihl)), > + }, > [ITEM_IPV4_TOS] =3D { > .name =3D "tos", > .help =3D "type of service", > @@ -8123,7 +8132,8 @@ update_fields(uint8_t *buf, struct rte_flow_item > *item, uint16_t next_proto) > break; > case RTE_FLOW_ITEM_TYPE_IPV4: > ipv4 =3D (struct rte_ipv4_hdr *)buf; > - ipv4->version_ihl =3D 0x45; > + if (!ipv4->version_ihl) > + ipv4->version_ihl =3D RTE_IPV4_VHL_DEF; > if (next_proto && ipv4->next_proto_id =3D=3D 0) > ipv4->next_proto_id =3D (uint8_t)next_proto; > break; > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 33857acf54..ab7e91ad6c 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -3654,6 +3654,7 @@ This section lists supported pattern items and > their attributes, if any. >=20 > - ``ipv4``: match IPv4 header. >=20 > + - ``version_ihl {unsigned}``: IPv4 version and IP header length. > - ``tos {unsigned}``: type of service. > - ``ttl {unsigned}``: time to live. > - ``proto {unsigned}``: next protocol ID. > -- > 2.31.1