From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 822C1A034E; Thu, 4 Jun 2020 07:59:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F106B1D5D7; Thu, 4 Jun 2020 07:59:43 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 045861D5CF; Thu, 4 Jun 2020 07:59:41 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0545u30g004012; Wed, 3 Jun 2020 22:59:40 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=y0z+FwTYJ95uCLjYdLuV+zPK1ocmej4ae5EJbgKvTTo=; b=wJNSaMYNEz9psI3LpZhHEmbLpdeacbqmINeCXAUz4jkxEj9MTYExZOn5sB/NqMzGW/EQ rpD1V/N2W8JAffisJrTU1i1f4bzrPuLhTNZfAIuo8X4SXmzkgR77MW8Y9Ags/N3edr9i t4WeC+nQE9UMBep8McI8AKHy4ziLw8RVk2KWzj0Vyk5EkoX+rFlGpbnDYXqPq2tJuepA qnpGBR6344euf041xvr01Pmn8t1wn7YB2KPtLX051aYQ2oXBOTEmMW5LVUktLyKCMw7x ttA9ewbPa2+hQj81miSl2pLI7Pvg7BRSkJUysSZlvii0KkyuMmxMerae+ohrORo61Xno 5g== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 31bmuq37g0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 03 Jun 2020 22:59:40 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Jun 2020 22:59:38 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.53) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 3 Jun 2020 22:59:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUHasAX9Obb1aoBRY9uT3VuWN0YPcnkCPTyLMlD3JmiJYQ0pR3JVs7d8uquACLFI+TJ6VrfeN3SYQf5GhQkqCHAv6YZXo5/Npo7xjc6LLRMU7pJIF3lF4Hn6vDBPO+SoI765+f9F8ZYJmi89OPEuIKGbugOMqYMWEb0EWfE7J5mSw9LxGu8EbcvK2ZMidh81mlQvyCoyphFqN6dQOicK42sY/x7/NnHHi81SWeJbkGO6E0+rBPWIVk0jSWxXip+hyUdnjerJMSTMTl1ebzv6735SI/8Sr+TxRkhpyTgEqXN9ycBRM6ODvtiAXE2XRryQ7sKMcXf+y+Wx02VzHtLhXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y0z+FwTYJ95uCLjYdLuV+zPK1ocmej4ae5EJbgKvTTo=; b=MWgvBzidROfaTjdrdBVhA+wVJaWmZw5U3Ld9Che1LHnzwTn5F6rwYT56wXGko0Uocu6NN6Oy/7Bc14ynY58gToCD9Qq0I9b89goAbHMA5PF/wZbHyk8b7nqfHwMoPSGDZVOqZ/GSGwEoG8OGSe6wt5V8EcF2bN0Bf6nQQlMo9PkPT9lPX4nByVZ6CnEA9kKzOd2tHHLXwtz7k644wPEOnlPwrwjZisxX8zTIadfa1ZdUgTAcQdh32jSfGxg0kVnH/Ynxmzcv2bIjK6GGR8KkDcmrV6Rlqgkyiip+KvnTDYITGqF1J+rZDh/pFfZXhbcHEaDqHLOyQ7gUST0Q22K/5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y0z+FwTYJ95uCLjYdLuV+zPK1ocmej4ae5EJbgKvTTo=; b=kh3wGZt90IKU8B9miNwjgp0L+bM8Vm15eIDqANM8r44/WnUU2sA/DCOHdtk6uurMkkK7qcQ5++Feht5Etrhf6UpnkqldIiy/VZiDvI5p1OHsMP7EBPW24yXH7zDPvR8b+RCPQqxUo857qM+a3N1J3ljRyV9YUbHJ5IRDydA19xM= Received: from BY5PR18MB3105.namprd18.prod.outlook.com (2603:10b6:a03:1a4::30) by BY5PR18MB3267.namprd18.prod.outlook.com (2603:10b6:a03:1ab::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Thu, 4 Jun 2020 05:59:37 +0000 Received: from BY5PR18MB3105.namprd18.prod.outlook.com ([fe80::cc7:b35a:8b18:3d0c]) by BY5PR18MB3105.namprd18.prod.outlook.com ([fe80::cc7:b35a:8b18:3d0c%7]) with mapi id 15.20.3045.024; Thu, 4 Jun 2020 05:59:37 +0000 From: Sunil Kumar Kori To: Harman Kalra , Jerin Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda CC: "dev@dpdk.org" , Harman Kalra , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/octeontx2: fix dmac filtering Thread-Index: AQHWObaqbTMPqqUIhkKdf7qvqv9ctqjH9wfg Date: Thu, 4 Jun 2020 05:59:37 +0000 Message-ID: References: <1591195933-16362-1-git-send-email-hkalra@marvell.com> In-Reply-To: <1591195933-16362-1-git-send-email-hkalra@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2401:4900:44e1:a3c:d5da:77ec:8d43:526c] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69e02cb3-92f8-4139-24c8-08d8084c76c8 x-ms-traffictypediagnostic: BY5PR18MB3267: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:568; x-forefront-prvs: 04244E0DC5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OqByyW5fHLEfymR5sEEaB9SwyUekWRvyu5ddlB4cDs6VsRVuLoccfRB6v3IqkACu0sDSs6DCtPG9OMrIrWG0eFyuPh42EPCEtz8wxB1vPy39v/36vDUF/JoZLmLwmdC4EEaISiN5xHiGY8U4w6kgncDLaU2qRqbm2dQNDRGpFXd4l0EjpSPhSHvkSipFwC9UX6pG+vYjShteXnZrIckvhipDpXilPC5KLbVlE3dzzig8iDgbs+Hk4nXEabrYMsfIGMfa/PKahR6LPznFzNldZhPqvIKUrYBuX+yUjidy1NN6QG04jqU2NFjBRaVIioBUowo9JSUZOefLOgwukOXmqA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR18MB3105.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(71200400001)(8676002)(450100002)(66946007)(9686003)(6636002)(4326008)(2906002)(66446008)(66476007)(64756008)(66556008)(86362001)(76116006)(83380400001)(54906003)(478600001)(55016002)(186003)(316002)(8936002)(33656002)(5660300002)(6506007)(110136005)(7696005)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: VtK3nlWEyyB7svskB9rtShLPXYClSTsScf9mWewSSsbXTKH54AJUIOiz9DJ/+HBhvsR3+CfGtqXbT0RCmAnzxLcNrK/2/Qm1bNgLVlMuKHDYSVIcJRu4h2DA5hzU+TiteUjHnNmE1hlVKH3JmN2SO91sIWXNO1szpgthfdi1biVldqPKcOiUYn7kRNrptTiyERazgVrP57kF2FNLqtqlVrwLjB8CJCSQXMPqKa8CiUGvfwQYoJsncPhqfbsAxs7WE46Ddmj0I5Kfm3afumqL5b2UjnmZ/AfAH1yvrMDdxYY0JUjIpydIryB8rZ7tRuQVo8MmQ/3dst87tzd0EpDZHanRlZvVNwrj+CsrLIodm7PpqlYGMSYy2RF8zUPCWchIqZuDZFFrUdq38GIFjTJmnqgZRcUMcOW6sExgu5u++CUDwkiqejtH48bv3iedHuZwVUKZ5+HfiS0tfydjKODzW1i81oDyorJMMhOklEGl72rGORi3K9zKRaAFKIbULDAL6CP8plpWAjbhhxfVPyVKtLlrKkU/AN2CIR29LHi8NFTmKv6JaBRXCXWKri5V7vE3 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 69e02cb3-92f8-4139-24c8-08d8084c76c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2020 05:59:37.5070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5NzIEmak7ft8V3Ebwri/587lW7t9zgP/E6ijFStDnlJAG5zp1PYFgh/conhaP+nBELgmOr5+gOy5mJhM5n/VjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3267 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-04_01:2020-06-02, 2020-06-04 signatures=0 Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix dmac filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Harman Kalra >Sent: Wednesday, June 3, 2020 8:22 PM >To: Jerin Kollanukkaran ; Nithin Kumar Dabilpuram >; Kiran Kumar Kokkilagadda > >Cc: dev@dpdk.org; Harman Kalra ; stable@dpdk.org >Subject: [dpdk-dev] [PATCH] net/octeontx2: fix dmac filtering > >Issue has been observed where packets are getting dropped >at DMAC filtering if a new dmac address is added before >starting of port. > >Fixes: c43adf61682f ("net/octeontx2: add unicast MAC filter") >Cc: stable@dpdk.org > >Signed-off-by: Harman Kalra >--- > drivers/net/octeontx2/otx2_ethdev.h | 1 + > drivers/net/octeontx2/otx2_ethdev_ops.c | 4 +++- > drivers/net/octeontx2/otx2_mac.c | 2 ++ > 3 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/octeontx2/otx2_ethdev.h >b/drivers/net/octeontx2/otx2_ethdev.h >index 0fbf68b8e..16b0d8163 100644 >--- a/drivers/net/octeontx2/otx2_ethdev.h >+++ b/drivers/net/octeontx2/otx2_ethdev.h >@@ -271,6 +271,7 @@ struct otx2_eth_dev { > uint8_t mac_addr[RTE_ETHER_ADDR_LEN]; > uint8_t mkex_pfl_name[MKEX_NAME_LEN]; > uint8_t max_mac_entries; >+ bool dmac_filter_enable; > uint8_t lf_tx_stats; > uint8_t lf_rx_stats; > uint16_t flags; >diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c >b/drivers/net/octeontx2/otx2_ethdev_ops.c >index 80ac2b96e..faecf216c 100644 >--- a/drivers/net/octeontx2/otx2_ethdev_ops.c >+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c >@@ -148,8 +148,10 @@ otx2_nix_promisc_enable(struct rte_eth_dev >*eth_dev) > int > otx2_nix_promisc_disable(struct rte_eth_dev *eth_dev) > { >- otx2_nix_promisc_config(eth_dev, 0); >+ struct otx2_eth_dev *dev =3D otx2_eth_pmd_priv(eth_dev); >+ otx2_nix_promisc_config(eth_dev, dev->dmac_filter_enable); > nix_cgx_promisc_config(eth_dev, 0); >+ dev->dmac_filter_enable =3D false; > > return 0; > } >diff --git a/drivers/net/octeontx2/otx2_mac.c >b/drivers/net/octeontx2/otx2_mac.c >index 262d185e5..49a700ca1 100644 >--- a/drivers/net/octeontx2/otx2_mac.c >+++ b/drivers/net/octeontx2/otx2_mac.c >@@ -76,6 +76,8 @@ otx2_nix_mac_addr_add(struct rte_eth_dev *eth_dev, >struct rte_ether_addr *addr, > > /* Enable promiscuous mode at NIX level */ > otx2_nix_promisc_config(eth_dev, 1); >+ dev->dmac_filter_enable =3D true; >+ eth_dev->data->promiscuous =3D 0; > > done: > return rc; >-- >2.18.0 Acked-by: Sunil Kumar Kori