From: Long Li <longli@microsoft.com>
To: Srikanth Kaka <srikanth.k@oneconvergence.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Vag Singh <vag.singh@oneconvergence.com>,
Anand Thulasiram <avelu@juniper.net>
Subject: Re: [dpdk-dev] [PATCH 08/11] net/netvsc: moving event monitoring support
Date: Sat, 6 Nov 2021 20:51:54 +0000 [thread overview]
Message-ID: <BY5PR21MB15061A132E10D9F6CD2E01C5CE8F9@BY5PR21MB1506.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20210927134231.11177-9-srikanth.k@oneconvergence.com>
> Subject: [PATCH 08/11] net/netvsc: moving event monitoring support
>
> [You don't often get email from srikanth.k@oneconvergence.com. Learn why
> this is important at http://aka.ms/LearnAboutSenderIdentification.]
>
> Event monitoring is not yet supported on FreeBSD, hence moving it the OS
> specific files
>
> Signed-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>
> Signed-off-by: Vag Singh <vag.singh@oneconvergence.com>
> Signed-off-by: Anand Thulasiram <avelu@juniper.net>
Reviewed-by: Long Li <longli@microsoft.com>
> ---
> drivers/net/netvsc/freebsd/hn_os.c | 14 ++++++++++++++
> drivers/net/netvsc/hn_ethdev.c | 7 +++----
> drivers/net/netvsc/hn_os.h | 6 ++++++
> drivers/net/netvsc/linux/hn_os.c | 19 +++++++++++++++++++
> 4 files changed, 42 insertions(+), 4 deletions(-) create mode 100644
> drivers/net/netvsc/freebsd/hn_os.c
> create mode 100644 drivers/net/netvsc/hn_os.h create mode 100644
> drivers/net/netvsc/linux/hn_os.c
>
> diff --git a/drivers/net/netvsc/freebsd/hn_os.c
> b/drivers/net/netvsc/freebsd/hn_os.c
> new file mode 100644
> index 0000000000..3bd67e06c8
> --- /dev/null
> +++ b/drivers/net/netvsc/freebsd/hn_os.c
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2016-2021 Microsoft Corporation */
> +
> +#include <stdio.h>
> +
> +#include "hn_logs.h"
> +#include "hn_os.h"
> +
> +int eth_hn_os_dev_event(void)
> +{
> + PMD_DRV_LOG(DEBUG, "rte_dev_event_monitor_start not supported on
> FreeBSD");
> + return 0;
> +}
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 6f9053c4d5..61d7d3daeb 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -39,6 +39,7 @@
> #include "hn_rndis.h"
> #include "hn_nvs.h"
> #include "ndis.h"
> +#include "hn_os.h"
>
> #define HN_TX_OFFLOAD_CAPS (DEV_TX_OFFLOAD_IPV4_CKSUM | \
> DEV_TX_OFFLOAD_TCP_CKSUM | \ @@ -1244,11 +1245,9 @@
> static int eth_hn_probe(struct rte_vmbus_driver *drv __rte_unused,
>
> PMD_INIT_FUNC_TRACE();
>
> - ret = rte_dev_event_monitor_start();
> - if (ret) {
> - PMD_DRV_LOG(ERR, "Failed to start device event monitoring");
> + ret = eth_hn_os_dev_event();
> + if (ret)
> return ret;
> - }
>
> eth_dev = eth_dev_vmbus_allocate(dev, sizeof(struct hn_data));
> if (!eth_dev)
> diff --git a/drivers/net/netvsc/hn_os.h b/drivers/net/netvsc/hn_os.h new file
> mode 100644 index 0000000000..618c53cdcd
> --- /dev/null
> +++ b/drivers/net/netvsc/hn_os.h
> @@ -0,0 +1,6 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright (c) 2009-2021 Microsoft Corp.
> + * All rights reserved.
> + */
> +
> +int eth_hn_os_dev_event(void);
> diff --git a/drivers/net/netvsc/linux/hn_os.c b/drivers/net/netvsc/linux/hn_os.c
> new file mode 100644
> index 0000000000..862dc190c1
> --- /dev/null
> +++ b/drivers/net/netvsc/linux/hn_os.c
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2016-2021 Microsoft Corporation */
> +
> +#include <rte_ethdev.h>
> +
> +#include "hn_logs.h"
> +#include "hn_os.h"
> +
> +int eth_hn_os_dev_event(void)
> +{
> + int ret;
> +
> + ret = rte_dev_event_monitor_start();
> + if (ret)
> + PMD_DRV_LOG(ERR, "Failed to start device event
> + monitoring");
> +
> + return ret;
> +}
> --
> 2.30.2
next prev parent reply other threads:[~2021-11-06 20:52 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 13:42 [dpdk-dev] [PATCH 00/11] add FreeBSD support to VMBUS & NetVSC PMDs Srikanth Kaka
2021-09-27 13:42 ` [dpdk-dev] [PATCH 01/11] bus/vmbus: stub for FreeBSD support Srikanth Kaka
2021-11-06 20:44 ` Long Li
2021-09-27 13:42 ` [dpdk-dev] [PATCH 02/11] bus/vmbus: scan and get the network device Srikanth Kaka
2021-10-08 11:39 ` [dpdk-dev] [PATCH v2 " Srikanth Kaka
2021-09-27 13:42 ` [dpdk-dev] [PATCH 03/11] bus/vmbus: handle mapping of device resources Srikanth Kaka
2021-09-27 13:42 ` [dpdk-dev] [PATCH 04/11] bus/vmbus: get device resource values using sysctl Srikanth Kaka
2021-09-27 13:42 ` [dpdk-dev] [PATCH 05/11] bus/vmbus: open subchannels Srikanth Kaka
2021-09-30 23:17 ` Long Li
2021-10-08 11:41 ` [dpdk-dev] [PATCH v2 " Srikanth Kaka
2021-11-06 20:49 ` Long Li
2022-02-08 16:35 ` Thomas Monjalon
2021-09-27 13:42 ` [dpdk-dev] [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels Srikanth Kaka
2021-09-30 23:19 ` Long Li
2021-10-01 5:31 ` Srikanth K
2021-09-27 13:42 ` [dpdk-dev] [PATCH 07/11] bus/vmbus: map the subchannel resources Srikanth Kaka
2021-09-27 13:42 ` [dpdk-dev] [PATCH 08/11] net/netvsc: moving event monitoring support Srikanth Kaka
2021-11-06 20:51 ` Long Li [this message]
2021-09-27 13:42 ` [dpdk-dev] [PATCH 09/11] net/netvsc: moving hotplug retry to OS dir Srikanth Kaka
2021-11-06 20:54 ` Long Li
2021-09-27 13:42 ` [dpdk-dev] [PATCH 10/11] bus/vmbus: add meson support for FreeBSD OS Srikanth Kaka
2021-11-06 20:54 ` Long Li
2021-09-27 13:42 ` [dpdk-dev] [PATCH 11/11] net/netvsc: add meson support for FreeBSD Srikanth Kaka
2021-10-08 11:42 ` [dpdk-dev] [PATCH v2 " Srikanth Kaka
2021-11-06 20:50 ` Long Li
2021-09-30 23:25 ` [dpdk-dev] [PATCH 00/11] add FreeBSD support to VMBUS & NetVSC PMDs Long Li
2022-02-17 16:05 ` [PATCH v3 00/15] " Srikanth Kaka
2022-02-17 16:05 ` [PATCH v3 01/15] bus/vmbus: scan and get the network device Srikanth Kaka
2022-02-17 16:29 ` Stephen Hemminger
2022-02-17 16:06 ` [PATCH v3 02/15] bus/vmbus: handle mapping of device resources Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 03/15] bus/vmbus: get device resource values using sysctl Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 04/15] bus/vmbus: add resource by index Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 05/15] net/netvsc: make event monitor OS dependent Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 06/15] bus/vmbus: add ring mapping APIs Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 07/15] bus/vmbus: add stub for subchannel support API Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 08/15] bus/vmbus: open subchannels Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 09/15] net/netvsc: make IOCTL call to " Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 10/15] bus/vmbus: get subchannel info Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 11/15] net/netvsc: moving hotplug retry to OS dir Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 12/15] bus/vmbus: add meson support for FreeBSD Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 13/15] net/netvsc: " Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 14/15] bus/vmbus: add APIs to mask/unmask IRQs Srikanth Kaka
2022-02-17 16:06 ` [PATCH v3 15/15] bus/vmbus: update MAINTAINERS and docs Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 00/14] add FreeBSD support to VMBUS & NetVSC PMDs Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 01/14] bus/vmbus: move independent code from Linux Srikanth Kaka
2022-04-19 14:49 ` Stephen Hemminger
2022-04-19 14:52 ` Srikanth K
2022-04-18 4:29 ` [PATCH v4 02/14] bus/vmbus: move independent bus functions Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 03/14] bus/vmbus: move OS independent UIO functions Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 04/14] bus/vmbus: scan and get the network device on FreeBSD Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 05/14] bus/vmbus: handle mapping of device resources Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 06/14] bus/vmbus: get device resource values using sysctl Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 07/14] net/netvsc: make event monitor OS dependent Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 08/14] bus/vmbus: add sub-channel mapping support Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 09/14] bus/vmbus: open subchannels Srikanth Kaka
2022-04-19 15:00 ` Stephen Hemminger
2022-04-18 4:29 ` [PATCH v4 10/14] net/netvsc: make IOCTL call to " Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 11/14] bus/vmbus: get subchannel info Srikanth Kaka
2022-04-19 14:51 ` Stephen Hemminger
2022-04-18 4:29 ` [PATCH v4 12/14] net/netvsc: moving hotplug retry to OS dir Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 13/14] bus/vmbus: add meson support for FreeBSD Srikanth Kaka
2022-04-18 4:29 ` [PATCH v4 14/14] bus/vmbus: update MAINTAINERS and docs Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 00/14] add FreeBSD support to VMBUS & NetVSC PMDs Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 01/14] bus/vmbus: move independent code from Linux Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 02/14] bus/vmbus: move independent bus functions Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 03/14] bus/vmbus: move OS independent UIO functions Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 04/14] bus/vmbus: scan and get the network device on FreeBSD Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 05/14] bus/vmbus: handle mapping of device resources Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 06/14] bus/vmbus: get device resource values using sysctl Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 07/14] net/netvsc: make event monitor OS dependent Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 08/14] bus/vmbus: add sub-channel mapping support Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 09/14] bus/vmbus: open subchannels Srikanth Kaka
2023-08-10 15:41 ` Stephen Hemminger
2022-04-23 4:28 ` [PATCH v5 10/14] net/netvsc: make IOCTL call to " Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 11/14] bus/vmbus: get subchannel info Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 12/14] net/netvsc: moving hotplug retry to OS dir Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 13/14] bus/vmbus: add meson support for FreeBSD Srikanth Kaka
2022-04-23 4:28 ` [PATCH v5 14/14] bus/vmbus: update MAINTAINERS and docs Srikanth Kaka
2023-08-10 15:44 ` Stephen Hemminger
2022-05-18 8:18 ` [PATCH v5 00/14] add FreeBSD support to VMBUS & NetVSC PMDs Thomas Monjalon
2022-10-06 14:58 ` Thomas Monjalon
2023-07-04 0:07 ` Stephen Hemminger
2022-04-14 8:54 ` [PATCH v3 00/15] " Thomas Monjalon
2022-04-14 9:01 ` Srikanth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR21MB15061A132E10D9F6CD2E01C5CE8F9@BY5PR21MB1506.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=avelu@juniper.net \
--cc=dev@dpdk.org \
--cc=srikanth.k@oneconvergence.com \
--cc=sthemmin@microsoft.com \
--cc=vag.singh@oneconvergence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).