From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B93AA00C5; Wed, 16 Feb 2022 09:10:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0E92410F7; Wed, 16 Feb 2022 09:10:24 +0100 (CET) Received: from na01-obe.outbound.protection.outlook.com (mail-centralusazon11021014.outbound.protection.outlook.com [52.101.62.14]) by mails.dpdk.org (Postfix) with ESMTP id 184454013F for ; Wed, 16 Feb 2022 09:10:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UFvqEvpwcmZuwUHIO78gaQ6neh2e1bbx5qezX/s6MqxVUGZbDtf88CHnxJ7bYu63aNPWA2KJcpLbmapdAcubb9y0RbT1MDvx65AuG9Mlkm53HQIcVSBG7yoP14ZyWKDxZ4dG0+i4NmS5sCmtXeuPlAPdch9tBOJxpp2gqhdcMMhJhIVZH8J8DEAld6B1mTKpWUdgZFpC7z1FxqFf6yncqqqYZUFKA+Wn/wE26dY/Tko6hJ9N0FHlD1HF/l6wf/5QUDSQkbVXo07cO8zaqGTMQBQ+jkZSjwJre+py3JJp2PuMAcBd3Ts9kh+5v7eTYX/cv23WX9fRblsmrpExJNeGkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eoiIPx6UGSRqBoJNwDlSgr8FqBUnorLm9ZG0eNGSdMo=; b=Sv1sWjWiN/qJQtIi2ZIxt47ofh3P5W/EIrYETMq1Dgmlj3a6Rc8uz/phuaHeAHmvkd7ZYwejW7C+rGsu5NJ83cAWIyOvsIw9LmOL7dws32x2OFGiTWf0bHq3NFY/a1on4hxkgb4iwUpWUrK8nAbEpPBrxOWytt4SxMN3P/05AQ16EdaWhP3TANwM/N2pBH9/Ngpoh64mPWt5k3FidYlSYxgatFIKZcPICi/X+h4ScMPl1qsIl9Z6SxhTnQyBGcodo8EnGwv7XIt499N6IgTv/fk2Pb/gPYD7XD7Lox+919mz1ZG86Ny7DjMfLf3fiPWQBqLyiw4O3AD0kx2fr32f3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eoiIPx6UGSRqBoJNwDlSgr8FqBUnorLm9ZG0eNGSdMo=; b=MbSod5UCseaoSDZtewOrsfmGeyd71tjQ/hOP8Jursx3RJ6xGtwMagOEdPLxvaQNoNW14aAaOsihBWqBIbbxsyLvifaP6c4abKViz9FBYOFQnGhDmoYdu2M5HN7zMjLkqUa1ZICb+wIoOi+jOiCSipmyLDR7KMUo0d25njZZI/1M= Received: from BY5PR21MB1506.namprd21.prod.outlook.com (2603:10b6:a03:23d::12) by BN6PR21MB1268.namprd21.prod.outlook.com (2603:10b6:405:8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.6; Wed, 16 Feb 2022 08:10:16 +0000 Received: from BY5PR21MB1506.namprd21.prod.outlook.com ([fe80::7d2c:2d96:8a89:3192]) by BY5PR21MB1506.namprd21.prod.outlook.com ([fe80::7d2c:2d96:8a89:3192%3]) with mapi id 15.20.5017.008; Wed, 16 Feb 2022 08:10:15 +0000 From: Long Li To: "wenxuanx.wu@intel.com" , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , "nhorman@tuxdriver.com" CC: "dev@dpdk.org" Subject: RE: [PATCH] eal/linux: fix fail to stop device monitor error Thread-Topic: [PATCH] eal/linux: fix fail to stop device monitor error Thread-Index: AQHYHxbYV2VDbkii2UuZnTTJYzCtjayV2IBQ Date: Wed, 16 Feb 2022 08:10:13 +0000 Message-ID: References: <20220211065315.66814-1-wenxuanx.wu@intel.com> In-Reply-To: <20220211065315.66814-1-wenxuanx.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=7fd3e01a-375d-4a63-8566-0a85c51a32da; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-02-16T08:01:02Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f1d5127-00dc-42ce-6299-08d9f123c393 x-ms-traffictypediagnostic: BN6PR21MB1268:EE_ x-ms-exchange-atpmessageproperties: SA|SL x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LEjRga6bjM4TH5G0Mdykwnz3d/sLcpPjQC+HeFk3aKupshc1N1QGuI/ItCK8WFQNkb3LTKgCDYbjt5oALrHIW3nX3LM8bqTNw4Js8ev1CMXMJ7vlFIbsK4PQSO5IM1UMWcF++W/wJvX4gScESlz5k+tiS2dPs0pZM1HC3r4aL8uHKzub0wwbRR87rk/2o6swJIx4bxxDIQ7YHzIN+XEwecXo3MThE2DWBCvel7ZjkAXOHRa/6K6ePciIc6FCKsWqNkW0znh81SGwma+2mPvZVJkrkaKkYo+GCQH303/XDy5ADkDHYly82+pWfmkUi1zuG2EMKq46gv2C3HfgD/7UhDb+F+breFTy5HweMebE9O76QZwr0pjaCDJ7fqqWc/YmX1Dq9a/c4djFbu6xzeXRubLQ8VyVw3qH7mmRPaSHbCX6FmQuE6iqRqfgiyfzNW2xxQH8Yo+/OoIR59mnzWbRR47xsn1URGYdSgSgINfdQ1Ulk+gExOPpkeuG9WnXRbyzeC1CqctcjGsU705GCwAIEWOMRuBM4R2G19WeZvF+79tnCE8/Ijz3Yf/7EzT4QDfMALvWC2EGrOqhC1zN/WHHtOx5TY/PcgqlrLtakU9+M4vwGSKnYcayRYsjIyEfybVPyYs+m9hzIFzgHYQe+6znrBVC/xgdA7y8eD7J7mYeuACu8po8fcyT1y+rU3wYhMIbp0FD8jW4Zq+0VXrfKoBAIYHcCrSlR6emCnYlVQJSxVbeFaQpNwYwWGC4j6m0WUHUDgqi6YeRbzoLyK2e5gn0t2V6/ba71XRTGh0lvUtR93sv89H0ydNlgWxySyh2MroazleutSA1d19fNTPMbZKou7zcPfGYRa7wt5SaRChjWOw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR21MB1506.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(966005)(8676002)(71200400001)(33656002)(55016003)(66556008)(508600001)(76116006)(66946007)(38070700005)(66476007)(8936002)(10290500003)(4326008)(64756008)(66446008)(186003)(26005)(2906002)(82960400001)(86362001)(82950400001)(8990500004)(83380400001)(5660300002)(122000001)(110136005)(316002)(6506007)(7696005)(38100700002)(9686003)(10090945009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6r0jSatRk5E7qZeCAIUX2jOrPK4EI06CrLxBDXV4Nigw+0eMcI9cRX1h0ie3?= =?us-ascii?Q?RiiPX7F/ZO/jckNyfxZiYUiCfDYYT0J427l3yLK4HIN7rChbBgmEgYhVBBUv?= =?us-ascii?Q?gAL+xSN638QR2LsrYaGx9Y2v7LhpknLOTTaXPypbczRPu0+jOBgmuGYU7Y03?= =?us-ascii?Q?ZyemDK1DaDvKk1a55AMytWs2kRK6hx0t3IQjsbpYGf3m/4Wdy1ExT31v1iSC?= =?us-ascii?Q?8VzpqG7PAWrXulEEgpzuASI+JbiAJLBHEjUIDqFCzdKIreGpNqR94TMEG9PR?= =?us-ascii?Q?PCkBKVbZoCQpiUvXjZ2t1vLflczDK2j74OqOtKIfDkTAk6FDENJBJqVJ/gFX?= =?us-ascii?Q?ODLncggLaJuLE0LLUtgXYxEHrPgOlX9X+OIESzjY5f/mRY5DRKgxYZHJndTi?= =?us-ascii?Q?PmlM7UeHARA1OcZHniaS/egVFpyOI2aYMbEIveirdJ3fT/XAZgXNPhm8obQs?= =?us-ascii?Q?OsLv640fh1Qy2k3Q9ghE93OJwkU3qBxgGYdjCgvN42B5VoNK8nnORoTNZi96?= =?us-ascii?Q?zHsxPI2S93/c+CFceOY5WpFOjmBFZcyiKagLpJNNIDtTVORlIgmbRrjPXT/d?= =?us-ascii?Q?LWZKwK8DF/Kzfjzai6fJZ2kfnO8mRC6pLXEsk6A5g1EwHzMvxGkPLAye3Y+O?= =?us-ascii?Q?775eCH9Bs19JbREILfm1PDjczb/AU74Rot6F/pbuE7U0L4d5CnLUlEa2DxGz?= =?us-ascii?Q?gbh0OodGdcOGSSULslpJodYbXUt3H+AIpM1JSVzeDd+AWxfQoud9AU1XiCfd?= =?us-ascii?Q?s1MAMpi/ylAALnxP1t/NT9odLsLr+1Okw/MZbCFN/8jkfSkSvS6VJ1a1ptvi?= =?us-ascii?Q?MqA0sHJB/STTT2Da68Q3DrHIzz5NFh4FtVZx6ggvRwXG7z6p0j4KsIncNlWg?= =?us-ascii?Q?ZduiFpj6MtcFwTz6R5Ifcbgt7Uc9/YbAdJoqjjbGqeJ/wAlDmZQYvJBdVTM9?= =?us-ascii?Q?49kXA0E1xoY9v/SQwYeDzS53focXKYBTKfkJsOZarkr7Kan2kWzV5C9oHa17?= =?us-ascii?Q?Chp2084gVyA+e0N7XdXufErcs+mx1JQ+zS/giEOGM4ioK9mKaVvn4E/jARR/?= =?us-ascii?Q?hudwe6/4uqiuEQGoHB9n/wvcWqOb3BSHx6Bu5CJ9c2f1+qEpzZNo+Zh8Vv1n?= =?us-ascii?Q?pEs16jh0v2PDKPjL3iN4sxAaTF0vbMgoyFb0zfYTvp8VRId2C/RM0iEhRZHU?= =?us-ascii?Q?AMNPPpKfqkXafmIntD3e4yjDvP1lXQkNefNOeve1Fif93oY/El65xZHrGPbe?= =?us-ascii?Q?FksS4Fvb00ibaesFwE2KfEffSX0vKJ0dbu7SZHIlgb8+AIDst3MGJGTye03x?= =?us-ascii?Q?YKE3FER8EoWArtCCrdxcRnaSOOL4iEEGIYlvvFY9nnwjt2Pg5HsGVTmwdgfI?= =?us-ascii?Q?w1lnb1I1cHcedelgiB9+PXPPkxq4VTLdLUodjrxH9YkfUp2F4S/qYqc+NuT+?= =?us-ascii?Q?hHCzWpaLDU/iCVJz9AUFJSzN7tUWx363WTi9H1NLvWTxcxK7jUyXADcfgbSj?= =?us-ascii?Q?oaR+W6EGOEm4Mw3Iu4Y/pYYF/C/H367rdB+Di9J/28anSR9aPc9SSLvfCXb4?= =?us-ascii?Q?FKb4UNknr/0z7nyTkUxFp+pPLODGT4vcwxRK7gpL/PwCw6oqGlEJQ6x9A3DT?= =?us-ascii?Q?MA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR21MB1506.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f1d5127-00dc-42ce-6299-08d9f123c393 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 08:10:15.5701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o4Drhv33TJIxPma3nQf3RVq4BnyiGEBCo9g339a6btShuo6buRv28kRxNMxLDNLRHc8BEpIq5bqHfLKBe/Y0sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR21MB1268 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH] eal/linux: fix fail to stop device monitor error >=20 > [You don't often get email from wenxuanx.wu@intel.com. Learn why this is > important at http://aka.ms/LearnAboutSenderIdentification.] >=20 > From: Wenxuan Wu >=20 > The ret value stands for whether the device monitor has been successfully > closed, and has nothing to do with rte_intr_callback_unregister funcs onc= e it > return a value greater than 0 .So if the closure procedure has gone to th= e > right exit point ,we should set this value to 0. It seems to be a display problem with the patch in this email. But the patch at https://patchwork.dpdk.org/project/dpdk/patch/202202110841= 31.72606-1-wenxuanx.wu@intel.com/ looks good to me. >=20 > Also ,the refmonitor has been carefully evaluted .at the beginning of > ret_dev_event_monitor_stop ,the value is 1, at the end of this func ,the > value is 0, it reveals that the monitor has been succefully closed. >=20 > Signed-off-by: Wenxuan Wu > --- > lib/eal/linux/eal_dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index > babd444d9d..8cf7ea5520 100644 > --- a/lib/eal/linux/eal_dev.c > +++ b/lib/eal/linux/eal_dev.c > @@ -366,7 +366,7 @@ rte_dev_event_monitor_stop(void) >=20 > if (!monitor_refcount) { > RTE_LOG(ERR, EAL, "device event monitor already stopped\n= "); > - > + > goto exit; > } >=20 > @@ -381,7 +381,7 @@ rte_dev_event_monitor_stop(void) > RTE_LOG(ERR, EAL, "fail to unregister uevent callback.\n"= ); > goto exit; > } > - > + > close(rte_intr_fd_get(intr_handle)); > rte_intr_instance_free(intr_handle); > intr_handle =3D NULL; > -- > 2.25.1