From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730069.outbound.protection.outlook.com [40.107.73.69]) by dpdk.org (Postfix) with ESMTP id A191D1B5DB for ; Wed, 19 Dec 2018 06:47:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+76Brkk/zpxDQvlbeOMaRb90fwU+VXou+9RiwDSu7hE=; b=MSLVJ/UliPqa2+bd7dZCPCMo4j7Jd3HlWLoVw1fupttZzEm7Qq8T77nqQ7KEgHJ/xtJj2tGr2Ob37Pm36xk5p7dG1odp85h76KiuWxpm+g26E3wix/uZJ0W8u5OQMwJPPEGn3DdIC5eCtaMAs0SZQElISeZ44IvFvVMoBVlKwXo= Received: from BYAPR07MB5141.namprd07.prod.outlook.com (20.176.254.206) by BYAPR07MB5141.namprd07.prod.outlook.com (20.176.254.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.22; Wed, 19 Dec 2018 05:47:35 +0000 Received: from BYAPR07MB5141.namprd07.prod.outlook.com ([fe80::44d4:2955:f8ba:3c07]) by BYAPR07MB5141.namprd07.prod.outlook.com ([fe80::44d4:2955:f8ba:3c07%2]) with mapi id 15.20.1425.024; Wed, 19 Dec 2018 05:47:35 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , Stephen Hemminger CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Jozwiak, TomaszX" , "Gupta, Ashish" , "Daly, Lee" , "Luse, Paul E" Thread-Topic: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done Thread-Index: AQHUgHHzFvAwN1WsuUCvEJs8a5amE6VX5t6AgADzhoCAABxlgIAryE4AgAD8WHA= Date: Wed, 19 Dec 2018 05:47:35 +0000 Message-ID: References: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> <20181119175349.2bd2fdd1@xeon-e3> <348A99DA5F5B7549AA880327E580B4358967C84F@IRSMSX101.ger.corp.intel.com> <20181120100703.34c462e9@xeon-e3> <348A99DA5F5B7549AA880327E580B435896A4B55@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435896A4B55@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5141; 6:5vLcN0o96Xp50FYw1Xd4CIHKeJGEO/rbLkkd7/ybgWZrEd+QoMCr3rlHTBadMbRCY44eS4eO6azSFiQjmBx8rF3DEJw0nfsoGg6rSa4y754CmdL7EW9QZ8R1QQATErDxGHN4cGNlKNvWsAAiAemTnZa8HwKWY5+obeXg2iPlBpsj9KvNiOsGNsPNc/iUn4rENUNVgRs1+zb2G/W71bNOs0EVaAg85Zb9hrppqiOxiKcPYDPgkPQF5/QQIz4Kz4YmF5dnLSqS3nXRY1F7a6nyvZQwqJDZ5uUR0iDblLDZ6zgf/3kws3iWNZ8j+WMn5rvnlkD8bfPEIs76Z1rXAaDzl3s9Rg9L4dcSigLLm0RN+VAPoVQJbTgb5nz7hfDx/BJXq1AIw1lADb8Tnm2OqeQKRJOMf8nf7/1Zty+08wJPhvyrdbrJpCZCQzjGl03c9bYNzcAenJRdc3oZCuRsx2RhRw==; 5:jY7davXd4VaVvQX4QhXm8Rp81RNFNQ7NMdOoapIIjE3LnbCtNWYOUcrxoVLHWtyGXKGGBMiR46yaHmbuepseK9cRcUkvgFn2hOke3d3izBHggMRABrfzyq4SrFTsL9b2xYisTzCJrD9WLyAYLXid3Eu3qtqANcG392OXr/dtnas=; 7:lzxVlcQfngVEMCDhMvg1D5yqUjBavlCuvMwp1KSIcOx6vxqAxTnkpKXfFwqTp2v2IfFWjZyJZi+SU35gOLXHjxAVYPZgATy/cn3RLvNll63T+1tuEeAQSR0QahtQt4xiBHbUVDM3ii0P4dk5i3/9qQ== x-ms-office365-filtering-correlation-id: 22f64042-0b7b-4ffd-e53a-08d665757a11 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5141; x-ms-traffictypediagnostic: BYAPR07MB5141: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231475)(944501520)(52105112)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB5141; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5141; x-forefront-prvs: 0891BC3F3D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(376002)(396003)(366004)(346002)(13464003)(189003)(199004)(66066001)(93886005)(14444005)(256004)(81156014)(14454004)(81166006)(8936002)(86362001)(9686003)(6436002)(76176011)(71200400001)(6506007)(55016002)(55236004)(102836004)(110136005)(478600001)(7736002)(72206003)(6116002)(3846002)(25786009)(71190400001)(486006)(8676002)(74316002)(54906003)(5660300001)(305945005)(97736004)(316002)(476003)(33656002)(229853002)(2906002)(4326008)(446003)(11346002)(26005)(99286004)(53936002)(6246003)(186003)(7696005)(106356001)(68736007)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5141; H:BYAPR07MB5141.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: t0lnuyPXuhruiHlfwK7S6W86bqfKEIVt5Q6G4i3SpvJptMejhG6gQJGRvTfHKjylkC903beCAhasKSuuCrsK0bfcddyQGpUICyG0YxU+6dzUfLqvn/j+RPY+/ATz02omrMNOL1728xqwxVH9ZLW95LWpeW7zhOyPdCQChvAdLZgNb0k8rkWPmux8s5gdH8raGyusxoKeQN7zdb3URhyb3AKaZPQGk8v4s9fdZDZ6+e58Dminy/qf8k+CDUYCLLJVKv6vc1qSWn8bV4NUtQ0dAr7TuqespvdraD03O0yjL8s+K4IU7nquNLatcvtqEbx6 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22f64042-0b7b-4ffd-e53a-08d665757a11 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2018 05:47:35.1357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5141 Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 05:47:38 -0000 >-----Original Message----- >From: Trahe, Fiona >Sent: 18 December 2018 20:13 >To: Stephen Hemminger >Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX ; Verma, Shally >; Gupta, Ashish ; Daly, = Lee ; Luse, Paul E >; Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH] compressdev: add feature flag to specify w= here processing is done > >External Email > >Hi Stephen > >//snip// >> > > Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to spe= cify where processing is done >> > > >> > > On Tue, 20 Nov 2018 01:39:48 +0000 >> > > Fiona Trahe wrote: >> > > >> > > > A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE >> > > > is added. A PMD which processes operations using a software >> > > > acceleration engine should set this if the bulk of the >> > > > processing is done during the dequeue. It should leave it >> > > > cleared if the bulk of the processing is done during the >> > > > enqueue (default). >> > > > An application may find this useful for tuning. >> > > > >> > > > Signed-off-by: Fiona Trahe >> > > >> > > What application? or is this "if we build it they will come?" >> > [Fiona] Our storage team asked for this, so not quite. >> > Seems like it might by generically useful, so a bit of the latter too = :) >> > Would you prefer I removed that line? >> >> Hopefully, there would be one or more open source projects using the API= . >> I just did a survey of DPDK an 1/3 of it is never used by any open sourc= e >> project. Hate to see more dead code and special cases created. >> >> At least, some example code in examples would help. Something like a sim= ple >> in memory compressed storage server using a network API (SMB?/SSH?/FTP?) >[Fiona] There is no compressdev sample app yet. >However I've double-checked with the SPDK team, they're currently integrat= ing >compressdev and intend to push a patch to SPDK - a storage open-source pro= ject - using this flag. [Shally] Am seeing some of our HW based PMD also leveraging this choice. So= I would say to make it generic feature flag instead of SW specific. Thanks Shally