From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0055.outbound.protection.outlook.com [104.47.40.55]) by dpdk.org (Postfix) with ESMTP id 164285F33 for ; Wed, 19 Sep 2018 18:41:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fUJq5Z+lXSOKFO3kqHi4U2q9+i6pDWl31lMiRxmDAI4=; b=AiGRc66xzeWGcFvdSyM1VOcoX4vETR5Ey5AAoejcSQRa+AyAcBWD8Ev9uPeiVN8mvptLzwEQlRQ6CpwBOJaepPadgEMxQu3ZEQFWOhHf32MGhEYigI2+KRmFrW4AEkJm1JFKA7ALO6GCrfMdUjsaFumkc4BiZyeX5dM8pQw9ngg= Received: from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by BYAPR07MB5270.namprd07.prod.outlook.com (20.177.124.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.17; Wed, 19 Sep 2018 16:40:58 +0000 Received: from BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::2047:9647:f196:bde0]) by BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::2047:9647:f196:bde0%6]) with mapi id 15.20.1143.017; Wed, 19 Sep 2018 16:40:57 +0000 From: "Mody, Rasesh" To: Stephen Hemminger , Thomas Monjalon CC: "dev@dpdk.org" , Stephen Hemminger , "Patil, Harish" Thread-Topic: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity Thread-Index: AQHUJEQwZJ/0yIGfPEqmtFYGIvshV6T2HrsAgABbTYCAAJSGEA== Date: Wed, 19 Sep 2018 16:40:57 +0000 Message-ID: References: <20180725182019.31518-1-stephen@networkplumber.org> <20180725182019.31518-3-stephen@networkplumber.org> <3009159.xGyNxZp9MA@xps> <20180918080715.17fcd7d8@xeon-e3> In-Reply-To: <20180918080715.17fcd7d8@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [2601:646:8280:69f0:75c7:16b0:9674:a00] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5270; 6:slksnaeSybJa2nEB1+6ZneasHNyEoP4nDUkVZmfIGLkLBqh96qZTsYSSz1lVZ9bQ/BzTLpleCZXXv+14N/KvYIbrfkX5NQVxYNHt6ZlxMrUKX/m6y2BQ1DCtJRFCx41DzL6muBaGKa2lOEL6/D0sfkpPgmRhYTHrh3hD5qIGSDyR3ur81dCL3yEFeWC9yiJOAd2t4YXq2vRBFRejAw/oqIkv3wmIMGom7A/l/ukcOVsdvabEPoRdqWfGyBwjzJys+iDixWDfsiq+Z6JqhHy41VZPUEY44fleyLTftSbzXuVBGSi8RWfJQYlCBikgRAyFl6CedPuH8iPzEmN8pvFEDlVVKukMD7aiYbIoanfM5zl99aQb3Nu6VwQCRipXRH3O2qLjdxFp77qeiyDggdvHBxuTaBjSWgBEXPn+2puN6zHE6NJJKlxJVvFbOmrFG7ysvwMuaRszLPyKfW7veq4kww==; 5:fLSzTUa1jwmVEo8TW+YilU1LUelAm8ZOxUCCcxBUj45Zp9XcMZd2Zh1NyKro3LBPLVxoXeQPw0YnDViH7k7rlRARkwwks4hPos55DYfdc2D4IbhRZ29/fkb+KEvjrMSq7mMGlDbqmv6TE/RhkwGSDmotHkQXZOQTUFne7szJH4I=; 7:KOy8gsFsoyLGLSPUd8c/YJDl9sh0d0rCiJY4kHHWSTZYLBp7oan0YEzvFwUVImdDoV681MieOC++bSGF6gwl5N8qSV2167BP0fsClmwu+Zh5ZCWgq+81cwLYCYjsUQDN7oT2tHKAf6FfVEfShVTwDcU1dJUTFeMgN7pdMJ9uyxpOqs0On9xFQmwYSWAbjRjl1eDh4FdJpeAlCIWeIQMjh66owZmzvZSDIWJzXgaJVreS673DclIrjJqEjyHvU2Sz x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(136003)(366004)(396003)(199004)(189003)(74316002)(81166006)(256004)(14454004)(86362001)(5250100002)(6506007)(2900100001)(93886005)(8676002)(305945005)(106356001)(105586002)(68736007)(54906003)(478600001)(7736002)(25786009)(72206003)(99286004)(53936002)(5660300001)(11346002)(446003)(316002)(102836004)(33656002)(110136005)(186003)(4326008)(97736004)(6116002)(6436002)(46003)(476003)(486006)(81156014)(6246003)(55016002)(107886003)(7696005)(9686003)(2906002)(229853002)(8936002)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5270; H:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: e29ceacf-feea-42a5-4189-08d61e4eacff x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5270; x-ms-traffictypediagnostic: BYAPR07MB5270: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699050); SRVR:BYAPR07MB5270; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5270; x-forefront-prvs: 0800C0C167 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: I+pDY8nUNIJ9SiQPDfTjlpJIJSZu3YBmjpwrMfxG59UDfC04w1xmF2E8GgP7D6DrWpScQuryNWWILyP+d5irJJoZgMmtlb+o25j2PJ8hB07SvN+oOscTWfa9uaaiL9WYH2rj/SjzOFdiV14ph7G7ilVeiL5xV/90n9+eJinJOfzQz0SgOD4qIjNDUeBMXjw6f2jWuAJks3u+OOn7BxPdiLFhJw1s07zpXgVQHe7CrmxnF6yPKmzLbtf8yZTeruei7hL4Nmt/JSlFMum2jL8WgHryRzD/Pdkztg0yrtvZ7R9gD36W4ZRJT/EtRQmb6cHrzUh9moR8EOL2d97TdveTLHek28h99bZUN4Y6QO1ddRE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: e29ceacf-feea-42a5-4189-08d61e4eacff X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2018 16:40:57.6584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5270 Subject: Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 16:41:01 -0000 >From: Stephen Hemminger >Sent: Tuesday, September 18, 2018 8:07 AM > >On Tue, 18 Sep 2018 11:40:28 +0200 >Thomas Monjalon wrote: > >> 25/07/2018 20:20, Stephen Hemminger: >> > No need for profanity in comments. >> > >> > Signed-off-by: Stephen Hemminger >> > --- >> > drivers/net/bnx2x/elink.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c >> > index 34a29373af3b..08fe817720a1 100644 >> > --- a/drivers/net/bnx2x/elink.c >> > +++ b/drivers/net/bnx2x/elink.c >> > @@ -3993,11 +3993,11 @@ static elink_status_t >elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc, >> > PORT_HW_CFG_E3_MOD_ABS_MASK) >> >> > PORT_HW_CFG_E3_MOD_ABS_SHIFT; >> > >> > - /* Should not happen. This function called upon interrupt >> > + /* >> > + * Should not happen. This function called upon >> > + interrupt >> > * triggered by GPIO ( since EPIO can only generate interr= upts >> > * to MCP). >> > * So if this function was called and none of the GPIOs wa= s set, >> > - * it means the shit hit the fan. >> > */ >> >> It makes the comment ends with a comma, like the end is missing. >> >> >> > >Yes, better language would be. > /* This should not happen since this function is called > * from interrupt triggered by GPI .. +1 I've re-worded the last bit. /* This should not happen since this function is called * from interrupt triggered by GPIO (since EPIO can only * generate interrupts to MCP). * So if this function was called and none of the GPIOs was set, * it means something disastrous has already happened. */ Thanks! -Rasesh