From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 2/5] net/bnx2x: update link/PHY management
Date: Sat, 22 Sep 2018 01:37:45 +0000 [thread overview]
Message-ID: <BYAPR07MB5365A9726633D46D0869583A9F110@BYAPR07MB5365.namprd07.prod.outlook.com> (raw)
In-Reply-To: <d2c9ec28-3426-3056-4a3c-c6641a8a79f1@intel.com>
>From: Ferruh Yigit <ferruh.yigit@intel.com>
>Sent: Friday, September 21, 2018 11:10 AM
>
>On 9/19/2018 10:59 PM, Mody, Rasesh wrote:
>> This patch has changes to update the link/PHY management (elink) code
>> to the latest.
>>
>> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
>> ---
>> drivers/net/bnx2x/bnx2x.h | 3 +
>> drivers/net/bnx2x/ecore_hsi.h | 20 +-
>> drivers/net/bnx2x/elink.c | 7951 ++++++++++++++++++++++++++--------
>-------
>> drivers/net/bnx2x/elink.h | 234 +-
>> 4 files changed, 5231 insertions(+), 2977 deletions(-)
>
><...>
>
>>
>> -static uint8_t elink_xgxs_config_init(struct elink_phy *phy,
>> - struct elink_params *params,
>> - struct elink_vars *vars)
>> +static void elink_xgxs_config_init(struct elink_phy *phy,
>> + struct elink_params *params,
>> + struct elink_vars *vars)
>
>
>Getting many build error because of these kind of changes.
>
>.../drivers/net/bnx2x/elink.c:12555:17: error: cast between incompatible
>function types from ‘void (*)(struct elink_phy *, struct elink_params *, struct
>elink_vars *)’ to ‘uint8_t (*)(struct elink_phy *, struct elink_params *, struct
>elink_vars *)’ {aka ‘unsigned char (*)(struct elink_phy *, struct elink_params
>*, struct elink_vars *)’} [-Werror=cast-function-type]
>
>
>
> .config_init = (config_init_t)elink_xgxs_config_init,
>
>
>
> ^
>
>perhaps "struct elink_phy" also needs to be updated?
>
>Overall build fail log is long, I am not sharing here, I guess if you can able to
>reproduce one, you will be able to reproduce all.
We didn’t see build errors with an older gcc. We'll reproduce with latest gcc and address the build errors.
next prev parent reply other threads:[~2018-09-22 1:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 21:59 [dpdk-dev] [PATCH 1/5] net/bnx2x: fix logging to include dev name Mody, Rasesh
2018-09-19 21:59 ` [dpdk-dev] [PATCH 2/5] net/bnx2x: update link/PHY management Mody, Rasesh
2018-09-21 18:10 ` Ferruh Yigit
2018-09-22 1:37 ` Mody, Rasesh [this message]
2018-09-19 21:59 ` [dpdk-dev] [PATCH 3/5] net/bnx2x: fix to disable further interrupts Mody, Rasesh
2018-09-19 21:59 ` [dpdk-dev] [PATCH 4/5] net/bnx2x: fix call to link handling periodic function Mody, Rasesh
2018-09-19 21:59 ` [dpdk-dev] [PATCH 5/5] net/bnx2x: fix to add phy lock Mody, Rasesh
2018-09-29 5:42 ` [dpdk-dev] [PATCH v2 1/5] net/bnx2x: fix logging to include dev name Mody, Rasesh
2018-10-02 12:40 ` Ferruh Yigit
2018-09-29 5:42 ` [dpdk-dev] [PATCH v2 2/5] net/bnx2x: update link/PHY management Mody, Rasesh
2018-09-29 5:42 ` [dpdk-dev] [PATCH v2 3/5] net/bnx2x: fix to disable further interrupts Mody, Rasesh
2018-09-29 5:42 ` [dpdk-dev] [PATCH v2 4/5] net/bnx2x: fix call to link handling periodic function Mody, Rasesh
2018-09-29 5:42 ` [dpdk-dev] [PATCH v2 5/5] net/bnx2x: fix to add phy lock Mody, Rasesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB5365A9726633D46D0869583A9F110@BYAPR07MB5365.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).