From: "John Daley (johndale)" <johndale@cisco.com>
To: Weiguo Li <liwg06@foxmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Weiguo Li <liweiguo@xencore.cn>
Subject: Re: [PATCH] net/enic: avoid extra unlock when setting MTU in enic
Date: Thu, 2 Nov 2023 01:25:15 +0000 [thread overview]
Message-ID: <BYAPR11MB253539941CDFEF2CD787D680CFA6A@BYAPR11MB2535.namprd11.prod.outlook.com> (raw)
In-Reply-To: <tencent_349DCE470CE9C87F1F8D508878C438F2DC0A@qq.com>
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
Reviewed-by: John Daley <johndale@cisco.com>
Thanks,
John
From: Weiguo Li <liwg06@foxmail.com>
Date: Wednesday, November 1, 2023 at 12:28 AM
To: John Daley (johndale) <johndale@cisco.com>
Cc: dev@dpdk.org <dev@dpdk.org>, stable@dpdk.org <stable@dpdk.org>, Weiguo Li <liweiguo@xencore.cn>
Subject: [PATCH] net/enic: avoid extra unlock when setting MTU in enic
The 'set_mtu_done' goto statement is being executed in a context
where the 'mtu_lock' has not been previously locked.
To avoid the extra unlocking operation, replace the goto statement
with a return statement.
Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update")
Cc: stable@dpdk.org
Signed-off-by: Weiguo Li <liweiguo@xencore.cn>
---
.mailmap | 2 +-
drivers/net/enic/enic_main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.mailmap b/.mailmap
index 3f5bab26a8..b4f0ae26b8 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1500,7 +1500,7 @@ Waterman Cao <waterman.cao@intel.com>
Weichun Chen <weichunx.chen@intel.com>
Wei Dai <wei.dai@intel.com>
Weifeng Li <liweifeng96@126.com>
-Weiguo Li <liwg06@foxmail.com>
+Weiguo Li <liwg06@foxmail.com> <liweiguo@xencore.cn>
Wei Huang <wei.huang@intel.com>
Wei Hu <weh@microsoft.com>
Wei Hu (Xavier) <xavier.huwei@huawei.com>
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 19a99a82c5..a6aaa760ca 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1639,7 +1639,7 @@ int enic_set_mtu(struct enic *enic, uint16_t new_mtu)
* packet length.
*/
if (!eth_dev->data->dev_started)
- goto set_mtu_done;
+ return rc;
/*
* The device has started, re-do RQs on the fly. In the process, we
--
2.34.1
[-- Attachment #2: Type: text/html, Size: 4830 bytes --]
prev parent reply other threads:[~2023-11-02 1:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 7:28 Weiguo Li
2023-11-01 19:55 ` Ferruh Yigit
2023-11-02 1:25 ` John Daley (johndale) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB253539941CDFEF2CD787D680CFA6A@BYAPR11MB2535.namprd11.prod.outlook.com \
--to=johndale@cisco.com \
--cc=dev@dpdk.org \
--cc=liweiguo@xencore.cn \
--cc=liwg06@foxmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).