DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Rong, Leyi" <leyi.rong@intel.com>
To: David Marchand <david.marchand@redhat.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Tal Shnaiderman <talshn@nvidia.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Kadam, Pallavi" <pallavi.kadam@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Menon, Ranjit" <ranjit.menon@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>, dev <dev@dpdk.org>,
	Aaron Conole <aconole@redhat.com>, "ci@dpdk.org" <ci@dpdk.org>,
	dpdklab <dpdklab@iol.unh.edu>
Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error
Date: Tue, 2 Feb 2021 09:09:36 +0000
Message-ID: <BYAPR11MB2614B7637799D067B81DBFD5ECB59@BYAPR11MB2614.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wqzMKwfsJGai4otHUkDe=eV1YUQzb_NsOPvCPA9fNtPg@mail.gmail.com>


> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, February 2, 2021 4:37 PM
> To: Rong, Leyi <leyi.rong@intel.com>; Dmitry Kozlyuk
> <dmitry.kozliuk@gmail.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Richardson, Bruce
> <bruce.richardson@intel.com>; Tal Shnaiderman <talshn@nvidia.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Kadam, Pallavi <pallavi.kadam@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; dev <dev@dpdk.org>; Aaron Conole
> <aconole@redhat.com>; ci@dpdk.org; dpdklab <dpdklab@iol.unh.edu>
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error
> 
> On Thu, Jan 28, 2021 at 10:27 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > 28/01/2021 13:28, David Marchand:
> > > On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong <leyi.rong@intel.com> wrote:
> > > >
> > > > This patchset fix mingw build error when avx512 is introduced.
> > > >
> > > > ---
> > > > v2:
> > > > - Set i40e_avx512_cc_support to false to avoid the build error under
> > > >   windows with mingw.
> > > >
> > > > Leyi Rong (2):
> > > >   config: disable avx512 on mingw cross build
> > > >   net/i40e: fix mingw build error
> > > >
> > > >  config/x86/cross-mingw       | 3 +++
> > > >  drivers/net/i40e/meson.build | 4 ++++
> > > >  2 files changed, 7 insertions(+)
> > >
> > > LGTM with fc32 mingw.
> > > Tested-by: David Marchand <david.marchand@redhat.com>
> >
> > Applied, thanks.
> >
> > Dmitry found a lighter alternative option to be tested and discussed.
> 
> We still have build failures at UNH for Windows, on the rc2 tag:
> http://mails.dpdk.org/archives/test-report/2021-February/177464.html
> 
> Is this issue being looked at?
> 
> 
> --
> David Marchand

Hi David,

Seems the issue still exist on the platform which CPU has AVX512 capability, I think previous patch is not verified to cover this case.
Will send hotfix patch for this.

      reply	other threads:[~2021-02-02  9:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 15:38 [dpdk-dev] [PATCH] net/i40e: " Leyi Rong
2021-01-26 16:18 ` Kadam, Pallavi
2021-01-26 17:04 ` Tal Shnaiderman
2021-01-27  8:30   ` Rong, Leyi
2021-01-27  8:47 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong
2021-01-27  8:47   ` [dpdk-dev] [PATCH v2 1/2] config: disable avx512 on mingw cross build Leyi Rong
2021-01-27  8:47   ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error Leyi Rong
2021-01-27 10:40     ` Bruce Richardson
2021-01-27 12:18       ` Rong, Leyi
2021-01-27 14:27 ` [dpdk-dev] [PATCH v3 0/2] " Leyi Rong
2021-01-27 14:27   ` [dpdk-dev] [PATCH v3 1/2] config: disable avx512 on mingw cross build Leyi Rong
2021-01-27 14:27   ` [dpdk-dev] [PATCH v3 2/2] net/i40e: fix mingw build error Leyi Rong
2021-01-27 19:15   ` [dpdk-dev] [PATCH v3 0/2] " Kadam, Pallavi
2021-01-28 12:28   ` David Marchand
2021-01-28 21:26     ` Thomas Monjalon
2021-02-02  8:36       ` David Marchand
2021-02-02  9:09         ` Rong, Leyi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB2614B7637799D067B81DBFD5ECB59@BYAPR11MB2614.namprd11.prod.outlook.com \
    --to=leyi.rong@intel.com \
    --cc=aconole@redhat.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dpdklab@iol.unh.edu \
    --cc=ferruh.yigit@intel.com \
    --cc=pallavi.kadam@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git