From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 805F8A04DB;
Fri, 16 Oct 2020 07:58:22 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 3047F1D734;
Fri, 16 Oct 2020 07:58:21 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 69EE81D732
for <dev@dpdk.org>; Fri, 16 Oct 2020 07:58:18 +0200 (CEST)
IronPort-SDR: Msc0uIVcz12MaL8vXPRejZEUyOZkvD3m1Ltyt+bPXuLCJfSW2FbUyXp5JyB/Lz0YZPXrO9pKD0
ev9G4QOrw1Ow==
X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="146395788"
X-IronPort-AV: E=Sophos;i="5.77,381,1596524400"; d="scan'208";a="146395788"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
15 Oct 2020 22:58:17 -0700
IronPort-SDR: krQj2mp5IysZHmGxhzRCqw0SqywPME1QHRJHLH2gI9dTBDiOfXaoQYoXSOeOfVZEbdpGmOplY+
SKKF/HWYhyWg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,381,1596524400"; d="scan'208";a="300601809"
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
by fmsmga007.fm.intel.com with ESMTP; 15 Oct 2020 22:58:17 -0700
Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Thu, 15 Oct 2020 22:58:17 -0700
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Thu, 15 Oct 2020 22:58:16 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
via Frontend Transport; Thu, 15 Oct 2020 22:58:16 -0700
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169)
by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.1713.5; Thu, 15 Oct 2020 22:58:16 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=PjurjRG8mTPu0cfNZVR+75HXOyDcDHH2c0mInd6FV6i4qBpJJ7QKiB4lb8qvDAxavropj0YpmdrkPAku1fS8XhMyxjm47Tud3FChgD/m+Cv7f/Fhh9vMipAN1C09RmHS4nlthRp98cRxYfatvI1rlZb4oHgKv14RuiYPhKdIzlrB9UUmfa6JOCbzaIaTDee/K71DXVitpNs2w9ClxoxJDlC4vEmxDOeV0puTX/dAX/7SbxquyxEl5g4tacGCqYwfQa/bUBoNsW2NBDKWptUsWXiZ1JqdAFo/ru961PkBBf+50MEQi5d1rUNAGLMpwcnNbMrUS3rK+4n7zKkQx1U0vg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=MqvXsyR01hFEkdYbywsoY2sNDKu8dPReTry1YzoNf/k=;
b=XTHfNJhm6voUd6wtxVoLFnrxgfx/PbJUy8YbuVHJUx/yEJa6mQyF1Xm2cEHWRFl9YG/4qoxJQos9qD5jBuQZVQIeS1iKQmx3l10lLIQudHoKEh+6VnusGI8C+0oL8Cs+QPSkQZmCXo4+qbguyxbZRK1UqJ9GeDjALKV95wA0vcdg2ia31k2uuYvE5JNwOiMOqiRdeQ6WlgEUqcFKLWKREOjlOSSf78aidh2vCiSWUdPVgYbpyh0ggpUF+gxLHNLaL0Ix6S8WSwAi+AUSsMzIm6TJLiHeCK3mEN/OfXExwk5FTwkRE/XzX8ulK9frk7QHdakmdP9TX2KwoJ1W347/Xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=MqvXsyR01hFEkdYbywsoY2sNDKu8dPReTry1YzoNf/k=;
b=FC1PibqBmz+fJNc8LQaX/7uCxKn5QNi5x9zq2dO+YrVHf0CqSVu2KBHmBzfFUYiMtzyOCR5qeOTcChcTBSvkffAjvQacAAts2i0vkHjfmnx9ZRA20OS3chRGUpPSlYs/rekWXYbm8/rYMzlmMZkXMfgjvYmNeli6aad5ndczb4s=
Received: from BYAPR11MB2648.namprd11.prod.outlook.com (2603:10b6:a02:c7::10)
by BYAPR11MB2885.namprd11.prod.outlook.com (2603:10b6:a03:87::19)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Fri, 16 Oct
2020 05:58:14 +0000
Received: from BYAPR11MB2648.namprd11.prod.outlook.com
([fe80::990c:c0a1:b470:1916]) by BYAPR11MB2648.namprd11.prod.outlook.com
([fe80::990c:c0a1:b470:1916%6]) with mapi id 15.20.3477.021; Fri, 16 Oct 2020
05:58:14 +0000
From: "Wang, Yinan" <yinan.wang@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>, "dev@dpdk.org"
<dev@dpdk.org>, "Xia, Chenbo" <chenbo.xia@intel.com>, "Fu, Patrick"
<patrick.fu@intel.com>, "amorenoz@redhat.com" <amorenoz@redhat.com>
Thread-Topic: [dpdk-dev] [PATCH v3 3/8] net/virtio: move backend type
selection to ethdev
Thread-Index: AQHWlnvV8UzSLAoMzEaf98ns6JWpQKmZzMXggAAHgnA=
Date: Fri, 16 Oct 2020 05:58:14 +0000
Message-ID: <BYAPR11MB264872FFF2673B80184941B78F030@BYAPR11MB2648.namprd11.prod.outlook.com>
References: <20200929161404.124580-1-maxime.coquelin@redhat.com>
<20200929161404.124580-4-maxime.coquelin@redhat.com>
<BYAPR11MB26488FCFE99D9BECAA03CC188F030@BYAPR11MB2648.namprd11.prod.outlook.com>
In-Reply-To: <BYAPR11MB26488FCFE99D9BECAA03CC188F030@BYAPR11MB2648.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
authentication-results: redhat.com; dkim=none (message not signed)
header.d=none;redhat.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [192.102.204.37]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b2084dfa-68fa-4e4f-0fcd-08d8719878ad
x-ms-traffictypediagnostic: BYAPR11MB2885:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR11MB28856D7DCC2137C92FC2236D8F030@BYAPR11MB2885.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2089;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: xN7sUMjbHQlRWsbDFi9u7zxHvCvgBZZWxCOOnSyZHBwXr7cKa4BDPCoAziJ9B/NuYlbbLQ/+UJqEy1qPGmnonrgumlEDYndc7137Hdt3DoVO34cf/YDlETxRLdS09EhxpeOzt1yzoCvSHVzogW8fkhOUbxPe7h+sj824E5CviLW1ioicx0270KSWEC7up5cBaTS0+jat4/qsCKKPmUVa7/Yd26c0F0/f6lQwah4RHNogSFYFBkX+bhWx6cRGrRWq2C/1uZ0yvXHHswepeMJtwbmyJlCxHGv4L0kVOerRj4scgeQCk8TwsfDQ6LYKNdoKfPSTzBnr5WEHB/3Q1kgUBS6FrBKrhGB4M9ZhVP3BD5GvxBnb8ONu8MTu6Sy94efKAZI/pjfwBewZZMwGmIjxgg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BYAPR11MB2648.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(396003)(346002)(366004)(376002)(39860400002)(136003)(66556008)(2906002)(2940100002)(66446008)(6506007)(64756008)(8936002)(66946007)(53546011)(7696005)(83380400001)(71200400001)(9686003)(55016002)(33656002)(66476007)(316002)(52536014)(76116006)(966005)(110136005)(5660300002)(86362001)(186003)(26005)(478600001);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: HKtld0/i5+eK8izbNANAIbMY4zTRr2hBrbytw+XXyV+LC85VNorYcPFb9FvfiwGUiBi8NeUc0QjKwwFqUsQbMnh0TfROo6eYPezCGuY/y0oEo9cTPy4Kb+1DTjriaprv3PQ5/mlg2yyAVVG1zQb75RIW1lnQOasgLiv9fiNNX3ALGFlfenfuniKDRdLDNKO3bWx7q8lLjmNyxcxsSzOmfEKs92WdeAAtJIDbz/epBlDSRhCnBzZvWATkYJC6+GR3bul7a61do0ZCEDDC5PuScLm1d17JM3qY1Nj5Ia81SnycK4ArRH2pQTIPZDuXE2/XDQ70jGd/q3zyPuGk69TazctQ0SZ4J/1HSQvzBtpKxpNJcJ8HHx5dunAKYQesmyrjYPab5QhxG3Ql3v09S/vukHj8TqWvENMtKcmyleWML4FmRJ7iEHrAgeJnVRJOwcBYjcdf1GXOJRs0lwpynDtTj7+Q4C4h72y6KzSRo7PM+IKgxJcFVvhflXsotjlOXD1gbcaWMKTMcIz5DtyRerhNbvf0laiP82/L+qDBAx6BAiNWtr+yyo8c1vktKNJunAGkCW2SuatgQc07Qskm6nnEOWsq6FxVXreMbEL6Oh0pcjw+35yBhcJR+yrbykJzzB2moQ9/BJfxaBn0kmQUTpqBwg==
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2648.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2084dfa-68fa-4e4f-0fcd-08d8719878ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2020 05:58:14.4251 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: phpBxvV0Iy/sZyGpgpLvIHc9JTaOIBsgsDPdUEoTzInAp8rlI9piOoJJwlTcGVg07mXUCJ2REhAAj2xYVrgn8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2885
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v3 3/8] net/virtio: move backend type
selection to ethdev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Correct my typo issue that vhost-user can't launch with client mode.
BR,
Yinan
> -----Original Message-----
> From: Wang, Yinan
> Sent: 2020?10?16? 13:42
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; dev@dpdk.org; Xia,
> Chenbo <Chenbo.Xia@intel.com>; Fu, Patrick <patrick.fu@intel.com>;
> amorenoz@redhat.com
> Subject: RE: [dpdk-dev] [PATCH v3 3/8] net/virtio: move backend type sele=
ction
> to ethdev
>=20
> Hi Adrian,
>=20
> This patch introduce a regression issue that vhost-user can't launch with=
server
> mode, details in https://bugs.dpdk.org/show_bug.cgi?id=3D559.
> This issue blocked amount of regression cases, could you help to take a l=
ook?
> Thanks in advance!
>=20
>=20
> BR,
> Yinan
>=20
>=20
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Maxime Coquelin
> > Sent: 2020?9?30? 0:14
> > To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Fu, Patrick
> > <patrick.fu@intel.com>; amorenoz@redhat.com
> > Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Subject: [dpdk-dev] [PATCH v3 3/8] net/virtio: move backend type select=
ion to
> > ethdev
> >
> > From: Adrian Moreno <amorenoz@redhat.com>
> >
> > This is a preparation patch with no functional change.
> >
> > Use an enum instead of a boolean for the backend type.
> > Move the detection logic to the ethdev layer (where it is needed for th=
e
> > first time).
> > The virtio_user_dev stores the backend type in the virtio_user_dev
> > struct so the type is only determined once
> >
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
> > ---
> > .../net/virtio/virtio_user/virtio_user_dev.c | 37 ++++++++-----------
> > .../net/virtio/virtio_user/virtio_user_dev.h | 11 +++++-
> > drivers/net/virtio/virtio_user_ethdev.c | 28 +++++++++++++-
> > 3 files changed, 50 insertions(+), 26 deletions(-)
> >
> > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> > b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> > index 2a0c861085..b79a9f84aa 100644
> > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> > @@ -111,17 +111,6 @@ virtio_user_queue_setup(struct virtio_user_dev *de=
v,
> > return 0;
> > }
> >
> > -int
> > -is_vhost_user_by_type(const char *path)
> > -{
> > - struct stat sb;
> > -
> > - if (stat(path, &sb) =3D=3D -1)
> > - return 0;
> > -
> > - return S_ISSOCK(sb.st_mode);
> > -}
> > -
> > int
> > virtio_user_start_device(struct virtio_user_dev *dev)
> > {
> > @@ -144,7 +133,8 @@ virtio_user_start_device(struct virtio_user_dev *de=
v)
> > rte_mcfg_mem_read_lock();
> > pthread_mutex_lock(&dev->mutex);
> >
> > - if (is_vhost_user_by_type(dev->path) && dev->vhostfd < 0)
> > + if (dev->backend_type =3D=3D VIRTIO_USER_BACKEND_VHOST_USER &&
> > + dev->vhostfd < 0)
> > goto error;
> >
> > /* Step 0: tell vhost to create queues */
> > @@ -360,16 +350,16 @@ virtio_user_dev_setup(struct virtio_user_dev *dev=
)
> > dev->tapfds =3D NULL;
> >
> > if (dev->is_server) {
> > - if (access(dev->path, F_OK) =3D=3D 0 &&
> > - !is_vhost_user_by_type(dev->path)) {
> > - PMD_DRV_LOG(ERR, "Server mode doesn't support
> > vhost-kernel!");
> > + if (dev->backend_type !=3D
> > VIRTIO_USER_BACKEND_VHOST_USER) {
> > + PMD_DRV_LOG(ERR, "Server mode only supports
> > vhost-user!");
> > return -1;
> > }
> > dev->ops =3D &virtio_ops_user;
> > } else {
> > - if (is_vhost_user_by_type(dev->path)) {
> > + if (dev->backend_type =3D=3D
> > VIRTIO_USER_BACKEND_VHOST_USER) {
> > dev->ops =3D &virtio_ops_user;
> > - } else {
> > + } else if (dev->backend_type =3D=3D
> > +
> > VIRTIO_USER_BACKEND_VHOST_KERNEL) {
> > dev->ops =3D &virtio_ops_kernel;
> >
> > dev->vhostfds =3D malloc(dev->max_queue_pairs *
> > @@ -430,7 +420,8 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)
> > int
> > virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queu=
es,
> > int cq, int queue_size, const char *mac, char **ifname,
> > - int server, int mrg_rxbuf, int in_order, int packed_vq)
> > + int server, int mrg_rxbuf, int in_order, int packed_vq,
> > + enum virtio_user_backend_type backend_type)
> > {
> > uint64_t protocol_features =3D 0;
> >
> > @@ -445,6 +436,8 @@ virtio_user_dev_init(struct virtio_user_dev *dev, c=
har
> > *path, int queues,
> > dev->frontend_features =3D 0;
> > dev->unsupported_features =3D ~VIRTIO_USER_SUPPORTED_FEATURES;
> > dev->protocol_features =3D
> > VIRTIO_USER_SUPPORTED_PROTOCOL_FEATURES;
> > + dev->backend_type =3D backend_type;
> > +
> > parse_mac(dev, mac);
> >
> > if (*ifname) {
> > @@ -457,7 +450,7 @@ virtio_user_dev_init(struct virtio_user_dev *dev, c=
har
> > *path, int queues,
> > return -1;
> > }
> >
> > - if (!is_vhost_user_by_type(dev->path))
> > + if (dev->backend_type !=3D VIRTIO_USER_BACKEND_VHOST_USER)
> > dev->unsupported_features |=3D
> > (1ULL << VHOST_USER_F_PROTOCOL_FEATURES);
> >
> > @@ -539,7 +532,7 @@ virtio_user_dev_init(struct virtio_user_dev *dev, c=
har
> > *path, int queues,
> > }
> >
> > /* The backend will not report this feature, we add it explicitly */
> > - if (is_vhost_user_by_type(dev->path))
> > + if (dev->backend_type =3D=3D VIRTIO_USER_BACKEND_VHOST_USER)
> > dev->frontend_features |=3D (1ull << VIRTIO_NET_F_STATUS);
> >
> > /*
> > @@ -792,7 +785,7 @@ virtio_user_send_status_update(struct virtio_user_d=
ev
> > *dev, uint8_t status)
> > uint64_t arg =3D status;
> >
> > /* Vhost-user only for now */
> > - if (!is_vhost_user_by_type(dev->path))
> > + if (dev->backend_type !=3D VIRTIO_USER_BACKEND_VHOST_USER)
> > return 0;
> >
> > if (!(dev->protocol_features & (1ULL <<
> > VHOST_USER_PROTOCOL_F_STATUS)))
> > @@ -815,7 +808,7 @@ virtio_user_update_status(struct virtio_user_dev *d=
ev)
> > int err;
> >
> > /* Vhost-user only for now */
> > - if (!is_vhost_user_by_type(dev->path))
> > + if (dev->backend_type !=3D VIRTIO_USER_BACKEND_VHOST_USER)
> > return 0;
> >
> > if (!(dev->protocol_features & (1UL <<
> > VHOST_USER_PROTOCOL_F_STATUS)))
> > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h
> > b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> > index 9377d5ba66..575bf430c0 100644
> > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
> > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> > @@ -10,6 +10,12 @@
> > #include "../virtio_pci.h"
> > #include "../virtio_ring.h"
> >
> > +enum virtio_user_backend_type {
> > + VIRTIO_USER_BACKEND_UNKNOWN,
> > + VIRTIO_USER_BACKEND_VHOST_USER,
> > + VIRTIO_USER_BACKEND_VHOST_KERNEL,
> > +};
> > +
> > struct virtio_user_queue {
> > uint16_t used_idx;
> > bool avail_wrap_counter;
> > @@ -17,6 +23,7 @@ struct virtio_user_queue {
> > };
> >
> > struct virtio_user_dev {
> > + enum virtio_user_backend_type backend_type;
> > /* for vhost_user backend */
> > int vhostfd;
> > int listenfd; /* listening fd */
> > @@ -60,13 +67,13 @@ struct virtio_user_dev {
> > bool started;
> > };
> >
> > -int is_vhost_user_by_type(const char *path);
> > int virtio_user_start_device(struct virtio_user_dev *dev);
> > int virtio_user_stop_device(struct virtio_user_dev *dev);
> > int virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int =
queues,
> > int cq, int queue_size, const char *mac, char **ifname,
> > int server, int mrg_rxbuf, int in_order,
> > - int packed_vq);
> > + int packed_vq,
> > + enum virtio_user_backend_type backend_type);
> > void virtio_user_dev_uninit(struct virtio_user_dev *dev);
> > void virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue=
_idx);
> > void virtio_user_handle_cq_packed(struct virtio_user_dev *dev,
> > diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> > b/drivers/net/virtio/virtio_user_ethdev.c
> > index 60d17af888..38b49bad5f 100644
> > --- a/drivers/net/virtio/virtio_user_ethdev.c
> > +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > @@ -6,6 +6,7 @@
> > #include <sys/types.h>
> > #include <unistd.h>
> > #include <fcntl.h>
> > +#include <sys/stat.h>
> > #include <sys/socket.h>
> >
> > #include <rte_malloc.h>
> > @@ -518,6 +519,19 @@ get_integer_arg(const char *key __rte_unused,
> > return -errno;
> > }
> >
> > +static enum virtio_user_backend_type
> > +virtio_user_backend_type(const char *path)
> > +{
> > + struct stat sb;
> > +
> > + if (stat(path, &sb) =3D=3D -1)
> > + return VIRTIO_USER_BACKEND_UNKNOWN;
> > +
> > + return S_ISSOCK(sb.st_mode) ?
> > + VIRTIO_USER_BACKEND_VHOST_USER :
> > + VIRTIO_USER_BACKEND_VHOST_KERNEL;
> > +}
> > +
> > static struct rte_eth_dev *
> > virtio_user_eth_dev_alloc(struct rte_vdev_device *vdev)
> > {
> > @@ -579,6 +593,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)
> > struct rte_kvargs *kvlist =3D NULL;
> > struct rte_eth_dev *eth_dev;
> > struct virtio_hw *hw;
> > + enum virtio_user_backend_type backend_type =3D
> > VIRTIO_USER_BACKEND_UNKNOWN;
> > uint64_t queues =3D VIRTIO_USER_DEF_Q_NUM;
> > uint64_t cq =3D VIRTIO_USER_DEF_CQ_EN;
> > uint64_t queue_size =3D VIRTIO_USER_DEF_Q_SZ;
> > @@ -631,8 +646,17 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)
> > goto end;
> > }
> >
> > + backend_type =3D virtio_user_backend_type(path);
> > + if (backend_type =3D=3D VIRTIO_USER_BACKEND_UNKNOWN) {
> > + PMD_INIT_LOG(ERR,
> > + "unable to determine backend type for path %s",
> > + path);
> > + goto end;
> > + }
> > +
> > +
> > if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_INTERFACE_NAME) =3D=3D 1=
)
> > {
> > - if (is_vhost_user_by_type(path)) {
> > + if (backend_type !=3D VIRTIO_USER_BACKEND_VHOST_KERNEL) {
> > PMD_INIT_LOG(ERR,
> > "arg %s applies only to vhost-kernel backend",
> > VIRTIO_USER_ARG_INTERFACE_NAME);
> > @@ -751,7 +775,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)
> > hw =3D eth_dev->data->dev_private;
> > if (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,
> > queue_size, mac_addr, &ifname, server_mode,
> > - mrg_rxbuf, in_order, packed_vq) < 0) {
> > + mrg_rxbuf, in_order, packed_vq, backend_type) < 0) {
> > PMD_INIT_LOG(ERR, "virtio_user_dev_init fails");
> > virtio_user_eth_dev_free(eth_dev);
> > goto end;
> > --
> > 2.26.2