From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D36DFA0547;
	Wed, 27 Oct 2021 08:34:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9856740DDA;
	Wed, 27 Oct 2021 08:34:40 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by mails.dpdk.org (Postfix) with ESMTP id 6C122407FF
 for <dev@dpdk.org>; Wed, 27 Oct 2021 08:34:39 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="230359812"
X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="230359812"
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Oct 2021 23:34:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="555122841"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
 by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2021 23:34:38 -0700
Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Tue, 26 Oct 2021 23:34:38 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 23:34:38 -0700
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Tue, 26 Oct 2021 23:34:38 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RvA5/OLV1fnTdil74UFvgurzhzgWgiUmAM0VMbZLU1wrbNocq2jPFRb0aNRUSW01AJt7RG4a/wyu+IL0XfnW40GIoOrQchf6fspMdcJvwh39BZIRI/ghUMnZcIDlNkX+iwSU63DF0VJ4HpRWeg7m8c10To6XAOdc+WulgQXcv5rjkzj4/cRFdhCGGwbVsRSyqu2GXleySBYKi4WFnNPzeedZtDheCRmHLU9dEeFrEV08Lw6LyA5L1dwdJMr9IeIDv8wluo5somqI4RE1Ok8gHuvN4IPHKhve/Gp5iefI+tC36CqfzsqZD/lnUTpVcD/e4yK2WkyDv7NNyZjbMpdwaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qny0K2cAV/Ojc5RJHHEUSzXK4LRGo4ngH31iKD7a2tQ=;
 b=CHza66nquK55GZ8jgxxYJm5lXpPKe/oQ2+nwSB3Dk+zIqYBiNTE+IG06bb6uu+ZoDtrhZZQPIWjLjEyIm8JiTvdbX7j+D7ETa7T/MO1hZe/FJ8fNk73dUW4hDNNOf6+QvRDi2Lt1NTmiG2hQdU+JH3peFB8K70glONOEKzi1jRaDT/3v6AYZKqUBdU5ncWlolf+EZ/Vctnb/SZbdUjVr00t/s8yqHgiu6C6I7aQRm4q1xnCJJw+o7NkQFEF44obBRVke2/X2V0PBsPN1Cg1gxZCjUTQwSWSiPoI+fmN4UcgX+/+HT6epuoQBMD5h6hWMl3ZXlldWrnYglCvKh1ZmPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Qny0K2cAV/Ojc5RJHHEUSzXK4LRGo4ngH31iKD7a2tQ=;
 b=vfMVG6/mzKjQM+UoIv4rEHDClOARgq8EkOCAqHJzaVbxBaPakRf48SWdhL2hHW1o6UMyqvF/l0uqy+a/vVVoaOClLjY52Q4vh/8aPVUlWVWAyB4fq2MvZdKq+K94KUV/mzHtzSoXXLUmL34DoXnrBbTCZYC4MOEr/ODMeTFRoQQ=
Received: from BYAPR11MB2648.namprd11.prod.outlook.com (2603:10b6:a02:c7::10)
 by BYAPR11MB3430.namprd11.prod.outlook.com (2603:10b6:a03:89::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct
 2021 06:34:36 +0000
Received: from BYAPR11MB2648.namprd11.prod.outlook.com
 ([fe80::1464:a3d7:1da2:9c36]) by BYAPR11MB2648.namprd11.prod.outlook.com
 ([fe80::1464:a3d7:1da2:9c36%7]) with mapi id 15.20.4628.022; Wed, 27 Oct 2021
 06:34:36 +0000
From: "Wang, Yinan" <yinan.wang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "Pattan, Reshma" <reshma.pattan@intel.com>, Ray Kinsella <mdr@ashroe.eu>, 
 "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Ling, WeiX"
 <weix.ling@intel.com>, "He, Xingguang" <xingguang.he@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering
Thread-Index: AQHXxfudX7CkJRIcVkq2/dg7JmvHYavmY/SA
Date: Wed, 27 Oct 2021 06:34:36 +0000
Message-ID: <BYAPR11MB26489E0BA79C43FAF3D494528F859@BYAPR11MB2648.namprd11.prod.outlook.com>
References: <20210903004732.109023-1-stephen@networkplumber.org>
 <20211020214236.71444-1-stephen@networkplumber.org>
 <20211020214236.71444-7-stephen@networkplumber.org>
In-Reply-To: <20211020214236.71444-7-stephen@networkplumber.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-reaction: no-action
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
authentication-results: networkplumber.org; dkim=none (message not signed)
 header.d=none;networkplumber.org; dmarc=none action=none
 header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 05dc1cdd-1f43-45fc-6f40-08d99913d8a5
x-ms-traffictypediagnostic: BYAPR11MB3430:
x-microsoft-antispam-prvs: <BYAPR11MB34302763A0CACB185265952A8F859@BYAPR11MB3430.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3968;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: aveM1t3icPYHH5dsLz8KC6PV6wvdKHq5++2/4WRWnoxFEiY2eals/0eSl0qYyrlRyeOCr64yLslKfc+lC14T3/SjLFnfT8Py7Dq2yzHHYB19afRWeI1suvFN6pQdjr0IKz9oPWnzdyKG405gPzFsNpGUgR3a3pYelhWbXVjqRi4JoMiOM/U4ARBYCspPNXFxoyB7DUtCXgo95Y0MRNWr64LNtje/isAIoAcX+b0/ZlYjtuD37YeQt9kdneeEw7+w8OOzNElnUhx6Bt33+EtNkz0wFwtPnO33EPTOSkZJVGAuuR+UN/e5rOt1ZTeE7aV2bXK63GpOB1dhUSgOS6ye/Rlmn2EiyLAX+NqjQFwlwwRKiMGElO4BOX1e58Z3jpFUBH38BAP9YemhLfcdDA/NLWzYSKA9tcgKnd1BfIfel5wNl2vYpYcy309Hcx9J1XivUhMyz4T5TSPjF2kjcaETertsaEl7mPRjEyISiXGHbupkranmr5VVLchT3Alat674tKQAOuL54pHJAxeltKjw2Ee3U9eyslQp8pwVaGNW4x3u+CHIhfg5Hwxvi7iG12I7l1ecFVUou2D/u6lXwmf9+E7u/jQeL4NcSQlYHPZAAX2MigJnduPl/EmNY/jVd5IcTP9TlOI5rXmTbT7arVrdAI3G5/3O9dD/Qi/yC4JxJtjd3UwpH+C75EQ16MHsmHhlGKA7TFGE7a81MWSmuLdH+u2wUUsRXIbHgVJ8sANaAhqxrN7kkYW+CrCasV0L9RtfgB6fcT9Wi27i8Gvi2Ll91Sc2GesM05MQjYnAxELUKls=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BYAPR11MB2648.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(366004)(508600001)(6506007)(5660300002)(53546011)(2906002)(38100700002)(54906003)(71200400001)(76116006)(186003)(316002)(110136005)(122000001)(9686003)(86362001)(83380400001)(8676002)(66946007)(4326008)(82960400001)(66446008)(52536014)(64756008)(38070700005)(107886003)(33656002)(26005)(8936002)(7696005)(66556008)(55016002)(66476007);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?CA7k6mBfivB8VKdrFapAP4FKR85eSBZV8aAOjEdnY+zennu+QqTaZQ9C?=
 =?Windows-1252?Q?B9cam9toryMKVNbrWz5Mvc3Cc709LrvBRNxwSZOFMdrJNMXlOD5jX1Ht?=
 =?Windows-1252?Q?AD/1dwK4HwaqNr7RbGAGa/fYtP2aVEPYVB0TE8fZwQRrU0gqyCHcSRKg?=
 =?Windows-1252?Q?XXsxUvLhAKza96IHufYpdvMBd/PE4kqnZdx0e/TDjd/3T9f7LBx1GWeE?=
 =?Windows-1252?Q?kNgaBUsLd84BEgpBHoCZhdit+rLAeOYpy0KWSFJzD/SmxVHVVQXKVAU3?=
 =?Windows-1252?Q?Jukpvx00SfYc9jtgsWCPE67RdSOHoe4tKI1rQcRFBJk2/O1pQ97njVm1?=
 =?Windows-1252?Q?2xXwOeTvYa7ROXlZ2AFgL3XO+GhAUhwW2lw/pkyZxEchsYiOtkFIx9Tf?=
 =?Windows-1252?Q?Qi6ITfe7y/SBtxcQ3IZzgdKjB3BuVv2u2tiN44XXqvHf8Vl5HinvzkNb?=
 =?Windows-1252?Q?KBfgIDm5HfkfiLqh5rvMnIcK+0eRmYlv2OXVsuWPvBLG4wwmyEz3h0oI?=
 =?Windows-1252?Q?OgaTPwXcLgMWPMf01dZfG7FOIzY8uSFneYrjsSKWSwnK6teV0xRSptYw?=
 =?Windows-1252?Q?ij7/jfXJ7kAMDKYWM6H3S/3CA+8vfuAzHhzyA4cqei/iBsVe2AD7IQ5b?=
 =?Windows-1252?Q?Xc//mH2azYbdB95Qz2iEjceKUH5TvmTfWfRdconnHQWQKDtc+zF9NTu5?=
 =?Windows-1252?Q?veNLpnH2i2Z8KQIwIq7f18I+02zPyl+/yU4m4AL2cmU/NOHTwU+Iw/CV?=
 =?Windows-1252?Q?OcGSztf5kPrGchTslAH2bYLs2GVObZQ2kXhbZfW3oHRFOLyoCXlctH+5?=
 =?Windows-1252?Q?FGFCcAI6RLobC+66AOSlDO3k2LCfgI1AJZ0aaQY1hChwKnHSdUagm6H7?=
 =?Windows-1252?Q?ZIi4ybXbRBcj7bxaPrXRVk5pCM36+xzHMlZzK25oEuMJGTLyk68yJ+UH?=
 =?Windows-1252?Q?S8dtxHva4aHQcI82huRawJ4cvMAiTszeXMNqxeSXZYsJ4YojnRJsvgVO?=
 =?Windows-1252?Q?cSKP+iEbfQbP79dp9XQM+01CpVwsVcnezYHaS7tiY4BJSKxyT0CYajLb?=
 =?Windows-1252?Q?gpRSzWb+0nz4HWMVZqlSItw+eAIOMOpZ+pQo+8RX4U+wddMjQaw4QcLR?=
 =?Windows-1252?Q?ARldjeiSZBDfGoeSB4RIc2rMiMQWs4mZutjn0wllB4F/B+lrJJGyT+13?=
 =?Windows-1252?Q?OJ4GqUTiP+elMaHNfGbushn21qAzp7/ybQyEli0bQCLDfDoazOLbZNpc?=
 =?Windows-1252?Q?1QwXgSVj18bRE4HW9d5/+IGJpj3eNYg0tFrJn9IT/s2gfJiUaOpxE+Qf?=
 =?Windows-1252?Q?Jc2/GyaLHeTQZnV9+Rv0Nqk3B+lvHa8gyZec5ZPjP4eDlpQ1ZKq+iTTX?=
 =?Windows-1252?Q?yMorrW+Cpl3XjHQhuAIScODGTN23azo696WPgqVpB+MJomBahINnUiDa?=
 =?Windows-1252?Q?+b9ZyoAiU+XjpCWHB2GvBQyDb/1zDiOc0/owwr7QqNU+P+IqNsZIcBoQ?=
 =?Windows-1252?Q?hCLqxmpwaF2Q4LwnmLIifv2My98AVOe3/wDp+sAQJXn/4fFsByJBM95G?=
 =?Windows-1252?Q?OT+0nNirf5vleorIUJk8869C/pMLkw861I4AJhPaG8ZOoZ6z9pGWgzP7?=
 =?Windows-1252?Q?QTPnu0Wj8cBIduQJyCLKQH7sp3qKxzGq6oqk6eOFnNJdZg56RG/LfWOP?=
 =?Windows-1252?Q?OD7soA905hL4C8CdvJbhzQlXVMgcWy4gLw3DOsit09VTVuUsoiwzzGXT?=
 =?Windows-1252?Q?aEChtbSPfx9HDsx/Y88=3D?=
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2648.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05dc1cdd-1f43-45fc-6f40-08d99913d8a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 06:34:36.5546 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t2F5zNgxGy2J68OL5zsA4hiBxU6njCcVJj23ZdjoPZIOUpoA6DXx54urGwMmY2fDZoiwaWMfIqWO+vySdY8bAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3430
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Hemminger,

I meet an issue when using dpdk-pdump with your patch ,we try to capture pk=
ts from virtio port, all packets captured shows malformed packets , and no =
issue if remove your patch. Bug link:https://bugs.dpdk.org/show_bug.cgi?id=
=3D840
 Could you help to take a look at this issue?

BR,
Yinan

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> Sent: 2021?10?21? 5:43
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Pattan, Reshma
> <reshma.pattan@intel.com>; Ray Kinsella <mdr@ashroe.eu>; Burakov,
> Anatoly <anatoly.burakov@intel.com>
> Subject: [dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering
>=20
> This enhances the DPDK pdump library to support new
> pcapng format and filtering via BPF.
>=20
> The internal client/server protocol is changed to support
> two versions: the original pdump basic version and a
> new pcapng version.
>=20
> The internal version number (not part of exposed API or ABI)
> is intentionally increased to cause any attempt to try
> mismatched primary/secondary process to fail.
>=20
> Add new API to do allow filtering of captured packets with
> DPDK BPF (eBPF) filter program. It keeps statistics
> on packets captured, filtered, and missed (because ring was full).
>=20
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>