DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Govindharajan, Hariprasad" <hariprasad.govindharajan@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser
Date: Thu, 20 Feb 2020 15:46:57 +0000	[thread overview]
Message-ID: <BYAPR11MB2648D70700AD9A87E10610CF84130@BYAPR11MB2648.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1582213402-18941-1-git-send-email-hariprasad.govindharajan@intel.com>



> -----Original Message-----
> From: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>
> Sent: Thursday, February 20, 2020 3:43 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stephen@networkplumber.org; david.marchand@redhat.com;
> Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>
> Subject: [PATCH v2] app/testpmd: fix return value in portlist parser
> 
> The function parse_port_list() is designed to return unsigned int value. After
> sanitizing the inputs, it is returning -1. Changed it to return 0.
> 
> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
> Cc: hariprasad.govindharajan@intel.com
> 
> Signed-off-by: Hariprasad Govindharajan
> <hariprasad.govindharajan@intel.com>
> ---
>  app/test-pmd/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 9d95202..91db508 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int
> *values, unsigned int maxsize)
>  	unsigned int marked[maxsize];
> 
>  	if (list == NULL || values == NULL)
> -		return -1;
> +		return 0;
> 
>  	for (i = 0; i < (int)maxsize; i++)
>  		marked[i] = 0;
> --
> 2.7.4

This patch was acked previously by Bernard Iremonger.
Just changed the patch head line to correct format.

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

  reply	other threads:[~2020-02-20 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 13:26 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list Hariprasad Govindharajan
2020-02-20 15:29 ` Iremonger, Bernard
2020-02-20 15:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser Hariprasad Govindharajan
2020-02-20 15:46   ` Govindharajan, Hariprasad [this message]
2020-02-20 17:01   ` Ferruh Yigit
2020-02-20 17:39 ` [dpdk-dev] [PATCH v3] " Hariprasad Govindharajan
2020-02-20 20:41   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB2648D70700AD9A87E10610CF84130@BYAPR11MB2648.namprd11.prod.outlook.com \
    --to=hariprasad.govindharajan@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).