* [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list
@ 2020-02-20 13:26 Hariprasad Govindharajan
2020-02-20 15:29 ` Iremonger, Bernard
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Hariprasad Govindharajan @ 2020-02-20 13:26 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, ferruh.yigit, stephen, david.marchand, Hariprasad Govindharajan
The function parse_port_list() is designed to return
unsigned int value. After sanitizing the inputs,
it is returning -1. Changed it to return 0.
Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
Cc: hariprasad.govindharajan@intel.com
Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 9d95202..91db508 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
unsigned int marked[maxsize];
if (list == NULL || values == NULL)
- return -1;
+ return 0;
for (i = 0; i < (int)maxsize; i++)
marked[i] = 0;
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list
2020-02-20 13:26 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list Hariprasad Govindharajan
@ 2020-02-20 15:29 ` Iremonger, Bernard
2020-02-20 15:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser Hariprasad Govindharajan
2020-02-20 17:39 ` [dpdk-dev] [PATCH v3] " Hariprasad Govindharajan
2 siblings, 0 replies; 7+ messages in thread
From: Iremonger, Bernard @ 2020-02-20 15:29 UTC (permalink / raw)
To: Govindharajan, Hariprasad, Lu, Wenzhuo, Wu, Jingjing
Cc: dev, Yigit, Ferruh, stephen, david.marchand
Hi Hariprasad,
> -----Original Message-----
> From: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>
> Sent: Thursday, February 20, 2020 1:27 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stephen@networkplumber.org; david.marchand@redhat.com;
> Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>
> Subject: [PATCH] app/testpmd: fix wrong return value in parse_port_list
>
> The function parse_port_list() is designed to return unsigned int value. After
> sanitizing the inputs, it is returning -1. Changed it to return 0.
>
> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
> Cc: hariprasad.govindharajan@intel.com
>
> Signed-off-by: Hariprasad Govindharajan
> <hariprasad.govindharajan@intel.com>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 9d95202..91db508 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int
> *values, unsigned int maxsize)
> unsigned int marked[maxsize];
>
> if (list == NULL || values == NULL)
> - return -1;
> + return 0;
>
> for (i = 0; i < (int)maxsize; i++)
> marked[i] = 0;
> --
> 2.7.4
./devtools/check-git-log.sh -1
Wrong headline format:
app/testpmd: fix wrong return value in parse_port_list
Line too long:
Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
Otherwise:
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser
2020-02-20 13:26 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list Hariprasad Govindharajan
2020-02-20 15:29 ` Iremonger, Bernard
@ 2020-02-20 15:43 ` Hariprasad Govindharajan
2020-02-20 15:46 ` Govindharajan, Hariprasad
2020-02-20 17:01 ` Ferruh Yigit
2020-02-20 17:39 ` [dpdk-dev] [PATCH v3] " Hariprasad Govindharajan
2 siblings, 2 replies; 7+ messages in thread
From: Hariprasad Govindharajan @ 2020-02-20 15:43 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, ferruh.yigit, stephen, david.marchand, Hariprasad Govindharajan
The function parse_port_list() is designed to return
unsigned int value. After sanitizing the inputs,
it is returning -1. Changed it to return 0.
Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
Cc: hariprasad.govindharajan@intel.com
Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 9d95202..91db508 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
unsigned int marked[maxsize];
if (list == NULL || values == NULL)
- return -1;
+ return 0;
for (i = 0; i < (int)maxsize; i++)
marked[i] = 0;
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser
2020-02-20 15:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser Hariprasad Govindharajan
@ 2020-02-20 15:46 ` Govindharajan, Hariprasad
2020-02-20 17:01 ` Ferruh Yigit
1 sibling, 0 replies; 7+ messages in thread
From: Govindharajan, Hariprasad @ 2020-02-20 15:46 UTC (permalink / raw)
To: Lu, Wenzhuo, Wu, Jingjing, Iremonger, Bernard
Cc: dev, Yigit, Ferruh, stephen, david.marchand
> -----Original Message-----
> From: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>
> Sent: Thursday, February 20, 2020 3:43 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stephen@networkplumber.org; david.marchand@redhat.com;
> Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>
> Subject: [PATCH v2] app/testpmd: fix return value in portlist parser
>
> The function parse_port_list() is designed to return unsigned int value. After
> sanitizing the inputs, it is returning -1. Changed it to return 0.
>
> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
> Cc: hariprasad.govindharajan@intel.com
>
> Signed-off-by: Hariprasad Govindharajan
> <hariprasad.govindharajan@intel.com>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 9d95202..91db508 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int
> *values, unsigned int maxsize)
> unsigned int marked[maxsize];
>
> if (list == NULL || values == NULL)
> - return -1;
> + return 0;
>
> for (i = 0; i < (int)maxsize; i++)
> marked[i] = 0;
> --
> 2.7.4
This patch was acked previously by Bernard Iremonger.
Just changed the patch head line to correct format.
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser
2020-02-20 15:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser Hariprasad Govindharajan
2020-02-20 15:46 ` Govindharajan, Hariprasad
@ 2020-02-20 17:01 ` Ferruh Yigit
1 sibling, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2020-02-20 17:01 UTC (permalink / raw)
To: Hariprasad Govindharajan, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, stephen, david.marchand
On 2/20/2020 3:43 PM, Hariprasad Govindharajan wrote:
> The function parse_port_list() is designed to return
> unsigned int value. After sanitizing the inputs,
> it is returning -1. Changed it to return 0.
>
> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
> Cc: hariprasad.govindharajan@intel.com
>
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 9d95202..91db508 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
> unsigned int marked[maxsize];
>
> if (list == NULL || values == NULL)
> - return -1;
> + return 0;
Can you please clarify what is the expected return value on error in the
function comment?
>
> for (i = 0; i < (int)maxsize; i++)
> marked[i] = 0;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v3] app/testpmd: fix return value in portlist parser
2020-02-20 13:26 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list Hariprasad Govindharajan
2020-02-20 15:29 ` Iremonger, Bernard
2020-02-20 15:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser Hariprasad Govindharajan
@ 2020-02-20 17:39 ` Hariprasad Govindharajan
2020-02-20 20:41 ` Ferruh Yigit
2 siblings, 1 reply; 7+ messages in thread
From: Hariprasad Govindharajan @ 2020-02-20 17:39 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, ferruh.yigit, stephen, david.marchand, Hariprasad Govindharajan
The function parse_port_list() is designed to return
unsigned int value. After sanitizing the inputs,
it is returning -1. Changed it to return 0.
Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
Cc: hariprasad.govindharajan@intel.com
Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
v3:
corrected the documentation comments.
updated the comments on return values.
v2:
modified the head line in the patch
---
app/test-pmd/config.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 9d95202..e9b89c4 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2616,9 +2616,6 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt)
* If the user wants to use only the ports 1,2 then the input
* is 1,2.
* valid characters are '-' and ','
- * invalid chars like '.' or '#' will result in
- * EAL: Error - exiting with code: 1
- * Cause: Invalid fwd port list
* @param[out] values
* This array will be filled with a list of port IDs
* based on the user input
@@ -2630,7 +2627,8 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt)
* 1) Number of elements in the values array
* 2) Maximum value of each element in the values array
* @return
- * -returns total count of parsed port IDs
+ * On success, returns total count of parsed port IDs
+ * On failure, returns 0
*/
static unsigned int
parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
@@ -2642,7 +2640,7 @@ parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
unsigned int marked[maxsize];
if (list == NULL || values == NULL)
- return -1;
+ return 0;
for (i = 0; i < (int)maxsize; i++)
marked[i] = 0;
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v3] app/testpmd: fix return value in portlist parser
2020-02-20 17:39 ` [dpdk-dev] [PATCH v3] " Hariprasad Govindharajan
@ 2020-02-20 20:41 ` Ferruh Yigit
0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2020-02-20 20:41 UTC (permalink / raw)
To: Hariprasad Govindharajan, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, stephen, david.marchand
On 2/20/2020 5:39 PM, Hariprasad Govindharajan wrote:
> The function parse_port_list() is designed to return
> unsigned int value. After sanitizing the inputs,
> it is returning -1. Changed it to return 0.
>
> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
> Cc: hariprasad.govindharajan@intel.com
>
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
(Carrying ack from previous version)
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-20 20:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20 13:26 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list Hariprasad Govindharajan
2020-02-20 15:29 ` Iremonger, Bernard
2020-02-20 15:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser Hariprasad Govindharajan
2020-02-20 15:46 ` Govindharajan, Hariprasad
2020-02-20 17:01 ` Ferruh Yigit
2020-02-20 17:39 ` [dpdk-dev] [PATCH v3] " Hariprasad Govindharajan
2020-02-20 20:41 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).