[PATCH] app/testpmd: fix display types failure when query RSS rule

[PATCH] app/testpmd: fix display types failure when query RSS rule

[Huisong Li]

Now testpmd fails to display types when query RSS rule. The failure is
because the '\n' character is missing at the end of the function
'rss_config_display()'.

Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 app/test-pmd/config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 608bec9796..bcb6d42da3 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
 		return;
 	}
 	rss_types_display(rss_conf->types, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
+	printf("\n");
 }
 
 static struct port_indirect_action *
-- 
2.22.0

Re: [PATCH] app/testpmd: fix display types failure when query RSS rule

[Ferruh Yigit]

On 7/7/2022 11:50 AM, Huisong Li wrote:
> Now testpmd fails to display types when query RSS rule. The failure is
> because the '\n' character is missing at the end of the function
> 'rss_config_display()'.
> 

Bugzilla ID: 1048

> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
>   app/test-pmd/config.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 608bec9796..bcb6d42da3 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
>   		return;
>   	}
>   	rss_types_display(rss_conf->types, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
> +	printf("\n");


Thanks Huisong for the fix.

What do you think to have '\n' in the 'rss_types_display()' function and 
update 'port_rss_hash_conf_show()' usage?

And can do same change for 'rss_offload_types_display()', having last 
'\n' in the function.

>   }
>   
>   static struct port_indirect_action *

Re: [PATCH] app/testpmd: fix display types failure when query RSS rule

[lihuisong (C)]

在 2022/7/7 20:22, Ferruh Yigit 写道:
> On 7/7/2022 11:50 AM, Huisong Li wrote:
>> Now testpmd fails to display types when query RSS rule. The failure is
>> because the '\n' character is missing at the end of the function
>> 'rss_config_display()'.
>>
>
> Bugzilla ID: 1048
>
>> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>>   app/test-pmd/config.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index 608bec9796..bcb6d42da3 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss 
>> *rss_conf)
>>           return;
>>       }
>>       rss_types_display(rss_conf->types, 
>> TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
>> +    printf("\n");
>
>
> Thanks Huisong for the fix.
>
> What do you think to have '\n' in the 'rss_types_display()' function 
> and update 'port_rss_hash_conf_show()' usage?
>
> And can do same change for 'rss_offload_types_display()', having last 
> '\n' in the function.
For the quering RSS rule command, the 'rss_types_display()' is the last 
function
of 'port_flow_query(). But it is not the case in other RSS commands, and 
all have
''printf("\n")'' after 'xxx_types_display()'.
>
>>   }
>>     static struct port_indirect_action *
>
> .

Re: [PATCH] app/testpmd: fix display types failure when query RSS rule

[Ferruh Yigit]

On 7/7/2022 1:42 PM, lihuisong (C) wrote:
> CAUTION: This message has originated from an External Source. Please use 
> proper judgment and caution when opening attachments, clicking links, or 
> responding to this email.
> 
> 
> 在 2022/7/7 20:22, Ferruh Yigit 写道:
>> On 7/7/2022 11:50 AM, Huisong Li wrote:
>>> Now testpmd fails to display types when query RSS rule. The failure is
>>> because the '\n' character is missing at the end of the function
>>> 'rss_config_display()'.
>>>
>>
>> Bugzilla ID: 1048
>>
>>> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
>>>
>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>> ---
>>>   app/test-pmd/config.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>>> index 608bec9796..bcb6d42da3 100644
>>> --- a/app/test-pmd/config.c
>>> +++ b/app/test-pmd/config.c
>>> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss
>>> *rss_conf)
>>>           return;
>>>       }
>>>       rss_types_display(rss_conf->types,
>>> TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
>>> +    printf("\n");
>>
>>
>> Thanks Huisong for the fix.
>>
>> What do you think to have '\n' in the 'rss_types_display()' function
>> and update 'port_rss_hash_conf_show()' usage?
>>
>> And can do same change for 'rss_offload_types_display()', having last
>> '\n' in the function.
> For the quering RSS rule command, the 'rss_types_display()' is the last
> function
> of 'port_flow_query(). But it is not the case in other RSS commands, and
> all have
> ''printf("\n")'' after 'xxx_types_display()'.

It shouldn't matter if it is last function or not. I think we can make 
'xxx_types_display()' functions self sufficient, without needing 
additional '\n' after them.

Current output of functions:
"
A B C
D E"

Suggested output"
"
A B C
D E
"


>>
>>>   }
>>>     static struct port_indirect_action *
>>
>> .

Re: [PATCH] app/testpmd: fix display types failure when query RSS rule

[lihuisong (C)]

在 2022/7/7 21:12, Ferruh Yigit 写道:
> On 7/7/2022 1:42 PM, lihuisong (C) wrote:
>> CAUTION: This message has originated from an External Source. Please 
>> use proper judgment and caution when opening attachments, clicking 
>> links, or responding to this email.
>>
>>
>> 在 2022/7/7 20:22, Ferruh Yigit 写道:
>>> On 7/7/2022 11:50 AM, Huisong Li wrote:
>>>> Now testpmd fails to display types when query RSS rule. The failure is
>>>> because the '\n' character is missing at the end of the function
>>>> 'rss_config_display()'.
>>>>
>>>
>>> Bugzilla ID: 1048
>>>
>>>> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
>>>>
>>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>>> ---
>>>>   app/test-pmd/config.c | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>>>> index 608bec9796..bcb6d42da3 100644
>>>> --- a/app/test-pmd/config.c
>>>> +++ b/app/test-pmd/config.c
>>>> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss
>>>> *rss_conf)
>>>>           return;
>>>>       }
>>>>       rss_types_display(rss_conf->types,
>>>> TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
>>>> +    printf("\n");
>>>
>>>
>>> Thanks Huisong for the fix.
>>>
>>> What do you think to have '\n' in the 'rss_types_display()' function
>>> and update 'port_rss_hash_conf_show()' usage?
>>>
>>> And can do same change for 'rss_offload_types_display()', having last
>>> '\n' in the function.
>> For the quering RSS rule command, the 'rss_types_display()' is the last
>> function
>> of 'port_flow_query(). But it is not the case in other RSS commands, and
>> all have
>> ''printf("\n")'' after 'xxx_types_display()'.
>
> It shouldn't matter if it is last function or not. I think we can make 
> 'xxx_types_display()' functions self sufficient, without needing 
> additional '\n' after them.
>
> Current output of functions:
> "
> A B C
> D E"
>
> Suggested output"
> "
> A B C
> D E
> "
Yes, every place calling "xxx_types_display()" needs '\n'. I will move 
it to the inside of "xxx_types_display()"
>
>
>>>
>>>>   }
>>>>     static struct port_indirect_action *
>>>
>>> .
>
> .

[PATCH V2] app/testpmd: fix display types failure when query RSS rule

[Huisong Li]

Now testpmd fails to display types when query RSS rule. The failure is
because the '\n' character is missing at the end of the function
'rss_config_display()'. Actually, all places calling 'xxx_types_display()'
need to '\n'. So this patch moves '\n' to the inside of these function.

Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output")

---
v2:
 - move '\n' to the inside of 'xxx_types_display()'.

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 app/test-pmd/config.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 608bec9796..a2939867c4 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -761,6 +761,7 @@ rss_offload_types_display(uint64_t offload_types, uint16_t char_num_per_line)
 			total_len += str_len;
 		}
 	}
+	printf("\n");
 }
 
 void
@@ -870,7 +871,6 @@ port_infos_display(portid_t port_id)
 		printf("Supported RSS offload flow types:\n");
 		rss_offload_types_display(dev_info.flow_type_rss_offloads,
 				TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
-		printf("\n");
 	}
 
 	printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize);
@@ -1648,6 +1648,7 @@ rss_types_display(uint64_t rss_types, uint16_t char_num_per_line)
 			total_len += str_len;
 		}
 	}
+	printf("\n");
 }
 
 static void
@@ -3924,7 +3925,6 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)
 	}
 	printf("RSS functions:\n");
 	rss_types_display(rss_hf, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
-	printf("\n");
 	if (!show_rss_key)
 		return;
 	printf("RSS key:\n");
-- 
2.22.0

RE: [PATCH V2] app/testpmd: fix display types failure when query RSS rule

[Li, WeiyuanX]

> -----Original Message-----
> From: Huisong Li <lihuisong@huawei.com>
> Sent: Friday, July 8, 2022 9:42 AM
> To: ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru;
> dev@dpdk.org
> Cc: thomas@monjalon.net; Li, WeiyuanX <weiyuanx.li@intel.com>;
> huangdaode@huawei.com; liudongdong3@huawei.com;
> lihuisong@huawei.com
> Subject: [PATCH V2] app/testpmd: fix display types failure when query RSS
> rule
> 
> Now testpmd fails to display types when query RSS rule. The failure is
> because the '\n' character is missing at the end of the function
> 'rss_config_display()'. Actually, all places calling 'xxx_types_display()'
> need to '\n'. So this patch moves '\n' to the inside of these function.
> 
> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
> Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output")
> 
> ---
> v2:
>  - move '\n' to the inside of 'xxx_types_display()'.
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>

Tested-by: Weiyuan Li <weiyuanx.li@intel.com>

RE: [PATCH V2] app/testpmd: fix display types failure when query RSS rule

[Jiang, YuX]

> -----Original Message-----
> From: Li, WeiyuanX <weiyuanx.li@intel.com>
> Sent: Friday, July 8, 2022 1:32 PM
> To: Huisong Li <lihuisong@huawei.com>; ferruh.yigit@xilinx.com;
> andrew.rybchenko@oktetlabs.ru; dev@dpdk.org
> Cc: thomas@monjalon.net; huangdaode@huawei.com;
> liudongdong3@huawei.com
> Subject: RE: [PATCH V2] app/testpmd: fix display types failure when query
> RSS rule
> 
> > -----Original Message-----
> > From: Huisong Li <lihuisong@huawei.com>
> > Sent: Friday, July 8, 2022 9:42 AM
> > To: ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru;
> > dev@dpdk.org
> > Cc: thomas@monjalon.net; Li, WeiyuanX <weiyuanx.li@intel.com>;
> > huangdaode@huawei.com; liudongdong3@huawei.com;
> lihuisong@huawei.com
> > Subject: [PATCH V2] app/testpmd: fix display types failure when query
> > RSS rule
> >
> > Now testpmd fails to display types when query RSS rule. The failure is
> > because the '\n' character is missing at the end of the function
> > 'rss_config_display()'. Actually, all places calling 'xxx_types_display()'
> > need to '\n'. So this patch moves '\n' to the inside of these function.
> >
> > Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
> > Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output")
> >
> > ---
> > v2:
> >  - move '\n' to the inside of 'xxx_types_display()'.
> >
> > Signed-off-by: Huisong Li <lihuisong@huawei.com>
> 
> Tested-by: Weiyuan Li <weiyuanx.li@intel.com>

Thanks Huisong.

Hi Huisong, Ferruh,

May I know that this patch can be merged into RC4?

Best regards,
Yu Jiang

Re: [PATCH V2] app/testpmd: fix display types failure when query RSS rule

[Ferruh Yigit]

On 7/8/2022 6:32 AM, Li, WeiyuanX wrote:
>> -----Original Message-----
>> From: Huisong Li <lihuisong@huawei.com>
>> Sent: Friday, July 8, 2022 9:42 AM
>> To: ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru;
>> dev@dpdk.org
>> Cc: thomas@monjalon.net; Li, WeiyuanX <weiyuanx.li@intel.com>;
>> huangdaode@huawei.com; liudongdong3@huawei.com;
>> lihuisong@huawei.com
>> Subject: [PATCH V2] app/testpmd: fix display types failure when query RSS
>> rule
>>
>> Now testpmd fails to display types when query RSS rule. The failure is
>> because the '\n' character is missing at the end of the function
>> 'rss_config_display()'. Actually, all places calling 'xxx_types_display()'
>> need to '\n'. So this patch moves '\n' to the inside of these function.
>>

Bugzilla ID: 1048

>> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
>> Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output")
>>
>> ---
>> v2:
>>   - move '\n' to the inside of 'xxx_types_display()'.
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> 
> Tested-by: Weiyuan Li <weiyuanx.li@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@xilinx.com>

Applied to dpdk-next-net/main, thanks.