RE: [PATCH v2] test/ipsec: fix performance test failure

["Jiang, YuX" <yux.jiang@intel.com>]

> -----Original Message-----
> From: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> Sent: Tuesday, June 21, 2022 9:31 PM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; stable@dpdk.org; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Subject: [PATCH v2] test/ipsec: fix performance test failure
> 
> This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct.
> Before it was passed uninitialized to rte_ipsec_sa_init(), which does not
> check whether prm->ipsec_xform.esn.value is greater than sa->sqn_mask.
> 
> Bugzilla ID: 1023
> Fixes: f7f3ac6dcbe2 ("test/ipsec: add performance cases")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
> 
> Notes:
>     v2:
>      - fix gcc4 warnings
> 
>  app/test/test_ipsec_perf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_ipsec_perf.c b/app/test/test_ipsec_perf.c index
> 346a851648..11de9a6aac 100644
> --- a/app/test/test_ipsec_perf.c
> +++ b/app/test/test_ipsec_perf.c
> @@ -592,8 +592,8 @@ testsuite_teardown(void)  static int
>  test_libipsec_perf(void)
>  {
> -	struct ipsec_sa sa_out;
> -	struct ipsec_sa sa_in;
> +	struct ipsec_sa sa_out = { .sa_prm = { 0 } };
> +	struct ipsec_sa sa_in = { .sa_prm = { 0 } };
>  	uint32_t i;
>  	int ret;
> 
> --
> 2.25.1
Tested-by: Yu Jiang  <YuX.Jiang@intel.com>