From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E9EBA034F; Thu, 1 Apr 2021 10:49:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A74140142; Thu, 1 Apr 2021 10:49:25 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D8F2014102C; Thu, 1 Apr 2021 10:49:22 +0200 (CEST) IronPort-SDR: AfxmLh7I96Pkry62k8AEj4dO8iGgwIZXnu+ctLfMBuLnrQT5ZQ7gtgORlPYoap+I+91ICEOHEc 5xueFkMCoTeQ== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="172220767" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="172220767" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 01:48:52 -0700 IronPort-SDR: SgZgqiksRsvewRiPJi5Yx8Dzoj1+phQ3TfaZyXJPxomyoLpr2czU90CDqe3tmn5AhKiwEF6MaX XJhXYK5LSMnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="446149968" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 01 Apr 2021 01:48:52 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 01:48:51 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 01:48:48 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 1 Apr 2021 01:48:48 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 1 Apr 2021 01:48:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfyJYU7A9WP4fGqVBSnE5lEljjVcLNpN629yiA9Q5a35vsfpgiDlSIRquK1bPhvL8OMlChcQF5aOVVFi+s/b9jWIztgRC70g/ejRahnCtouNTqA8fHszsekfk5uHcICYSt7YGKtm1SBywJ/nXw8l8lOjqSxTMlTsyMBLbmxKDb9ys/9G+LLY/jUQ2zU4IUML5MH2wg1hCYJPyvY30li37Z0Jj9OmcpWBFt02dsDl/l9mGv5BOylxQEGqOQiY2F+hZ+hZLNThdT4MLNLmbGMTQth07jSt4D+11n8PJTfeGaojnXhpISUad+6IDCoI0sjOSGfP6o0rRCTCK1h8yrUFVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnsTLM0ZlRx5zp6jfDgEfxzT7tZkA9LHQtLiZ8lZ8AQ=; b=jHGWOssQQjim5cznLZxfFdXes/EykDqiTfC6Q4bMbuKZTYwZ7HnoSWtVjR5JOpCIcgGMVAgz6qfB2RewVA0RwCKqVRJPTqUFuSPavjwg1ynLgeC22UQA7Tb+cITZ5syri7wr0882Ku9mHVhUfXvjyxAQxk+jooO3YCXfDxjPV/ItiR5bU2FYcHL8SgqUiYhB8O/KmigYzU3jy1XBypH9mUU0Csk9Ln78O7owKdR5NqQugLFIf3KwWz+89QxRPLtcq18t9QXAwfH2MsxKfV87IN/HZnJUNCC34xGbu40mAbElSBJ5VmiwtbR66ulNVt8FH+n8tFemrWzT0ZhBxk1uqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnsTLM0ZlRx5zp6jfDgEfxzT7tZkA9LHQtLiZ8lZ8AQ=; b=ZCREyceg7ISVH+kRhlnPL5n36yDM56WgWVhKn+eNsnhd6F2u+2/F6ZR1MggtB8R86Ns3hXx6dAncAusgZBo6vXIWRM81aFm+x+8EZj7OzW0579y88Qgdu8hwUxJaWWnAVgk9EPNqq5p8HlJS1aMMhkKLJMliATcZk29fwhStLkw= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BY5PR11MB4305.namprd11.prod.outlook.com (2603:10b6:a03:1bf::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Thu, 1 Apr 2021 08:48:46 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::4447:5f1e:984e:57f3]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::4447:5f1e:984e:57f3%3]) with mapi id 15.20.3999.028; Thu, 1 Apr 2021 08:48:46 +0000 From: "Xu, Rosen" To: "Huang, Wei" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" , "Zhang, Tianfei" Thread-Topic: [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Thread-Index: AQHXGwbdUYs3oC7TqEq7x34FRKQkI6qfcY3g Date: Thu, 1 Apr 2021 08:48:46 +0000 Message-ID: References: <1615969417-17118-1-git-send-email-wei.huang@intel.com> <1615969417-17118-3-git-send-email-wei.huang@intel.com> In-Reply-To: <1615969417-17118-3-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15e90f6f-8fa1-4029-7872-08d8f4eaf67a x-ms-traffictypediagnostic: BY5PR11MB4305: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DoXfD7KWB9o8aSdUmsnxzJFNeaBWax26FXDApYxOzxmTWi+zqrfgLLFCUMhLmGP+vu+Frj+q891uSR6GaDs1SmG0tb8cqf3rfkNqU7KcLjuzB7G5g9RemvNhRK8aMQB8Nnn4ph6WwkTBP1new4u/9aZEhBluxuKPckYykE2/xFZXj6ZyYjV+AcaTINi6Q3BDvY5W5+OlWEw6HG78cRx3q2XXhRWRkFOhI0cKt/hJPgjosdtNTepyTIWj7XNykpyl9qGa6/w6ldUWI52yrf94G+guus2CCOthnREq91hFvTwfrMZNBwZLTRccnDgp2SaeM06SLydILDnuF6rbt7OjX8Q4/dKizINY2K/cVPQ4FfwOroLv3B+6/UT1LUotVEcZyG+jCbfT7U5GEAL2/cTzGW+C2FiZ0Ka/ykrDSi9zG9CWseUpwB2K9Tk3bk2gSziFCUESJiTK0sRFl4ihybpI2CqUoOubMmV1BOTEXkM7e+2JawEige51SXwR69W4PsNYRxpgnFAGyTAWzHtFUREW7kJ1S7d7h3mM55EVpYXIemWQJCbK6Q+YdNDLISl8um7OhbkCcjihQiuzlP9QFi69i5Ye8+CCMgxvYObxTpiS8E/VgE75E+KiRlT7lN3NGgVSqS72aBC1JAxwGo0XTuWmtdfzb6noRV1Qja1GlgBCvXI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(346002)(39860400002)(366004)(396003)(38100700001)(8676002)(55016002)(9686003)(71200400001)(54906003)(110136005)(8936002)(478600001)(4326008)(53546011)(107886003)(450100002)(6506007)(7696005)(5660300002)(186003)(2906002)(26005)(76116006)(316002)(64756008)(66476007)(52536014)(66556008)(66946007)(66446008)(33656002)(83380400001)(6636002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?delM7yM12kywXDm9ntI8yRmfi4sADf+K5HFshAU7uX9NBy9bjLWEVhslcR59?= =?us-ascii?Q?GxB4jA681ldqCUlnpSz9SDXOEbt5S2MWlN6A5E7Qfu3KrITaa2A9rBzsXX9L?= =?us-ascii?Q?YfnvEyLEjSmxVRdDJlybYXTFl0vtMkZaF2zGXgHrW2064xdctaCf7l0IT6en?= =?us-ascii?Q?vF8tH2uRq4NfRj4AqYbVij7u1eXW5KSIQ5yrAZDyaJMHTtDku/bqpW+GNa6O?= =?us-ascii?Q?S/dM1KxTYgc96a+EnvUk70237TU4ZVLcwBlo3I1i9eEEiIQXCHtUu5y8pBiQ?= =?us-ascii?Q?H3upjV50AcJtX6K4gv1TKuB2eAe8LAkEKPN14dPTD4BRzmqw/8KoSSgIaQuq?= =?us-ascii?Q?fn//3Q9wRfp8oxxJMWj4zj+wdIWbbz66GQTpG8rcNoGU0xj6LoUQXa/qa8s9?= =?us-ascii?Q?YrMr5NAbBX6opSueEI3Ktx/Z233FQDESwI+546TeKK4KMwP2IZWLt1FkSRmz?= =?us-ascii?Q?cwMMWEnN/nPG2KWKim41ZYuQa68XH66REYXTONNVZ4LF68gh8m923T4ONhBz?= =?us-ascii?Q?OU3h1Cti7HVrshT9LHbp4Sjg0mM8/H03G8eECPewYV0OekyJUtue6a52/457?= =?us-ascii?Q?HbMPYl7WwznMMOzNkFIZzqryKMjYZ1fVNqqMyiLrfJ/LfRWCTB7I8SZS95vl?= =?us-ascii?Q?ldiboCPJVg6hLzIt9mFN+A6fhu9v/O98sma3lJuoDDpRqXpQVPq7+OtXb6ss?= =?us-ascii?Q?k6JMeEtsH7akM0hNMw4CCIbzy8oFr66lUzvDn8xP0ypGrNsXYZ/Lf7X9CJYX?= =?us-ascii?Q?rqT2rcbXiyJRF5gAVxOVUsKPmfTaUmjyIoK57j0BgZTQxFZD4HXi7lKJGAS7?= =?us-ascii?Q?Ekg1QwfbZQzHGEOKVANuyl/HYhkFYLhQ5JNEmsy7+zVv2ulhLYejm/SCHQHN?= =?us-ascii?Q?7tmz9fP/FJki7H+uW8K/w8mZxTth83n3wBvDUfbL2ubB7BMuMl3V1gaal97u?= =?us-ascii?Q?zvtBRj0oeFLgsFyUxnpz8Vl12GzV3qGcaqpW3uIvP5yrkX73yoO6rE1neu5f?= =?us-ascii?Q?9sHtF7TAqjdjypkG+TnTunvWt9Cx2BNB48bNxZrLd3ryCajHBfAUtIaI7crX?= =?us-ascii?Q?vMDJ3NL8gDInQEMpSXQwtsYNmV7LlecVNHeQqdE15BmS2IHfJtpJwQuGZdg1?= =?us-ascii?Q?ZCbFdWADtCJoyuV3bWbaDmfRPb2mKr2uJLP6yNSYiGZdED7PMMKWgX50Jjco?= =?us-ascii?Q?NAsYpoMmrux8qJumOTzSRy/z6C8nK/5jqdjVOKSpxH3yYMAFOUIEVgxd2bp0?= =?us-ascii?Q?juTFbf9VXQioTCABU5Cwvdmy3FJOpkXK6WYlOhyNOD2mdbDslXWUtcGhlUOX?= =?us-ascii?Q?lxOjnzOFzSY+vLx0LfCX8r7l?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15e90f6f-8fa1-4029-7872-08d8f4eaf67a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 08:48:46.6122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B1JVhRUmpdLZzRfSQarrDJy+2Mw9UbON1ykpkukDMbUIq3nVgk9t64MG4sd+8jzzuwjfftdl6GAWzggtt1xf1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4305 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, -----Original Message----- From: Huang, Wei =20 Sent: Wednesday, March 17, 2021 4:24 PM To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: stable@dpdk.org; Zhang, Tianfei ; Huang, Wei <= wei.huang@intel.com> Subject: [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variab= le In fme_nios_spi_init(), passing tainted expression "fme->max10_dev" to function "fme_get_board_interface" has risk. Add new arguemnt in functio= n "fme_get_board_interface" to accept untainted variable. Coverity issue: 367482 Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_fme.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/if= pga_fme.c index a63f90331f..4edb9e09e1 100644 --- a/drivers/raw/ifpga/base/ifpga_fme.c +++ b/drivers/raw/ifpga/base/ifpga_fme.c @@ -857,7 +857,8 @@ static int board_type_to_info(u32 type, return 0; } =20 -static int fme_get_board_interface(struct ifpga_fme_hw *fme) +static int fme_get_board_interface(struct ifpga_fme_hw *fme, + struct intel_max10_device *max10_dev) { struct fme_bitstream_id id; struct ifpga_hw *hw; @@ -911,15 +912,15 @@ static int fme_get_board_interface(struct ifpga_fme_h= w *fme) fme->board_info.nums_of_fvl, fme->board_info.ports_per_fvl); =20 - if (max10_sys_read(fme->max10_dev, FPGA_PAGE_INFO, &val)) + if (max10_sys_read(max10_dev, FPGA_PAGE_INFO, &val)) return -EINVAL; fme->board_info.boot_page =3D val & 0x7; =20 - if (max10_sys_read(fme->max10_dev, MAX10_BUILD_VER, &val)) + if (max10_sys_read(max10_dev, MAX10_BUILD_VER, &val)) return -EINVAL; fme->board_info.max10_version =3D val; =20 - if (max10_sys_read(fme->max10_dev, NIOS2_FW_VERSION, &val)) + if (max10_sys_read(max10_dev, NIOS2_FW_VERSION, &val)) return -EINVAL; fme->board_info.nios_fw_version =3D val; =20 @@ -1169,7 +1170,7 @@ static int fme_nios_spi_init(struct ifpga_feature *fe= ature) =20 max10->bus =3D hw->pci_data->bus; =20 - fme_get_board_interface(fme); + fme_get_board_interface(fme, max10); =20 mgr->sensor_list =3D &max10->opae_sensor_list; =20 @@ -1186,7 +1187,7 @@ static int fme_nios_spi_init(struct ifpga_feature *fe= ature) return ret; =20 spi_fail: - intel_max10_device_remove(fme->max10_dev); + intel_max10_device_remove(max10); release_dev: altera_spi_release(spi_master); return -ENODEV; -- 2.29.2 Acked-by: Rosen Xu