From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1F0BDA0564;
	Fri, 12 Mar 2021 02:21:20 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 899724067E;
	Fri, 12 Mar 2021 02:21:19 +0100 (CET)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by mails.dpdk.org (Postfix) with ESMTP id D9C434014D
 for <dev@dpdk.org>; Fri, 12 Mar 2021 02:21:17 +0100 (CET)
IronPort-SDR: DSiVy7FutL5qfbI4BcDTXwEOS3FS6OTO926tIjmfWg8Z+TRrppHTen+foLfGM0xSoR3JRVPhlP
 LRK2Hc6MNmVA==
X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="168039713"
X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="168039713"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 11 Mar 2021 17:21:15 -0800
IronPort-SDR: mAQfK/1qqVeCEZw4HOWDCSgGv3QB0hqqSIB+f5XshsieGOic7BYWCzSst5HSTCY3QSP81Z3iLC
 RufHQ+gKubHg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="370738460"
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
 by orsmga003.jf.intel.com with ESMTP; 11 Mar 2021 17:21:14 -0800
Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by
 ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2106.2; Thu, 11 Mar 2021 17:21:14 -0800
Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by
 ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2106.2; Thu, 11 Mar 2021 17:21:13 -0800
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2
 via Frontend Transport; Thu, 11 Mar 2021 17:21:13 -0800
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169)
 by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2106.2; Thu, 11 Mar 2021 17:21:13 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DPIKu+IGiI8hVPHXQNtdeQ8cYB49y0Rrq2MhgSo1OCqfTEh+j1/VaovdHGTUUl6XbHL0Qw/bAKfDk4cB8n765Mnn/+GKXLm0nuB/1cGlZzd7EO1/cE0PkzBWjNBPR13R2Pa0YQezmm4ryNORyCT+XzDnk9vvr5Gc6jtTerxh0scg45i3lKpgy6JxNz5KLvq1oDe4s537CjQs67RfP7upTPxVvvDGrmgONHXUc/lVaemDPRj+BHTJaFgdocULb05aO/uhVlNbgyoBpg20LD5HsbRK94GXXA67g9iN7qN71VIeIw+Q8Koarq6hSkE7AR49eY3oLRvzsP/o8ZyTnRlM2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Frgc9zwhVQr7B4+oBWazhEEgeQ5JOb1owAQCs2cis4U=;
 b=id78/VH+9s+V54QmFFLgp07sIETbsrcaQU6QvIWe4AYQYGkV6OqCNG3CEaKyZGM9h8Ku4vjZmqx/ET60FDZFETufuvCsbCZnMnBbiMMyKvNaFovqCZ93tBhf1YCGvc0QeSZkIKNV+joGvDLUKQj06ux6CfD2weQfFeTv8HPo+FG6PgQbrlGQG8pHAQBhlNEVx0i/9UwMocwnHxcHVMS8ztZqUUgjllYu2M3MJub66vmKvSwRbNa15oB1CyNBjoWnSrFpnAg6WiIKTa6eQtpY5rBvbdflbgoO7KGkF0YAZzKdH4wAMw+df8sWsYExgsZbPApQkOIduOSWHH7F8O24NQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Frgc9zwhVQr7B4+oBWazhEEgeQ5JOb1owAQCs2cis4U=;
 b=tuqPiMps6vZrSxtXNd+rDahBWgVO07OFGRXuwO1jSIIZXioc8KXz9I9j1Wsaj79XshSXz6L2Q/z5gMCZAoI8cwnTP/fJkk0SEwYvRfo0w6jMupRCPjj/zaqE65Qp6o2X0Uw/T0cpKWP6jTzhyDjfK2ocV4UO0TXs92wYDMOXWwc=
Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23)
 by BYAPR11MB2533.namprd11.prod.outlook.com (2603:10b6:a02:c8::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.29; Fri, 12 Mar
 2021 01:21:10 +0000
Received: from BYAPR11MB2901.namprd11.prod.outlook.com
 ([fe80::4946:fd9f:86f7:43f9]) by BYAPR11MB2901.namprd11.prod.outlook.com
 ([fe80::4946:fd9f:86f7:43f9%7]) with mapi id 15.20.3846.054; Fri, 12 Mar 2021
 01:21:10 +0000
From: "Xu, Rosen" <rosen.xu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
CC: Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena
 <sachin.saxena@oss.nxp.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Xing,
 Beilei" <beilei.xing@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Guo, Jia" <jia.guo@intel.com>, "Wang,
 Haiyue" <haiyue.wang@intel.com>
Thread-Topic: [PATCH 2/2] drivers/net: remove explicit include of legacy
 filtering
Thread-Index: AQHXFsR1joL4hCzGYUWUByt6wWlCPqp/jljw
Date: Fri, 12 Mar 2021 01:21:09 +0000
Message-ID: <BYAPR11MB290117C71466DF5693748D39896F9@BYAPR11MB2901.namprd11.prod.outlook.com>
References: <20210311221742.3750589-1-thomas@monjalon.net>
 <20210311221742.3750589-3-thomas@monjalon.net>
In-Reply-To: <20210311221742.3750589-3-thomas@monjalon.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: monjalon.net; dkim=none (message not signed)
 header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com;
x-originating-ip: [192.102.204.36]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0e0f1d26-f12b-40e9-0dfd-08d8e4f51e72
x-ms-traffictypediagnostic: BYAPR11MB2533:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR11MB2533786433873AFE6C225D2E896F9@BYAPR11MB2533.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:785;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: jHuNifmTk6JbqgbxpZsyW8MuZ3l2QT1N8EM3o339t5pcipweZ7B0/SjDQOIqU57ECMLlFUFxd5RkOAXK+8lTjjAw3pGNXOSPs0luj1aH9GnpyiFvLPJHyc1P/IZ4zODsgW236OCiotDbCImHSNgzlwLh1I1Nifm3aJ2/EooJiA8KVd5WsK42BwrDpGc0YaLNCpuFYB52WeXomXoL67j+ZRwDnFYSOU1xoQ9CG7HrdeLAtmX7l6LgZos28iPTpytzsq26uttLLAs0cpbJNTvTAdYlQQoZ8GwOWTgpoF+ebfRCenhxkOCHbPR5jHE5c/pP9fofN3HhjkrkTwxjnD1Bb/um1CTX4S/8c5xqlMi3K4d+XSOJycfIHZnXJH+oO3RYRajncJUukVO6Hdfp1JA8lkLP3PV7p7MKE1udSXETd7t3uidrMYb8XfMHw4Cu+IvMeFqXXBgf5Q9v6WjSSlJCMAdEQE2/ll2KHTr1ijFK2xrodD8TlMi8qmql1GEP0TDb4AeDZ/yDlKK4dsGLWkyZWQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(136003)(396003)(366004)(346002)(376002)(39860400002)(83380400001)(2906002)(8676002)(54906003)(107886003)(316002)(186003)(55016002)(86362001)(9686003)(26005)(52536014)(33656002)(71200400001)(110136005)(478600001)(4326008)(5660300002)(76116006)(7696005)(53546011)(6506007)(8936002)(66946007)(66446008)(66476007)(66556008)(64756008);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0A7GMMeakkF1G8VrNBTa6Zdk3BRtpPfzkh8kVivKitOx4yEGlUpFk/z6fHPN?=
 =?us-ascii?Q?5JnmDsCaAq+7ZEuTFjbOPjFB3DB6BDyq6gWK/JTQupwYjkT4BA3hkh0XUeMf?=
 =?us-ascii?Q?pAPvguKhaQZ01kmJHevF1UGeFK1gcmGe4rBBi8+3Zfrk575o2ZfBUYMgG7lH?=
 =?us-ascii?Q?Ihat3PXWf+zXp2d7nL/r2bHHMf590aKEJJyGPGdcius1cXt7gMYHQ6p617CL?=
 =?us-ascii?Q?nim8+zaJB6YVNhEjS3MFLEgLpGH9FdW1jWzSo0mWxgPl49EmkAA+paAlBh9G?=
 =?us-ascii?Q?dnNlQECETR243cUtYmBsD3nDkvGM7SXPJdG7PE3ipxzgbZBKWIKIXSiZUr9L?=
 =?us-ascii?Q?Oz5sTMEEsWH7ZJxoIRblN4IphISdGkJElctcQ63Vjn1Rl2XR7S1L1mT6lf2v?=
 =?us-ascii?Q?fjGJPRWOqfbqB05cKf6bHavumYpoA9FeLyD56wRd0+bC5He4JHT3a+Ejg9A1?=
 =?us-ascii?Q?izmft4pwHhh3W5dRCpDZOXUDi8zY5aVZAC6Eu9+9jQB1mpkqCnJwXzaTrlXE?=
 =?us-ascii?Q?J3pbsF5aQSayFh1C5Zo1VBeq8j6jSySD9Y040mpbRw+vqNZwzxhcb/KzAhW2?=
 =?us-ascii?Q?gq6e2CKVsPltNdwwMOJ5j9yKr1kIp39pv20gwN9iR8sT39o3OjwTrmKjzbwc?=
 =?us-ascii?Q?Yw694WQzgpNAHp6cU0ygEF3bnA0V6fhJa7UBTYR4bgazVlew66QGbmCT1tPu?=
 =?us-ascii?Q?8ekVW0Bhgu3mebmOaaWIrHYRHpklUTTzCQGke3zZ+nJPy3AwlqpiSsUMRnK3?=
 =?us-ascii?Q?9oBgWCmJsPx8Dj3IHFsVTPXlotHgmuHnPkSs86I6ZVqgd7qxdnxO2xdAdavu?=
 =?us-ascii?Q?yvvGyqiBlusRDG4uvXEXqJJ7GHAhx2DoUCh2JMHZWm193Wl+ZCfnSse03xpQ?=
 =?us-ascii?Q?iIhszOZ96wJtjpWrL55s28UWEz4oR4M0W4zgD9WRLxL/MdREuhP0rywfnCP8?=
 =?us-ascii?Q?/LehnbiK/rJfBTYVZrYzdvhYqV8C0CLI6t+mcCpFMQtRoOhGQL4gZfBe0ISu?=
 =?us-ascii?Q?F68sIShaaiFMwz/vWfbT5oMzHCwnEJ7iXefAWla4RC05kahsM9egT9WfSknG?=
 =?us-ascii?Q?EKRF9d4iL1X8iCXQZQlnmAYmeoCj9MtGZQ4pjrCbcU3O87ZYS5fj11znWeZT?=
 =?us-ascii?Q?MBv+rCNAgHltCCFWAcKAtxbqAtd6bsr3fS53GMEYRea4Q0LeVc0lYMOIIdCp?=
 =?us-ascii?Q?A+rT2Pr04RQ6Y59jRVuagb0NFEGZg/l3PeJSY3gvoGsZeFzjp7UGA+HLJaDH?=
 =?us-ascii?Q?9N/3wzbqLz4I2nPBKuIkxHKa/DxtfaItqFg7x5HQKUKYxIKssVHMpsBWY1wZ?=
 =?us-ascii?Q?4/cCv4ZJsczgil2KBEb7Mxa5?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e0f1d26-f12b-40e9-0dfd-08d8e4f51e72
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2021 01:21:10.0037 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YwGyjse/AzvpA1kJ/wQo/fsigfeVt9J6XHlLHBzTHncYYZfR7mjIwmVgeB+n/PVzjKIu3pIkdq7s8JOeo0inXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2533
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] drivers/net: remove explicit include of
 legacy filtering
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net>=20
Sent: Friday, March 12, 2021 6:18 AM
To: dev@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@o=
ss.nxp.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xin=
g@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang=
@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.=
com>; Xu, Rosen <rosen.xu@intel.com>
Subject: [PATCH 2/2] drivers/net: remove explicit include of legacy filteri=
ng

The header file rte_eth_ctrl.h should not be needed because this legacy fil=
tering API is completely replaced with the rte_flow API.
However some definitions from this file are still used by some drivers, but=
 such usage is already covered by an implicit include via rte_ethdev.h.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/dpaa2/dpaa2_ptp.c       | 1 -
 drivers/net/iavf/iavf_hash.c        | 1 -
 drivers/net/ice/ice_acl_filter.c    | 1 -
 drivers/net/ice/ice_hash.c          | 1 -
 drivers/net/ice/ice_switch_filter.c | 1 -
 drivers/net/igc/igc_filter.h        | 1 -
 drivers/net/ipn3ke/ipn3ke_flow.c    | 1 -
 7 files changed, 7 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_ptp.c b/drivers/net/dpaa2/dpaa2_ptp.c =
index 899dd5d442..6290a559d0 100644
--- a/drivers/net/dpaa2/dpaa2_ptp.c
+++ b/drivers/net/dpaa2/dpaa2_ptp.c
@@ -12,7 +12,6 @@
=20
 #include <rte_ethdev.h>
 #include <rte_log.h>
-#include <rte_eth_ctrl.h>
 #include <rte_malloc.h>
 #include <rte_time.h>
=20
diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c in=
dex d8d22f8009..82f017db3d 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -15,7 +15,6 @@
 #include <ethdev_driver.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
-#include <rte_eth_ctrl.h>
 #include <rte_tailq.h>
 #include <rte_flow_driver.h>
=20
diff --git a/drivers/net/ice/ice_acl_filter.c b/drivers/net/ice/ice_acl_fil=
ter.c
index 113cb68765..6fd6e2d6af 100644
--- a/drivers/net/ice/ice_acl_filter.c
+++ b/drivers/net/ice/ice_acl_filter.c
@@ -14,7 +14,6 @@
 #include <ethdev_driver.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
-#include <rte_eth_ctrl.h>
 #include <rte_tailq.h>
 #include <rte_flow_driver.h>
 #include <rte_flow.h>
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index =
81caf6c635..6ac9f374fa 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -15,7 +15,6 @@
 #include <ethdev_driver.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
-#include <rte_eth_ctrl.h>
 #include <rte_tailq.h>
 #include <rte_flow_driver.h>
=20
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_swit=
ch_filter.c
index 6525e6c115..2742ce29c5 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -14,7 +14,6 @@
 #include <ethdev_driver.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
-#include <rte_eth_ctrl.h>
 #include <rte_tailq.h>
 #include <rte_flow_driver.h>
 #include <rte_flow.h>
diff --git a/drivers/net/igc/igc_filter.h b/drivers/net/igc/igc_filter.h in=
dex 781d270def..fb51f7066c 100644
--- a/drivers/net/igc/igc_filter.h
+++ b/drivers/net/igc/igc_filter.h
@@ -9,7 +9,6 @@
 #include <rte_ethdev.h>
 #include <rte_ethdev_core.h>
 #include <ethdev_driver.h>
-#include <rte_eth_ctrl.h>
=20
 #include "igc_ethdev.h"
=20
diff --git a/drivers/net/ipn3ke/ipn3ke_flow.c b/drivers/net/ipn3ke/ipn3ke_f=
low.c
index c702e19ea5..452fb447ef 100644
--- a/drivers/net/ipn3ke/ipn3ke_flow.c
+++ b/drivers/net/ipn3ke/ipn3ke_flow.c
@@ -16,7 +16,6 @@
 #include <ethdev_driver.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
-#include <rte_eth_ctrl.h>
 #include <rte_tailq.h>
 #include <rte_rawdev.h>
 #include <rte_rawdev_pmd.h>
--
2.30.1

Acked-by: Rosen Xu <rosen.xu@intel.com>