From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 441DFA04DB; Tue, 1 Dec 2020 09:38:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F8A1C982; Tue, 1 Dec 2020 09:38:30 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BC2C6C956; Tue, 1 Dec 2020 09:38:26 +0100 (CET) IronPort-SDR: aMXw5bw7jIqOYX4RuvJ23JTzS+I4Pp067yrouoAhs1+oBrx/q3GB+OvG32Kp6qxun96sRbqNcv hzjpWdu7yCXQ== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="152044596" X-IronPort-AV: E=Sophos;i="5.78,384,1599548400"; d="scan'208";a="152044596" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 00:38:25 -0800 IronPort-SDR: BdSsSv1glWq1qqECljAxpsmTF01OXwsAw16jeB4aqu92Hkx9m9BNKdrnChFSCc1xuwCRZGhgZT espIQiP9nWiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,384,1599548400"; d="scan'208";a="537389843" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 01 Dec 2020 00:38:25 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Dec 2020 00:38:24 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Dec 2020 00:38:24 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Dec 2020 00:38:24 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 1 Dec 2020 00:38:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MxfdEwmsVO5ANm60jp2ErIkWm+QuoqLa/7IKgUcD2FBhwkbDNAZTLwNqmRT0fQCIoEUw5B4w+J7+TRqQDseJ1KZpfu8A9G6aHpw5p8EBtyWw1zgH35QuDy3S+2D7dKQN7/flNcND8fdVmkse8ssbKCgt2BFYoDvyXRRbbXG0RA0MFdTQnHa9Xe4M//cW7Eafy7P4LnNVU5BES9tP/96FUreKuPTQWzhvE+sPfwfQvRGcuSqIa/AvE1h/doybPrNqjqYFAKVClUttCxUXowyu86n7XGftEU5K0OIFuc1llFd04+zm7uIinPm0ALFHLxfmOP5TznrbXkhsT78ywDuQsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzbzu9tbt2teW9QHto5bHsGfk+5dBjBLCN5H8Vy+U5U=; b=ZCfFQ2CBSb0HeCqDmeF/1pkJbI7WD8/BNH4oX/MQQu+qwikaa0OD3xhhzBTn/xJ5c979khgauVrHk+7PVEbyer6XpshNTvx9s9T3CbVENpouWB8cQvR3pglFPOM5hZw5Sj+im6v5GpjFKGHu8S6rj6MEgfmlHoKcZJmLvAcqNsm4gltPmRyqa9PjokK/BzedOsGyS4P68KWKdEPXFS0dnx8jScN8pEF4YbSGRBDT8g8W7wM4h7QjjZw7toQKO4vStJ1CZA84LAwCss+CvJn5mebWSz2PioGDFQBAw5p6Z3IGhaxS6xtDtjnr+QrPvMoThwgFzwfzgI/I94z4+pKzKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzbzu9tbt2teW9QHto5bHsGfk+5dBjBLCN5H8Vy+U5U=; b=l3x/wQOAmJ20ZZG9X9cKGHadtOKQskOnG7OL2uNTzrJN5giVAyULlZ67JMe1Z+aktsjrJ4cWFSZx3OLw7yppFB+860BUA60EjxQ3AB8yKYg7SAXYH/zf9x8VSb1g3iQbB6dz3Pn5EL1UPpidiNuhczX5b/ttOdDm089vMsMHT9I= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by SJ0PR11MB4845.namprd11.prod.outlook.com (2603:10b6:a03:2d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Tue, 1 Dec 2020 08:38:19 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::944f:d718:5ed7:fe75]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::944f:d718:5ed7:fe75%2]) with mapi id 15.20.3611.025; Tue, 1 Dec 2020 08:38:19 +0000 From: "Xu, Rosen" To: "Zhang, Tianfei" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH] raw/ifpga/base: release eth group devices Thread-Index: AQHWwvtJ/hibIxQ0E0K+urPG5yoC06nh9JwA Date: Tue, 1 Dec 2020 08:38:18 +0000 Message-ID: References: <1606288756-24705-1-git-send-email-tianfei.zhang@intel.com> In-Reply-To: <1606288756-24705-1-git-send-email-tianfei.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTI5MmNlNmYtZDg4OC00YjVlLThjOGMtOGQyMjA4YmI2OTViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTHY1N2FpRWRaRFkzdE8xbkVRcWNwSEFMZjh6UndieE9BYVpqbUZ0TUw4S01PcmRGNFZmeEtrSzRzbTg2MmdTKyJ9 x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed2cfd8f-d7d6-46bd-c7a8-08d895d4746e x-ms-traffictypediagnostic: SJ0PR11MB4845: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NbhxfAA0eRNnpcL2uk4BkyOOydqXWH1kyc8FQfalg9O7QTYHAGKzwLn+klz6BNpNMAhhFdogw/Grt36AnirM//BhcPPDzPe9/egUr1bnE3SUyyZSjVArgIEVJlmLccYIiWL+IXOv+1oPDwzrnIxtLR/f0A20zrPMbFQKhNvDR2WXU052555wV5u+T80McPQBKPJZWYa9hb2OUZYl4U60wJhaU4gLWCnLYom0m3QKTMg+VvDrPwK0Sw4sJ7h/5df2lJImZ5y61XzBtuklhwVPFGFYJ4mcHEKss8DQbfIXHftdgzAHP1laopZicxicBfn50L9MXKN55L/l/L3bPsJbNRLRtZpKfTz/G+gnRMAAna4QUJRIsTC/THX5bQAG5bhC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(376002)(39860400002)(396003)(136003)(4326008)(450100002)(86362001)(52536014)(76116006)(66946007)(66476007)(478600001)(83380400001)(66556008)(64756008)(66446008)(71200400001)(8676002)(26005)(186003)(33656002)(8936002)(5660300002)(9686003)(316002)(55016002)(2906002)(110136005)(7696005)(6636002)(6506007)(53546011)(6606295002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?eYGgj3hEy4dqJqNk9O8chuRDQKbw/QM5o1mHwRpYRtNg8jlR1wwfDn+X16YM?= =?us-ascii?Q?u6il/KttrIP7ZwzyAD8xvYPNSuBD4gf70jRmRr+2DIK1U4VAT1UuaixlU0gP?= =?us-ascii?Q?i5fnLAd3SPxNPNocmepH2s4u3KB+g2xAxNOtBOz4t6oq2P3nDJIzL2XqifLu?= =?us-ascii?Q?qgkSAxn8c3apGspRepMkba4rX266MXcTPNSAUIxMfvi+WAgAql51ICuUbii2?= =?us-ascii?Q?+hYJJoZ8uwoRoEChVEs1AJDtrp4YqCRXeb0FzgeQJJOC+mujALzxmk7fcXVr?= =?us-ascii?Q?g+8rEC6jQdLRNqj37cK2rzfGHgS6jpV4cf1SBm7oRnao3yEv46Oc/Y0ID6kx?= =?us-ascii?Q?sWx950VnZDSVNGBPulCIX5v+QGHGq10luyacyth6y2Orfv2ACw6gzRgMp0sq?= =?us-ascii?Q?9RY2+sVbfTQT69gUgrt3CWl2L4Zy2zymMsyluzm3pbVdtk6t8wWeg2SW+9Ic?= =?us-ascii?Q?J3X81ijdOzjOx5w9wq7ge82CtnovGk6oGTI0wDTTWenLTJC6CDnVuakufBwt?= =?us-ascii?Q?CqAVElrqctlauzdflSsrkGVO3Jw6fycihz2zjBGVji5LvOvEAfJBdVumvuw6?= =?us-ascii?Q?F/JGT0rQgwcEKFU7UeSVvW6D/jm/fpjEVXr2dQ1GJTenb8KX8qhXlJqK/MRB?= =?us-ascii?Q?K+vOgk+iCwBcy9dHbF37GoGOfGBVte23g1I5+jepWp+LO4u1gWenvlfZt5Zj?= =?us-ascii?Q?Jo1F+QZagnlB/O9Kq9h3JAps3z691T74hyTi+86oi3DYLwMidXj8go1mPg8P?= =?us-ascii?Q?eGtagrXoM4jLyEGXtnfZUvNPu1X+jyY9oNkLrs1JrrzfZ34UKNPwYC/4FERW?= =?us-ascii?Q?5z9alzhidYGYv0Iisjptsn3HqjIZGVFeZmUsjJ2YKmvJG1jvrShbtU4/347X?= =?us-ascii?Q?ZdWFNy1MLYtJGyS82DNXbt8bZ3CpVcbAZFEG80WkTwNK5ioDDuSARrr/zo4g?= =?us-ascii?Q?VJrdwG/QIHY4MYItDo1KFHT+LnhcPhvvOI1SjqztMMc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed2cfd8f-d7d6-46bd-c7a8-08d895d4746e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2020 08:38:19.0058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a1Dp16sI5Rc4JNq//McWUhCZKjLjHBArfqzcBMjjajppMGrO1pHuu9uy81fdlMMdjsJdvJ3bUY6aOHIZOUknCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4845 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] raw/ifpga/base: release eth group devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Zhang, Tianfei > Sent: Wednesday, November 25, 2020 15:19 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: Zhang, Tianfei ; stable@dpdk.org > Subject: [PATCH] raw/ifpga/base: release eth group devices >=20 > From: Tianfei zhang >=20 > Release the eth group resource in fme_eth_group_uinit(). >=20 > Fixes: 8a256bef32 ("raw/ifpga/base: add eth group driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Tianfei zhang > --- > drivers/raw/ifpga/base/ifpga_fme.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/raw/ifpga/base/ifpga_fme.c > b/drivers/raw/ifpga/base/ifpga_fme.c > index f29ff31..0a7d3c2 100644 > --- a/drivers/raw/ifpga/base/ifpga_fme.c > +++ b/drivers/raw/ifpga/base/ifpga_fme.c > @@ -1288,9 +1288,27 @@ static int fme_eth_group_init(struct ifpga_feature > *feature) > return 0; > } >=20 > +static unsigned char fme_eth_group_get_gid(void *base) { > + struct eth_group_info_reg info; > + > + info.info =3D opae_readq((u8 *)base + ETH_GROUP_INFO); > + > + return info.group_id; > +} > + > static void fme_eth_group_uinit(struct ifpga_feature *feature) { > - UNUSED(feature); > + struct ifpga_fme_hw *fme =3D (struct ifpga_fme_hw *)feature->parent; > + struct eth_group_device *dev; > + unsigned char group_id =3D fme_eth_group_get_gid(feature->addr); > + > + if (group_id >=3D MAX_ETH_GROUP_DEVICES) > + return; > + > + dev =3D fme->eth_dev[group_id]; > + if (dev) > + eth_group_release(dev); > } >=20 > struct ifpga_feature_ops fme_eth_group_ops =3D { > -- > 1.8.3.1 Reviewed-by: Rosen Xu