From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FC64A04B1; Thu, 5 Nov 2020 12:32:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8382ABE85; Thu, 5 Nov 2020 12:32:31 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6BC15BE59; Thu, 5 Nov 2020 12:32:28 +0100 (CET) IronPort-SDR: OJkw5zLEpcLrqdNqxdhm4odlVaChVN5NS68K1GkGYcY3BF74+y+gzwrfstndIJvf9w8PZV7iae DLYiPBEEJavw== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="149220008" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="149220008" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 03:32:27 -0800 IronPort-SDR: WQX6KJ57hXaRunx3l6YHwuE3H6IDbJ1Vobv4Z0DOYJNzsZCOIBqCu7L4ImecyrQnFGtJ3MkVk/ BQnP4kKdeLww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="358393613" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 05 Nov 2020 03:32:27 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 03:32:27 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 5 Nov 2020 03:32:27 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 5 Nov 2020 03:32:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NArTaqrqXm2lkVAFZM6/qe0jARcEJTtyXbLPtorBtR9Rd0LNNmIOiAaoONiXYNPOC1hPD9gIs/6a+yRHQ617nyRWDK7x9dbDdGv2ukkMQcLPKoY/UeyUi8atJTlreUCY85g2WjimkkBHymECQUvUy7NTIA/Qiws9rcEneZmTRcPmxali+A1duTQgzOuLPbb+gvHGIc+jI7cPeJQJIl2cFeAJ2DTHIrcqMh1C1EvUWnwMzfCzeHO6qFIbffcpuN8ehSc+pJTB0Mc+8I3y3SiVhosmDBvgaWwnioFrPmIoMVRYlzJ0LLS274wGPK4Er4sLng2ozsLfoDl9qylvxXo7BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOQlGrgqiBrvZVFrbDVtd0pH6TnJcuTo+i6lEw3Zfig=; b=P+noyqUtESVQ3R/MlPfK978B+2JDiJWCdosCPcGrq9+emBLsG/mqnmgxDmqOOel14J6M1UURfSIIApLC6yBNggflXNIyZ6yj2LrmauEnTx6YtysMwS7ElvD+BdjsiJwz8HFwBlQiuVx21QatIHMM7+tcrKlfyMw/yPgmREW0Uumi2a17vnnjndtC6QbjKDAjocbfgIHUAO2DaXgHwEJP3ZgHfqYURPCjCuLVtfJilLnLv+F60j5qf3kL+RKfSM9F3FjXxR1pQAl7ZPmf0s+epZIRFvV1mIMh1rOKy7yX1M4dqw2BCAzwDLK4/M+3N8lkOpo7rkBNCmHvw9TveHRabA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOQlGrgqiBrvZVFrbDVtd0pH6TnJcuTo+i6lEw3Zfig=; b=X5E5vVy4wHH4zI2uU5s2+nPdM+kRq2wmleaQeFF9xBuumZuy6k734o3TGIWF0Z4YJYm6J5pwDt+q6Unol4to9jsFZdTOtQK342/XcOFUeNl0BtTRI8OlHWqBghpEM9U8yJ88XIN70Yh3vlyvRqWhMNmwKxlIj8X4E8FL5QQRbT4= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BY5PR11MB3911.namprd11.prod.outlook.com (2603:10b6:a03:18d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.30; Thu, 5 Nov 2020 11:32:23 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::8d75:dadd:9af1:81ab]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::8d75:dadd:9af1:81ab%7]) with mapi id 15.20.3499.032; Thu, 5 Nov 2020 11:32:23 +0000 From: "Xu, Rosen" To: "Huang, Wei" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2 1/2] raw/ifpga/base: unlock mutex when nios init fail Thread-Index: AQHWsyCWLfVkHSOwB0SuB+q8A5Saw6m5aELQ Date: Thu, 5 Nov 2020 11:32:23 +0000 Message-ID: References: <1604541940-5994-1-git-send-email-wei.huang@intel.com> <1604541940-5994-2-git-send-email-wei.huang@intel.com> In-Reply-To: <1604541940-5994-2-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzBjN2JmMzItOTRkNC00ZGY5LTgzMzMtMmRmMDMyYjIyMTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVGVXOEJvXC9UeVduZE9zRTJUaFF6blRiOFk3SHdQNDZJK0FLYm12WG14MURpODdvS2JHOUlEbmRaUTdYdTZabnAifQ== x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 732a030a-9f87-413b-4f75-08d8817e7701 x-ms-traffictypediagnostic: BY5PR11MB3911: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fSBMDS3dwOr1dJ5xhp/yI3BZ/Z4Ga/yQJFbfCDTV0LQ4i2H5e2tZHilkjpudwDd81Y/lfrlITrsGskecnmw6kAXU7YtGufDD8Cu4tdRY5B3Lo+erhpeoSwZdB1c8BxYqQ3O0hXR+wMG2DAW1yzrtueMtU9rAG1jKuN9wO937s4PfnP1+0wfNfI+HrURwW4BMJW0txq5EtoAqcuH2GlAwtG4IesrYJ+UPekj4OawsEF50MbySVQoBKP37pXzr1PKrLuCv0wWVh40Hz43wJNnMx8aZGcIu8DmErB469ZW0WdiXEWXCLfTNESJb+BW4ImjN0yjcRAVhkTWRoYF2BqCPng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(66946007)(316002)(4326008)(26005)(53546011)(110136005)(6506007)(83380400001)(2906002)(186003)(52536014)(33656002)(478600001)(55016002)(9686003)(8936002)(71200400001)(66556008)(66476007)(450100002)(5660300002)(76116006)(7696005)(66446008)(64756008)(86362001)(8676002)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: sKxfpltCqB6C0xjOho72F0YEaHGxwAOG6pw8gxxVARmIiGJfDH2RI5j7nqLPVW9G+NnwJhqiG7akimH1IIWO/Lj991BxZJ4W3G3T1g4MB+oTweme4VfZA6n/ebxGTUS+5UwD79aS1Go8G9x9HDUKtz+YOZYBs2r+4IH4pTuYWFf82FU+DOJM7GsRN1hqeV+nbLX87KlLZs5sRbZz5FrREgmNU+NDbQADIzvIaR2dCjv6YfqnwbqgKelbUkdYFk184Br7EDsFEMsQTTxkHE+apVJfcH3Ya5tU/QnoXmaJ0doqNAASkAhfyWWeAO4+bpQ4xQa9xuCF26ICVb60kn9FbyGPknJ8w/SdWo4e4nfdg4wzSPhlNg0NKjQk7bjpdicFS2hN8DCAbdhdezra0qfxwvQjh0XCZb7+AbjqckYnqAGu/y7h5GTjo4AloUktFJiWXvkPlX0/kV6s4X0R9FyZHJznkCVO+qq7YV2NatDJzy4VOlZID6nSBUo+Goqn+XDS3kcXhB1xfQm34w/keaBAqgHbKAV17pMeVkaPs7lf9GjYbLG09iecaxdzXXDP8m6Hvh88aZA3PM2AJmnxuygTkdyWedCgDiuyY9PbVGDjRDRL1eXI1+61MOF8epuVyKA7VPojzPoFrMzRWThbimGsdw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 732a030a-9f87-413b-4f75-08d8817e7701 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 11:32:23.4292 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2OUw9aJ35K8UgfS2b2w3cqSn8nobhBwGLWD3JEwZzETiSA7hVmR1qh21KQW5Nko1uP315PIme9jlOb8sDzSBgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3911 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/2] raw/ifpga/base: unlock mutex when nios init fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Huang, Wei > Sent: Thursday, November 05, 2020 10:06 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: stable@dpdk.org; Huang, Wei > Subject: [PATCH v2 1/2] raw/ifpga/base: unlock mutex when nios init fail >=20 > In fme_nios_spi_init(), a mutex is locked for protecting nios initializat= ion > process, the mutex is only unlocked when process is successful, it should= also > be unlocked when process fail. >=20 > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi= - > process") Coverity issue: 363751 >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/base/ifpga_fme.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/raw/ifpga/base/ifpga_fme.c > b/drivers/raw/ifpga/base/ifpga_fme.c > index 540bb1110..f29ff3159 100644 > --- a/drivers/raw/ifpga/base/ifpga_fme.c > +++ b/drivers/raw/ifpga/base/ifpga_fme.c > @@ -1115,6 +1115,8 @@ static int fme_nios_spi_init(struct ifpga_feature > *feature) > ret =3D nios_spi_wait_init_done(spi_master); > if (ret !=3D 0) { > dev_err(fme, "FME NIOS_SPI init fail\n"); > + if (spi_master->mutex) > + pthread_mutex_unlock(spi_master->mutex); > goto release_dev; > } >=20 > -- > 2.29.2 Acked-by: Rosen Xu