From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB246A04C0; Mon, 28 Sep 2020 02:46:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE9411C21E; Mon, 28 Sep 2020 02:46:49 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3A8EF1C20A for ; Mon, 28 Sep 2020 02:46:48 +0200 (CEST) IronPort-SDR: Z7bbTQDaxml29c714mVPfe1RW9hJ10eM9X4fO+yHho+QUwit/n1cyDdToOqbGlXFZLIt/pWcIi n8O3yV9gUUSg== X-IronPort-AV: E=McAfee;i="6000,8403,9757"; a="162808662" X-IronPort-AV: E=Sophos;i="5.77,312,1596524400"; d="scan'208";a="162808662" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2020 17:46:45 -0700 IronPort-SDR: L9UsPBQdt271AQgXR+vAnESSpPGPe8nmDtwVMMMiNjQFwtwLuGhgQ7dsh9D4ByOZNC4PVS39wB k4rTCDwxk2vA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,312,1596524400"; d="scan'208";a="414835456" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2020 17:46:43 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 27 Sep 2020 17:46:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 27 Sep 2020 17:46:43 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.54) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 27 Sep 2020 17:46:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8PDA5ospjQwEV7Ydb/TyxeX/1L7qSqJsDLLa2wc5OlLp4HIJRmMl5uXglzQZ4IQvefJCO27W95hCdry6X4Pu6dZbYq5wXiMkgAJ6ea1o1ZEB5CT3RTw8Iy0FDeBxHyiszN6Bgw8Wq7d2rGHREZh4jRpIvYbxm2P5xNAt3AtPizS552Wsa+Etf2DYKS7+ujnQQoFZCL38UU2jFlmhHW6n2d7nFox+eWGgvq+UP/AknfSnzHJol7A4ArhoVKkTae98S45lLnC16Id6Iheg5UhwMJVMeKKpnt1XWFdrWYZeq3vsQHDBfJgNpz/RB/zXYTRy1lABN2tsdETmtP3eyrMcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3galcnPKtgK+8sqtbbl6a/RS606IjOFglKGu8N5aJSw=; b=dXkZ7WRmfo/BuBrLhZw/4aXp/mX7Bvzq2f1E4A+sVhmO48taWD14EqGgi6FzVrESeUlfKzEv6spzYxlG/LxDwsNXu2nm12c59ETMoFQxiw06TkPl1zrAYZteJ4rYT8rnMYxkF4nTSuM6poqEYGudu9Enwm/D9M3CtkfjZNwo+M0culLKsQAF+loErqJhKLOToc2KpwmLr7XxuqrmzCOU3Mo2xosDI8VlO4WFPMB+XFt+cc8cePH+4eNUHqqc56RlT50D9rhtLPl1ho7OwfHW4gZgTiVFd7nsfOMloEQnAgQukWIaqRfZTzPdrQp0n01s4zOqHLq0suKtZJ+c5S9s7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3galcnPKtgK+8sqtbbl6a/RS606IjOFglKGu8N5aJSw=; b=tnDIx2D9SQHFLqMSyazy2HxGTlOBJ/Ez5kcNR2XhosXXSccT9qgBmVimg86xWLuluWmgoIFNwdCjOKk1lZDkj1GEIA7QUPh9LMNeDDcIuidWJp0b6nYcUwGw4rjvlaRQLy4ip0bfDIlxK/UdCD6TecuL9VGcQcYyfDIdSCTkaV4= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BYAPR11MB3445.namprd11.prod.outlook.com (2603:10b6:a03:77::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Mon, 28 Sep 2020 00:46:32 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::515:a970:3fec:fb73]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::515:a970:3fec:fb73%6]) with mapi id 15.20.3391.027; Mon, 28 Sep 2020 00:46:32 +0000 From: "Xu, Rosen" To: Thomas Monjalon , "dev@dpdk.org" CC: "Yigit, Ferruh" , "arybchenko@solarflare.com" , "John W. Linville" , "Loftus, Ciara" , "Zhang, Qi Z" , Shepard Siegel , "Ed Czeck" , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , "Somnath Kotur" , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Guo, Jia" , "Wang, Haiyue" , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , Gagandeep Singh , John Daley , "Hyong Youb Kim" , Gaetan Rivet , "Wang, Xiao W" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Alfredo Cardigliano" , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , "Zyta Szpak" , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , "Haiyang Zhang" , Long Li , "Martin Spinler" , Heinrich Kuhn , Harman Kalra , Jerin Jacob , "Nithin Dabilpuram" , Kiran Kumar K , Akhil Goyal , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Wiles, Keith" , Maciej Czekaj , Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" , Yong Wang Thread-Topic: [PATCH v2 02/25] ethdev: allow drivers to return error on close Thread-Index: AQHWlSgGL0eZ+i+2mE2Ce222ypy2Nql9NiKw Date: Mon, 28 Sep 2020 00:46:31 +0000 Message-ID: References: <20200913220711.3768597-1-thomas@monjalon.net> <20200927234249.3198780-1-thomas@monjalon.net> <20200927234249.3198780-3-thomas@monjalon.net> In-Reply-To: <20200927234249.3198780-3-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcwOTQ1M2MtMDM4Ni00ZjU1LTkwYTItZTBlMGE2YmNiYWM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaDJnTnI3ZEIyWk1hcW9ybjVMUWc0T25vREhlVkpiMytFeUtQQVFjWjdBN2tKbW5sQTBlSEtwY3I1U3J6b0pTTiJ9 x-ctpclassification: CTP_NT authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.223] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9a15ba8-0366-48ea-4bbc-08d86347f1ae x-ms-traffictypediagnostic: BYAPR11MB3445: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oEal2DiLA4ByNBQYOEbvrglCngoDtcGYVs2W2cQJFlm2q43v/GBlTJwQ6/lOgiIjya0+xYjM1IZLpimIRCauAbOB2jJ1wDpSSUhRfgE7Dm6G9PD5qsKYjQ/iUfM4yx/4xaBBTlAiOiPvkT6J+P8vTHbmVth+EBid3KNtqEOtW2gV0dNIoY8EqM4F+ALsmmCDtvsrKV7guKnBk2Wk/vsceQkxMGgPAcoyApaFi3Kr3bgyX101ptIBXdMLrxCUhZN/EqBGNbEndmi45wkL6/O7RMhCzOeA6WZBphTdVXuD3nkpNKaB5Se4+mbvep2th1zYKiQyQ5tA1AFK56Q2hMeXRLlB6LoO5px+6RwKNLx8gx7+/YcI1+/ZWgywv5SzCHWZ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(66946007)(7696005)(6506007)(53546011)(4326008)(2906002)(7366002)(7406005)(7416002)(478600001)(86362001)(33656002)(55016002)(9686003)(52536014)(110136005)(83380400001)(76116006)(186003)(66556008)(66476007)(66446008)(26005)(64756008)(71200400001)(5660300002)(316002)(8676002)(8936002)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3SQb7NKSmUgTHmgkWuB2bcLuNRYbLPsFKl6cCk9XW4astYn0xboQu7H9vhXiYYBDlkPDSuJlrUhFXRnVl5Ngpe+RYld1b7EHEEe9dQ9df+WQ7KqG1JHU5kuDZ6ePcf0A4YMsPPwhFqgYHuOXwmj18dktI/pORV+FCQTcKV2MyEW4nUkuJGrnrYEm2jlapdzXPXOgQoeAKc+zp+E0qm0iRsC6qbMJb/lyit6HclrqPbVvZ9e570zOywWBjmeIoTviNVDz+e4gfTnwdyEUAIi4+cme+kz9lwQkg45HHZAngRgadnseHghyPnaj0w0KNmOY7bbF+29tyFxsT8xOQIl+9t+/EwY5sFisChladppwiYVKiE1PLm9etpMqo5UTcX63YgYqAxSWwJCaULV8nn2syEV79i+lavstxr060MC/VeliYCEQ4FdR/NrmHudrlguSij+jmPkJ6mBF9YIALRu4w0SnCJ5V4P7zjdVD5gVhQNhlzeBbTFlWYjp/ScBcZ0wM5oUpBcqVmkGUGHHzmf2MjLQSeTaPiBeBsdh+69Td4F1HoAd6zbl6xVdWAPtZ7IuIKZ23xGoiDEj9FYTLSNKrTX3M63VHPKN8TkqAI7ALVR3tZzGPrD0k59uVrLW+yXkyN1B7gD6kIT4MzJYgS/AKng== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9a15ba8-0366-48ea-4bbc-08d86347f1ae X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2020 00:46:31.5698 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 46Il6/PhR+daJtfBYHJwMG6q0fuKoQFT5twUiVjqamv3FhS22/5xjZedDRthpfnaj5v7viWEvuIRksTGWQdooA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3445 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 02/25] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, September 28, 2020 7:42 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybchenko@solarflare.com; Jo= hn > W. Linville ; Loftus, Ciara ; > Zhang, Qi Z ; Shepard Siegel > ; Ed Czeck ; > John Miller ; Igor Russkikh > ; Pavel Belous ; > Steven Webster ; Matt Peters > ; Somalapuram Amaranath > ; Rasesh Mody ; Shahed > Shaikh ; Ajit Khaparde > ; Somnath Kotur > ; Chas Williams ; Wei Hu > (Xavier) ; Rahul Lakkireddy > ; Hemant Agrawal > ; Sachin Saxena ; > Guo, Jia ; Wang, Haiyue ; > Marcin Wojtas ; Michal Krawczyk ; > Guy Tzalik ; Evgeny Schemeilin > ; Igor Chauskin ; > Gagandeep Singh ; John Daley ; > Hyong Youb Kim ; Gaetan Rivet ; > Wang, Xiao W ; Ziyang Xuan > ; Xiaoyun Wang > ; Guoyang Zhou > ; Min Hu (Connor) ; > Yisen Zhuang ; Xing, Beilei > ; Wu, Jingjing ; Yang, Qimi= ng > ; Alfredo Cardigliano ; Xu, > Rosen ; Shijith Thotton ; > Srisivasubramanian Srinivasan ; Jakub Grajciar > ; Matan Azrad ; Shahaf Shuler > ; Viacheslav Ovsiienko ; > Zyta Szpak ; Liron Himi ; Stephen > Hemminger ; K. Y. Srinivasan > ; Haiyang Zhang ; Long Li > ; Martin Spinler ; Heinrich Kuhn > ; Harman Kalra ; > Jerin Jacob ; Nithin Dabilpuram > ; Kiran Kumar K ; > Akhil Goyal ; Singh, Jasvinder > ; Dumitrescu, Cristian > ; Wiles, Keith ; > Maciej Czekaj ; Maxime Coquelin > ; Xia, Chenbo ; > Wang, Zhihong ; Yong Wang > > Subject: [PATCH v2 02/25] ethdev: allow drivers to return error on close >=20 > The device operation .dev_close was returning void. > This driver interface is changed to return an int. >=20 > Note that the API rte_eth_dev_close() is still returning void, > although a deprecation notice is pending to change it as well. >=20 > Signed-off-by: Thomas Monjalon > --- > app/test/virtual_pmd.c | 6 ++++-- > drivers/net/af_packet/rte_eth_af_packet.c | 3 ++- > drivers/net/af_xdp/rte_eth_af_xdp.c | 4 +++- > drivers/net/ark/ark_ethdev.c | 6 ++++-- > drivers/net/atlantic/atl_ethdev.c | 6 ++++-- > drivers/net/avp/avp_ethdev.c | 5 +++-- > drivers/net/axgbe/axgbe_ethdev.c | 5 +++-- > drivers/net/bnx2x/bnx2x_ethdev.c | 4 +++- > drivers/net/bnxt/bnxt_ethdev.c | 4 +++- > drivers/net/bnxt/bnxt_reps.c | 3 ++- > drivers/net/bnxt/bnxt_reps.h | 2 +- > drivers/net/bonding/eth_bond_private.h | 2 +- > drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- > drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++++++---- > drivers/net/cxgbe/cxgbe_pfvf.h | 2 +- > drivers/net/dpaa/dpaa_ethdev.c | 4 +++- > drivers/net/dpaa2/dpaa2_ethdev.c | 6 ++++-- > drivers/net/e1000/em_ethdev.c | 6 ++++-- > drivers/net/e1000/igb_ethdev.c | 12 ++++++++---- > drivers/net/ena/ena_ethdev.c | 6 ++++-- > drivers/net/enetc/enetc_ethdev.c | 4 +++- > drivers/net/enic/enic_ethdev.c | 4 +++- > drivers/net/enic/enic_vf_representor.c | 5 +++-- > drivers/net/failsafe/failsafe_ops.c | 3 ++- > drivers/net/fm10k/fm10k_ethdev.c | 4 +++- > drivers/net/hinic/hinic_pmd_ethdev.c | 6 ++++-- > drivers/net/hns3/hns3_ethdev.c | 6 ++++-- > drivers/net/hns3/hns3_ethdev_vf.c | 6 ++++-- > drivers/net/i40e/i40e_ethdev.c | 5 +++-- > drivers/net/i40e/i40e_ethdev_vf.c | 5 +++-- > drivers/net/iavf/iavf_ethdev.c | 6 ++++-- > drivers/net/ice/ice_dcf_ethdev.c | 6 ++++-- > drivers/net/ice/ice_ethdev.c | 6 ++++-- > drivers/net/igc/igc_ethdev.c | 6 ++++-- > drivers/net/ionic/ionic_ethdev.c | 10 ++++++---- > drivers/net/ipn3ke/ipn3ke_representor.c | 4 +++- > drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++---- > drivers/net/kni/rte_eth_kni.c | 4 +++- > drivers/net/liquidio/lio_ethdev.c | 4 +++- > drivers/net/memif/rte_eth_memif.c | 4 +++- > drivers/net/mlx4/mlx4.c | 3 ++- > drivers/net/mlx5/mlx5.c | 9 +++++---- > drivers/net/mlx5/mlx5.h | 2 +- > drivers/net/mvneta/mvneta_ethdev.c | 4 +++- > drivers/net/mvpp2/mrvl_ethdev.c | 4 +++- > drivers/net/netvsc/hn_ethdev.c | 4 +++- > drivers/net/nfb/nfb_ethdev.c | 4 +++- > drivers/net/nfp/nfp_net.c | 6 ++++-- > drivers/net/octeontx/octeontx_ethdev.c | 4 +++- > drivers/net/octeontx2/otx2_ethdev.c | 5 +++-- > drivers/net/pcap/rte_eth_pcap.c | 3 ++- > drivers/net/pfe/pfe_ethdev.c | 8 +++++--- > drivers/net/qede/qede_ethdev.c | 4 +++- > drivers/net/sfc/sfc_ethdev.c | 4 +++- > drivers/net/softnic/rte_eth_softnic.c | 4 ++-- > drivers/net/szedata2/rte_eth_szedata2.c | 4 +++- > drivers/net/tap/rte_eth_tap.c | 4 +++- > drivers/net/thunderx/nicvf_ethdev.c | 4 +++- > drivers/net/vhost/rte_eth_vhost.c | 6 ++++-- > drivers/net/virtio/virtio_ethdev.c | 6 ++++-- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++-- > lib/librte_ethdev/rte_ethdev_driver.h | 2 +- > 62 files changed, 206 insertions(+), 103 deletions(-) >=20 > static int > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c > b/drivers/net/ipn3ke/ipn3ke_representor.c > index b673c49149..d49abbf758 100644 > --- a/drivers/net/ipn3ke/ipn3ke_representor.c > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c > @@ -208,7 +208,7 @@ ipn3ke_rpst_dev_stop(struct rte_eth_dev *dev) > } > } >=20 > -static void > +static int > ipn3ke_rpst_dev_close(struct rte_eth_dev *dev) > { > struct ipn3ke_hw *hw =3D IPN3KE_DEV_PRIVATE_TO_HW(dev); > @@ -221,6 +221,8 @@ ipn3ke_rpst_dev_close(struct rte_eth_dev *dev) > /* Disable the RX path */ > ipn3ke_xmac_rx_disable(hw, rpst->port_id, 0); > } > + > + return 0; > } >=20 > /* > 2.28.0 For net/ipn3ke Reviewed-by: Rosen Xu