From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3D2D41BA8; Thu, 2 Feb 2023 07:52:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C33C42BFE; Thu, 2 Feb 2023 07:52:51 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 589BD406A2; Thu, 2 Feb 2023 07:52:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675320769; x=1706856769; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tF1SgrtdttVp4SatpjCI3IUDIkd4H8CAKckpZZfaJ1g=; b=jaPE4UX+s1g085l9kTGHRpVrITGm4J0FkLnvFZeSnwGTZtB5GVC69ZGp x7f8gXJ+AeCmt3H+4KBx1RQw9rmq3k52XJWymLcCpQSSoznrnYTWvoWzk xEThCR90kSl2HmAEDobSRvABtp6X1u8rK5vmlNt5vKTWb1WkbiIlypm8Z 9+moO1NvJui5DH25r+FxITzHn3ntJYft8JaA99t8e1xwr0Frae9eSoP4H 3AS4YjEi7ErkqJDVAbM0j7SdLhXudjLIDCu+vN8GQjefgewS+MlJGp7Tf +bRLF6xEhavdyGnotSVL/zMVnSJIveyA5XtnNSVMhF2H8TWxkvaHjhAZR Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="355707883" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="355707883" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 22:52:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="728733485" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="728733485" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 01 Feb 2023 22:52:47 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 22:52:47 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 22:52:47 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 22:52:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjSWTxjjPh/v5bsodyMCVP4/PjHp615U4j9dfTNKhHpeQ8V+90nj650Dhto0k37E3hmWJSLyTRO546NNgXW0eu5gJxpobR8RLh6TQyef8gp703nU22U9MYGMg2zuMuKE77Sf01iJAyYPLBgO5sy77YteQG3pdvONyDWRYkz4bSS6acHVN+g8VC7MNS1eG0iNa2ot+FgGY8E1W3/VOPTdCTi+5mPscfbxK433lILSvHHq8s9Ax6HNukN4aIaoOkpZdcWEFBTbSKzmmfJjZMO3K+UorM3c86Ed7CQdYaY03CNH5MpFTdxtbLuA3h1LyoMYuFiw2VsPOl0rimPR8e2m/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KLG6Zkg5jijNFcZHHo05ElGDatVk1U6HXKQ6tQi1wnE=; b=cQtGLb/L/n0Oqi5cCBQpGiN67H96aW9HRxsZ0gLdWKzC9c5W8EHtSdmLV4EP5yV6rhvV1vCiTgHqk/L15+AUnmZ3HLzeRQ5N+QQbxRD0pZjafvxo69bKwe1X8UOp8htuhNuKZWTEKE/56wcx4rOiHEtPrdtJt9M2adiDA2Zx16318+SL1sfWnJ3xaRuzebMkpnZRvE+d4bQ2JcoZHtNnA5USmLi977SQP4ZkGlZSvvunAgolWo36IyyoAqMvLVAOM25+GeDkl2hCUp17+myEmUhoa/5y0dr8wVHWu8xm+M4krQBczAb7Ike3EjfzuA7Y7PnqdAoL/HejLbTjhCyA5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB2903.namprd11.prod.outlook.com (2603:10b6:a03:89::31) by DM4PR11MB5375.namprd11.prod.outlook.com (2603:10b6:5:396::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 2 Feb 2023 06:52:45 +0000 Received: from BYAPR11MB2903.namprd11.prod.outlook.com ([fe80::b37d:2fd9:9b0:6882]) by BYAPR11MB2903.namprd11.prod.outlook.com ([fe80::b37d:2fd9:9b0:6882%6]) with mapi id 15.20.6043.038; Thu, 2 Feb 2023 06:52:45 +0000 From: "Deng, KaiwenX" To: "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhou, YidingX" , "Wu, Wenjun1" , "Zhao1, Wei" , "Xing, Beilei" , "Lu, Wenzhuo" , "Dai, Wei" Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Topic: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Index: AQHZMuxpNrcDaRQ6q069jkDPOeP1pK67NAKAgAAKm/A= Date: Thu, 2 Feb 2023 06:52:44 +0000 Message-ID: References: <20230128071519.42946-1-kaiwenx.deng@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB2903:EE_|DM4PR11MB5375:EE_ x-ms-office365-filtering-correlation-id: a83af682-9037-4a2c-7fbc-08db04ea1656 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yl756wPH66E6koiuMk4YF0mXpiE0NzG0mL5x4IAZ+LMnw0PnHNkMzSWFBHwg/hLfxdS8Rad238rxP8SAgCrkbpcqJsGITfAWNN5YqyDFM7he4EM7l0Gef9BCuT6U3s6J4gJXAeYwR4Bz5IhIIYDKD0mb+IfVBEQgsY0voV8Tp5Anoqt6s8s0jAmAwuNq95GLBAFjWgKpx60SYD4uRDpvtbqoRWih88QJpljgnpX7RI5pSWHbd4IP4SQspN2mTFQJu5gYzLIpLoi4gewO28iTlHTO+4ZAKQ9084DEKiTB2wH81Ae2zqcShQkCrDkKBBj5LJZob/pSSPbQ9hw/7y0ccJMZyUOXTAt7CyoToqXTpfQdGLGQYyjwOdCgNFmKDM25KCckilnsA7Jzh+mBY9tFAFCZ/w+j8TB7Q35Gra8wgEB2qRBrARAek28DGyj2SIcg48vWJaxZTKTAsMmq2E+rfUt/kB6AlfraGdjMoOsA1nYc1Hgp3zFhSDv7iO41K9kDpyNRSrCFlpWHQrhoAXDM+Ut+QL8uRlnF8faj+6/0Va0WjUpwusCX28nQe8ZtPmNMAUW6jkmvS52YR6LybuWvGTxS4WGkOBxdYlgqCIYllmzPg7Z5eoUvoXQSZ9nAV4NJOvQOg+UT357ycf1WQFt2e0/iJPLEFix33mrFFtzQgavSGXzHfMtvS/yyXePE78uF31P5dcqotk4HirnZEQX+uA74ZxU4wyUYFaBxF02SVBM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2903.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(346002)(39860400002)(396003)(366004)(376002)(451199018)(122000001)(33656002)(86362001)(38100700002)(38070700005)(8676002)(4326008)(450100002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(7696005)(71200400001)(316002)(107886003)(54906003)(110136005)(52536014)(5660300002)(41300700001)(8936002)(2906002)(55016003)(82960400001)(53546011)(186003)(6506007)(9686003)(26005)(478600001)(83380400001)(41533002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QihOcr7eFZFxkSEWcjNFcIJd9RoSfDYwESXCwgqJvAtCvX2kKgcxs/WtqjkH?= =?us-ascii?Q?ouqCu1Jkcx6VJnoHi5AYw67lNetCKEzPABYRdTplbU2su7ot4QVf/L+C/Tfv?= =?us-ascii?Q?GjSlBRY1xuAQdiXVullNlOKqPcgcuAW52HFXEcI0bI93GV9hZ8GLdpLq1Ap4?= =?us-ascii?Q?V/aajuwGpgCe4tXpSNjr2iqBmgcEwcX8rGA/zx/Io2tPw7bAxN+rZfGb+Fz8?= =?us-ascii?Q?NXIfPxgqudOd4TlBgS5vQ50h10QJ3xTGQjdK9RvB4NkBn2X2GMPYdwxynoS2?= =?us-ascii?Q?YDwdPP7NtOiiMVmTre9sniLnbYXPmgqtJxPMNy6yBj12G00aQmb2qpXh6ca6?= =?us-ascii?Q?yaWPFCAG2BaaqUt/c7tPKbUqvH8RtC6SImE3mUHrCupB+ja7tidBSWZ7BnaI?= =?us-ascii?Q?OK/XgsQH9SrhpVCxeaU3vyvTyShdiYi9OkZ1CcHYXi3rkD6yReqyOs7WNaOv?= =?us-ascii?Q?y8NMLM9d4G4FzyHb48+cVvtI4/6t73wIOswkoohbFoDIfAKX+UzfJfJLtfzj?= =?us-ascii?Q?+aXd5Zv8SJGlBM9qCnbni+B1O+hXIJTND2icm+Ohu7IdSKG9+SRFpKS7FHjo?= =?us-ascii?Q?Dm1M+XHWxOSLdOiA8cjCuiArSAzpybgpLtCQmCLofcPBemN/pP2DTCCZr3GN?= =?us-ascii?Q?tLSAFp7ssnOUZd19kw+c0d1qxwpR60mK68BeviRaRqFlvDT6lUsyTUCgRl+p?= =?us-ascii?Q?cjCfJmVx+NvOGXWuiLA7qE9zaOxWIk8if28o/IhxJiC8wJypVZDyW+VRJy+/?= =?us-ascii?Q?hL4sX4xbXL86QQHWoXqbLZuWy0TA+N1npIc7k691ajqOmGNR2vUZkGr0LhYu?= =?us-ascii?Q?S2oorVnPckxhzwHLlX/jO5REU9Vgsysl7yaXJm5UVAezh9c7BR/GJO6zqiGC?= =?us-ascii?Q?04Ljlr0BvT81c4rgaajOeh9dNNAGwsNx/CMSWxXjixn/5awulj+/bi1gg6Am?= =?us-ascii?Q?7mVbIMQNEbTwTCk3XZ7HfAFoeVg2e4cUg9rkzjlJyEPLZFQjegt+viThbe+U?= =?us-ascii?Q?5Gjx/8Z44/CoRUKvrIqYpLiRMBuZzuQi5uOpLMLtIg3z8eV1Dt+WVTEtEGCX?= =?us-ascii?Q?l+QHfKq5sQTJjMzMSHnnDqABvEtkbGyn3Tnu7wp8dR5ud5D9iK4t9rFEq+5h?= =?us-ascii?Q?84rJppGQs9pQH7WgUmXbGZ/PVZCWlhJ0un63atA3QrmgOGZqRFzly8Y+dh0P?= =?us-ascii?Q?ymeeRJAmmMDnOLB4GGPhmQe5vJODkkovdVZDTjbVbDOye4oR2Xh//kdUPew8?= =?us-ascii?Q?WoGzyZ/6UCaOP+KUgLFRZE6F1mx81r96KDIWn3N29gdt5ML4hCInCTdLm6DO?= =?us-ascii?Q?AfUiutPOHuXUu4V7NSJbuW1c01SXzBWcgNGAnCC64ZeFTja9cem5xeNFess3?= =?us-ascii?Q?Tj7z+xg2HRfDhsvhjBJXxEMocFHYG/jnXWpY8KDDshHlYHLdyEAjxNEpnnXE?= =?us-ascii?Q?uTgUy9ViQC81fE5Trw2e4rcqgq30yjjAScL+LA9UPRJraX5W1UUO/XKe/2lh?= =?us-ascii?Q?oTHbF611FDTWGbYtdxeEJemYDyOz7A+eklsaxKo4lUOSIwfzeybQyxOJt+pb?= =?us-ascii?Q?korKM8FsrD4LiIcdhAyFHKrGspFx43xkJWY3CSxn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2903.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a83af682-9037-4a2c-7fbc-08db04ea1656 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 06:52:44.6214 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IpUbi/d97P7dFdQcIUXEWn1ubzlLYLCtCs+aiG/0AuBYhQWJp8DKvbGtlJYf+BsRAui1y4jdRBLsn48QTrLx+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5375 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yang, Qiming > Sent: Thursday, February 2, 2023 2:10 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: stable@dpdk.org; Zhou, YidingX ; Wu, > Wenjun1 ; Zhao1, Wei ; > Xing, Beilei ; Lu, Wenzhuo ; > Dai, Wei > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API >=20 > Hi, Kaiwen >=20 > The code looks good to me. > Can you ask someone to test this behavior and add a tested-by? >=20 > Qiming >=20 Hi,Qiming Peng Yuan just added tested-by. Kaiwen > > -----Original Message----- > > From: Deng, KaiwenX > > Sent: Saturday, January 28, 2023 3:15 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Zhou, YidingX ; Deng, > > KaiwenX ; Yang, Qiming > > ; Wu, Wenjun1 ; > Zhao1, > > Wei ; Xing, Beilei ; Lu, > > Wenzhuo ; Dai, Wei > > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API > > > > Add IPv6 addr mask and L4 mask support for rte_flow APIs. > > > > IPv6 flow rules do not take effect in ixgbe when set > > IPv6 addr mask and L4 mask to default value as 0xFF. > > > > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue= . > > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > > Cc: stable@dpdk.org > > > > Signed-off-by: Kaiwen Deng > > --- > > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c > > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27 100644 > > --- a/drivers/net/ixgbe/ixgbe_flow.c > > +++ b/drivers/net/ixgbe/ixgbe_flow.c > > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct > > rte_eth_dev *dev, > > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask)); > > rule->mask.vlan_tci_mask =3D 0; > > rule->mask.flex_bytes_mask =3D 0; > > + rule->mask.dst_port_mask =3D 0; > > + rule->mask.src_port_mask =3D 0; > > + rule->mask.src_ipv6_mask =3D 0; > > + rule->mask.dst_ipv6_mask =3D 0; > > > > /** > > * The first not void item should be > > -- > > 2.34.1