From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8B47A04A2; Wed, 13 May 2020 15:55:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63ECF1D609; Wed, 13 May 2020 15:55:38 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E8F4E1D5E5 for ; Wed, 13 May 2020 15:55:35 +0200 (CEST) IronPort-SDR: p35RATD2JyY8j718FjQBZ2q+bKZz4boiyVq34/XzRzXCeTAR3g1y3uQKUtuR02jQLYpIVe9gbp 4dR5QnH0vniw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 06:55:34 -0700 IronPort-SDR: pqADAEeJqauzGBfzZQSdp19qrv871lyZYu639Tye6xGDHBTjakNPusG1iGz2Nbl5mwSGJUoi0z t6T01IF0zIZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,387,1583222400"; d="scan'208";a="341260471" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga001.jf.intel.com with ESMTP; 13 May 2020 06:55:34 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 06:55:34 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 06:55:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8hzAX9J6TS7W7LIihrI0UeXpoBkq0iKxoNQWAksLGAe0yVUXGWIxwZuOS6bnXp79Fflekz46R98I0h7Hhnl9ZNHBEV6kTHV1w+uZD0h6qOfg+VFCzVsDIuaqz2cD8J0whws6iLR2IZegZAYlr/nCfz462W2OOD5QD8aing+8E4qa2E86aaibJbOJ/4oO+RPwIlNUy1ZZs9z/ghAc09DQiEDx3WaGLluyfFuAb1pyP9BWX1v4lkovPlEv8CNWUToHfLitr/+layDPeAOlRMjv3tAb62v7ZZH91dqq+/I6QOcx8VgLNiRIh1UAUd8IovqEDABtfqDWtWRw0CnHQ+Wdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5W0fYk9vIg2U9KNgeT8kR59+fWJo52NvdRiNFyNLucg=; b=O9marrdr0U2bUfyL6q+hs0GcJ8RI71cMQeiWv+1hrvtQh/EXcQ2jXNooToTxK5eKKtA3dfkG9mzseeDPQSXTBoZMYZsp48dcUNdjLkva+MaGjb1f4asy+qyubaOTDqBnmnizqn5VdxPHFNxf/JFRfe9myvQbTU1geR1vFLOzCkO1/ZKWhGhcbASUnTI8EQQ1gLbs43ngptPqlLrJqSoGlrPg07xz9W06TNrma4U818zILG59GQ1roV5XIWP/dZzzms8jubVLE7tun7+akC/5f07omM/7ZYjG3cWUXQXpPtJVhhyNjCV/FXEhB9MS5EmYqUGLAQs/dzj50DA8v6DVyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5W0fYk9vIg2U9KNgeT8kR59+fWJo52NvdRiNFyNLucg=; b=Ry/1WU0Mk//XGQA20hh77iWGw4aLwT9pXmEIum5aDKebESDTHqIK0xvf4V/9EIfiT/iprp5W2TBJ7r0OszoF5iYsG+E2qLSN1VS5LaP4Y2oSOI4OKdpksAJRrJbZ0gWl8dvj+DkEP6E+i/qgRN/Kn2+H3M1Cak4FJh+bf3p/GUo= Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) by BYAPR11MB3687.namprd11.prod.outlook.com (2603:10b6:a03:ff::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Wed, 13 May 2020 13:55:30 +0000 Received: from BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::786e:a42b:df03:a829]) by BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::786e:a42b:df03:a829%5]) with mapi id 15.20.2979.033; Wed, 13 May 2020 13:55:30 +0000 From: "Dumitrescu, Cristian" To: "Mcnamara, John" CC: "dev@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH] net/softnic: fix resource leak Thread-Index: AQHWHJzDXKxHWkiSxEyRc4SP7eR2O6imD4yAgAATcgA= Date: Wed, 13 May 2020 13:55:30 +0000 Message-ID: References: <20200427140325.83191-1-jasvinder.singh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c4b36b0d-3e2d-408c-55bd-08d7f7454cbf x-ms-traffictypediagnostic: BYAPR11MB3687: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HgZATeUcyHFoHTgUbe575p9dbBH6xt6XdTIE/b4/0+/tFct8cyNax1bdabNirUrpz04I1h+oN/a4ZCfvF8cSCXMpmrodDtLAH5sVFkfE3qfPrnbwgfkFZokpoyINGHJC8QdpH5dZOLjTqEX3zsHCKQXzyghS/4jTjvj6jm/mIXapReFrlLfsY18eDZRlnJHgYEJF/zyJ8hdtUNVrpnxSbLGTysf/yc/qAJOxw5L8ClV32dKtQ2U4GXKb0IWWw2Cf9LpSDmPZ9P8rPgPQ9bqRNVcDWScXukFjQUpVvYZA8EsViJRv3gDftbr+/ThDSWGJ4YI/mfKr5lUBGrZWMDhRVaB0hs6qhiQ7QdRFTfEgJ0287/bw497BNo1FCzi95WJcDjebdkd45AuqL8RYJ4ESRcytQQwMhshtyugDzBx263ZqPnpTiPqGs82TiBRZxzI3aBPgqkx50PWiFI5IOsUjjw/FkRoLi9wjHlQMd5NJm0Ou5a67uzibt8xZV5xi4iv9cuojzrbV7XUIuUufBJs4Qw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(39860400002)(346002)(396003)(136003)(366004)(33430700001)(66946007)(66476007)(33656002)(8676002)(66556008)(186003)(316002)(478600001)(7696005)(33440700001)(55016002)(64756008)(53546011)(2906002)(4326008)(8936002)(54906003)(26005)(107886003)(6636002)(86362001)(5660300002)(66446008)(9686003)(6506007)(6862004)(52536014)(71200400001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: wFFAhX5ZCSJXLGf3k6bGC+eY8tzPXBBpQYxUqRZEWPMfrei8ZiU0epEAcYOWvB93E/4nQGYF8OjKk3mtUPvH3jDqWnIiMtW5uGaQkB7LwEgdTXj30cmk6NTy3QDmHZ3LePzkNSgoXHi5NT/HeNqd1RaEuN/0hC3UxXC7iq3GKRe0ojuNGLLfLJOXpkMPbkasQFT3brYWIr1WteuSeHhbBDyEXAiIm7Pym3Izk+f6WOuyMi0SwMghXdFawHTFbj6UNGIuHBbAZdWJHEmQEvOzzUYWsKyuEil/Vg90GrNaGiCBLif05AOhPFN6XkE9Kr2N5gsZfMIWRy2ZB+lirjqgEyl5BjrbYRCC5rBj7tj7irNxcovHMXWG3hw50MqNxsRAl4IhVFi4cYbpx4kbVdInJb0Gp5PwMcR2YOiclQOTH6LtLMqh4xN1SQTlj3RhLpgB/pPK3520dJ2E9JoJYiGVar/7sDDGiB7vCP+0QzncIduZzrSlHUp6iXrkO35wVUrB Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c4b36b0d-3e2d-408c-55bd-08d7f7454cbf X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 13:55:30.7736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fswh+yLnWlOtEBOF5kar9vnw0xomZPj5j4XRrOtM0a4ln6aHHD5NVTolc1p69VmvfjbBTtJpdRsYfCGR6X+YcXM9VzQDwVJ0XAQunCF5ao0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3687 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Mcnamara, John > Sent: Wednesday, May 13, 2020 1:46 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder > Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak >=20 > > -----Original Message----- > > From: dev On Behalf Of Jasvinder Singh > > Sent: Monday, April 27, 2020 3:03 PM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian > > Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak > > > > When sending request messages to data plane pipelines, the caller must > > free the memory allocated to request message on receiving error > response. > > > > Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711= , > > 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787 > > > > Fixes: 6d4d05402501 ("net/softnic: add command to read stats") > > Fixes: 202905f3ee4d ("net/softnic: add command to create objects") > > Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table > > entries") > > Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action") > > Fixes: 2505030a8383 ("net/softnic: add command for TTL action") > > > > Signed-off-by: Jasvinder Singh >=20 >=20 >=20 >=20 > Cristian, >=20 > Can you merge this and other Coverity fixes. They need to be cleared for > DPDK 20.05. >=20 > John Ferruh and Jasvinder confirmed these are already merged.