From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6849FA0526; Wed, 22 Jul 2020 10:49:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4783B1BFEC; Wed, 22 Jul 2020 10:49:59 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 91EC32C6E; Wed, 22 Jul 2020 10:49:56 +0200 (CEST) IronPort-SDR: UtRfdNOl/E6g1lAnlM5CwKP4QjpvN8/VBnu1KQjlJx4b9ZvY+HJ9GcF4PTZsDBzoMX1LCPOifU rxJl00gcC75g== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="148227834" X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="148227834" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 01:49:55 -0700 IronPort-SDR: TvoZhHXdVTIQUexBr4pztr0TQL6gGQShL8O4nX486rwoJH6v6ZGZjPfAIzRCcl6hvclSPVd9hw ED3cQ8YvJ6Ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="488389655" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga005.fm.intel.com with ESMTP; 22 Jul 2020 01:49:55 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 01:49:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 01:49:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JtjRw370/SdpYn7ixttmKtoqzWX+VKEUU5Tex9fUxHDp9Q5ELZpm7M1/ntNkP7jsjwvLu73mhRTtDM0B6OWy0Vu/zH15LnmogrA2du0AZk3guZd5tK9sJhYJpSKPIEcwLIEjn8EdT4DBJpvNHOOWFlbVUgqGzVFJoYuC7VOGC+lZ4QyMh63VQTkxp6qFpwws4t4AErvK3VionsDKM51q5cvV6gqa00gr7Ms2wsfFnGVfR1H5QJk2qk6X2RLFA8u8Uk6vgWd3xbSfL609OJ5HhgUrbWQ0SWgOH6GGkKRMc2LEqH689eFO/oa8b5WFuHJ8ajKevnJuifxQ7km53Q/gTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BBoAZEK1Yp9jsFK7Z9MOmXjj8CuU1HPc0PTd1p7q32s=; b=CdwSAnEQhzvxDWzCYm2HVmRw2XL+IVezNyhe0YPwfNJpgUrHDLA+xyvc/Xmkps8VahvYaKGIbGfx892jVMfRe/hgC2sFlWb8mpsRlbpTcOrhjri8NE1LKYXp0vFuT78SxhUnQaSIZ0+PsOSTLOAV1IGl3DCY7DbOT8iBILEhO6UlB/k7J+rSJZr0w+ujvyh0yIehfg+OF50jlFAkkR8hl4eS7YaIN10YCyYNZbk4uE57CZKZyQoPht+vTZ0cgQLTED45s+1mS8v//aaTfDvumPLlyIXsKmR+8nfEnKNtqBQuSoh7R3qLgDnigG8paLCRIy0j44RzxvHKZi/ooBt0Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BBoAZEK1Yp9jsFK7Z9MOmXjj8CuU1HPc0PTd1p7q32s=; b=FprkdHR+NYOHB+10Xv4+IXniOrjKL2A3tvHO/FREQqkc3+ypyyGhBGmsZhbnFa2Vwu3+kG/jDGQ/+6N5cbVTili0KKIMnI3pnE1/9Ezs0yOiizi3ik86tMwXwQgfXpWnlGV73AR6yfD15roA+cMqFhNd4h35QEpWZo2y2tvd01Y= Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) by BYAPR11MB3240.namprd11.prod.outlook.com (2603:10b6:a03:18::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Wed, 22 Jul 2020 08:49:53 +0000 Received: from BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061]) by BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061%3]) with mapi id 15.20.3195.026; Wed, 22 Jul 2020 08:49:53 +0000 From: "Dumitrescu, Cristian" To: "Xu, Ting" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4] lib/table: fix cache alignment issue Thread-Index: AQHWX82i+KTf+DtoXESWs1iJ7M+JEakTQuIAgAACR4CAAAUjsA== Date: Wed, 22 Jul 2020 08:49:53 +0000 Message-ID: References: <20200616162705.83575-1-ting.xu@intel.com> <20200722021628.17194-1-ting.xu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.55.254] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7c6deb6-1400-41db-f2c0-08d82e1c33d8 x-ms-traffictypediagnostic: BYAPR11MB3240: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VFLSWJhQzy+lChHAXsLAn6CRYQ+7+4cgi5ZPuNlHOhurI53uWC0Z/Zs939+XwbMkrqQafQe+tgBibZctW8dd0eiJx4s1vc9Pp2Q3tLUHTZbFFMLJD6Nipo4Q8e6ugpctMg0qOlwRE52WI0ANxAXr2JBR2OtO94f/Rh2P6FLpMs5lamba2maCCeyTYzw++pbR7p28bBzJ4CL0QI9gw8R6p64tQm5cdbuOUFa8/I1bgOrRvrQgenegibSfvX93LxZXd1ABSOqQ5WjIVmnEUGl1KnqPlHu8zj96UrlQMliDzvCKC4oV0SQNfjyVhxbD5WE9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(26005)(33656002)(316002)(110136005)(71200400001)(8936002)(2906002)(86362001)(5660300002)(4326008)(450100002)(52536014)(66446008)(7696005)(66556008)(478600001)(8676002)(55016002)(9686003)(186003)(76116006)(66946007)(66476007)(6506007)(53546011)(83380400001)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: rR7RiQcRsulJgbG1u6kWKQWnH+64JBYaGt6nhif5712SAQySbwM1xW1uHlymseQ+0PJ302bEBG6F7NaMCgomb7roWW/tosWk2xVAel0o6o80ann/8GqQQB79Sfpv8Amn9QwoPxS0pu8cBVvY+B7R3XvWnUlrDga2rYv79PTmkBY0LYYLiQdn9hQ4peAH/3/OVwa4hMFmYgz09yRM6KZFpGhSQ95HsBPmCOgeKNSAuEroW7EpydgSLEpG1mCBG4pSKJ1tWUfc/27CnlCdsAsQiHiFw4d92irnJZvAvw9+LR+CZmqbRiIoMwMSJ3NwedOA8GEXZIR6886IHlXmKFFwCTef5Xyq3nBqErn4c0Ug7oSiMLWScW/jgRwaYxVhV20+wa925nNYYnNZ1+Bb0pedRfzEqn11QO8BFx66gSqDaLkNW6ADLkRJ+/m2e7qd9bs1PnscR3qw1zG8cKVqU5kCWvwA37jV3FUgR9YPG4Pn95M= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2935.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7c6deb6-1400-41db-f2c0-08d82e1c33d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 08:49:53.4904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lk6jG/HpKyCf2UKRCe6PAg+FRXQxSWC3J1I2JKGff2GhKCB1XTpk2cXdYwLZFpjsrzXVs+V85E0LQom9uSpZd9YjPyJbk35nEBnF1V2tqRI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3240 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xu, Ting > Sent: Wednesday, July 22, 2020 9:31 AM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v4] lib/table: fix cache alignment issue >=20 > Hi, Cristian, >=20 > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Wednesday, July 22, 2020 4:27 PM > > To: Xu, Ting ; dev@dpdk.org > > Cc: stable@dpdk.org > > Subject: RE: [PATCH v4] lib/table: fix cache alignment issue > > > > > > > > > +#ifdef RTE_ARCH_64 > > > struct rte_bucket_4_32 { > > > /* Cache line 0 */ > > > uint64_t signature[4 + 1]; > > > @@ -46,6 +47,22 @@ struct rte_bucket_4_32 { > > > /* Cache line 3 */ > > > uint8_t data[0]; > > > }; > > > +#else > > > +struct rte_bucket_4_32 { > > > + /* Cache line 0 */ > > > + uint64_t signature[4 + 1]; > > > + uint64_t lru_list; > > > + struct rte_bucket_4_32 *next; > > > + uint32_t pad; > > > + uint64_t next_valid; > > > + > > > + /* Cache lines 1 and 2 */ > > > + uint64_t key[4][4]; > > > + > > > + /* Cache line 3 */ > > > + uint8_t data[0]; > > > +}; > > > +#endif > > > > > > > Hi Ting, > > > > Yes, it looks good, but as mentioned previously please do the same on t= he > > other files in the same folder and add the changes to your patch, as we > need > > to keep all these files in sync: > > > > rte_table_hash_key8.c, struct rte_bucket_4_8 rte_table_hash_key32.c, > struct > > rte_bucket_4_32 > > >=20 > I have did the changes to 8 and 32 bytes in this patch. >=20 > > Thanks, > > Cristian Upss, sorry, somehow I missed it. I just acked this patch. Thanks, Ting! Regards, Cristian