From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 497F6A0526; Wed, 22 Jul 2020 10:49:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 866811BFEB; Wed, 22 Jul 2020 10:49:05 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id AF7832C6E; Wed, 22 Jul 2020 10:49:03 +0200 (CEST) IronPort-SDR: 6Ss2ezq7oPvAfMDNN1uQ6UCtL/OP4+LK8vbbCvJLtz+6CWzwxHh4CCy7K7p9v+AXTH4Ay9Vp6L OvRym+HBSiPA== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="147789818" X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="147789818" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 01:49:02 -0700 IronPort-SDR: Iccy/VSJDxUjdp9r5eRsBq7Jw/wNdZZp2dQdvqufduwTdpuE7DpEbvJJoQ1qR+1/x726UUAEdc MCamNHcbzEZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="487921758" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 22 Jul 2020 01:49:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Jul 2020 01:49:02 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 22 Jul 2020 01:49:02 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 01:49:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P+gPZxKuds/8JQq/wSEUbXAQpQ5deWncHdJu2+QESbteLI32PLdF2du/rU8CkIp8nuyy5/m2OES/Nxv23+GQB/28D6LiSni4PJEORmzMmv/hJ/szvaeTVgJGlB/un4Kp2lrj9Hi9yWKtIuqmCZPWA5hioU/7CdqPi4vnDohoF15ZRxDIX+2ZveiHcxdURFYQSDVONJDAiDNN8OLKwO5gxn7OCfzUQu2mC0XU7tAn4nLtDijM995z13p1V6cDERTx5Ha5xptfEyef0izIXWDOs+6Dp2pSLOEmiQVeU5C12q/8w1EGUeSqJozjyKiIFzjNmZIKNawURgous1w9/Yljvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f50+PTLSDxASz7q95MCDSJK4gkukVUt6ILAL08V1wjc=; b=nfu9W4uumeDiytrUUThNGpY9s/pTBc0Tly0Rdt3vf2fhv7KFIMJUigONUviHpgs6S7BJRjbEdHjVN7QgGy8bKaVqQVQ7w02pbr1V2mdBN7II/x8R3SMCI7V+ubXkLPAx1X1hXQ+F/o0u/afcudqNyUFEbNGywbqa0LQ1cS2po2AR0zG5mHvS4vHltFmnG0Ks2l8dvg9O5RrElhFwHYMtz0Mcci12Sf9qqGEQ4jQ7DE1gv7ePo8wHAF0kz0OhfHUwcu5Eqn5ybJdnAFecZzGwkPsrh7yDamdBUWPkIOUGk41Apy/GTHUc4icP4eJEdgR1RwhFL6uzGy6B5GchjRUK/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f50+PTLSDxASz7q95MCDSJK4gkukVUt6ILAL08V1wjc=; b=C/QMtcf5ZJ8sTgkfYmsLy3zZWDm8Hd3ms1q+rVmGAyKlkzza3F8+gjp0KOIJSpEgoVY3v7DxAT+hWg9dctuJpgg459oCSY9C6L9x+QcvzIqA0we9pt2F16/uH4ZcfVMOALcx4YeoydMPIPlf4OcEyelZy0ZxQHjW8FrSuj2aAW4= Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) by BYAPR11MB3240.namprd11.prod.outlook.com (2603:10b6:a03:18::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Wed, 22 Jul 2020 08:48:59 +0000 Received: from BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061]) by BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061%3]) with mapi id 15.20.3195.026; Wed, 22 Jul 2020 08:48:59 +0000 From: "Dumitrescu, Cristian" To: "Xu, Ting" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4] lib/table: fix cache alignment issue Thread-Index: AQHWX82i+KTf+DtoXESWs1iJ7M+JEakTShgw Date: Wed, 22 Jul 2020 08:48:58 +0000 Message-ID: References: <20200616162705.83575-1-ting.xu@intel.com> <20200722021628.17194-1-ting.xu@intel.com> In-Reply-To: <20200722021628.17194-1-ting.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.55.254] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4339709-b68e-4d2a-0e66-08d82e1c134d x-ms-traffictypediagnostic: BYAPR11MB3240: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BIjMSd27z76VwePQGHovvmr7ngtA/QsZ+T+vBStUVVqvUjMhbRfsr/4Le8SFvRW001iPTsOJwefI3ZZPkoGuz6fBwK63kiaaSSUP6r7BGcU617c/dqNYytWSTQz6UcFBdzT8ciV755DxsZpM/IoFui6mFxp9w81vZ4TtI9lVYx6nRyAW9xaydB14qaovBAlZlju9eVrcdZF3OgWmcEOZTMRjPcNNCi2YdEGzLof/c8ZQbibzLAL3h6QxXOWpqnlA7Xygo/OtyMQvJQ95W5pE4fUmelORFlgsu4y92x9Mtlojh7vSIG+4uFeP6CRRHW89MNH5j6KE9mE51Lc74KNoVg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(26005)(33656002)(316002)(110136005)(71200400001)(8936002)(2906002)(86362001)(4744005)(5660300002)(4326008)(450100002)(52536014)(66446008)(7696005)(66556008)(478600001)(8676002)(55016002)(9686003)(186003)(76116006)(66946007)(66476007)(6506007)(53546011)(83380400001)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 7E0pVtjm0ppCZvmtHa4bSfvmLNRme0pqtGN1wrnCJxDmUfu3IEltuEujk10bWMFxDcABZhvuBoOJlb4MRJsSxuiLPQA8n176Jk8PnsNiIAB07FU+TKDDz6GNc5nBvlIhKsngrz6QY+iexJZiohbbsE5q4LYhOBRyVVfXisetG8yJDyL1BLbtfAs4JetF4FKJsoSiUTRQfRCGv++rjnN1nHEEouzmcojZtfq486ItfYh+qDeKnHSgzJUMbhywrLEcN32rWAY5rDzCnntWLqWWjrQu6D2gb6EI0NzJRLxx/yshrNm9KOcctkDB1HizZp3EkMqxlUbx6pQ3y3jFULZqANAD/tCD6sj56HwWUGIFRgaYESk4XxD1x5f1uBh8OmyRz9mFAoAUEnsYFqHSVBkmL6RP7kTz9hetUgVOz+0MPU0CrTSrbGHAW2gPbzC40ADkXXjodqRVyS/Jac0LjybDf8T7y8/Gm6iJq9yTRzNj2QM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2935.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4339709-b68e-4d2a-0e66-08d82e1c134d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 08:48:58.7486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BCXHsESh1JMyJ/ZpmY/VQGt2eRl4gM0oJLgcIPoSGykNrIBiExzu5WaG0K8tvFXwvFVbu+dHgMBpdjxJWYHh0O1yASP92645LdgvwCdMHLo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3240 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > -----Original Message----- > From: Xu, Ting > Sent: Wednesday, July 22, 2020 3:16 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Xu, Ting > ; stable@dpdk.org > Subject: [PATCH v4] lib/table: fix cache alignment issue >=20 > When create softnic hash table with 16 keys, it failed on 32-bit > environment, because the pointer field in structure rte_bucket_4_16 > is only 32 bits. Add a padding field in 32-bit environment to keep > the structure to a multiple of 64 bytes. Apply this to 8-byte and > 32-byte key hash function as well. >=20 > Fixes: 8aa327214c ("table: hash") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ting Xu >=20 > --- > v3->v4: Change design based on comment > v2->v3: Rebase > v1->v2: Correct patch time > --- Acked-by: Cristian Dumitrescu