From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33DAEA0540; Mon, 20 Jul 2020 13:20:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F256B1AFB; Mon, 20 Jul 2020 13:20:47 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0FA49A69 for ; Mon, 20 Jul 2020 13:20:45 +0200 (CEST) IronPort-SDR: 2umDQR71uz/cfnnjskgor8RsHFZ/E85wPO8x1lWMCtqTU3fViEWcK6IN7n8cTEaGoTpiGv1t+b LFdK3bj/NaFg== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="137987041" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="137987041" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 04:20:44 -0700 IronPort-SDR: sI5GNohgyhto4CzJ37mGRFHzACht1hkvhoZbBw1bXX6pUz6TEanbvZZYiVTTCQcvridj6DTRFk mvQDjHmEZY7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="327500902" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 20 Jul 2020 04:20:44 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 04:20:44 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 04:20:44 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 04:20:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqiybtA1h07TmkaKPF283UHQaGxU8Bos2qt9NjRZtnqWOYC5ZNkm+gHlJsMQZknmYMOkyewEhbzIIyDJ84rVUxDvMXOn1QugilKgQVjGHk/EbgEJ8mKBuLGg6WH+6/mDvq5O8ZkYLpKddVn7JCbXESY8xdHe024uyuCr0mJuB+GH1WITC23Cb3Txwuz8NdpeaCqlcgQ+uI51v2BdMJ6Uwhcyd9a5xSIfsfaA57eqQI6GbcHSrjIw7tZ3nh3dUclZGm5l4KAYRdKZgqz12Djm2y7oddOjoiwxpIrho1eUzEOveQYXw9QjKiPMy2bjPygViDHYRQZyektD4EZz6dXATA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Px+Gunn+y6udgRbQz1X/CmBZ21L0vbz6V++6mIS6Il8=; b=RIvCbIISMUR8VzD1DZ27697Rj5hoXxFv+sIrG6yGvLCBiBQkRy14Gjh2kTb7y1KI7GthNyGeSy6/LaDGa+LNuOJyJIgH6OaEFeE1KZLC4LuNgL1bFPhlUUGwXQWz7yLtxPDhv2/517ImTBJMP+mpDjHMSlcyfbC47l47AveEkK0DPhIo9CbRupqLWW0g/zcfNjkg06J9VELzslEStCC5D/xJSfk5/mY52vy9umZvK31Sud1+cJbo1KsUFH6Ounrm3naPQmeBH+PJsyqN9zy7ROC7+udnHeIgkcunMW9L+9MBmbgeXZ+go2aR0UdSVni4+f18+tVHLhlcPLQz+m9phA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Px+Gunn+y6udgRbQz1X/CmBZ21L0vbz6V++6mIS6Il8=; b=JWOraW/ZcBmB0qGT0OU7unGKLwKQDFGbHniLVkDYAFIGcSx4MgLkTRnbYeeR9XH6+KqxOoebgKI/DPktmLtuD/VbBpIuY+c6M25XjrlEGeKIDS1CA/Q55u+BDJwtY2MQ1/9prKUDwenPzTBr92/L1LUu7QfOHfRULGSai5zvLnQ= Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) by BYAPR11MB2662.namprd11.prod.outlook.com (2603:10b6:a02:c8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Mon, 20 Jul 2020 11:20:43 +0000 Received: from BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061]) by BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061%3]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 11:20:43 +0000 From: "Dumitrescu, Cristian" To: "Dharmappa, Savinay" , "Dharmappa, Savinay" , "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport bandwidth profile Thread-Index: AQHWWtXn83LQJuRaFEWWX0EtHBYaGakQWLPQ Date: Mon, 20 Jul 2020 11:20:43 +0000 Message-ID: References: <1594837677-313175-1-git-send-email-savinay.dharmappa@intel.com> <1594837677-313175-2-git-send-email-savinay.dharmappa@intel.com> In-Reply-To: <1594837677-313175-2-git-send-email-savinay.dharmappa@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.55.254] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 42a7f330-72d2-4897-31dc-08d82c9ef0ee x-ms-traffictypediagnostic: BYAPR11MB2662: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mSEQwIAnp9yAZnVYLWXy07bdmN8uU84YSoZ92HIsP2RlgYonxdj7zH60tyXBJU4x5wvFrE2OrCHT/M40yEy3uiiYX74aJtMWpMuzQRmUHbcZoHd9EDoxay0IUm9nRRpIsdP+Nojllo5gDzg8WIMScOWZdNngeCs3pJO0iOC3NdAbY6Rq0zhn56V4ZqoPYw1xepOeLSFYQnbNLTHfgAhsL7Vr2cqiPccoIiOARG3GzJ2w2F8e6Zy9+BNTaTRPuAfwEwu2MYuAeGImLFR/NJ7oKePFHAtIgZeF3UwBqtfJgTKq3jM5kOVMDeMmLeFbfqDea8Rac31eiWAtPXS3KOesCQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(83380400001)(7696005)(71200400001)(55016002)(9686003)(8936002)(66946007)(33656002)(66446008)(66556008)(76116006)(5660300002)(86362001)(2906002)(316002)(186003)(6506007)(53546011)(110136005)(52536014)(478600001)(66476007)(64756008)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ua0IT/0EHZxUDRQ82QDlCmNTS0l090ez8sr3mUGnMhXVqWNBe9+oZA8zkc5heGt9VWS6ijCjGySoUQtWsGOdSQih6VCfCKpEF44BGhHTprjPXCTX+MickB5S16DwjLxWJYm/vSarMorZXaPmQbUvtYfdXmcvf4UM3kvkxTSS6LNPFxcxS9cx9KfE55XZ7XsN/NSQ1yAxik3DuqP55WUoBUyvAaR4e/3KwwFoqZH+J/vU0ySfda2tyynt9BYcpUvaMrSUhwIoDnM2mpJrBuUDSKTnRAMP25NVRA112qp17VrbddTtJuORcViOrqc/0ADP/ktkxcAkd63EeyCNfebQRjcUWU3NLuSa5juO+qcKNJqpfHU4hVEDoyDw4AhP2kZJKE1C6N7GC5ND1eo9HUXfC7oOIBYK/vpHX0ChYx5C099NFF+iaj5XrE989WFY5u+fUUB0ijJakrEmVeslezzVJHmLQ4oCOSdx6AYCnX/n4VM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2935.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42a7f330-72d2-4897-31dc-08d82c9ef0ee X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 11:20:43.0782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tvO4Ms7Re3QbLaP+XadNQQucVwR2fRxRM1fUM6/FMZuadRbS0Y8RyPTvRb7kyVqpRsbrN+7Z4Vlm7zE+Eurw8txasHwL+I/rPcimAg9SoN4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2662 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport bandwidth profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Savinay Dharmappa > Sent: Wednesday, July 15, 2020 7:28 PM > To: Dharmappa, Savinay ; Singh, Jasvinder > ; dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport > bandwidth profile >=20 > This patch modifies the subport level data structures > and add new API to allow dynamic configuration of the > subport bandwidth profile. >=20 > Signed-off-by: Savinay Dharmappa > Signed-off-by: Jasvinder Singh > --- > lib/librte_sched/rte_sched.c | 486 ++++++++++++++++++++++++---= --- > --- > lib/librte_sched/rte_sched.h | 82 +++++- > lib/librte_sched/rte_sched_version.map | 2 + > 3 files changed, 424 insertions(+), 146 deletions(-) >=20 Hi Savinay, Your patch makes sense, but it is very hard to review, as you put a massive= amount of changes (~500 LOCs) in a single patch file. Can you please split your patch into a patchset with incremental changes th= at can be reviewed easier? Some suggestions: split the internal changes in = multiple increments first before changing the API (like move the check code= into separate functions in individual patches, etc), change the API afterw= ards. Thanks, Cristian