From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6008A0093; Sun, 17 May 2020 21:52:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D30F1D56A; Sun, 17 May 2020 21:52:10 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4E9E91D547; Sun, 17 May 2020 21:52:07 +0200 (CEST) IronPort-SDR: fhwScdQxIwHWqJaAxAj4B+GT7M130u9PDJgMxRVQXNNo6nJ/p1/GOQC5RHEt0MTW3lZUW9KOCk LYIkzhPu4nhw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2020 12:52:06 -0700 IronPort-SDR: Nuuesksrkz+BYLQl8RzsUddSoXYFYS06A9Dy+5XgvgKkNuQTacyicgIjamONvYIoPINPmQO+8o FD1UCtbgkXtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,404,1583222400"; d="scan'208";a="252880227" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 17 May 2020 12:52:06 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 12:52:06 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 12:52:05 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 12:52:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWtV+CdqVM/BaFTwfef5doIi4EJ1nGncsHGNirwtOS0h+EdO516uGBhzY2CsfaYBgawi4QOPeM9WKRe2ngUTNnKx2oURhzZxpnYrLJ3+Kue+WeInMYLxd0BWSnvp3XF98eDZgPvjbJ9EAxJ1J3Fbj+nhOmPJvuLArksWHWzN8YIYrKqt9m389nx9NmPjQU6q+VtfccXy0zEl2R7L3n3Jr6FNe9V5zc4MrnL/AAmllowLRfkVwc+xeu1LB8VANcjXU40a8bshIMjyWjXcY29GAAS5xnVeqG+vnDx2UG03LGEJE6D6G8PWeEKc2yuLFmNuvjNFByNVcIyWdUIcWnviGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8V0GfoBBUd8y2p0P5IKkl8d/SlWxJyOCve3UZtbQxco=; b=PArxEdgw13y4I2znko1DjlbG4PWm6hI0rAT7NN1B7KYCh+j7XIzkvQKpYSKwrpZv7SNOUd0QWZU5S7uG66NQC1nfG1K6AHVaYUojFpT4A1ltkMGl4sisarrvLT41yQKvKoar5pHklqQHlMugSWL99P0rFye+N55UXJjz5TsK0XT63ngM4OvRKeAHb6UNTJhYbaPoP63L043utUHh2XrLgyg79EfQY4VKOQX6w0Vcfq6N0gMWzrvrXSW+PhRaZeApvjqnzRUbxLjRxFVBnbKD3lLCOywyZkwt/5OOkdt3sBG7qp9gDatBM3GWNqiPj2MRH8OGnbtadwEc4aoUJD9h0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8V0GfoBBUd8y2p0P5IKkl8d/SlWxJyOCve3UZtbQxco=; b=SWkjgyuDa8Q2lejuUKwg+E9IMnu1F9LPSR+/GY5qhixK7tjG/EG2qWBJcvLPB8z6sJaiyY5n09QDhbOlsUI6DwSpnVVbJlnoaySf+QE4xJXOjOOISHmhewnB/iwmx1Mr02tLO4JJtPXXwO6Ef29MNxfm4q9dO8EH6f8AY17StGQ= Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) by BYAPR11MB2693.namprd11.prod.outlook.com (2603:10b6:a02:cc::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Sun, 17 May 2020 19:52:03 +0000 Received: from BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::30cf:b71:6d62:7fd9]) by BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::30cf:b71:6d62:7fd9%4]) with mapi id 15.20.3000.022; Sun, 17 May 2020 19:52:03 +0000 From: "Dumitrescu, Cristian" To: "Yigit, Ferruh" , Ray Kinsella , Neil Horman , Eelco Chaudron CC: "dev@dpdk.org" , Thomas Monjalon , David Marchand , "stable@dpdk.org" , Luca Boccassi , "Richardson, Bruce" , "Stokes, Ian" , "Andrzej Ostruszka" Thread-Topic: [PATCH v4] meter: provide experimental alias of API for old apps Thread-Index: AQHWKgpn06hU8fDK2kmk46fSvpKUbaissiXg Date: Sun, 17 May 2020 19:52:03 +0000 Message-ID: References: <20200513121149.2283385-1-ferruh.yigit@intel.com> <20200514161104.1546493-1-ferruh.yigit@intel.com> In-Reply-To: <20200514161104.1546493-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48257456-3726-4908-92c9-08d7fa9bc567 x-ms-traffictypediagnostic: BYAPR11MB2693: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 040655413E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d5Xo6qRZTKxXdtHSEl+1Wsd3rxKKz3VyjGWcXbFWkygDPxpSesY4iOVonsOsEifgl/E/BJW12K5GJ7OqnakBKsRZbSIvg3C9HSkPj3EXJyJOpZQ7UdI9NvlFxiLZ5Q8Ye2N6LMQtNWgoKw3b17uTSP324LCj8TqoESmYzh2ZKvMRxdD6bYfwge3LUUcHbQWCTjEIcqw0VasI8SwVhipwCiFmRI/sHD7HZoLHT3MrliXyfa4QHTZvVhxJ3zdhVXqFfmfDNkbQdAArd+BOkw0Ylpcf4MMX+VQ6K/ghJ02ZsMT4B5kYrQ+lalV3WAAtStmgnw6ysDk45kIoF4UpZJ9iyukcdrX3fWzpjeXVoN6nTW7i0/9v5B6xzCsOvYxLqLqe4lgrQf0ag/gyQHIYvyymCYuG5iynvR+qiOEz5/kdjvJMfokFAtAGaZ2vgqbWyRUtxLV8liUh5HWpOh+4j+MWpb44HIO1Vt0X71yZeTv4ZhlreQpdBfCOBx46Zqvr9+m10nmRXFRfI92rrodH/WTYJQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(376002)(346002)(366004)(136003)(39860400002)(110136005)(33656002)(54906003)(316002)(55016002)(9686003)(966005)(4326008)(478600001)(2906002)(52536014)(186003)(26005)(66556008)(66476007)(64756008)(66446008)(66946007)(6506007)(53546011)(71200400001)(76116006)(7696005)(8936002)(86362001)(5660300002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: t9ilXvehqLtKUNPkyNpw27hwllFeDoMsuyxvFNIU5EcRZlEOui8oOaP8FtLKO5BkYWbOaHExfUvZAwNQ8MTCo3K2L4qgdsVtO3SA46DRpkRru5X98hIr7cq2vP5sc5f4TtKsmhy16Lvdz74lFWH1I5HuWGyriE19/YHjeA7HPqxkQVoxZnw/yCeqI8JdUYGl/sam5hkFOYL/kIZRH0xOtxOV3EJavIUtSTtK71gDzCSX90l6syVIfbkSMKeCw3V7hZk+JGxFOcXrKkbr4yv+jnrkbCxHUcuJMMx39JPrY6w7c4/7eomhbSz75CLIVv+P88iFrk0Bcjj1wMyCxph5ZGm8X6TzhzlJyZTj4iXrnKENB90G9w4EyCmcDQr57hBnMsAJXLRImn7FgefbiIT78BoV3/1jM1eFJjCqSnj+NThByGDkMRK6cFa3Nyj3XwjgQEjSYfcJIAp9VveU6kNRk+GGFLZ6ZtEtPYaJjyy3947ubkbGzGgsma/8WTL2zGXC Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 48257456-3726-4908-92c9-08d7fa9bc567 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2020 19:52:03.3139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lE84eY7RKjMsi79hDN6ruHp6/Y6Zl+UrVs92LGowirREkDZS/N6xq+1lnOptotySKcSzVIUet1Jj0IgYv7+PJFqwwcJeXrxil4R57601eT0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2693 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, May 14, 2020 5:11 PM > To: Ray Kinsella ; Neil Horman > ; Dumitrescu, Cristian > ; Eelco Chaudron > Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon > ; David Marchand ; > stable@dpdk.org; Luca Boccassi ; Richardson, Bruce > ; Stokes, Ian ; Andrzej > Ostruszka > Subject: [PATCH v4] meter: provide experimental alias of API for old apps >=20 > On v20.02 some meter APIs have been matured and symbols moved from > EXPERIMENTAL to DPDK_20.0.1 block. >=20 > This can break the applications that were using these mentioned APIs on > v19.11. Although there is no modification on the APIs and the action is > positive and matures the APIs, the affect can be negative to > applications. >=20 > Since experimental APIs can change or go away without notice as part of > contract, to prevent this negative affect that may occur by maturing > experimental API, a process update already suggested, which enables > aliasing without forcing it: > https://patches.dpdk.org/patch/65863/ >=20 Personally, I am not convinced this is really needed. Are there any users asking for this? Is there any other library where this is also applied, or is librte_meter t= he only library? > This patch provides aliasing by duplicating the existing and versioned > symbols as experimental. >=20 > Since symbols moved from DPDK_20.0.1 to DPDK_21 block in the v20.05, the > aliasing done between EXPERIMENTAL and DPDK_21. >=20 > Also following changes done to enabling aliasing: >=20 > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. >=20 > Updated the 'check-symbols.sh' buildtool, which was complaining that the > symbol is in EXPERIMENTAL tag in .map file but it is not in the > .experimental section (__rte_experimental tag is missing). > Updated tool in a way it won't complain if the symbol in the > EXPERIMENTAL tag duplicated in some other block in .map file (versioned) >=20 > Enabled function versioning for meson build for the library. >=20 > Fixes: 30512af820fe ("meter: remove experimental flag from RFC4115 trTCM > API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: Neil Horman > Cc: Thomas Monjalon > Cc: Luca Boccassi > Cc: David Marchand > Cc: Bruce Richardson > Cc: Ian Stokes > Cc: Eelco Chaudron > Cc: Andrzej Ostruszka > Cc: Ray Kinsella >=20 > v2: > * Commit log updated >=20 > v3: > * added suggested comment to VERSION_SYMBOL_EXPERIMENTAL macro >=20 > v4: > * update script name in commit log, remove empty line > --- > buildtools/check-symbols.sh | 3 +- > .../include/rte_function_versioning.h | 9 +++ > lib/librte_meter/meson.build | 1 + > lib/librte_meter/rte_meter.c | 59 ++++++++++++++++++- > lib/librte_meter/rte_meter_version.map | 8 +++ > 5 files changed, 76 insertions(+), 4 deletions(-) >=20 > diff --git a/buildtools/check-symbols.sh b/buildtools/check-symbols.sh > index 3df57c322c..e407553a34 100755 > --- a/buildtools/check-symbols.sh > +++ b/buildtools/check-symbols.sh > @@ -26,7 +26,8 @@ ret=3D0 > for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3` > do > if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE && > - ! grep -q "\.text\.experimental.*[[:space:]]$SYM$" > $DUMPFILE > + ! grep -q "\.text\.experimental.*[[:space:]]$SYM$" > $DUMPFILE && > + $LIST_SYMBOL -s $SYM $MAPFILE | grep -q EXPERIMENTAL > then > cat >&2 <<- END_OF_MESSAGE > $SYM is not flagged as experimental > diff --git a/lib/librte_eal/include/rte_function_versioning.h > b/lib/librte_eal/include/rte_function_versioning.h > index b9f862d295..f588f2643b 100644 > --- a/lib/librte_eal/include/rte_function_versioning.h > +++ b/lib/librte_eal/include/rte_function_versioning.h > @@ -46,6 +46,14 @@ > */ > #define VERSION_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) > RTE_STR(e) ", " RTE_STR(b) "@DPDK_" RTE_STR(n)) >=20 > +/* > + * VERSION_SYMBOL_EXPERIMENTAL > + * Creates a symbol version table entry binding the symbol > @EXPERIMENTAL to the internal > + * function name . The macro is used when a symbol matures to > become part of the stable ABI, > + * to provide an alias to experimental for some time. > + */ > +#define VERSION_SYMBOL_EXPERIMENTAL(b, e) __asm__(".symver " > RTE_STR(b) RTE_STR(e) ", " RTE_STR(b) "@EXPERIMENTAL") > + > /* > * BIND_DEFAULT_SYMBOL > * Creates a symbol version entry instructing the linker to bind referen= ces to > @@ -79,6 +87,7 @@ > * No symbol versioning in use > */ > #define VERSION_SYMBOL(b, e, n) > +#define VERSION_SYMBOL_EXPERIMENTAL(b, e) > #define __vsym > #define BIND_DEFAULT_SYMBOL(b, e, n) > #define MAP_STATIC_SYMBOL(f, p) f __attribute__((alias(RTE_STR(p)))) > diff --git a/lib/librte_meter/meson.build b/lib/librte_meter/meson.build > index 646fd4d43f..fce0368437 100644 > --- a/lib/librte_meter/meson.build > +++ b/lib/librte_meter/meson.build > @@ -3,3 +3,4 @@ >=20 > sources =3D files('rte_meter.c') > headers =3D files('rte_meter.h') > +use_function_versioning =3D true > diff --git a/lib/librte_meter/rte_meter.c b/lib/librte_meter/rte_meter.c > index da01429a8b..c600b05064 100644 > --- a/lib/librte_meter/rte_meter.c > +++ b/lib/librte_meter/rte_meter.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include >=20 > #include "rte_meter.h" >=20 > @@ -119,8 +120,8 @@ rte_meter_trtcm_config(struct rte_meter_trtcm *m, > return 0; > } >=20 > -int > -rte_meter_trtcm_rfc4115_profile_config( > +static int > +rte_meter_trtcm_rfc4115_profile_config_( > struct rte_meter_trtcm_rfc4115_profile *p, > struct rte_meter_trtcm_rfc4115_params *params) > { > @@ -145,7 +146,35 @@ rte_meter_trtcm_rfc4115_profile_config( > } >=20 > int > -rte_meter_trtcm_rfc4115_config( > +rte_meter_trtcm_rfc4115_profile_config_s( > + struct rte_meter_trtcm_rfc4115_profile *p, > + struct rte_meter_trtcm_rfc4115_params *params); > +int > +rte_meter_trtcm_rfc4115_profile_config_s( > + struct rte_meter_trtcm_rfc4115_profile *p, > + struct rte_meter_trtcm_rfc4115_params *params) > +{ > + return rte_meter_trtcm_rfc4115_profile_config_(p, params); > +} > +BIND_DEFAULT_SYMBOL(rte_meter_trtcm_rfc4115_profile_config, _s, 21); > +MAP_STATIC_SYMBOL(int rte_meter_trtcm_rfc4115_profile_config(struct > rte_meter_trtcm_rfc4115_profile *p, > + struct rte_meter_trtcm_rfc4115_params *params), > rte_meter_trtcm_rfc4115_profile_config_s); > + > +int > +rte_meter_trtcm_rfc4115_profile_config_e( > + struct rte_meter_trtcm_rfc4115_profile *p, > + struct rte_meter_trtcm_rfc4115_params *params); > +int > +rte_meter_trtcm_rfc4115_profile_config_e( > + struct rte_meter_trtcm_rfc4115_profile *p, > + struct rte_meter_trtcm_rfc4115_params *params) > +{ > + return rte_meter_trtcm_rfc4115_profile_config_(p, params); > +} > +VERSION_SYMBOL_EXPERIMENTAL(rte_meter_trtcm_rfc4115_profile_conf > ig, _e); > + > +static int > +rte_meter_trtcm_rfc4115_config_( > struct rte_meter_trtcm_rfc4115 *m, > struct rte_meter_trtcm_rfc4115_profile *p) > { > @@ -160,3 +189,27 @@ rte_meter_trtcm_rfc4115_config( >=20 > return 0; > } > + > +int > +rte_meter_trtcm_rfc4115_config_s(struct rte_meter_trtcm_rfc4115 *m, > + struct rte_meter_trtcm_rfc4115_profile *p); > +int > +rte_meter_trtcm_rfc4115_config_s(struct rte_meter_trtcm_rfc4115 *m, > + struct rte_meter_trtcm_rfc4115_profile *p) > +{ > + return rte_meter_trtcm_rfc4115_config_(m, p); > +} > +BIND_DEFAULT_SYMBOL(rte_meter_trtcm_rfc4115_config, _s, 21); > +MAP_STATIC_SYMBOL(int rte_meter_trtcm_rfc4115_config(struct > rte_meter_trtcm_rfc4115 *m, > + struct rte_meter_trtcm_rfc4115_profile *p), > rte_meter_trtcm_rfc4115_config_s); > + > +int > +rte_meter_trtcm_rfc4115_config_e(struct rte_meter_trtcm_rfc4115 *m, > + struct rte_meter_trtcm_rfc4115_profile *p); > +int > +rte_meter_trtcm_rfc4115_config_e(struct rte_meter_trtcm_rfc4115 *m, > + struct rte_meter_trtcm_rfc4115_profile *p) > +{ > + return rte_meter_trtcm_rfc4115_config_(m, p); > +} > +VERSION_SYMBOL_EXPERIMENTAL(rte_meter_trtcm_rfc4115_config, _e); To me, this is a significant amount of dead code that does not add any func= tionality and does not bring any added value to the library for any user. I= am not a build system expert, but I would definitely prefer avoiding addin= g any C code to the library for this purpose, and just modify the map file,= would this approach be possible? Also, very important, is this C code to be added permanently or is it added= just on a temporary basis? If temporary, when is it going to be removed? > diff --git a/lib/librte_meter/rte_meter_version.map > b/lib/librte_meter/rte_meter_version.map > index 2c7dadbcac..b493bcebe9 100644 > --- a/lib/librte_meter/rte_meter_version.map > +++ b/lib/librte_meter/rte_meter_version.map > @@ -20,4 +20,12 @@ DPDK_21 { > rte_meter_trtcm_rfc4115_color_blind_check; > rte_meter_trtcm_rfc4115_config; > rte_meter_trtcm_rfc4115_profile_config; > + > } DPDK_20.0; > + > +EXPERIMENTAL { > + global: > + > + rte_meter_trtcm_rfc4115_config; > + rte_meter_trtcm_rfc4115_profile_config; > +}; > -- > 2.25.4 Regards, Cristian