From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C09A8A0540; Mon, 20 Jul 2020 13:22:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 945F81AFB; Mon, 20 Jul 2020 13:22:02 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 99EDDA69 for ; Mon, 20 Jul 2020 13:22:00 +0200 (CEST) IronPort-SDR: xJVqb9ti8asRy9Fs6vVOaao/Eaouu/e0rCPpIZsX/Knz2qqLwP3th/0YryLMw+u0gsA/F9lzpJ rEkkabgOkbjw== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="137372373" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="137372373" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 04:21:59 -0700 IronPort-SDR: Nkq4wToTll+GOsEN1VB2Sri/BcNhwtRxV0xb/FJbPd5JJpNg7/aBRz0TMnRs6C6BJgfCIGxLQh rAnBcU9y8F0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="319495710" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga002.fm.intel.com with ESMTP; 20 Jul 2020 04:21:58 -0700 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 04:21:59 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX114.amr.corp.intel.com (10.22.240.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 04:21:58 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 04:21:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EL+7GLDts1wFpt+wvImNIEZbPLvJN779am02xmz4PEOsqWY6RYnfjG5NnD1H8OhCjECtDZlEtYO3Cieh2qhcxq0bRfJ4XO5pVCClDlF5pvck3p20idCQ5kMBVBmLmPDXRHFLYVwfLgg/OrFfynYTuQgCd3sBhMK16bhEYoVBPBZ9yjLFDz5Y2o+cGyaUPRSgsJS8wUH8y+Vet9uTYuVAQENiuPyPVSWXJDJrz5W79Qb/FcJqUF5S/fEKgopVYrfT34VWIseXet3xGd9LO6yBZl/rFqAFJeWEZEsLkxtlIMnNax05Jrp5Rn/JfS7kYfr0ABmwS79Peys58vPVkUiPNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzQeREALH8d68K4Ypq1QT0193G7iocZjqc1FmtB+z7s=; b=Lsn2mmXvYPTjP/uoQglLHwSvxwzaXLIkwXyFW+M+j1/AaC2Ze9K5IFyvNEo07bbvjehvkmvjOmfZP6ihYYSJJpZ8V+6i3f3fpqC878PHHtGCzAmBnX9vSduIEeaNGPNzyIIKK4WIr8Yt1Br9GyOy/LayvEgUhvmiR/AIK1IcKB9WO513RkyzoMOjq/isiybc3cPm0y2V/ASn42cUF6RCH+Q7mcMC6EcOyL3fuEvdKmdBgAlCJ/hmV4Qbtqoz35HMghJeB/aSCaYDjWQzNPxaxiWfE7IOBcrsvNsECFbsWLWk4a0ijB4xc2Ctw0TcmrZaVrw6ThbyaZABacdDQphW+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzQeREALH8d68K4Ypq1QT0193G7iocZjqc1FmtB+z7s=; b=AE/qqLa8KH5JOdlmeIGBwm8clh/wRmOhK+qb3G9eUPEdVHlR5p8FUoH2oajeUif81li6e6KWcqAqJEyEuo6ehI6loH8p4SO33dNUHa6Q/eXAwkPyvszVd6Z2EA6a5xDmJ4NMtVt/alJ6PbIX7/wqBf6Y+ygIc6bSIFwz8TMXxHU= Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) by BYAPR11MB2566.namprd11.prod.outlook.com (2603:10b6:a02:be::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Mon, 20 Jul 2020 11:21:57 +0000 Received: from BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061]) by BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::d514:54b4:8e58:2061%3]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 11:21:56 +0000 From: "Dumitrescu, Cristian" To: "Dharmappa, Savinay" , "Dharmappa, Savinay" , "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport bandwidth profile Thread-Index: AQHWWtXn83LQJuRaFEWWX0EtHBYaGakQWLPQgAABaRA= Date: Mon, 20 Jul 2020 11:21:56 +0000 Message-ID: References: <1594837677-313175-1-git-send-email-savinay.dharmappa@intel.com> <1594837677-313175-2-git-send-email-savinay.dharmappa@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.55.254] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 365c448b-f125-41a8-6013-08d82c9f1cea x-ms-traffictypediagnostic: BYAPR11MB2566: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dlBYfKW5qwA0+ZW92Bw7MVzDppdg+iv+wwD9FYSbrrqF9B+gFTIXtuZwkBY1V1z/JUmUZXd0adhR1Vp4WbNyDaZ3w9xqEqgNC1HqBf9tMZRew4iY2YB2MzKkpgicPQAkJSCZXEGcuV6/Tj2b5BMxA3/L0i8gPmDIdI4cOYDjxyiknECyQgmebpvTTFpmYq5/KV91TX7edjv3G9KE4/ecWycY1IDyowUgw8q4VgunNYAyJJQ79A/wu1i1FWWJeJl/a3Qq39bRNl2Rc3seSmQ374VXa/Jcu+SlZh8owO+HZcTdHsOWbxqOyrtp3KweqcDMB26bbBx4QR2LzSdJCO5YkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(8936002)(2906002)(83380400001)(5660300002)(53546011)(110136005)(316002)(6506007)(71200400001)(478600001)(52536014)(55016002)(86362001)(2940100002)(186003)(7696005)(26005)(9686003)(66446008)(76116006)(66476007)(66556008)(64756008)(66946007)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 1hB93WGRMnDPcwU0GgaHYfGWNKR5ay30+zi+U7qsQR09MQRBN51TUWdN9kx+0aa8hDqY+mAwPDBzekRP2fdoOM6JBDX+QvOdhXgg9FdQCg3nCxI3yuWTNJB+stROIrg/rZ4foyiiEgrqZ/WdzFvjDZ/P5BamB/SQhz0cXZ937Xp5R9SymgJENuC5v/KghqpiVqLoz8UZYN3DPZEcYWAvpnJ2bzFn+eYEgGj/lMw8UeXQEwPzRzimF//v69MCRjkHYATbub8Fa/ddTOX+UfUcKobnqOQpnatah3Fp5QblPPGgWVbXzxw82qZc84hbYZE3NqaPY0gnVcAwg9zDAlXXZhzHvqxow5V8UoFRvQwvHZq0wbtIe2y0T4jZ8q6OvHafeSEx/E8FX5EKiyIklXcjNMBfsmMMtF8LktrHEmJ6uAU7NRGWLMp+xs+L7xT1GnqZ5oJlsTdbq2c341+IT88KxULIrR0agzEPb+xMQ5yAG3c= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2935.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 365c448b-f125-41a8-6013-08d82c9f1cea X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 11:21:56.8510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o7Ugg1wZQr0AHxUZ65ow6qpv4iWOSX+PIJQ96f8y2BHzc4n30mWxa9/rSWAAeNqJdv6lh5rRdr12PnXV6WiRu/L3KGdgX3TncbGNi/MFDmw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2566 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subport bandwidth profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Monday, July 20, 2020 12:21 PM > To: Savinay Dharmappa ; Dharmappa, > Savinay ; Singh, Jasvinder > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of > subport bandwidth profile >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Savinay Dharmappa > > Sent: Wednesday, July 15, 2020 7:28 PM > > To: Dharmappa, Savinay ; Singh, Jasvinder > > ; dev@dpdk.org > > Subject: [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config of subpor= t > > bandwidth profile > > > > This patch modifies the subport level data structures > > and add new API to allow dynamic configuration of the > > subport bandwidth profile. > > > > Signed-off-by: Savinay Dharmappa > > Signed-off-by: Jasvinder Singh > > --- > > lib/librte_sched/rte_sched.c | 486 ++++++++++++++++++++++++-= --- > -- > > --- > > lib/librte_sched/rte_sched.h | 82 +++++- > > lib/librte_sched/rte_sched_version.map | 2 + > > 3 files changed, 424 insertions(+), 146 deletions(-) > > >=20 > Hi Savinay, >=20 > Your patch makes sense, but it is very hard to review, as you put a massi= ve > amount of changes (~500 LOCs) in a single patch file. >=20 > Can you please split your patch into a patchset with incremental changes = that > can be reviewed easier? Some suggestions: split the internal changes in > multiple increments first before changing the API (like move the check co= de > into separate functions in individual patches, etc), change the API > afterwards. >=20 > Thanks, > Cristian Also please send v1 (non-RFC) as part of the next iteration, thanks!