From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A6B2A09E4; Thu, 22 Apr 2021 13:10:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3077641A53; Thu, 22 Apr 2021 13:10:07 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id C20D5406A3 for ; Thu, 22 Apr 2021 13:10:05 +0200 (CEST) IronPort-SDR: S0xXepBrC8kwG7HI+rFwmAO+PWQpqtH8D3gMTR9bDm5X0uXFpsmDG45aa/NF7dgYlLXES7RGoQ ukddp4SLG8wA== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="192679831" X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="192679831" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 04:10:04 -0700 IronPort-SDR: GAm53zYPvrT9NwJ8GbSyLFdfKHqqHd+WLWE1vV3R0nzaknMv/Rtgre9oxp9SOkwqJD4ClvFznN ekIwubeSYOpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="524612732" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 22 Apr 2021 04:10:04 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 22 Apr 2021 04:10:04 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 22 Apr 2021 04:10:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 22 Apr 2021 04:10:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 22 Apr 2021 04:10:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mE46kK9DY9YfMdY3wPcByD+mQu1hZsPsFsTDdt2MJ+PfIIYf6tM34bOveroZVoliILHHIKQbEVaLPdi+xj/owGiKYmgxLGzAEW1ZbmI1H45EzvwKxN343Mfc0csvzfjeOL9uAOgDxkeQ2l1W/7Bhuy6H12HLQraoHU1c2qpv2qEGLT5lZBIk2uKyN6odKpBwSiKxSO19I31s2lqUqJOdryXw+6x+KAF8wucqptetWRFEBuW6+nKeWm4a1Q7MQrmQtARugp657Op0vz5yeCoZjl+drMyBE36L+7sROx31CAUG+W14um3nR9QDJedTLX+tZR0vlc5Ci7rYEmQiLXCjsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4TJ1/Bb2By/ASnglGED2I1O68nxeGvT5gbx3aIsK3c=; b=LKaO4qUpt05uAdd1nvbbfxNf6zimm5E/uMH/VeXHX9kn0MmNzLMs9r4sHGfObnm1GNpCSJttrilAHMoerWjts/UTv3V+3bowrrENteSETx1fZ0u+HGlHhCPtyfdB7vEWeyVpItZZ4JGhDEOrCQOQZGjX5NHHfTbVdobFZ7ojUH1qf1TQsLUmd4Ef6CnUyXiZ0GXD13FPOzN0fO1NIYdsAjSxERmpz/HlbmWStS9y1JjzCdF6T6Tv0kdZQSZKFITAWVWntlRzS/xP4cXlwd7DjLVMosaVxB+j4vo3TSuog9VT8xefkJhtinVJqSjpaXwNO5oBQbtOOjVhTJd0JVYutg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4TJ1/Bb2By/ASnglGED2I1O68nxeGvT5gbx3aIsK3c=; b=FsW97wzW7sGOk5arrfR1wlWc7OmXW2qLbThh9K80Dn0lhJwm2wjT5d4vvKx88BqAgxFLu3ASLeAHEYFLbHq0GA/tWW3VmERaewSZcYdSrSohf7oZfdfv6XeETiOzpa4sdEDHhOEXboLhViBEW7HhoNjdg/bVs7ic3GyN7KDlYwg= Received: from BYAPR11MB3047.namprd11.prod.outlook.com (2603:10b6:a03:8b::32) by SJ0PR11MB5021.namprd11.prod.outlook.com (2603:10b6:a03:2dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.22; Thu, 22 Apr 2021 11:09:34 +0000 Received: from BYAPR11MB3047.namprd11.prod.outlook.com ([fe80::8c8d:62e:59dc:849f]) by BYAPR11MB3047.namprd11.prod.outlook.com ([fe80::8c8d:62e:59dc:849f%6]) with mapi id 15.20.4042.024; Thu, 22 Apr 2021 11:09:34 +0000 From: "Liu, Lingyu" To: Thomas Monjalon CC: Olivier Matz , "dev@dpdk.org" , "Zhang, Qi Z" , "david.marchand@redhat.com" , Hemant Agrawal Thread-Topic: [PATCH v2] mbuf: support eCPRI hardware packet type Thread-Index: AQHXMzRqx6uwy2x/W0y0RWYkGCeIGaq76R6AgACsR2CAAHgygIABmMhQ Date: Thu, 22 Apr 2021 11:09:34 +0000 Message-ID: References: <20210417090415.5477-1-lingyu.liu@intel.com> <20210419142453.GC1726@platinum> <1960280.AK4zKTLmrX@thomas> In-Reply-To: <1960280.AK4zKTLmrX@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57eca9d9-17ca-48cf-989f-08d9057f1c55 x-ms-traffictypediagnostic: SJ0PR11MB5021: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FSt9kLDUrT4Qa4MnzNUkAtGGLPkyVeyIyTg2ipmGAUaVgrdkX4rW4PMdTE8xKtesflX2sjmTe0y/eQZhERDyoEHgTBKWQ7PiAJ37xK8TZVsaridLKJ3xE1KWqjc/ZLHgdBCmscpbzzVV6jtwF+C+jDbePQVh/+hACtt9p7USsfcrtfLNVtt6C/IA0PuxcakNy8CQ94pi5LcT/fE7ke2A/T4sZrLH7LHDewDU94z4ieY8Mt7mTkfFbhHjhoHY5q+hXsoo7cwfo73AGeGnpOaIDevIZ7zubEa+0nFVtBdZdo3xsl4aYtVZeJgh1VMUbFxZcdQUSCYrlHdflxVoMQUuEAoJ1V+bt4qeChhsnM70gNab5gaaaQtUS+ryah0xcNnL4ZRigXuw7gC5siSvMBnWCAYDHa22BfXYUIX0ZJ/ENBlF64Ws/Dn5kXc2oNgzMCQM3B7MvWYZBT2HQJMpbkkO2dvX/v8wIGpbPS5ecYDkM+cwLZpQTQjJgOvtb39IVvTBQTYuPWbe5KAx2/luELRVjzGulCV6Bmi9xy7c047BkqEkgEOtaqXzu3gtWXR0nIkK43/31o83kmACHxMCofV+ewhHnM9M2BCPoEvp+4Hwn5mYAa3HW1Qq5fy70AqXe05S5mnc5lsQ000tcVMjtPLEBJ3W3WQXi5ULf0tYNYyE6nbnfo4uqKC3BCKD1ZMclda6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(376002)(39860400002)(346002)(396003)(4326008)(478600001)(64756008)(966005)(186003)(26005)(66556008)(66446008)(6916009)(86362001)(316002)(66946007)(5660300002)(76116006)(52536014)(66476007)(8936002)(54906003)(2906002)(6506007)(7696005)(33656002)(9686003)(38100700002)(8676002)(122000001)(55016002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?qON/ttTUnueGBEOCe0dfP71PvDHSKg6jGGKLcDwK9+grKyqhcSnYs2nCwa?= =?iso-8859-1?Q?wCcJHep26++aUAKnOx1qygFAChK9kTRx+Sxw5NsO74e4AittVbI4DNN7Q1?= =?iso-8859-1?Q?s+ckVc9wOghr79K10Jh8XrCLA4FXnyT50xh/hb446HLAR0iHTpm1ClYwSo?= =?iso-8859-1?Q?qbiqWC1ar/SI7F9iX7T0JLxKLktFqEdfmSP6cM3aE2Zi2aGmrf0YBco9st?= =?iso-8859-1?Q?fcJ4iG4n+rkrMJoK9mZr0UV0TwPiXyYsaPnZolTuWddl2nCmALuS5RC0Zf?= =?iso-8859-1?Q?6yoOvO7dgzxe8qYqWOLus4wTO/KQ7DGSzc8kW/PkySPCDzJJ3M+2g7wuI5?= =?iso-8859-1?Q?By2751CQUhR6tsrpmZTWG7VKeRt1GL643I3EAU9nRvGlRqi9OUDc7/UAHc?= =?iso-8859-1?Q?jlHI1gVzLc3mk2gtDZ8RdLtqh4PkDEmahcQYk/V21LYk2d0MXpF6tXY0NW?= =?iso-8859-1?Q?AAWiX4BS0DRgf+84LbPe6reQFtvEWfa2bSU+53JUt59k661k+FYUQzRyR5?= =?iso-8859-1?Q?8mJdtmbB88PIZLvqmS4yfEqsLiZu93W2ERVybrebUoP1neERBFPvyE8DAH?= =?iso-8859-1?Q?YqYR+x92vc1Yugog71vrit3XxXUx5/+bdolSMhWXrJ8OsElX3mQFo/yIXZ?= =?iso-8859-1?Q?UnDbcbQ0IBgzjq5S2tf2MWSm5mu1jzhQSPh7lOmsmBRhyzRhcOqdqWvj81?= =?iso-8859-1?Q?otMn7Jtb+btZ8LFk1hvJROIHLwIGSaipzbCHcgkhDl+ZRTTuth//zN9s5a?= =?iso-8859-1?Q?L/qcVK9JNMI+aT0AlOlqRTSTpm+7AKHPlMqXDsT+gFk6TlTjcB75Ir/FTg?= =?iso-8859-1?Q?RHZYrzBKNra0qP3IG9cPAKx18/lROC9xkHd7sIJvdI/AcRnNmqNQdKSrXb?= =?iso-8859-1?Q?nuyxTh66x9uhfThi+8oLOjUYVxUgaCFg94A4SLrsCJPcP3HM9Nh6dCXS/4?= =?iso-8859-1?Q?7H5Pepf3faB2wLOL1BEbyGQf0Y0t+9xOPfuyWvOUuTY4Yy9JrgzWnR64rv?= =?iso-8859-1?Q?0d2u5z2dsxssE4cPj49Xvf486rzo/7vUVYIhAJ/rmDwM2GbqPJTj25aVuE?= =?iso-8859-1?Q?bbVhbZpv+9yvi8JEfLjL2C3dR3Kq/gjVoTyQ4PXjZhqlPPPbNvqpabiZdv?= =?iso-8859-1?Q?YqRRUvl40tukrZYUtP/Rpcqn9bVgWUspyM6kZozlCe6CiYss3jwie56qkX?= =?iso-8859-1?Q?deVWO24VTVJ197rYhaUlea2t9IfGw/606OeOlBFwPcIh6Nfga3RDeFBDrJ?= =?iso-8859-1?Q?DAoBm8hMJOijBg4mbcjiEQoMwuBF676pelxEjpcfeFqKeek0nXiPVL4nrJ?= =?iso-8859-1?Q?xKFpU/TpOLxB5rnSSlilmux1alUzJ3UIrsc+pgGKgn0Tm0Q=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57eca9d9-17ca-48cf-989f-08d9057f1c55 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 11:09:34.3013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fjz7XA1oPvaMALKOgw0o/iPYsLZu8+I8by7sY377TY1Cg826bnqDXWlwQkOsFC0zDk3BJmGXcGmQo0QuSgQCUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5021 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 20/04/2021 04:17, Liu, Lingyu: > > Hi Olivier, > > > > This new packet type will be used by iavf driver to map ECPRI hardware > packet. > > This is the patch which will use this new hardware packet type. > > http://patchwork.dpdk.org/project/dpdk/patch/20210420083817.10741-3- > li > > ngyu.liu@intel.com/ >=20 > I think it does not reply Olivier's question about how it will be used. > Why is it important to report this packet type in mbuf? >=20 > PS: please do not top-post >=20 In current implementation(w/o this patch), when receiving a eCPRI packet, t= estpmd prints like this: "port 2/queue 0: received 1 packets src=3D00:00:00:00:00:00 - dst=3D00:11:22:33:44:77 - type=3D0x0800 - lengt= h=3D60 - nb_segs=3D1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP - sw = ptype: L2_ETHER L3_IPV4 L4_UDP - l2_len=3D14 - l3_len=3D20 - l4_len=3D8 - = Receive queue=3D0x0 ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD PKT_RX_OUTER_L4_CKSUM= _UNKNOWN" We can't know the hw ptype. After adding this patch, when receiving an eCPRI packet, testpmd can print = like this: " port 1/queue 0: received 1 packets =A0 src=3D00:00:00:00:00:00 - dst=3D00:11:22:33:44:11 - type=3D0x0800 - len= gth=3D60 - nb_segs=3D1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP TUNN= EL_ECPRI=A0 - sw ptype: L2_ETHER L3_IPV4 L4_UDP=A0 - l2_len=3D14 - l3_len= =3D20 - l4_len=3D8 - ECPRI packet: packet type =3D58001, Destination UDP po= rt =3D20771 - Receive queue=3D0x0 =A0 ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD PKT_RX_OUTER_L4_CKS= UM_UNKNOWN " Then apps can recognize the packet type using hw ptype. This supports more = complete packet types and protocols. >=20 > > > From: Olivier Matz > > > > > > Hi Lingyu, > > > > > > On Sat, Apr 17, 2021 at 09:25:31AM +0000, Lingyu Liu wrote: > > > > Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE. > > > > > > > > Signed-off-by: Lingyu Liu > > > > Acked-by: Hemant Agrawal > > > > > > The number of available packet types for tunnels is quite low > > > (already mentionned in this thread [1]). > > > > > > [1] > > > https://patches.dpdk.org/project/dpdk/patch/20210408081720.23314-3- > > > ktejasree@marvell.com > > > > > > Can you give some details about how it will be used? For instance, > > > which driver will set it, which kind of application will use it. > > > > > > Thanks, > > > Olivier >=20 >=20