From: "P, Venkata Suresh Kumar" <venkata.suresh.kumar.p@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Khangar, Churchill" <churchill.khangar@intel.com>,
"Jangra, Yogesh" <yogesh.jangra@intel.com>
Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port
Date: Tue, 23 Mar 2021 18:07:49 +0000 [thread overview]
Message-ID: <BYAPR11MB30774B50A6AA5E1CB0F3298799649@BYAPR11MB3077.namprd11.prod.outlook.com> (raw)
In-Reply-To: <6532294.cV1ATAUDhe@thomas>
Thanks a lot for reviewing the code and providing your comments.
I have addressed below comments in V2 patch.
Thanks & Regards,
Suresh.
-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net>
Sent: Tuesday, March 23, 2021 9:52 PM
To: P, Venkata Suresh Kumar <venkata.suresh.kumar.p@intel.com>
Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Khangar, Churchill <churchill.khangar@intel.com>; Jangra, Yogesh <yogesh.jangra@intel.com>
Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port
19/03/2021 13:02, Venkata Suresh Kumar P:
> Add the file descriptor input/output port type for the SWX pipeline.
I think it deserves a bit more explanation about what is FD I/O port. -- [Suresh] - Addressed in V2 patch
> /*
> + * tap
> + */
> +#define TAP_DEV "/dev/net/tun"
Spaces are free :) -- [Suresh] - Addressed in V2 patch
> +#ifndef TRACE_LEVEL
> +#define TRACE_LEVEL 0
> +#endif
> +
> +#if TRACE_LEVEL
> +#define TRACE(...) printf(__VA_ARGS__) #else #define TRACE(...)
> +#endif
Would you consider rte_trace?
> --- /dev/null
> +++ b/lib/librte_port/rte_swx_port_fd.h
> @@ -0,0 +1,57 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2016 Intel Corporation
I guess you did not create it in 2016. -- [Suresh] - Addressed in V2 patch
> + */
> +
> +#ifndef __INCLUDE_RTE_SWX_PORT_FD_H__ #define
> +__INCLUDE_RTE_SWX_PORT_FD_H__
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +/**
> + * @file
> + * RTE SWX FD Input and Output Ports
> + *
> + ***/
Useless blank line. -- [Suresh] - Addressed in V2 patch
[...]
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif
A comment after such a far #endif is better: -- [Suresh] - Addressed in V2 patch
/* __INCLUDE_RTE_SWX_PORT_FD_H__ */
> --- a/lib/librte_port/version.map
> +++ b/lib/librte_port/version.map
> @@ -48,4 +48,6 @@ EXPERIMENTAL {
> #added in 21.02
In 21.05
> rte_swx_port_ring_reader_ops;
> rte_swx_port_ring_writer_ops;
> + rte_swx_port_fd_reader_ops;
> + rte_swx_port_fd_writer_ops;
Please sort in alphabetical order. -- [Suresh] - Addressed in V2 patch
next prev parent reply other threads:[~2021-03-23 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 12:02 Venkata Suresh Kumar P
2021-03-23 16:22 ` Thomas Monjalon
2021-03-23 18:07 ` P, Venkata Suresh Kumar [this message]
2021-03-23 18:38 ` Thomas Monjalon
2021-03-23 18:56 ` Dumitrescu, Cristian
2021-03-23 19:55 ` Thomas Monjalon
2021-03-24 10:23 ` Dumitrescu, Cristian
2021-03-23 18:24 ` Stephen Hemminger
2021-03-23 18:25 ` Stephen Hemminger
2021-03-23 18:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB30774B50A6AA5E1CB0F3298799649@BYAPR11MB3077.namprd11.prod.outlook.com \
--to=venkata.suresh.kumar.p@intel.com \
--cc=churchill.khangar@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yogesh.jangra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).