From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAE77A0C41; Tue, 23 Mar 2021 19:07:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FF824069E; Tue, 23 Mar 2021 19:07:54 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 86E9E40683 for ; Tue, 23 Mar 2021 19:07:52 +0100 (CET) IronPort-SDR: GM5+pYZhK35bi+/CnBkhGgWS3k6GO83wwP2vz8syQTcYyiydtbjYshhFZ6pgkaeX43sa7O+I23 vSqja0SDGJ4A== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="254536558" X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="254536558" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 11:07:51 -0700 IronPort-SDR: pLvrw81J75AOLf3fDFxNh6nh+ycLyRWUuy2QCFF1zIG2qWqFVUq/FekKR+0N+hbX0V3tkDow0r MrdspnO6qbJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="381446749" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 23 Mar 2021 11:07:50 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 11:07:50 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Mar 2021 11:07:50 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Mar 2021 11:07:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SAi05/pGr3yf+u1IGSBFIpNMWsOGaN7j2pP71UNBrTv4ZzKNmodv7HdD1oAKHqY3lv/Tof8CWhusWwWw0jeb7cd3k6EwFyKZsbJRGGHKcmuLZQH0/Uvxh6ti5/bYupTrfGU08+6Ofp8G6V3dDS+nIlpM/IdEFbjjHdLLn6nJZl9lUFBUNIJ50IAO+sD/9G6+IgADXTTMX1vpxdkt/tEudWWd1nNOCL8yL33RZMPwgJtU/8Iw9gSijNY79jSD3Kn2HYAV7yGn/Rg6Od0RanXeF2JTbVLdoM+xqu+ZzzjMApOUm17hwR84fug+kEb8l1+OPZSNUeaBePHjAYGqA22TUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=msqaO/WuJO6MFqPyjKjafJuLwQ8HSG2BMpWxo+P81Gk=; b=SXD3JnkhdF9D8XT8SpxqauI16hK8Dj2G4mU2TS10jyx/W68KuA+dcquRUt3wZ/WgZbp2Rcm5N4yK0OiLDsmrKX4HDeorQxXO50h+wSJ2Ef5Ngnm+9Z5XqxI/X9CleIBrrq/C+KsR2C19WanIDo0bnNlnHKOpt9+FNpSNeWg7VOrr8cXBxgumaZ9Q2d33gOqrKzfkHXDm1n3fT5wcn3DJipb3HYGCM8RyRVdA5gYI1MG01I7Tw1NPo/cj9e2kHeOOlrVyD9992EGRDqx31UqGcfpDQ31HC405Bw2zdsRzLnHCKwSP9imCv0cCnwO/MOvwivl2o/bjkM9+Qu33gYB62w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=msqaO/WuJO6MFqPyjKjafJuLwQ8HSG2BMpWxo+P81Gk=; b=LlzukP/BwxGGCfRr1KzkjoAzwYBg76NRgQqIIUZsSh+2PB5dF4kH+Sm/4a3DtilwR6A6FOywa+pYnqMEMvJVsXWyLf29UabGNLPzA+KNePSrxVic/Y2HMyuyihuaL1cYTM81aL1OOCqOwK2xoAs0ywRfruQt3h4BS763PMYckTc= Received: from BYAPR11MB3077.namprd11.prod.outlook.com (2603:10b6:a03:90::14) by BY5PR11MB4070.namprd11.prod.outlook.com (2603:10b6:a03:181::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.23; Tue, 23 Mar 2021 18:07:49 +0000 Received: from BYAPR11MB3077.namprd11.prod.outlook.com ([fe80::6cc9:d566:d792:5ab2]) by BYAPR11MB3077.namprd11.prod.outlook.com ([fe80::6cc9:d566:d792:5ab2%5]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 18:07:49 +0000 From: "P, Venkata Suresh Kumar" To: Thomas Monjalon CC: "dev@dpdk.org" , "Dumitrescu, Cristian" , "Khangar, Churchill" , "Jangra, Yogesh" Thread-Topic: [dpdk-dev] [PATCH] port: add file descriptor SWX port Thread-Index: AQHXHLdHaaw/pTIk3kaQzgaK1kXNw6qRx+mAgAAcPIA= Date: Tue, 23 Mar 2021 18:07:49 +0000 Message-ID: References: <1616155326-2639-1-git-send-email-venkata.suresh.kumar.p@intel.com> <6532294.cV1ATAUDhe@thomas> In-Reply-To: <6532294.cV1ATAUDhe@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [123.201.249.98] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85e438ac-3f95-440a-2aa9-08d8ee2691bc x-ms-traffictypediagnostic: BY5PR11MB4070: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pbW8IfqIsl5+ECZB3PetpmMsJeEWgv5rWUhdbmurs1ol6FzjfnpSv1eiZF+tOqU5IgJJaCbtDUjDEVA8MuYZDwwI5IeZHUoKCl6X2qj/rh5nJagqoZPRja5iurMg4s+5RA2K5eOjt7dEWv050pWRZly5vJUfNxXFoV9dM21xzO25Ow9AF5tUXH4OJy6D4pQRs+7hobFUKWABxcQXYPARZ5PmIXru1pNu5UlsQEbaAWIAgjDCf82PVzIbXQgxvZ7WnvaP5IL7RtGDSW+pFlCyzomSn6746C2QuK5rUSPUmh7UoNU0aAnOqw82w2E6R/odW9vGNZiqN+pagsRh1I5xMYjpAfkHWQBa7MbMiUUfYg8qKsL3d8wA1uvGckGtZoZ37DvDX4i5/x9zlRgAnCqq1UDRNnTWmXOM1VEG/id3WvgPmlaD6yRMAYUfAaM4mf9Dyh7LhclS1d+0H/zFNXO/PleD1CwpiXDbOS4/LJ1vyTdoN95tivS1UFeJzWMAAg+M0eOv7uUa4nKnOsBe7srKoIhrc2yEpcQ6nygX8GEufqfFDfFOCH4tGCE+q9PyKYwMJMtIJcB5qycmvCDH9LcdvGl+JS1Yl4Z7V64o6f77m8wIQ/jk+f5Gevmc8EIeCqyJ4yCa5/1zZSno7L23rEz3hRcH4wsMjdexY2SFMmNMDAE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3077.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(376002)(39860400002)(396003)(346002)(7696005)(2906002)(55016002)(66556008)(8936002)(66446008)(66946007)(8676002)(66476007)(5660300002)(186003)(26005)(76116006)(64756008)(53546011)(316002)(4326008)(6506007)(6916009)(38100700001)(9686003)(54906003)(107886003)(33656002)(478600001)(86362001)(52536014)(71200400001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?vsyvOk4w9CWNgRYhCXmzpdDlCwQRKAw/dO9kEsKubyXt3s31egdJnrzEuJ8V?= =?us-ascii?Q?uRDlL26HepwznBfRYLM8n+bAAlr2UfFX498WOGcUngGmFgHIs+l7CTZDwP54?= =?us-ascii?Q?f4OSuI9f0F1WLDcRXiyZkjdyxhn+JLLLczWBqNbpTtOoquv6kJ0GUq689FY7?= =?us-ascii?Q?4FrmHLEr2vh9Dw2aTMNtKhABRIsbQLTlelSLQiBDoyCQijKqSLbETLM+5iwr?= =?us-ascii?Q?5ECzgl4BbVSj0msRUedQED9zmX1kKc0v8kpX/ERDNPZV9lBZMuUDSCwPkqWk?= =?us-ascii?Q?tA5yCMaeMj14mRrvw+O3nxsMzI7ftnqkYEcM5z8rrRBmmdPvj/VsjXpBKkIv?= =?us-ascii?Q?TyhFxDe5trAuAkrgCSK0v2vwMfySM2/mMAMLi+J1AewXMrgIyodHLcI4MQOV?= =?us-ascii?Q?eSIb3SUZ+A6eX02L2t6lPr2ktDFdvkXjp05Mxn3lzyOY+x1pjaslSq+/hYuo?= =?us-ascii?Q?OR4i8SNj4gDF3wgoJi4L0oiHBZEiQFgTh8jeX1NUzF18nvWzYuYbobHs4UfU?= =?us-ascii?Q?pwCRNzle7PZIjpUEvHIPbRfzHMNRlORIDfdyfd5Q/Ai02+GODeMm6rPRcBqY?= =?us-ascii?Q?pfdwOiO3ClaOuYWVLLXryMXvg1jbZVLEecjc3M4lxLJKR+LL7hzCxmoqR5+3?= =?us-ascii?Q?9B7mgf7UhVdc8sKu9FfkaSs012/+hcC4ehNP5iwRU68ao1CEGbMnHgv6C3Vt?= =?us-ascii?Q?TxEPBXM3H5KdM34RRbxIapLQYMYVSA3pIBpwozpzBUdPaGWwkoPK8oAQdPVd?= =?us-ascii?Q?Obo9J7TGFrg8uUE6r97jAnw4+DUti10fSCUMcVHCK6xbkfL46XMfGOuqZv9+?= =?us-ascii?Q?7DyztFwa7yCnho3KIxV5SuRoKLJH2adpmXoyEfUUThTXmCRQAcr5fdQ8rkNo?= =?us-ascii?Q?g1Ca3s0EA25rXB+2n5t3fqj1LfCC8ZXUA7/Y4Ug9qUHEVy6ASES923KzhZWY?= =?us-ascii?Q?kSy4+8pGchUmXbd7aUMBhxIexkuejUV7jQAv531PSmYnN7j/AzR5dcDRKnxX?= =?us-ascii?Q?iHQhbKbfi7M/ar294YzLbwtaWmyIBKRcnG5LacIWv3aTkzoaqYA4WtJZBaz1?= =?us-ascii?Q?XZCYYFtTdgzQ4tF1ZouHWBI3Y5HPcLkbNDpGQuGZsE9gVEZXGMdrR+H3566N?= =?us-ascii?Q?Fb+3HQa9Zv8uuTVFwpgkReDlEd8MM3yKx0NSoC2SOvLgi/v6ldyEgjuF6MsL?= =?us-ascii?Q?VvstjyUNqbNTkbQYPJ2fcKODFVafiUxJiDWind2e9OSq4ZmJX0Rlgb45H07l?= =?us-ascii?Q?j+lBZ2VwAVszw/LZItrxqhxgMw/ndDPUBHttWFKBCq9rbjakmQ0pQNm/xdyn?= =?us-ascii?Q?cpEF77Ijv3mVfJlcm2YmrJNP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3077.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85e438ac-3f95-440a-2aa9-08d8ee2691bc X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 18:07:49.3217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xZBcveNoCexibWh6eOvUWnUWqeS4lvjjHlO9PWXcPRgbqzdKhAxOwyEuoBXWmfmmryVSPtrMqblZhc/fi4NNEmOG4h7sANe3kz1L/Kxmu3q1O9S/6OyKO1jrQ68oBPSt X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4070 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks a lot for reviewing the code and providing your comments. I have addressed below comments in V2 patch. Thanks & Regards, Suresh. -----Original Message----- From: Thomas Monjalon =20 Sent: Tuesday, March 23, 2021 9:52 PM To: P, Venkata Suresh Kumar Cc: dev@dpdk.org; Dumitrescu, Cristian ; Kha= ngar, Churchill ; Jangra, Yogesh Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port 19/03/2021 13:02, Venkata Suresh Kumar P: > Add the file descriptor input/output port type for the SWX pipeline. I think it deserves a bit more explanation about what is FD I/O port. -- [S= uresh] - Addressed in V2 patch > /* > + * tap > + */ > +#define TAP_DEV "/dev/net/tun= " Spaces are free :) -- [Suresh] - Addressed in V2 patch > +#ifndef TRACE_LEVEL > +#define TRACE_LEVEL 0 > +#endif > + > +#if TRACE_LEVEL > +#define TRACE(...) printf(__VA_ARGS__) #else #define TRACE(...)=20 > +#endif Would you consider rte_trace? > --- /dev/null > +++ b/lib/librte_port/rte_swx_port_fd.h > @@ -0,0 +1,57 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2016 Intel Corporation I guess you did not create it in 2016. -- [Suresh] - Addressed in V2 patch > + */ > + > +#ifndef __INCLUDE_RTE_SWX_PORT_FD_H__ #define=20 > +__INCLUDE_RTE_SWX_PORT_FD_H__ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +/** > + * @file > + * RTE SWX FD Input and Output Ports > + * > + ***/ Useless blank line. -- [Suresh] - Addressed in V2 patch [...] > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif A comment after such a far #endif is better: -- [Suresh] - Addressed in V2 = patch /* __INCLUDE_RTE_SWX_PORT_FD_H__ */ > --- a/lib/librte_port/version.map > +++ b/lib/librte_port/version.map > @@ -48,4 +48,6 @@ EXPERIMENTAL { > #added in 21.02 In 21.05 > rte_swx_port_ring_reader_ops; > rte_swx_port_ring_writer_ops; > + rte_swx_port_fd_reader_ops; > + rte_swx_port_fd_writer_ops; Please sort in alphabetical order. -- [Suresh] - Addressed in V2 patch