DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test: don't break terminal settings when running tests
Date: Thu, 14 Jan 2021 17:01:14 +0000
Message-ID: <BYAPR11MB314316A1262C3070DAAC9C1BD7A80@BYAPR11MB3143.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210114164537.28936-1-stephen@networkplumber.org>

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, January 14, 2021 4:46 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: stable@dpdk.org; dev@dpdk.org; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: [PATCH] test: don't break terminal settings when running tests
> 
> When running one test (via DPDK_TEST) the test program
> would leave the terminal in raw mode.  This was because
> it was setting up cmdline to do interactive input.
> 
> The fix is to use cmdline_new() for the interactive
> case.
> 
> This also fixes a memory leak because the test
> runner was never calling cmdline_free().
> 
> Fixes: 9b848774a5dc ("test: use env variable to run tests")
> Cc: harry.van.haaren@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Tested-by: Harry van Haaren <harry.van.haaren@intel.com>

  reply	other threads:[~2021-01-14 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 16:45 Stephen Hemminger
2021-01-14 17:01 ` Van Haaren, Harry [this message]
2021-01-17 17:45   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB314316A1262C3070DAAC9C1BD7A80@BYAPR11MB3143.namprd11.prod.outlook.com \
    --to=harry.van.haaren@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git