From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD478A0A02; Thu, 14 Jan 2021 18:02:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 420D71413D7; Thu, 14 Jan 2021 18:02:28 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id DB41F14125C; Thu, 14 Jan 2021 18:02:25 +0100 (CET) IronPort-SDR: 09eOjDSfxur8IpvXh4E6EpTc6dDj2/y1gw+SaSyv9T+TVMUddD7HNcR7Fkd8fqo5uJQlkEzt7+ qzfFJtAD2bvA== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="178552688" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178552688" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 09:01:36 -0800 IronPort-SDR: J7yU1BZ3ytUkBgDv8J3c+qlv4D/sT+iZIAxfjWL5XT90y0njJUmlQDOYiIu7FJnUaCRVqkei0o t7N7IC6lLCFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="400969291" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2021 09:01:17 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 Jan 2021 09:01:16 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 14 Jan 2021 09:01:16 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 14 Jan 2021 09:01:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AllpOKXvzs7Lx+6M6Les6D2mEzTNABS9m2CW8OodkFlthxKNSCuNjzYkcW30bmQW87dmfS9oaNikGwox4N2nZr42NBbfsMO18Pj3wmObgvzzR5X0NTQ4cdr0IqzteBbVV8iPAjURWPYzfFCEyveeE3OcJ660IWvCQhsAsxGVwPUSa2TpD3AeodUdDh0iq+QsPuuUnv8SBuwfz/7cph+ay/6+IxBMvXEnumO9nBXAquB+B9sSkYiN45GHmafbv+tE25B71o3K50CfjQV9/gW426qEsqwJH9kqROSkPn9mYIwNyiGvKf3YflhUjdtjdQqjHifu7+cs4bP9WzFti8lmkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kf8VC1rjQ4JxcXiT6miR6hlw1WtJiUirbCPwJOFQ6P4=; b=c6Q9e+/7J4nENlF+Yu5KylT40uvDtXr0vEe4ilN/lG3wsyoRimdM0p7eSQW5pNrEl7iqOJE6zZL072yuLE/QcwIytSZXoiu5G7nt6wMELb6CFtxhUV8VuxbjOOXl0B3V3ZJjI/oSmaiXvtAYgXoAnNbnwdGOP+E69ACWGo33XDc950WoXooStAK7PTMOfeRDwNpL7rEyoJfyTzoJXFyUcqpyfN5RIGBZeFgZRFJiYnQaFwn5JQnot6NhZoJv8EX2hh25kHE0BRpCy0ASHqMzkUl4E3Mh71dDF23s7E4EjPWezPW3E58IbB2JzkSCGUd9uBqNkgFCiQE3yKrGT1gapg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kf8VC1rjQ4JxcXiT6miR6hlw1WtJiUirbCPwJOFQ6P4=; b=D/89NQWIDj6iz2MwP4dwaQfHTu5+aZ8w53stl2jISLbhzxxhRNcg0AYrMhFNAKiPcmQxUuogvbII6cRc7gsX4mDE9YebV5l3XX9zJgxbqJgNVnCeMg6Pz6ZP7K6mytYsaO/sIs5uEJ3dSZMK2ETyInkNhzYfTSdQBfT+ydXQTdY= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by SJ0PR11MB4847.namprd11.prod.outlook.com (2603:10b6:a03:2d9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Thu, 14 Jan 2021 17:01:14 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::31df:76d6:bf35:3843]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::31df:76d6:bf35:3843%6]) with mapi id 15.20.3742.012; Thu, 14 Jan 2021 17:01:14 +0000 From: "Van Haaren, Harry" To: Stephen Hemminger , "Richardson, Bruce" , "De Lara Guarch, Pablo" CC: "stable@dpdk.org" , "dev@dpdk.org" Thread-Topic: [PATCH] test: don't break terminal settings when running tests Thread-Index: AQHW6pS7rG9/6v+ir0KfPaKDrMXxJKonWG7Q Date: Thu, 14 Jan 2021 17:01:14 +0000 Message-ID: References: <20210114164537.28936-1-stephen@networkplumber.org> In-Reply-To: <20210114164537.28936-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bd92db0d-5cfb-45a3-57d1-08d8b8ae0083 x-ms-traffictypediagnostic: SJ0PR11MB4847: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q9Y+8vDcqalJ7kEw8JZKzaBozC16wTvqyAUiDMgZi3QobKsb0VGSwWiSwkkzK0Mbr1WY9dmrJpPNubSeFDxFtzuQxJXOnCCCyti7u8Sl+RclLnycfx07dCHcVqx/s6lSrShC/hMIXLwYQ1F7DH+2hOXIAGeeOjvfdUVzwl9jmsJhySCTGpp7skpFY9p+PVriQKekt2xlSB7dvHP3KCeUV1BYcOxS8Q5algIhWB/uJCCNHXD7A/0GdUdBtpLIG6aCw+6yzJBuWXk89gsu5/ZWxlxK55STaKD3se2fkNnlHnx0J22IwFVNd8mPiTuqd5qZTsC6TzTs6J9DSXJdMYZtHYae85XNFsjJF41lY/fU5CdFZKQb+TW6ZUCQ5rxZ/1BDlpgJ+uVr8Hq2L8qf6Ev71w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(396003)(366004)(39860400002)(55016002)(66946007)(9686003)(64756008)(7696005)(66446008)(76116006)(66556008)(8936002)(66476007)(26005)(4744005)(6636002)(8676002)(53546011)(4326008)(6506007)(186003)(54906003)(33656002)(52536014)(2906002)(316002)(86362001)(110136005)(71200400001)(5660300002)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Av4IBDEW9WPfFJY6OrNNDTPJ2PtRDU27LXghlnqTYN1IRqr57+ZPHTEL08xX?= =?us-ascii?Q?nAIUFebtAbCZXvYJtVBfwKGP8e+TmKyVJJy50Sc+lrgc7f8Vl7AGFUNz9xuE?= =?us-ascii?Q?JmUQ/d6AXMCB46lCR7rp4hopY3Cw2S5xX5a0aJ/Yci00ROIuEjqm/zcCubsv?= =?us-ascii?Q?aVuMrDWT3yZ0148zJsj0PvdBq9Fp5sgHU4gUECO9iifF8BxxWebRDGDE/QaJ?= =?us-ascii?Q?YmAN3gYRnLO+aY4hzrt8EYImjWt7JiyiHXMYv+wK7FrWwJYLpiIzlrJ+sS4/?= =?us-ascii?Q?ygzj+95Yr6xwa9yK7pDsGxMMBhag31gvAIyqEQp81QqLm9RNyJ/u3yZ6c6Rp?= =?us-ascii?Q?+kJV4BECmeUeTN0ukZb9vLY5abRCmisQeA/SN+D8Q0fojRdTlTRTBaW8S5qg?= =?us-ascii?Q?Wp1Ata8eNxWVJO71oNMAF7Wvv5pIRXsTLCNGIkL/sjs/K7HLbzsDXV4u+q4e?= =?us-ascii?Q?ljbBIGsreRbYLNFi6++I2cO9hOFPDnSa8ntGqCbbbQVivoaOPTTlJb/DKJae?= =?us-ascii?Q?TmihYrG9hPXtoP5fsTiscyH3FPbHrAt6roUhBmfutQIMXOO/KolPLfZ+eDm1?= =?us-ascii?Q?1BDzx80gWN81oM6R3Xrv/W9WqkDvb5LHW+QOG4Av4RoEQmvZey6DSX+dErgh?= =?us-ascii?Q?hFafbpL4jC7KJW4pIgzR8FyDWc5DyHBM8qUQoa3M/E8Sv3DINfn2Zb60FYu8?= =?us-ascii?Q?ub+KOdvGIVEtAgd0XL2bf/RqtNt8VD6HDwENB9EX/sezYBCO3a540m8Q7Dk2?= =?us-ascii?Q?WSUbA77RdQIrI+e7pbCpUikV0NuC3xl0mg7qWid30yQryAgTKG20ZK/0J3e5?= =?us-ascii?Q?iMNsdN10klzQ7WxGJ+as75rzx44mWfEDzPeth6b82CAB0nWfuiZR6/tCeuS3?= =?us-ascii?Q?tfrEP6VzAPCec/4HCu1svIICe1umYU/H7Bg4PebQ8+p8uef85J8kguBcR1e6?= =?us-ascii?Q?lxKf/sF09g1+Hl9GLT2cBQ6kmNmkDR6YUrppxcf8/m4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd92db0d-5cfb-45a3-57d1-08d8b8ae0083 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2021 17:01:14.3684 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cVcENx/MJ7nVBVKM4Jdp2SqBbgaRdcvDoA9imIr5tX0vREVdk6DgXWGlpYLF6oI1PJ8IlHeNC1xUcoyYjr1fHSGttuMj+Ruow5WBAfR1xbE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4847 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test: don't break terminal settings when running tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Stephen Hemminger > Sent: Thursday, January 14, 2021 4:46 PM > To: Richardson, Bruce ; Van Haaren, Harry > ; De Lara Guarch, Pablo > > Cc: stable@dpdk.org; dev@dpdk.org; Stephen Hemminger > > Subject: [PATCH] test: don't break terminal settings when running tests >=20 > When running one test (via DPDK_TEST) the test program > would leave the terminal in raw mode. This was because > it was setting up cmdline to do interactive input. >=20 > The fix is to use cmdline_new() for the interactive > case. >=20 > This also fixes a memory leak because the test > runner was never calling cmdline_free(). >=20 > Fixes: 9b848774a5dc ("test: use env variable to run tests") > Cc: harry.van.haaren@intel.com > Signed-off-by: Stephen Hemminger Tested-by: Harry van Haaren