From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FB6BA0A0B; Mon, 1 Feb 2021 11:31:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2052B160652; Mon, 1 Feb 2021 11:31:24 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 0859740693 for ; Mon, 1 Feb 2021 11:31:21 +0100 (CET) IronPort-SDR: 1M4+EzSWQYZHdbFEVHewm5tjOKYookoUFrDUdQeQsukO8I4thQZNI7bXY4kl37p0dwbgw6lV9z MFHmYXV9+9Nw== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="199557853" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="199557853" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 02:31:20 -0800 IronPort-SDR: EDKHL/SRXK20VlInimd+w8//7orGUbGJ6rDs1aSJmr6XEp5gG4N1+Wci62jWic17hYx4yyqEm4 uxyMG7/5wy9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="432283389" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 01 Feb 2021 02:31:20 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 02:31:20 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 02:31:20 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Feb 2021 02:31:20 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 1 Feb 2021 02:31:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NfHirmMPYEK8RMLuAXEcN8xnPkWiOpWMTPXJfMQ0sY7nD79szH1S4gMqjl/goA7CJTi9zcAmh1spn5t73LC5B7VrUXIHCyE9TNh1QSVhl5FxSTS2ulGn3VYQqBmjJkIQsv+U+5kFrXnSdadJ1BTYIDWkNwE50lMPuBjNleuuhjYNPht8hNR1lrKNMveCBSo6FA+oMinVXQxJUJLxqUgXvNbV4wejtWdq1Lu/ABeYyHnEcbkYyGez1qf/qlMzeEpYS3x8xuP7FCxQNume9rlHBH3X4jb8MbR1PGjJfzR332td4nOuQzjDdDtCNt9c4RnOdM+o6zQ6Bw84wlz+NWjHQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SFLaG4sPO1Mz+KnlNfoM9rFjnkxiwh7CNqX80j/vv04=; b=gnDFpSDbvR9y0LjChDURIeGZEoCyqcmoeMC4l9VyyJ+ZN85YE+fs+srwhYwbGvX5HgZIXbxflHyAXuZtxCUa24i4XliFvp+EweCZjjKP8Allzs/WRwNvMF+DEwIEVW6ezYIqmdRI4e5TM/4tYDI/WQfJTTZOdUjlWyA3OMHvMDgC4ZEG+u27ChIxxVFtas07+yrAzKqjtUyKnDHKcYMJItgxuaFIivkYsDebwuDxP0HRtPlNRbEs+ihjDKDUsxLQYm8ImYZL64e/TqdaGIAQYtvfp0VMeRMzHHdUGAWxSboP4Qo8kcNgK0PMEkU+cW5Bp40ukOUFAcJ09XtwIR6l3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SFLaG4sPO1Mz+KnlNfoM9rFjnkxiwh7CNqX80j/vv04=; b=jVr/cPJKx7PTra0di1/oIhGOWepfKVMJ7hpNfrlzJUz5Bi8KCjoXrXPGCsjV+HlJ71GdlIPY/Cx5td14mljCap54zQdvLoqSheneBn5/XD4Y4FReRYzGwHtQUYi9Sed7dp+xICytCBoVRXyIWwmivy4MBdH4KGUoOwgMVpm4o7k= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3527.namprd11.prod.outlook.com (2603:10b6:a03:8b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.22; Mon, 1 Feb 2021 10:31:18 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::e1c7:915f:8714:9ce0]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::e1c7:915f:8714:9ce0%7]) with mapi id 15.20.3805.027; Mon, 1 Feb 2021 10:31:18 +0000 From: "Van Haaren, Harry" To: Fredrik A Lindgren , "dev@dpdk.org" Thread-Topic: Question: typedef of eventdev_info_get_t bug? Thread-Index: Adb4en0LIeGDpUGTRpesaiMx8+RA6gAA5+4QAACUs+AAARiigA== Date: Mon, 1 Feb 2021 10:31:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: tietoevry.com; dkim=none (message not signed) header.d=none;tietoevry.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 257bf91a-d872-44a2-2e57-08d8c69c82ff x-ms-traffictypediagnostic: BYAPR11MB3527: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NLNTEO0ZPeGX9HMlqbozC1MHt3ktQlyymy4gJrk1KKeiMgmUHHqoSmea9pPwD01nQdCOabsedceIQUy+bqv1k7Yw7/pU2zsYXGxbN+y5ONiqEMg7wr9pUuSrLQvDeLED4bce9Sgxj20dMZrCKeTII9uk12yo6sPh1Ur32P+9Cd4SZXACg/2hrZEZwfFTJUYQwMDoet7dZzLGK7ib3JXmIuOrZ65d0lR4UyZQdImR2cQ+yClYc3+IKaXwSc3xsT1s7E/Iazk9EgAni5t+2nata1IE4kmh64gg0DJfzJot9a+KU/VdzPrGuESJHHZoWSRmipzIrkJPoau85EjwBXWvoYPiGZZle8AJ1dYYkSWX/9WUxh9+bfJtpQRW1wd7p1v0cMwTMO0oKOhGsjGzsCNky6g1l/T9k1QYSkedU51p5YZpd1GGX/W7YCOgpC7QLv9ZxFyM9dHVwjzpP1hYbWiBtOuUNWbU7VaLcAPXl05hU/T3ZNEliJvQ0bXDMJKmP1OHvS6vxWlg4qxk2KlUqB0kZWCGk+LVsB55+EgFA7gprAcauKcgdTute12qbtC7Worpem9yvx6ftEnI4CD+DYucU8SWt04YZycuBU1qULdylRA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(66446008)(66476007)(66556008)(64756008)(76116006)(83380400001)(478600001)(966005)(2906002)(186003)(53546011)(26005)(8936002)(9686003)(86362001)(55016002)(7696005)(8676002)(33656002)(5660300002)(52536014)(66946007)(6506007)(71200400001)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?lFaYco3kNG+/2WWTt+BcCRQDqG1TrPddKs/UJZOsgjg6k/n78wJFuwEwi4S8?= =?us-ascii?Q?YAflsHmhwTsUWDfL1inmUTXCsLyCQbALMJgfFYkIynP8iMtZlUd7pi4c/Oyz?= =?us-ascii?Q?r6xzjbXZBYDS3QfBJayAE8lfi3YvmFFxJIWnZw6kWmlEFPbO5crlWpy0370x?= =?us-ascii?Q?jPIKUFXZmuLmydhs97MYcWY4LP5XyGpTFnrHuiPA6vHt2to/igeuyg0+pLdz?= =?us-ascii?Q?fCbl5if7r2XlNvWnWZJtNPCL3Ffa50OVz88y9jI5rR3pDbUjzup5GGQ1juf3?= =?us-ascii?Q?H9vwZRbFa5YnOzo5nlUJjtGWPKUISV1IhFN6qfSA/UbWNz+sa/CMHW5PPM/N?= =?us-ascii?Q?I3YPKQzioHUvx/APK9xCtnzw5Yu7V0yXkQSsIkBzJgp0mAuQR/Ri8NlEYnMF?= =?us-ascii?Q?RUYAPWg5uyn3dNW+CQjzVCXCgwGHtVxGNLmkkuIftce4F/03nYpRRQbxlu//?= =?us-ascii?Q?KnABusMxS0x/rKLaPe3os8mARUnG5P7dNzZ/6dG2ueCnuT0HyKpF9lc+kBAu?= =?us-ascii?Q?+J/yuQm8D0vve73O/L9p2kxKmyWgvlUGP08iBO/J+iEpyGY1otBlbv2EZ1Gd?= =?us-ascii?Q?cT8RiAz0gKbNZIi/9dom4CC3Wbr0jXoSZ6iGLFsbDaSC1o8+pFwruLgRJAEG?= =?us-ascii?Q?rbCTgJi00WmQyCcTI3kjH+MKJ6EMn8IlwpeGv2pOYdpjJoiMAY2hVLLYZKS6?= =?us-ascii?Q?HdBegplcGIjPmKQrLoXD34j4pbtAmGiG45MeLpew/RZ1fGrJX2czMv2Nw04K?= =?us-ascii?Q?l2W43i8AkpRl1GGnesl4dQ97YE63LhmwErVugruI9QDUwGabjiBg8KCQ/7z7?= =?us-ascii?Q?VPZOvhp0iEGrIFWywJgdeLJPI/r4V4oHSk212xzTWd/lJryq6gOAGrxUBaAr?= =?us-ascii?Q?1xEeUAf5y4tKnGUy2ucHrL4139voXtV9OvF6mN88wpBg56TVMJAQIzTIfXHF?= =?us-ascii?Q?0eZjSkoBvwcsxJtkSlDo2UswfVPSTtFFpfin59VbU2AsL2zBhHbHElqEYSQL?= =?us-ascii?Q?lEKcyL2hw1AX5rBVJ3+kMhzdhrMR7MTbpOzY7aJAuwbfRC+hRTVWus1zneGC?= =?us-ascii?Q?9ynLKZA0?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 257bf91a-d872-44a2-2e57-08d8c69c82ff X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2021 10:31:18.6375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rq5TqIeMOuHMnnb2ELAG3B3LWNflPypfopG0qTgRdLAiEqs0HeTl8rlJ3wdIiB0xIjT4padnZFY35q+aXuAsndhhDBiupoJiSTS5qah1o6E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3527 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] Question: typedef of eventdev_info_get_t bug? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Fredrik A Lindgren > Sent: Monday, February 1, 2021 10:02 AM > To: Van Haaren, Harry ; dev@dpdk.org > Subject: RE: Question: typedef of eventdev_info_get_t bug? >=20 > Hi Harry, >=20 > You are correct, multiple structs with dev_infos_get defined in them caus= ed me to > jump to wrong implementation. No problem. > Still a bit "wrong" that comment for eventdev_info_get_t for event setup = states > returns 0 on success. Agreed, a patch would be welcome to remove the "@return" bit of the docs. I can send it if you say you're not planning to, its a small/easy patch. > Using older version of > https://github.com/Xilinx/dma_ip_drivers/tree/master/QDMA/DPDK targeting = dpdk- > 19.11 for a corporate internal project as such can't give much details. > That version had a issue with no return statements in the infos_get funct= ion which > was causing me issues. Sounds like you've root-caused and know of a solution. > Br, > Fredrik Regards, -Harry > -----Original Message----- > From: Van Haaren, Harry > Sent: den 1 februari 2021 10:44 > To: Fredrik A Lindgren ; dev@dpdk.org > Subject: RE: Question: typedef of eventdev_info_get_t bug? >=20 > > -----Original Message----- > > From: dev On Behalf Of Fredrik A Lindgren > > Sent: Monday, February 1, 2021 9:22 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] Question: typedef of eventdev_info_get_t bug? > > > > While debugging a driver I was looking at the code and realized that > > eventdev_info_get_t typedef is defined with void return value but > > documentation for it says it should return 0 >=20 > Hi Fredrik, >=20 > Be aware that your snippets of code below is mixing Event-dev and Eth-dev= . > This is likely the cause of confusion. >=20 >=20 > > lib/librte_eventdev/eventdev_pmd.h: > > > > ... > > * @return > > * Returns 0 on success > > */ > > typedef void (*eventdev_info_get_t)(struct rte_eventdev *dev, > > struct > > rte_event_dev_info *dev_info); ... > > struct rte_eventdev_ops { > > eventdev_info_get_t dev_infos_get; = /**< Get device info. > */ > > ... > > > > While return value from it is used in lib/librte_ethdev/rte_ethdev.c: > > > > int > > rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info > > *dev_info) ... > > diag =3D (*dev->dev_ops->dev_infos_get)(dev, dev_info); > > if (diag !=3D 0) { > > ... >=20 > At the Eventdev layer, info_get() can return int (particularly 0 on succe= ss, or -ERROR > values). > At the Eventdev PMD layer, info_get() has a return void (the PMD cannot i= ndicate > failure on providing its info) >=20 > Hence, the info_get() typedef (for the PMD) is void, but the Eventdev lay= er itself > checks some dev_id values etc, and can return -EINVAL or -ENOTSUP in case= the > PMD doesn't support info_get(). >=20 >=20 > > Driver I'm debugging doesn't have any return statement in it's > > dev_infos_get function which seems to cause it to have "result" of > > last operation done in that function as return value. > > Though this behavior may be compiler specific but it should probably > > be clarified and updated (change prototype of stop using return value) = to avoid > issue with it. >=20 > Perhaps provide some more detail on Eventdev/Ethdev that you're debugging= a > driver on, provide some links to specific parts of the code? It seems lik= e (from > Eventdev anyway) its meant to work this way. >=20 > > Br, > > Fredrik >=20 > Regards, -Harry