DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: support using 0 as coremask for no-affinitization
Date: Tue, 16 Feb 2021 17:22:25 +0000	[thread overview]
Message-ID: <BYAPR11MB314343E9CAF7432D0426A141D7879@BYAPR11MB3143.namprd11.prod.outlook.com> (raw)
In-Reply-To: <42706d4c-f8de-55c5-1161-b1e54c77599e@intel.com>

> -----Original Message-----
> From: Burakov, Anatoly <anatoly.burakov@intel.com>
> Sent: Tuesday, February 16, 2021 10:53 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal: support using 0 as coremask for no-
> affinitization
> 
> On 16-Feb-21 10:46 AM, Bruce Richardson wrote:
> > On Tue, Feb 16, 2021 at 10:36:13AM +0000, Burakov, Anatoly wrote:
> >> On 16-Feb-21 9:43 AM, Bruce Richardson wrote:
> >>> Allow the user to specify that they don't want any core pinning from DPDK
> >>> by passing in the coremask of 0.
> >>> ---
> >>
> >> I haven't checked what happens yet, but down the line we also set affinity
> >> for service cores as well as interrupt thread. what would be the semantics
> >> of those in this particular case? do we want the same ability for service
> >> cores (i.e. pick a non-affinitized core)? And where does interrupt thread
> >> affinitize in this case (presumably, nowhere too)?
> >>
> > I have not checked the service core setup, because a) I forgot about them
> > and b) I'm not sure how their affinity rules work with respect to the main
> > lcore mask. On the other hand I did check out that the lcore mask for all
> > non-pinned threads, or control threads, is the full set of bits as
> > expected.
> >
> > /Bruce
> >
> 
> +Harry,
> 
> I believe service core mask must not overlap with lcore masks, so
> presumably using 0 as lcore mask would make it so that any service core
> mask will be valid (which is presumably what we want?). 

Services cores -S list or -s <mask> *must* overlap with the RTE lcores, EAL
then"steals" the service cores from the application lcores, code that implements here:
http://git.dpdk.org/dpdk-stable/tree/lib/librte_eal/common/eal_common_options.c?h=20.11#n657

> Should service cores also have a "just pick a core" parameter?

I'm not sure, depends on what the bigger goal is here.
Assuming we're enabling this for ROLE_RTE threads, then
it would seem to me that ROLE_SERVICE and control threads
would require similar treatment?


> I'm assuming this use-case is explicitly avoiding the CPU/memory/NIA
> NUMA affinity question, so i'm not bringing it up :)
>
> --
> Thanks,
> Anatoly

  reply	other threads:[~2021-02-16 17:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  9:43 Bruce Richardson
2021-02-16  9:51 ` Bruce Richardson
2021-04-14 16:15   ` David Marchand
2021-04-14 16:29     ` Stephen Hemminger
2021-04-14 17:02       ` Bruce Richardson
2021-04-14 16:55     ` Bruce Richardson
2021-02-16 10:36 ` Burakov, Anatoly
2021-02-16 10:46   ` Bruce Richardson
2021-02-16 10:52     ` Burakov, Anatoly
2021-02-16 17:22       ` Van Haaren, Harry [this message]
2021-02-16 17:30         ` Bruce Richardson
2021-02-16 17:44           ` Van Haaren, Harry
2021-02-17 12:09             ` Burakov, Anatoly
2021-02-17 12:14               ` Van Haaren, Harry
2021-02-17 13:26                 ` Bruce Richardson
2021-02-17 13:37                   ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB314343E9CAF7432D0426A141D7879@BYAPR11MB3143.namprd11.prod.outlook.com \
    --to=harry.van.haaren@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).