DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: David Marchand <david.marchand@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] service: separate dump and reset code
Date: Tue, 27 Oct 2020 10:57:22 +0000	[thread overview]
Message-ID: <BYAPR11MB314366296D1DF3297C1FB6F5D7160@BYAPR11MB3143.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201022080810.22153-1-david.marchand@redhat.com>

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, October 22, 2020 9:08 AM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>
> Subject: [PATCH] service: separate dump and reset code
> No functional change intended.
> service_dump_calls_per_lcore() was always called with a 0 reset flag.
> service_dump_one() was called with either a 0 reset flag or a NULL
> FILE pointer.
> We can split the code for readability sake.
> Note: there is no path to resetting calls_per_service[], this is left as
> is.
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Simplifies logic - thanks:
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

  reply	other threads:[~2020-10-27 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22  8:08 David Marchand
2020-10-27 10:57 ` Van Haaren, Harry [this message]
2020-10-27 12:24 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB314366296D1DF3297C1FB6F5D7160@BYAPR11MB3143.namprd11.prod.outlook.com \
    --to=harry.van.haaren@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).