From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DC4BA04DB; Fri, 16 Oct 2020 11:18:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1FE5B1EB9F; Fri, 16 Oct 2020 11:18:18 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B50401EB78 for ; Fri, 16 Oct 2020 11:18:14 +0200 (CEST) IronPort-SDR: CKDdfqv0kUMLYJXeaaGOyRvhlk2GYWdi7mVSezjNPO61KZ+ZconJTKAiGsfGTugFBet2+lcGCr A1jL+WfkxeUA== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="166671329" X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="166671329" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 02:18:12 -0700 IronPort-SDR: e0W3fHdahdH9eY4ZKfSsDsT10zNTwGeaXE8tvArj5DtEzmPh2yYiqqblJ26WkurlwPd9b+FEIS J4j3ISF7pvOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="464622304" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 16 Oct 2020 02:18:12 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 16 Oct 2020 02:18:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 16 Oct 2020 02:18:11 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.50) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 16 Oct 2020 02:18:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6A913YEsUpVUuzOt7EIHXDiywKGYiYivbNtxuFIw8GZ04SgmdeeTxrvqSyHD4CMFhZ6Q8/aY06uOXkPGU43VH+cnBWBwCpC4bayV83VMLBZ+EBGTsFYtdfKBr2kp5/FaDxotr+iAfxedKSyf6Q4JzbN9W5y0hysNeWHVvOzYtDvO+zMelp3yxy+QHzLQualyor+styNwD+6m5BwMkr7kUPmbzwa7ByEZVyt8HinC5DULpJlJFN3nKLI5g0uR0tM38KHvaHuh7wCleTQcMcOpAxBOaix9EJrSL16UseL3O78zt98oPe8gPKGGNYZcQ9BloqNxR53ZoiCsGu5yJAjhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRwCs9G+2IV00C7Dt2WZiN0H0zTQXjJ+bc5j/TZIPNQ=; b=A4iLe2MT0g80g7exkilVhTA8Kw6vYMTi/C9fT8kDPSRLtH3L6myCmHloHQEGmkME1wUHYoHo5rSDCHe+C306ltpQ+CzDHuz4IgdYI5xR8v8UYSQlkJFOOdV80qB0wSohk3ejR/ByS204ZrNr6WSKQ1r1GJB6alwF4LFgmn1kTeAXUMFKy4LiMKi/m3RTqZs3a1Gv2RDW5O28skIaGym2/mIT58iLH6szuRJe8ZsUsmTslDEiIy0g5cnWpFsqXDB8GWWOqrarx0UadiBtrrtrNhDsY9J8fCsU2TDaiU36o2U5e7rNjlWIZ+R5DLgrakvWYtq48EQI4q2mVr2JRXl+9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRwCs9G+2IV00C7Dt2WZiN0H0zTQXjJ+bc5j/TZIPNQ=; b=KgIlh98H7zA5TwRdkWHpTvgcyXQY+xwRGsuV01WwvcFApB1t30ZxMY3IUR7dasUTToRGGI7lgS4yfCeZ7Yn4nT/EgI4TGcLuisfbI2WzUInUw+LS2RuV7f/jWt7J+gb9MCaqYTzZawWaKEyGRFH8ZoNbjPvEYp0nBioorX5ekmU= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB2565.namprd11.prod.outlook.com (2603:10b6:a02:c9::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Fri, 16 Oct 2020 09:18:08 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::59e7:5ab9:4e99:27b9]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::59e7:5ab9:4e99:27b9%5]) with mapi id 15.20.3477.020; Fri, 16 Oct 2020 09:18:08 +0000 From: "Van Haaren, Harry" To: "Laatz, Kevin" , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "l.wojciechow@partner.samsung.com" , "Honnappa.Nagarahalli@arm.com" , "phil.yang@arm.com" , "aconole@redhat.com" Thread-Topic: [PATCH] test/service: fix race condition on stopping lcore Thread-Index: AQHWo5yTAPWJur6O30aWBnGAXDRTgqmZ8vEw Date: Fri, 16 Oct 2020 09:18:07 +0000 Message-ID: References: <20201016090804.1242907-1-kevin.laatz@intel.com> In-Reply-To: <20201016090804.1242907-1-kevin.laatz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1999e0ae-fa3b-49f6-2cc2-08d871b46546 x-ms-traffictypediagnostic: BYAPR11MB2565: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FBaUKPtHiS3+VNtn1Jw7sxd+nsGsZ4ajZ1gwsHmDspntH/HDXdFuTY2VLv1QbEvSfFkYeOVsWBe7/q4GnExNl+h0061pZHaWofxCMk6TopLPDjoF4BWUsW6WbfCBwHTITfOFQsYhKtrQTsQD1qybgeSJgQduCDvWs3LGyd/2DQnRwiqCnE+xObGtz5cAzkDt5y6Qb4EfWgy2gmjXSmvFzWDkR4dPXs0R5i9jCNkq4nxomZM058xSe5l+e6SYkr4iTP5gaB6m3G7USzaZBVvBrNtx14NCgvADGwy6xP8UUbV5nEZqqJ0MnUFjydfvcNwtZ/m3kXHObobosO0Kjf2qwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(478600001)(76116006)(53546011)(71200400001)(83380400001)(8936002)(2906002)(86362001)(8676002)(33656002)(6506007)(26005)(4326008)(4744005)(5660300002)(316002)(52536014)(110136005)(54906003)(66556008)(66476007)(66446008)(64756008)(186003)(66946007)(7696005)(9686003)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: iiGIgfo7Ff+d8ismTX9ahqOMouy776xSPGRhykGlt6tXLFTHjRrLLl2mRlMSTlP2sXM0clPB2TjVTJu4oyJVPUJALAeSWB1JOpqoBlHKaPzIE6vF8aohc7B041AAXOEIjXOCTmA8NvXDjUemc2ZEbn3vu7llQWJReZI1KpglXK6/KNkbyNxrUBXSWT1mHlvGgHGIe3pts6Rfw6CtOls1gIdg3oeL0h7yHk0A+8LnEExif2/9VyZ9IOPaNHckgsnm6IryH1jZlwzmBR/YxRnaqcE8w6W2VmZFWtraMP43hLKhBZfQ4Xd0Ym5ho+7bmknwB4+/c5fljv9PnrNwCNd5+H6hkNdSukB9EOeUjKm7WvcWxghMQ/1plHIxccV/vS+4unUfDnUXdKukqGoKHq/xcdruVeNjdgDPG7AQqpua6oULa06EZ0Hz/5kNKCeCA7UocXK8CFXQU3KjhP7VXE4hhvcSdYVpXH8prsP+KkNfoFSJmnj8R1iBDgT2N1QQ3HqCe7igdBuhBLkj1jy6DGPRFnr46+6Zj/EWw7J2kAH9tDUe/y6ZAVGqA5MWAAHBMDU/FLNcvP6PANz3uMEoPuQMVy65nrNACJbjlKRQJqeWDh4pX6lGZVt97FiiQcAUlPQ/VVAAjIOJf86T5KoLqSXn8g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1999e0ae-fa3b-49f6-2cc2-08d871b46546 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2020 09:18:07.8695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fvf1kkKXZulCtGVrW8d7FXsDbPCH76sEOCgOGcHUJwlFbo7L0P/OE4pamKBZKKKxob+IE/wthujxjPRJmxqhfDlZQOdKnL9i7OIZhTc8Lrk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2565 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Laatz, Kevin > Sent: Friday, October 16, 2020 10:08 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; > david.marchand@redhat.com; l.wojciechow@partner.samsung.com; > Honnappa.Nagarahalli@arm.com; phil.yang@arm.com; aconole@redhat.com; > Laatz, Kevin > Subject: [PATCH] test/service: fix race condition on stopping lcore >=20 > There is a potential race condition in 'service_attr_get' which will caus= e > test failures since the service core thread is still running while the > values are being retrieved/reset. >=20 > This patch fixes the race condition by waiting for the service core threa= d > to stop before continuing with the unit test checks. >=20 > Signed-off-by: Kevin Laatz Thanks Kevin for handling; can't reproduce race-cond here, but by code revi= ew this is the correct fix, thanks also for refactoring the wait into its own = function. Acked-by: Harry van Haaren