From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D34B0A0526; Wed, 22 Jul 2020 12:26:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FFE11BFF9; Wed, 22 Jul 2020 12:26:17 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A41051BFE9 for ; Wed, 22 Jul 2020 12:26:15 +0200 (CEST) IronPort-SDR: ivud7u9JhGyiEpuHdQDUDMbXVHEYPDzlYwt7iDVJQggjf/aLHV9xaRXxddqg35B7od748nSxS1 J6ZebdM/lXLA== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="130384577" X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="130384577" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 03:26:14 -0700 IronPort-SDR: nnSV5q+e4h+3LDmfph7uIJXVwEpd5cVjl0m5O73ZO7PQG/pajUYn4DsoDX3k4GJS1qiofoIZ1X mnml/8N4mc6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="432331105" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 22 Jul 2020 03:26:13 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Jul 2020 03:26:12 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 22 Jul 2020 03:26:12 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 03:26:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V8hLa0OwjD+vRpZDNltoFfcxtzMCACpoZ0TYwkB5n6CoYmh+frNnY5rTGkZbtRSmbOxMXQGHzSV4xG8ybEDcFOFXXrBZePf8ATC9rnikz/isXZO7cVhHQwMj4e66GMZ1Tt/4ZifH6V7wVfeSVAdML3P2/NYI7Ke0XxhMCufj/5cvj4fiN5b82hxXe0TJd49Sd5oyBnMZqvX17Xq82N1LjG4IR7Fv0ZWTOR/kha2Gr76t+3Ay9Zwgn44VBZEgopuXclCRN1F95Yc/bfJ1NVtYJyEF9m9odf4DkWEwAz6owPudBlZBvQSMbXk1ecB1uay3FGW2rhfGnle6oQcn+/+GrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pztmVqYu4u/BQYJU28fAPuRNe5Jo9ISlQv3vCGsvug=; b=cSbaIUkCqPeRqs7JNRqMG7lSmLm4t6BhO7iwdBHy76XNMjU28ZySpXZZ+kw2iNjpqR/5fPW+eRG4UB0JiSI2LgXEQUfS9zMkxBeJGrJhhjAPVCv5ANmQQieYm0fjNDyQe9PRTZa9nGRCeE06WJ+XFKg8SLODbrYB2/v2tma7OCJfEACN8Zlj+SNmVXRnEroX39t33ofVTwUyelbIb/nNLMjrVCEFWUuDGzMvwHBsPleX9M7PsVVtvXSj+eN/4Pmtlb3n0UqhXJnhsqoXmHK9t29IyBAWg4UgC+cWKazmbkaZrhnHvwZkWphLuJb/5Q2VbkxZ80nDSzq8v+sFBc2WJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pztmVqYu4u/BQYJU28fAPuRNe5Jo9ISlQv3vCGsvug=; b=h46Es5d5mD9VWsmjkO5bsYO+lF5GrfVpDbddxwkvzdHR55bWLYEnEfWxJReinawDi4p0Dpf8gG30JVjicw+GOYIaD62Go16qh4IbqEjPASasgR39hE796q2mE+Gq9bz0a+2c5dBwxV9iuOaZRCQn8ZxWpnv1A1RU1CIts0Rx7Bo= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3269.namprd11.prod.outlook.com (2603:10b6:a03:75::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Wed, 22 Jul 2020 10:26:08 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::9c6b:5ce:b551:8678]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::9c6b:5ce:b551:8678%4]) with mapi id 15.20.3195.026; Wed, 22 Jul 2020 10:26:08 +0000 From: "Van Haaren, Harry" To: Phil Yang , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "igor.romanov@oktetlabs.ru" , Honnappa Nagarahalli , "Yigit, Ferruh" , nd , "aconole@redhat.com" , "l.wojciechow@partner.samsung.com" , nd Thread-Topic: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on stopping lcore Thread-Index: AQHWXzptZMdQXJ09jky2OArSBK/ssqkTZArw Date: Wed, 22 Jul 2020 10:26:07 +0000 Message-ID: References: <20200720120938.34660-1-harry.van.haaren@intel.com> <20200720143829.46280-1-harry.van.haaren@intel.com> <20200720143829.46280-2-harry.van.haaren@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [87.198.126.230] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 05464878-4611-4998-d5b6-08d82e29a5bf x-ms-traffictypediagnostic: BYAPR11MB3269: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MtZDg/y8rh/flz5z3yZ2WGVxKXb6wS7GWSMsqJr21DChaQ537lGemjki7qNxbOjlv5M7dsHT4PGx8VVwoPgnbuirbgyDXixPbL3JvYaDErMi9caDuBtGR/3WDpwkFV82G0THmUMIRxjG5cVOoPbnW+6OZTfR+ucGVYRQj8U2ElH6ft9fwfWSMOdvU7yoSn//HdJ4v478/lJfujP5eedfvT4/7l6UeVIiDhe2/gu9SCHhsGWkf6k6/6nF12anbqkBo7zBwqp/0QxsI50UI67b4FVTCZeEvzWfobwVBTNsBVjqVHwJNJBC0BN5DDqgYeQDsl3g0s1HHXd5m4gCc5tcaQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(2906002)(186003)(76116006)(71200400001)(83380400001)(66946007)(66556008)(66446008)(4326008)(33656002)(66476007)(5660300002)(9686003)(64756008)(52536014)(55016002)(53546011)(478600001)(6506007)(7696005)(86362001)(8936002)(316002)(54906003)(110136005)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: vdq1FXd3WY1kNCa8r5AJC9l6d/CoH3CgUYA4nXoARY3KOzW+DlO8DY6l9YpWm+AjcovaXMYy/7voPd+0xDr4/NhCnYaZgvpaPtg0HqcNPBCPdO0wo3bKAnTC9P//XupzH9dYG2IsmLKTaz4hMw632+SeHkOYuBlQNxKd+4IuPyR714dYVbmCfT/bf7NeC2TDPEG2qgMqjsCS6AXL8YiPk+aD0b5Zp9a6cIQLtLm9/vpUKe1kjaYXyBA1oSsMngk0ZhrQIGcb2VOqZT2mSbYizkBMxYmDjIIIVXnAGG4TYiBELRJIN8GC0564o2cqlPGYRnYepIu6d+6IYZ72SjDvROSCduSnZDvvIxqW/d+isCTrlSTYHoEjiAgj2Oi45lDR1ywCmO3vzUJtEFYVcVJ6wDuu6lY8lrLxSIt9AbRe6V4qMfzc4a/GDI0Na61vf+ICUP7aDZaAdqdaAa6uuy4KE7HCGvAtu/z3Ud8vhvSroAxW1Iu/PTPBv8LR+oIFjlmY Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05464878-4611-4998-d5b6-08d82e29a5bf X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 10:26:08.0495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9sJYKWaniVHOLJWQd7Qfrxt0fnhGfEXMqMDDrh6hCHlCSUlXLmpqh3oxyIOnuei1jAUaGDGlaLH6Yad+iPqsL5+ZK4sfYFE4aCZUcMPVDc4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3269 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on stopping lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Phil Yang > Sent: Tuesday, July 21, 2020 9:39 AM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: david.marchand@redhat.com; igor.romanov@oktetlabs.ru; Honnappa > Nagarahalli ; Yigit, Ferruh > ; nd ; aconole@redhat.com; > l.wojciechow@partner.samsung.com; nd > Subject: RE: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition o= n > stopping lcore >=20 > <...> >=20 > > Subject: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on > > stopping lcore > > > > This commit fixes a potential race condition in the tests > > where the lcore running a service would increment a counter > > that was already reset by the test-suite thread. The resulting > > race-condition incremented value could cause CI failures, as > > indicated by DPDK's CI. > > > > This patch fixes the race-condition by making use of the > > added rte_service_lcore_active() API, which indicates when > > a service-core is no longer in the service-core polling loop. > > > > The unit test makes use of the above function to detect when > > all statistics increments are done in the service-core thread, > > and then the unit test continues finalizing and checking state. > > > > Fixes: f28f3594ded2 ("service: add attribute API") > > > > Reported-by: David Marchand > > Signed-off-by: Harry van Haaren >=20 > Minor nit, otherwise it looks good to me. >=20 > Reviewed-by: Phil Yang Thanks, will add in v3. > > + int i =3D 0; > > + while (rte_service_lcore_active(slcore_id) =3D=3D 1) { > > + rte_delay_ms(1); >=20 > Just as it does in other functions, use the macro instead of the magic nu= mber > would be better. > rte_delay_ms(SERVICE_DELAY); Sure, will change. I've refactored the while() to a for() too, think it cle= ans up a little.