From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B545CA0579; Thu, 8 Apr 2021 14:54:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D871140F7E; Thu, 8 Apr 2021 14:54:22 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id CE4C640698; Thu, 8 Apr 2021 14:54:20 +0200 (CEST) IronPort-SDR: kYsM1nS+W3DmrAHmsO71HJ+OSxq0PTRHfN53Owcyk1cYzI87pACpHZcHLmemtN4rLYAxgH9WgQ FFQ8I9+cnqMg== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="213937300" X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="213937300" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 05:54:19 -0700 IronPort-SDR: tpFxUrLAPY9Qv85s+mmXy0kjLneL5CjbhFG13cLBtznrUgt3OlU44gANQ0KVhNJrsP7OyP5jgn bR+nYHUdlgCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="387375336" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 08 Apr 2021 05:54:19 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 05:54:19 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 05:54:18 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 8 Apr 2021 05:54:18 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 8 Apr 2021 05:54:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QuIXkLl0DpVzTHxtZL5CaCUO9aKsiZryk5lhN70a9FKdcsk86/L6QaMYg4rESzmT2DkEZWdqVS7usq90inpy7u8FTIBBFaMgIe79zy1QD9aMDKCvZCKsyed5CFbhtW7VTZ9l9Kv7O0Zv61oLJ0PDlpfkxMyqQFL4/aUOgJNXS7rUN6TfQUgJvDmgKTNcvuA0RRs9nNH/qGOryxp75x/hdz7dnMcLdn3kdDvu3/Sf7ih7ja5jbJwnax7AaHsylxBz5kFss7HhMUPQoBSWxH/n56p99WK+1X0mwacW7gAyvlFwk6Qk1OchMmJzSQLHfO0hqQdsZ9TxVByl5eyrAMzn7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y32zrA3UzWGCYM8/xg3qduvzR9R29EwS+akfw+0Y/8o=; b=TYGzzvcHnVQ88XDVI3Hkygx6X5E6iR922WENKsd658zdmmgcAP4rtPJKhwmzuyUbA49wGk2rXQU2G/13/loAOU6V94liGOgNOI9nfIRALNUbCm303JItQ4Zer0i+JRPntXn97/JK47a4/xq9VrzsFr9mo1QFLJ/08RoI9zB+hOYaSBIWvXQqzfqolae9BWWLCnE0QK8xDM1xK0ej/8mpG2ka9QR9fd9jpp1VBI1LTy4g0sKv6+3IGO1B1c1/uAUFLTpwW0sEVmM1WmvEjpIB+4syKcgAsSYkcm6fudVUOZgFORFc2pkNR8qUMyC6fJ1t67cLgrM9AiFBixT0paUIVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y32zrA3UzWGCYM8/xg3qduvzR9R29EwS+akfw+0Y/8o=; b=olztuQpp2cMejQanA0yYtsDQWZ3lK+KOvHeGcJjqqAfNa2/eV82Q9NKTRtFwj62dQj2xT4cl3PvSwPVfE5sDgn37S2bRSFg+VpWZnL5UPBSutxBBSp+Oe9lnLSATAH0L/CSvW71kCChbti1UR0k0QOjFYQIwnsfMp6cVcjm//Jg= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB2997.namprd11.prod.outlook.com (2603:10b6:a03:8b::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Thu, 8 Apr 2021 12:54:17 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::8543:8483:f483:bcc7]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::8543:8483:f483:bcc7%4]) with mapi id 15.20.3999.032; Thu, 8 Apr 2021 12:54:17 +0000 From: "Van Haaren, Harry" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Ray Kinsella , "Neil Horman" , Pavan Nikhilesh Thread-Topic: [PATCH] service: clean references to removed symbol Thread-Index: AQHXK42XJAbyqCku8kOikttzwWUEK6qqlJMg Date: Thu, 8 Apr 2021 12:54:17 +0000 Message-ID: References: <20210407090656.29176-1-david.marchand@redhat.com> In-Reply-To: <20210407090656.29176-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 030b5d47-78f1-4228-5479-08d8fa8d6b88 x-ms-traffictypediagnostic: BYAPR11MB2997: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sQYjxcoKNx3yupVwSbjfDfbghM1Mq0v9f6pWzspwW1kXRfa8NcHB60rStEqTe4HlWulAIiUUaKnZ1kVBvR0bo6T7C8QqViSLht4N3BnYg8sPNnr9bXwiElfx/4b5pOR+dTguiR959qNJxP4M3d6gyfPL/jXLh0pYwhtck5c8g5kLRaRHzVUMxvBgm1QgF9XBjxQo3o0BPPTcc1d98HcrTcMynVEz/6wJU5tHPsyGZd+GT5D1u4yEMc4LkriTSlHL5Ep3SGmfTO/nH/Z/+/t8pHsrHDfWsoPUABFCODf3VrxfsmM32JCzr4fp1FlWbXl5Rt0WOsQTpN4hyBs1b1QMM80DtCblA8+lazIQnhDglwE4d2nvHrt1LwaEKE4VSY19tvfLYT1DCp8hdpSeOVd2FxiaDdV0Xi1E5Mc8vKkO4Y6+nFtCumjDD7mSvMzS2UaB9CZEYkYDSJqxOQVQ3XD4jFb8R4PUOqeqt7dPIXJMe9Bo4JMgK/9tYeZrewDwUB0QnpTrNeQCy21XbsH+DSkFvfQjYSG86t1e0I/W3120IW/v18ggwI27OTG3ERbvcht5P08Jm77LaGXbBlg0/PuFMR/rLCIpQTkyYmP5rQQL4SheK/Sj3ufvD7TAV/FJ9w48ixBkZBpkEtVOSCUnf+iV5/Sv5DphZrx6UquyBMLHHk8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(376002)(366004)(39860400002)(136003)(33656002)(86362001)(478600001)(83380400001)(66556008)(8676002)(38100700001)(53546011)(54906003)(9686003)(8936002)(6506007)(66476007)(7696005)(71200400001)(66446008)(26005)(66946007)(186003)(52536014)(316002)(2906002)(5660300002)(55016002)(110136005)(4326008)(76116006)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0GUj5OlO4acWJQKimwl/kdS8JpAMN7WO1fMzVLalIMK0FyZFTCKx1aMivta7?= =?us-ascii?Q?JbMu5hosxLXA0O5x6dKxfoKU8iYV/6Mi5FzoxvIvlSpr2cS1wbT90ew22zcc?= =?us-ascii?Q?VX0KAgVVS5BRn0LiTJbCMACGTtKBt9Ln8FelLk107ugF7d2UBjFU5fCyJ7o9?= =?us-ascii?Q?InStOkxYoq6xEkB8KExQumYUwZ/+VhgWs1Jzq9/snCEQFpurd54gMEdXYOeX?= =?us-ascii?Q?0UE3kvqZJSCkyy3LK1CNiUoo3X2pcvIzpLJYd0c6VwwWG19PTzTFJcWmSwBy?= =?us-ascii?Q?9NmgsdKi8ZZTLQFUJXLOayzP2eaT29k8R/bxbVbyWCTJjgmovig+sdjpQHhi?= =?us-ascii?Q?ELshGBSuyDDK7iu4in4b9cPKcql1VhiSgzlqDYwSFbdha+LZEBAU9ve6b3IT?= =?us-ascii?Q?2cCWAntqgyDhxieXq7k1Fstg1V69I4WsSlmqRGqno6IeMyhw+kMpP4taE7qm?= =?us-ascii?Q?Uh5XUKUwqH5mRtLT5nMGB6mVY/bfsDgXU06wOrYUk2BhB/HhbIOXtTyuSarf?= =?us-ascii?Q?w8JIWz2mH0SUK379l1+Vk+oYSqDrxKspGAEWtIo1727XYrbP4OFRdCLOFPJI?= =?us-ascii?Q?tiGeljWWPOmqezyxQ3Ur3u6gUwctvH44KDTSy4/e9tAMIND+9rF2kgl38/Yd?= =?us-ascii?Q?oJe6WxQUADR7N58U9yB/gd3pXoRRfcYtnuz+VkJ1gv563+O5uSCoiEBJx4ee?= =?us-ascii?Q?i7XkS15IZRpS1ynstIbT89xW88b5xaRG3fGqXM+3JPYGW1IPhxWzIKUnaVmz?= =?us-ascii?Q?SsMIfCeEfBgf1x6KKFcwxanXulKN2cN7wNNNzMBLiMvgrjKSOF/gByuonEFo?= =?us-ascii?Q?JHWaLnPGhtrnnN5/uqX0yXtTaVYHM4om3k3Zz2ywd/XxptZUBtPOLpJEvWyz?= =?us-ascii?Q?gorPx7psVUSCJiJRaSSdPN3opwIkHyR5abC5wy0/0Mqxq6FzRXo8IL4tcr7g?= =?us-ascii?Q?Q0aO/zdcJqyIBg0wg+iWQN6E8cpXhKZR89eulnxSeSWGRS1oWmh+1QB4sBU9?= =?us-ascii?Q?L+EbWNZZgUHylmkHbbZ8fFJz+0TGyQSCTGqOL89DVeERYNnnSAXT5h1ZKMgH?= =?us-ascii?Q?xAqBZA85Q5avqwJUe3x+NR8EDqNI3YVb9W7oFcDbRJM0IFC3+7bC9zitMzW0?= =?us-ascii?Q?WKK2p1rsex3Zt5lcwxoJByQDJy92L9TkS7ZQKXzwyGYI8R+fFdHDxcw2SB9l?= =?us-ascii?Q?N42I9r+5or7V0b+eZ3Fq5bfcT+fpEOTNUt9wOnKt+IsUdqQ+jc3VmjNQt7a8?= =?us-ascii?Q?j+o02ywo6ynFk4Xi7MiV+5Bcnx/lRMwTTtTBIYwW1pieh5oCP563CSraVgL6?= =?us-ascii?Q?raQ=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 030b5d47-78f1-4228-5479-08d8fa8d6b88 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 12:54:17.3445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YjussOmzxUqB3pwfU1LN/F5hvW/PfJTTsDcCeDhC4sm0demUbdHGtUdqmAA/UmR/nVDZP5IRQ9AbBsYSLL7NKfxzDh5HtwxSXoTGQGCbs5Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2997 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] service: clean references to removed symbol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand > Sent: Wednesday, April 7, 2021 10:07 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Van Haaren, Harry ; Ray > Kinsella ; Neil Horman ; Pavan > Nikhilesh > Subject: [PATCH] service: clean references to removed symbol >=20 > rte_service_get_id() was removed in v17.11 but the API description > still referenced it and a version node was still present in EAL map. >=20 > Fixes: 8edc9aaaf217 ("service: use id in get by name function") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand For rte_service.h doc changes I'm all fine. For ABI consistency, this removes a function from the DPDK_21 version map t= hat didn't exist in the shared object itself. I'm not sure if that's an ABI break or not... I s= ee ABI experts on CC, and will let them comment on that topic. Reviewed-by: Harry van Haaren > --- > lib/librte_eal/include/rte_service.h | 5 +---- > lib/librte_eal/version.map | 1 - > 2 files changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/lib/librte_eal/include/rte_service.h > b/lib/librte_eal/include/rte_service.h > index ca9950d091..c7d037d862 100644 > --- a/lib/librte_eal/include/rte_service.h > +++ b/lib/librte_eal/include/rte_service.h > @@ -47,10 +47,7 @@ extern "C" { > #define RTE_SERVICE_CAP_MT_SAFE (1 << 0) >=20 > /** > - * Return the number of services registered. > - * > - * The number of services registered can be passed to *rte_service_get_b= y_id*, > - * enabling the application to retrieve the specification of each servic= e. > + * Return the number of services registered. > * > * @return The number of services registered. > */ > diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map > index e23745ae6e..0f2a9228b3 100644 > --- a/lib/librte_eal/version.map > +++ b/lib/librte_eal/version.map > @@ -159,7 +159,6 @@ DPDK_21 { > rte_service_component_unregister; > rte_service_dump; > rte_service_finalize; > - rte_service_get_by_id; > rte_service_get_by_name; > rte_service_get_count; > rte_service_get_name; > -- > 2.23.0