From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCC3AA0A0B; Mon, 1 Feb 2021 10:44:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F2D5160688; Mon, 1 Feb 2021 10:44:49 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C070B40693 for ; Mon, 1 Feb 2021 10:44:46 +0100 (CET) IronPort-SDR: 3KUv6jgK9bGWeP/4YZP/RDxiSHqGgfzdVtlim7uuxF7tlEjMxuHtrk9BxyIvAksfpwkRG50dsF nhvQgYZ+J1mw== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="180805026" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="180805026" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 01:44:45 -0800 IronPort-SDR: JUDX/IFdm1Io4qkVOBhmWyVJ20N6LwtOr1INHi71NVx7cGKwntgo0N8BsZpWDZUEIg8EEhyMRk uVF82KzQFSdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="575052264" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 01 Feb 2021 01:44:44 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 01:44:44 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 01:44:43 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Feb 2021 01:44:43 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 1 Feb 2021 01:44:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQAK4HeFvjJjmoDlrJw+Mp0gdvzwAhi77PRz3K4+9WIegMJuMfX3Cl5uO/dqsQ4weQ4jdhKgIzcWDHTgDYuX5uq03UD5XXBYH7XOcwNu9z7/Hn4HI6Uc9e4OE6EesTdgZQK45BFDoEhvTwhzpq8/b5sUmAbojLGLrMPJSQFNAaYrpRbC2LC5LIcvF7hKGiepxoK3h/eVECtYu05pM2Vvr45apiNWKmKgK5NZL/uiCsoGyiF2uf1MQY9BSCFayx+tombxU/aVtkFt0l1DrepqOQgK9DaYgE9KwCRhNodzuAiahfQ+M56zzLKbzMZTauzkziRZ9uK4dJw+uO970XwW0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXbYIPMvfya+wDdSjU2PaO3PVfUvRdWL9DlJm49y9Dw=; b=REH/ARU5bc73u/zVaVDJFgZbjk767cMH1+8Xs2/HB8XphfgqKZ6GCnoz91g/2xvxF7VyKVHwnoKVkgoyx+Oyb7dxsHM1pvxeBcMHKVUq6N4cCGpQr4YoYvgs35+JAQ3II7nR7tqRqElXh+LQoVbuT0GfhnH9D/YYOyL9T1f7gSwUPh6E0grQSd+v8D9hh+QvQgp3qMW+wto/MzMVT96NND96e7cBdpdFSjfdPLZhdPPEQQgJec3PK+Br+xNs4qzCzAMy4Wu+h8/0dOjOlCRpfFlzO21zO4p3xODLpcKtXRU8SZ7TuU+++FSBj2BLGLmWlsfHbzMMWDGkgTvSdWuPJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXbYIPMvfya+wDdSjU2PaO3PVfUvRdWL9DlJm49y9Dw=; b=HuOGLVleSsfBeOpRbyEejJt7sawFZCB+owodbAfa0FTbvCV1JH1wFN6DrHl3+aeDSo68u0oIvV2XwgcabKZyudTEQkPE1VTSVzuzONAYKhCDmxF6uB18ZskJWbIBJbHEKht0xyaUPa3k5V1EI46yENKft5g/cuQmDyBYNbbTsis= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by SJ0PR11MB4943.namprd11.prod.outlook.com (2603:10b6:a03:2ad::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Mon, 1 Feb 2021 09:44:10 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::e1c7:915f:8714:9ce0]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::e1c7:915f:8714:9ce0%7]) with mapi id 15.20.3805.027; Mon, 1 Feb 2021 09:44:10 +0000 From: "Van Haaren, Harry" To: Fredrik A Lindgren , "dev@dpdk.org" Thread-Topic: Question: typedef of eventdev_info_get_t bug? Thread-Index: Adb4en0LIeGDpUGTRpesaiMx8+RA6gAA5+4Q Date: Mon, 1 Feb 2021 09:44:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: tietoevry.com; dkim=none (message not signed) header.d=none;tietoevry.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a91e09b8-a836-4c19-21d6-08d8c695ecfb x-ms-traffictypediagnostic: SJ0PR11MB4943: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TAEB5irPh+lAvxT+ED1TLet+2pOcYjnl0OQV/rhofTmRmXiCrZrWJsJypiwzNniA2O87FJphjG9enaoqR4CdMbx1OHfUXBMuDs2jEBlf6/I3mPQbxM13sW/ujbyYkBAiISmjzgclf4KKDAtUkfP/8TlOBp5krA3muVZw6c9UCZGF3Zfys+PRUKpZK/ul+V8wRyljkvoebz2Ei4sirGRb6RG2711H5ax8K4HFSOYL65BuufVpD5PwGzpq4++yjNz8gLFOYDt2jIkh32EwM3v1DzyphuWMo8sCjpKOE7+m5+GUJj/FCkrPlLT9KTlt7VcAadraVaqXU/yrAWIvuVNl1FXXsyniwp3s16rmLKqltMVdNZd8qX2eqO34kUYZbcXVQO9SWDe6n2HDBQXZE+N7JA4RW87XiOV+HCspQLXT2iLR8+YPsg+BDY6shE7vZR3mwXT4IEYhKupuFiRfqk6yiZhSuOlx5215TbMjhjf/mHJCUKdyP1Zj/MTCkaWnrG+WLH0pMsTj/e2+PVBr1/UXSA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(396003)(39860400002)(346002)(66556008)(64756008)(5660300002)(66946007)(53546011)(66476007)(76116006)(8936002)(8676002)(9686003)(86362001)(6506007)(110136005)(316002)(66446008)(83380400001)(2906002)(52536014)(7696005)(186003)(33656002)(71200400001)(478600001)(26005)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ZliAMGvalo1PiX1gRC7vzjiEZx73RW5tSelwyuQRxvwnw8ssX3KzYloNHMqI?= =?us-ascii?Q?pyBJ+UN7T0v28srBBcHsyiEbKJKDjnYCkstsM4ma7SfAvZDfSHIPIbadPZbN?= =?us-ascii?Q?C584UxjkKXjsGATUCUiPC8iRKPFIHUqH3ItqfYSak69L+YCJZBTfD2iU7fd9?= =?us-ascii?Q?zesfR/1hcfypcA1Q1r/yKz52yzEEA+9FHA8WOdLtw81bquewocSvp/jySfK5?= =?us-ascii?Q?pc+5hLplTMvuqqrH0NC+1fhYHF60omyzw47etz2MjqjDvgY1sInmWb6o2lRO?= =?us-ascii?Q?u3zS6PplaZ5PE4Xye5o4euJrqSc5iqYDu+VZ5PhaEnNTiKBUxbSEL0+vFGeE?= =?us-ascii?Q?sHJc6JCwPmqpVG3/n0LjvbBh1lwLAOe18kPzKQmJlBaotawZnyNjex2TtJIp?= =?us-ascii?Q?Q5YWY7KLCW3SsTR3HxUtAUE3kHcpT2ez1Mz2VtpwHIYxIe7sF4tOKffRqIsA?= =?us-ascii?Q?R6KYhH7AdvNoMp+TJdO5Kty7EBhOlsAaAgDXYe5eeg2cq6OmJS2WIH1iDYpg?= =?us-ascii?Q?zkBYdLYAq3ohtkenSposuaDqhVlW1izZzmf6/+2fvgxoRDAln1up4F5KYq2d?= =?us-ascii?Q?fvRUyGhj8mzpUGUq+ufAgV2snNFIu45a+3qMfhkfw+q957x//4qB75/zhvfn?= =?us-ascii?Q?N3aveRIQU/2iXdeX0EbAtfY7D3/Ym+CmscIdNY2q9rS4JLaDTr10o50Q2OjX?= =?us-ascii?Q?BurDd5JQ6ogj43gHKvueyZi7k+3XCLgDdJqNJqFYCKAJPFspOaFMV1Dl8QUF?= =?us-ascii?Q?zX0Nbd351RzxSWN08CPdb0RrAyabP8OfIvUZ+kfkVpx1wVd2fGQSYFIQkhYH?= =?us-ascii?Q?kVcG5W5CBcrvZrv9xOr3LEp8oFM7oRQC674a2KEbIkmVVX1FzSi2Mev3A11j?= =?us-ascii?Q?zSHCz/K+RGMBIsUCJNRdHM27iW4pIj3yth16Gbfxy63mWBkS6x9nwV7WdXRd?= =?us-ascii?Q?oOlfWW+VgsWzoDk6vzyytpqjlcPRq26tr9ypZOBzCImMtgae5iwLFVyPgTMI?= =?us-ascii?Q?shBy30+qz0liibxPro5i5GWgl+2QofX9Tuid//xdf9Pmoyb2eROK/bWcVRDG?= =?us-ascii?Q?Hfj1AeNN?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a91e09b8-a836-4c19-21d6-08d8c695ecfb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2021 09:44:09.9714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lL4ACmjKTiJ4Whc/50v+4BlsqTqZzD/fUrpgKRr5iR1UDdwkweBgqlOBG2KLPS2CXLSYd4nUkWV65oGe4/3fNezyQoc/ewdesNVfTe/sB+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4943 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] Question: typedef of eventdev_info_get_t bug? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Fredrik A Lindgren > Sent: Monday, February 1, 2021 9:22 AM > To: dev@dpdk.org > Subject: [dpdk-dev] Question: typedef of eventdev_info_get_t bug? >=20 > While debugging a driver I was looking at the code and realized that > eventdev_info_get_t typedef is defined with void return value but documen= tation > for it says it should return 0 Hi Fredrik, Be aware that your snippets of code below is mixing Event-dev and Eth-dev. This is likely the cause of confusion. > lib/librte_eventdev/eventdev_pmd.h: >=20 > ... > * @return > * Returns 0 on success > */ > typedef void (*eventdev_info_get_t)(struct rte_eventdev *dev, > struct rte_even= t_dev_info *dev_info); > ... > struct rte_eventdev_ops { > eventdev_info_get_t dev_infos_get; = /**< Get device info. */ > ... >=20 > While return value from it is used in lib/librte_ethdev/rte_ethdev.c: >=20 > int > rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) > ... > diag =3D (*dev->dev_ops->dev_infos_get)(dev, dev_info); > if (diag !=3D 0) { > ... At the Eventdev layer, info_get() can return int (particularly 0 on success= , or -ERROR values). At the Eventdev PMD layer, info_get() has a return void (the PMD cannot ind= icate failure on providing its info) Hence, the info_get() typedef (for the PMD) is void, but the Eventdev layer= itself checks some dev_id values etc, and can return -EINVAL or -ENOTSUP in case the PMD doesn't support inf= o_get(). > Driver I'm debugging doesn't have any return statement in it's dev_infos_= get > function which seems to cause it to have "result" of last operation done = in that > function as return value. > Though this behavior may be compiler specific but it should probably be c= larified and > updated (change prototype of stop using return value) to avoid issue with= it. Perhaps provide some more detail on Eventdev/Ethdev that you're debugging a= driver on, provide some links to specific parts of the code? It seems like (from Event= dev anyway) its meant to work this way. > Br, > Fredrik Regards, -Harry